GNU bug report logs - #67490
[PATCH v2] tail: fix tailing sysfs files on large page kernels

Previous Next

Full log

Message #8 received at 67490 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: dann frazier <dann.frazier <at> canonical.com>, 67490 <at> debbugs.gnu.org
Subject: Re: bug#67490: [PATCH] tail: fix following /proc and /sys files when
 using a 64K page size
Date: Mon, 27 Nov 2023 19:10:26 +0000

On 27/11/2023 16:24, dann frazier wrote:
> * src/tail.c (file_lines): Use fstat() to determine a file's block
> size and dynamically allocate a buffer of that size for traversing
> backwards.

Thanks for the patch.
Could you describe it a bit more.
What happens if we use smaller reads?
Also what about all the other safe_read() calls in tail.c ?

thanks,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.