GNU bug report logs - #67490
[PATCH v2] tail: fix tailing sysfs files on large page kernels

Previous Next

Full log

Message #11 received at 67490 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: dann frazier <dann.frazier <at> canonical.com>, 67490 <at> debbugs.gnu.org
Subject: Re: bug#67490: [PATCH] tail: fix following /proc and /sys files when
 using a 64K page size
Date: Mon, 27 Nov 2023 11:17:57 -0800

On 2023-11-27 08:24, dann frazier wrote:
> +  if (fstat (fd, &stats) != 0)
> +    {
> +      error (0, errno, _("cannot fstat %s"), quoteaf (pretty_filename));
> +      return false;
> +    }
> +
> +  bufsize = ST_BLKSIZE (stats);


If fstat fails, that's no reason to exit. Just use bufsize = BUFSIZ and 
keep going. fstat can fail for reasons unrelated to what 'tail' needs 
(e.g., time_t overflow).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.