GNU bug report logs - #67473
[PATCH gnome-team 00/12] Hopefully the last world rebuild

Previous Next

Full log

Message #280 received at 67473 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 67473 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v5 06/19] gnu: json-glib: Update to 1.6.6.
Date: Fri, 08 Dec 2023 16:26:18 -0500

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (json-glib-minimal): Update to 1.6.6.
> [arguments]: Convert to list of G-Expressions.
> [#:configure-flags]: Add -Dgtk_doc=disabled.
> [native-inputs]: Drop labels.
> (json-glib) [#:configure-flags]: Remove -Ddocs=true.  Unless cross-compiling,
> add -Dgtk_doc=enabled and -Dintrospection=enabled.
> [#:phases] <move-docs>: Replace /share/gtk-doc with /share/doc.
> [native-inputs]: Add gi-docgen.  Remove docbook-xml-4.3, docbook-xsl, gtk-doc,
> libxslt.

> Change-Id: Ib88f2fb59a776312bf3b452eecfe201e272a3888
> ---
>  gnu/packages/gnome.scm | 31 +++++++++++++++----------------
>  1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d9aedff159..44b487662f 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -4697,7 +4697,7 @@ (define-public dconf
>  (define-public json-glib-minimal
>    (package
>      (name "json-glib-minimal")
> -    (version "1.6.2")
> +    (version "1.6.6")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/json-glib/"
> @@ -4705,14 +4705,16 @@ (define-public json-glib-minimal
>                                    "/json-glib-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "092g2dyy1hhl0ix9kp33wcab0pg1qicnsv0cj5ms9g9qs336cgd3"))))
> +                "03j9ba2sccbz954smk3n1swwnvpzl8yhwwin6vixvxligaz9iv4n"))))
>      (build-system meson-build-system)
>      (arguments
> -     `(#:glib-or-gtk? #t))           ; To wrap binaries and/or compile schemas
> +     (list #:glib-or-gtk? #t
> +           #:configure-flags #~'("-Dgtk_doc=disabled")))

The comment is gone.  Was this intended?  Nitpick: #~(list ...) reads
better than #~'(...) to my eyes.

Otherwise,

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.