Subject: Re: [PATCH gnome-team v5 09/19] gnu: libsoup-minimal: Update to 3.4.4.

From: Maxim Cournoyer <[email-masked]>
Date: Fri, 08 Dec 2023 16:30:59 -0500

Hello,

Vivien Kraus <[email-masked]> writes:

[...]

> * gnu/packages/gnome.scm (libsoup-minimal): Update to 3.4.4.
> [#:configure-flags]: Change name of docs option.
> [#:phases]<adjust-tests>: Change the file name of socket test.
> (libsoup-minimal-2) [arguments]: Override #:configure-flags.
> [#:phases]: Override 'adjust-tests.
> (libsoup) [version]: Remove field.
> [source]: Remove field.
> [#:configure-flags]: Replace -Ddocs=disabled with -Ddocs=enabled.

[...]

>               ;; These fail because "subdomain.localhost" does not resolve in
> @@ -5095,9 +5094,13 @@ (define-public libsoup-minimal-2
>                  "04rgv6hkyhgi7lak9865yxgbgky6gc635p7w6nhcbj64rx0prdz4"))))
>      (arguments
>       (substitute-keyword-arguments (package-arguments libsoup-minimal)
> +       ((#:configure-flags configure-flags)
> +        ;; The option named changed between libsoup 2 and libsoup 3.
                             ^
                             name

Reviewed-by: Maxim Cournoyer <[email-masked]>

-- 
Thanks,
Maxim