Subject: Re: [PATCH gnome-team v3 09/14] gnu: lbsoup-minimal: Update to 3.4.4.

From: Liliana Marie Prikler <[email-masked]>
Date: Sat, 02 Dec 2023 17:34:13 +0100

Am Samstag, dem 02.12.2023 um 16:08 +0100 schrieb Vivien Kraus:
> The libsoup-minimal comment about inkscape is irrelevant, because
> inkscape uses libsoup-minimal-2.
> 
> The option to build documentation has changed between libsoup 2 and
> libsoup 3. The failing socket test has been moved to a different
> file.
> 
> libsoup-minimal-2 introduces a new phase to disable tests, however
> the
> 'adjust-tests phase of libsoup-minimal must be removed. For
> simplicity, we use
> the 'adjust-tests name for the phase of all variants.
> 
> * gnu/packages/gnome.scm (libsoup-minimal): Update to 3.4.4.
> [#:configure-flags]: Change name of docs option.
> [#:phases]<adjust-test>: Change the file name of socket test.
> (libsoup-minimal-2) [arguments]: Override #:configure-flags.
> [#:phases]: Override 'adjust-tests.
> (libsoup) [version]: Remove field.
> [source]: Remove field.
> [#:configure-flags]: Replace -Ddocs=disabled with -Ddocs=enabled.
> 
> Change-Id: Iace1bf0f1d805a0eed7e484a7cd496ac04631b32
> ---
You typo'd in the subject line: it's libsoup, not lbsoup.

Lexically, the change LGTM, semantically CI may or may not have us
covered :)
Anyhow, queuing for Dec 10th.

Cheers