GNU bug report logs - #67460
[PATCH] Add ert-font-lock

Previous Next

Full log

Message #14 received at 67460 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67460 <at> debbugs.gnu.org
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Sun, 3 Dec 2023 09:51:43 +0000

[Message part 1 (text/plain, inline)]

Hi Eli,

Thanks for looking into this!

Note to myself: I need to make byte-compiling into a habit. Anyway,
warnings fixed, here's the updated patch.

On Sat, 2 Dec 2023 at 12:50, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > From: Vladimir Kazanov <vekazanov <at> gmail.com>
> > Date: Sun, 26 Nov 2023 18:47:30 +0000
> >
> > As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
> > Emacs. Ert-font-lock is an extension to ERT providing an easy way to
> > check font faces either in inline strings or resource files.
> >
> > The assertion syntax is based on Tree-sitter's syntax highlighter unit
> > tests [2]. This makes it easy to port existing tree-sitter grammar
> > tests to support both new-style ts-based major modes and the
> > traditional ones.
>
> Thanks.
>
> Byte-compiling this I get two warnings:
>
>     ELC      emacs-lisp/ert-font-lock.elc
>
>   In ert-font-lock--parse-macro-args:
>   emacs-lisp/ert-font-lock.el:82:19: Warning: Unused lexical variable `keys'
>
>   In ert-font-lock--comment-start-p:
>   emacs-lisp/ert-font-lock.el:191:10: Warning: `derived-mode-p' called with 3 arguments, but accepts only 1
>
> Could you please fix these and resubmit the patch?



-- 
Regards,

Vladimir Kazanov

[0001-Add-ert-font-lock.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.