GNU bug report logs - #67460
[PATCH] Add ert-font-lock

Previous Next

Full log

Message #11 received at 67460 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 67460 <at> debbugs.gnu.org
Subject: Re: bug#67460: [PATCH] Add ert-font-lock
Date: Sat, 02 Dec 2023 14:50:17 +0200

> From: Vladimir Kazanov <vekazanov <at> gmail.com>
> Date: Sun, 26 Nov 2023 18:47:30 +0000
> 
> As suggested in emacs-devel@ [1], this patch adds ert-lont-lock.el to
> Emacs. Ert-font-lock is an extension to ERT providing an easy way to
> check font faces either in inline strings or resource files.
> 
> The assertion syntax is based on Tree-sitter's syntax highlighter unit
> tests [2]. This makes it easy to port existing tree-sitter grammar
> tests to support both new-style ts-based major modes and the
> traditional ones.

Thanks.

Byte-compiling this I get two warnings:

    ELC      emacs-lisp/ert-font-lock.elc

  In ert-font-lock--parse-macro-args:
  emacs-lisp/ert-font-lock.el:82:19: Warning: Unused lexical variable `keys'

  In ert-font-lock--comment-start-p:
  emacs-lisp/ert-font-lock.el:191:10: Warning: `derived-mode-p' called with 3 arguments, but accepts only 1

Could you please fix these and resubmit the patch?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.