GNU bug report logs - #67453
[PATCH] home: services: unclutter: Convert to non-one-shot service

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67453: closed ([PATCH] home: services: unclutter: Convert to
 non-one-shot service)
Date: Sun, 02 Mar 2025 09:04:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 02 Mar 2025 10:02:47 +0100
with message-id <87y0xnbya0.fsf <at> nicolasgoaziou.fr>
and subject line Re: [PATCH] home: services: unclutter: Convert to non-one-shot service
has caused the debbugs.gnu.org bug report #67453,
regarding [PATCH] home: services: unclutter: Convert to non-one-shot service
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67453: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67453
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Saku Laesvuori <saku <at> laesvuori.fi>
To: guix-patches <at> gnu.org
Cc: Saku Laesvuori <saku <at> laesvuori.fi>
Subject: [PATCH] home: services: unclutter: Convert to non-one-shot service
Date: Sun, 26 Nov 2023 11:00:15 +0200

* gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
[one-shot?]: Remove field.
[stop]: Add kill action.

Change-Id: I33551607b05dbac30da94f81fd605ff9624ebe24
---
 gnu/home/services/desktop.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/home/services/desktop.scm b/gnu/home/services/desktop.scm
index 91465bf168..6bb117ea8c 100644
--- a/gnu/home/services/desktop.scm
+++ b/gnu/home/services/desktop.scm
@@ -347,7 +347,6 @@ (define (home-unclutter-shepherd-service config)
    (shepherd-service
     (provision '(unclutter))
     (requirement '())
-    (one-shot? #t)
     (start #~(make-forkexec-constructor
               (list
                #$(file-append
@@ -360,7 +359,8 @@ (define (home-unclutter-shepherd-service config)
                           (or (getenv "XDG_STATE_HOME")
                               (format #f "~a/.local/state"
                                       (getenv "HOME")))
-                          "/log/unclutter.log"))))))
+                          "/log/unclutter.log")))
+    (stop #~(make-kill-destructor)))))
 
 (define home-unclutter-service-type
   (service-type

base-commit: 9f67681db15d22f7ede5488315d52b78e357343e
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 67453-done <at> debbugs.gnu.org
Cc: Saku Laesvuori <saku <at> laesvuori.fi>
Subject: Re: [PATCH] home: services: unclutter: Convert to non-one-shot service
Date: Sun, 02 Mar 2025 10:02:47 +0100

Hello,

> On Mon, Jan 15, 2024 at 05:50:12PM +0200, Saku Laesvuori wrote:
> > On Sun, Nov 26, 2023 at 11:00:15AM +0200, Saku Laesvuori wrote:
> > > * gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
> > > [one-shot?]: Remove field.
> > > [stop]: Add kill action.
> > 
> > A reminder about this trivial change. The unclutter service spawns a
> > process that hides the cursor when it is inactive. The process runs for
> > the entire session and killing it causes the cursor to stay visible even
> > when inactive, so it seems to me that it should be provided by a normal
> > service that can be started/stopped.
> 
> Ping

Thank you for the patch! Unfortunately, it seems it felt through the
cracks. I’m sorry about that.

The proposed change was applied recently to the service, so I’m closing
this report.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.