Subject: bug#67453: closed (Re: [PATCH] home: services: unclutter: Convert to non-one-shot service)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 02 Mar 2025 09:04:02 +0000

Your bug report

#67453: [PATCH] home: services: unclutter: Convert to non-one-shot service

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
67453: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67453
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH] home: services: unclutter: Convert to non-one-shot service
From: Nicolas Goaziou <[email-masked]>
To: [email-masked]
Cc: Saku Laesvuori <[email-masked]>
Date: Sun, 02 Mar 2025 10:02:47 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

> On Mon, Jan 15, 2024 at 05:50:12PM +0200, Saku Laesvuori wrote:
> > On Sun, Nov 26, 2023 at 11:00:15AM +0200, Saku Laesvuori wrote:
> > > * gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
> > > [one-shot?]: Remove field.
> > > [stop]: Add kill action.
> > 
> > A reminder about this trivial change. The unclutter service spawns a
> > process that hides the cursor when it is inactive. The process runs for
> > the entire session and killing it causes the cursor to stay visible even
> > when inactive, so it seems to me that it should be provided by a normal
> > service that can be started/stopped.
> 
> Ping

Thank you for the patch! Unfortunately, it seems it felt through the
cracks. I’m sorry about that.

The proposed change was applied recently to the service, so I’m closing
this report.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] home: services: unclutter: Convert to non-one-shot service
From: Saku Laesvuori <[email-masked]>
To: [email-masked]
Cc: Saku Laesvuori <[email-masked]>
Date: Sun, 26 Nov 2023 11:00:15 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/home/services/desktop.scm (home-unclutter-shepherd-service)
[one-shot?]: Remove field.
[stop]: Add kill action.

Change-Id: I33551607b05dbac30da94f81fd605ff9624ebe24
---
 gnu/home/services/desktop.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/home/services/desktop.scm b/gnu/home/services/desktop.scm
index 91465bf168..6bb117ea8c 100644
--- a/gnu/home/services/desktop.scm
+++ b/gnu/home/services/desktop.scm
@@ -347,7 +347,6 @@ (define (home-unclutter-shepherd-service config)
    (shepherd-service
     (provision '(unclutter))
     (requirement '())
-    (one-shot? #t)
     (start #~(make-forkexec-constructor
               (list
                #$(file-append
@@ -360,7 +359,8 @@ (define (home-unclutter-shepherd-service config)
                           (or (getenv "XDG_STATE_HOME")
                               (format #f "~a/.local/state"
                                       (getenv "HOME")))
-                          "/log/unclutter.log"))))))
+                          "/log/unclutter.log")))
+    (stop #~(make-kill-destructor)))))
 
 (define home-unclutter-service-type
   (service-type

base-commit: 9f67681db15d22f7ede5488315d52b78e357343e
-- 
2.41.0