GNU bug report logs - #67452
30.0.50; [PATCH] Make split-root-window functions handle argument

Previous Next

Package: emacs;

Reported by: Cy <cycoding23 <at> gmail.com>

Date: Sun, 26 Nov 2023 08:47:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 67452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Cy <cycoding23 <at> gmail.com>, martin rudalics <rudalics <at> gmx.at>
Cc: 67452 <at> debbugs.gnu.org
Subject: Re: bug#67452: 30.0.50;
 [PATCH] Make split-root-window functions handle argument
Date: Sun, 26 Nov 2023 13:01:19 +0200
> Date: Sun, 26 Nov 2023 00:42:54 -0800
> From: Cy <cycoding23 <at> gmail.com>
> 
> I noticed the split-root-window-below and split-root-window-right 
> commands fail when passing an argument using C-u:
> 
> split-root-window-right: Wrong type argument: number-or-marker-p, (4)
> 
> I have edited these functions to remedy this error, and attached a 
> patch. I hope that the changes are satisfactory.

I guess we should do this for consistency with other split-window-*
commands?  Martin, any reasons the split-root-window-* commands didn't
follow the example of the corresponding split-window-* commands?

In any case, to make the split-root-window-* commands support C-u we
just need to change the interactive spec from "P" to "p", there's no
need for anything more complex.

Thanks.




This bug report was last modified 1 year and 146 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.