GNU bug report logs - #67452
30.0.50; [PATCH] Make split-root-window functions handle argument

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Cy <cycoding23 <at> gmail.com>
Subject: bug#67452: closed (Re: bug#67452: 30.0.50; [PATCH] Make
 split-root-window functions handle argument)
Date: Wed, 29 Nov 2023 14:17:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67452 <at> debbugs.gnu.org.

-- 
67452: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67452
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: hugo <at> heagren.com, 67452-done <at> debbugs.gnu.org, cycoding23 <at> gmail.com
Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions
 handle argument
Date: Wed, 29 Nov 2023 16:16:19 +0200

> Date: Mon, 27 Nov 2023 10:20:36 +0100
> Cc: 67452 <at> debbugs.gnu.org, hugo <at> heagren.com
> From: martin rudalics <rudalics <at> gmx.at>
> 
>  > I guess we should do this for consistency with other split-window-*
>  > commands?  Martin, any reasons the split-root-window-* commands didn't
>  > follow the example of the corresponding split-window-* commands?
> 
> No idea.  Maybe Hugo Heagren can tell.
> 
>  > In any case, to make the split-root-window-* commands support C-u we
>  > just need to change the interactive spec from "P" to "p", there's no
>  > need for anything more complex.
> 
> I think so.  Here 'split-window-below' and 'split-window-right' use
> 
>    (let* ((size (and size (prefix-numeric-value size)))
> 
> maybe to "just work" when being passed an invalid SIZE argument but I
> don't remember the details.

Thanks, I've now installed the change on the emacs-29 branch, using
the "p" interactive spec, and I'm closing this bug.

[Message part 3 (message/rfc822, inline)]

From: Cy <cycoding23 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Make split-root-window functions handle argument
Date: Sun, 26 Nov 2023 00:42:54 -0800

[Message part 4 (text/plain, inline)]

Hello,

I noticed the split-root-window-below and split-root-window-right 
commands fail when passing an argument using C-u:

split-root-window-right: Wrong type argument: number-or-marker-p, (4)

I have edited these functions to remedy this error, and attached a 
patch. I hope that the changes are satisfactory.

Best,

Cy

[0001-Make-split-root-window-functions-handle-argument.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.