From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 03:46:08 2023 Received: (at submit) by debbugs.gnu.org; 26 Nov 2023 08:46:09 +0000 Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7AmG-0003zL-I0 for submit@debbugs.gnu.org; Sun, 26 Nov 2023 03:46:08 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7AjW-0003ti-4j for submit@debbugs.gnu.org; Sun, 26 Nov 2023 03:43:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7AjK-00073n-FZ for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 03:43:06 -0500 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7AjF-0001yq-3d for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 03:43:06 -0500 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5cd2f1a198cso29380887b3.0 for ; Sun, 26 Nov 2023 00:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700988179; x=1701592979; darn=gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=csgK99dlnHR9oiTczOwYb8EVTnvPLnKxHjUezv2vtaU=; b=Kwr0qs/7rxipokH2rFMnxPxUIZRe30rxu4xKD0b+cTVHYDzx9MtlJJ2LbZMxZapgN/ KWDpq1TQreCdkFwpLA3a15yOgQ4QQP4Ee1yW0ad4tntkgkc7Rl6Empe75SQnSeSnAvOd arH9qS/me2PEl6xXusfzfB/AxXSuS/Q7G47hMWCHPVCVqp6fPK3EB3IkOyaUIlwUD/XZ 0M0RPh+lFGpClMfr9A8kNFN+4PGdsiF7ti/LobLuEPpP8xC8w2Nmp7xOfG8WPePPVrZu QQCZs4CJ3lQvkGzHjkZYuAlbZltZBO1G05Bu3OBLkVqr/OVThQ8+J1Eo0l5sQQDRAHur VOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700988179; x=1701592979; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=csgK99dlnHR9oiTczOwYb8EVTnvPLnKxHjUezv2vtaU=; b=wlNPsPuYNNCx3lNPN7IttftcHJBu6+iQzMbc8mKxt+nO278B7qeuhGaXDAdypKQPLP 9smWM61YjaWy5zLyS5qhf+rJfh/C4+KbYCJGilEGO2k6RQW2thYpief6w3ZuwgnVPjL8 GPU4VKheQN5xOAlyXeRXoCOQhxh54RDaMSK65/5YMubZToSYvV36/kvm94ZAS1mtMBOo qGVZFbswDKHP5ZBrASMBv0xJhWZySvnPnOJWDvlQ1dZowjWmMI0YX+lIrGBekpNzbuQe 2QfIAh5KEvJdbrNlGgXetb5aQZec6NpfAxyd9J3fL69geydEeXo6uXzlDjSk3zrJkJp5 u1KQ== X-Gm-Message-State: AOJu0YyVJONTap67A8AgSacMA0yhth5YhOeNXOMIHui3rxPeQl/tI1CH zXoBPkrTQFt+vAcw2fPTnvxMQFWb45KxaZlZ X-Google-Smtp-Source: AGHT+IFpe94zwM3RZYG/t5KTA/9z4lGvdvBkB/ju8RSOPz6UcAmEKuPNV4XAHkNCFnZ7T8BDKdb7/Q== X-Received: by 2002:a81:8141:0:b0:5b3:1d71:6df7 with SMTP id r62-20020a818141000000b005b31d716df7mr10496092ywf.22.1700988179142; Sun, 26 Nov 2023 00:42:59 -0800 (PST) Received: from ?IPV6:2600:1700:1151:72b0::49? ([2600:1700:1151:72b0::49]) by smtp.gmail.com with ESMTPSA id j9-20020a816e09000000b0058fc7604f45sm2334384ywc.130.2023.11.26.00.42.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Nov 2023 00:42:58 -0800 (PST) Content-Type: multipart/mixed; boundary="------------4wdqeXaMzxO3yh7OvbbOy7Zn" Message-ID: Date: Sun, 26 Nov 2023 00:42:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Cy Subject: 30.0.50; [PATCH] Make split-root-window functions handle argument Received-SPF: pass client-ip=2607:f8b0:4864:20::1131; envelope-from=cycoding23@gmail.com; helo=mail-yw1-x1131.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, I noticed the split-root-window-below and split-root-window-right commands fail when passing an argument using C-u: split-root-window-right: Wrong type argument: number-or-marker-p, (4) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (cycoding23[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (cycoding23[at]gmail.com) -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 26 Nov 2023 03:46:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This is a multi-part message in MIME format. --------------4wdqeXaMzxO3yh7OvbbOy7Zn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I noticed the split-root-window-below and split-root-window-right commands fail when passing an argument using C-u: split-root-window-right: Wrong type argument: number-or-marker-p, (4) I have edited these functions to remedy this error, and attached a patch. I hope that the changes are satisfactory. Best, Cy --------------4wdqeXaMzxO3yh7OvbbOy7Zn Content-Type: text/x-patch; charset=UTF-8; name="0001-Make-split-root-window-functions-handle-argument.patch" Content-Disposition: attachment; filename*0="0001-Make-split-root-window-functions-handle-argument.patch" Content-Transfer-Encoding: base64 RnJvbSBlOGYzNzUxYTA4NTk2MmM4NWU1ZjM2MDQ2OWNlMDAyMjlmNGVhNjBmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDeSA8Y3ljb2RpbmcyM0BnbWFpbC5jb20+CkRhdGU6 IFN1biwgMjYgTm92IDIwMjMgMDA6MzQ6MjUgLTA4MDAKU3ViamVjdDogW1BBVENIXSBNYWtl IHNwbGl0LXJvb3Qtd2luZG93IGZ1bmN0aW9ucyBoYW5kbGUgYXJndW1lbnQKCiogbGlzcC93 aW5kb3cuZWwgKHNwbGl0LXJvb3Qtd2luZG93LWJlbG93LCBzcGxpdC1yb290LXdpbmRvdy1y aWdodCk6IEhhbmRsZSBwcmVmaXggYXJndW1lbnQgcGFzc2VkIGJ5IEMtdQotLS0KIGxpc3Av d2luZG93LmVsIHwgNiArKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aW5kb3cuZWwgYi9saXNwL3dp bmRvdy5lbAppbmRleCAwYzVjY2YxNjdkYy4uMjJlZDhjYzJiZGYgMTAwNjQ0Ci0tLSBhL2xp c3Avd2luZG93LmVsCisrKyBiL2xpc3Avd2luZG93LmVsCkBAIC01NzM1LDcgKzU3MzUsOCBA QCBhbW91bnQgb2YgcmVkaXNwbGF5OyB0aGlzIGlzIGNvbnZlbmllbnQgb24gc2xvdyB0ZXJt aW5hbHMuIgogVGhlIGN1cnJlbnQgd2luZG93IGNvbmZpZ3VyYXRpb24gaXMgcmV0YWluZWQg aW4gdGhlIHRvcCB3aW5kb3csCiB0aGUgbG93ZXIgd2luZG93IHRha2VzIHVwIHRoZSB3aG9s ZSB3aWR0aCBvZiB0aGUgZnJhbWUuICBTSVpFIGlzCiBoYW5kbGVkIGFzIGluIGBzcGxpdC13 aW5kb3ctYmVsb3cnLiIKLSAgKGludGVyYWN0aXZlICJQIikKKyAgKGludGVyYWN0aXZlICh3 aGVuIGN1cnJlbnQtcHJlZml4LWFyZworICAgICAgICAgICAgICAgICAocHJlZml4LW51bWVy aWMtdmFsdWUgY3VycmVudC1wcmVmaXgtYXJnKSkpCiAgIChzcGxpdC13aW5kb3ctYmVsb3cg c2l6ZSAoZnJhbWUtcm9vdC13aW5kb3cpKSkKIAogKGRlZnVuIHNwbGl0LXdpbmRvdy1yaWdo dCAoJm9wdGlvbmFsIHNpemUgd2luZG93LXRvLXNwbGl0KQpAQCAtNTc3NSw3ICs1Nzc2LDgg QEAgVGhlIGN1cnJlbnQgd2luZG93IGNvbmZpZ3VyYXRpb24gaXMgcmV0YWluZWQgd2l0aGlu IHRoZSBsZWZ0CiB3aW5kb3csIGFuZCBhIG5ldyB3aW5kb3cgaXMgY3JlYXRlZCBvbiB0aGUg cmlnaHQsIHRha2luZyB1cCB0aGUKIHdob2xlIGhlaWdodCBvZiB0aGUgZnJhbWUuICBTSVpF IGlzIHRyZWF0ZWQgYXMgYnkKIGBzcGxpdC13aW5kb3ctcmlnaHQnLiIKLSAgKGludGVyYWN0 aXZlICJQIikKKyAgKGludGVyYWN0aXZlICh3aGVuIGN1cnJlbnQtcHJlZml4LWFyZworICAg ICAgICAgICAgICAgICAocHJlZml4LW51bWVyaWMtdmFsdWUgY3VycmVudC1wcmVmaXgtYXJn KSkpCiAgIChzcGxpdC13aW5kb3ctcmlnaHQgc2l6ZSAoZnJhbWUtcm9vdC13aW5kb3cpKSkK IAwKIDs7OyBCYWxhbmNpbmcgd2luZG93cy4KLS0gCjIuNDMuMAoK --------------4wdqeXaMzxO3yh7OvbbOy7Zn-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 06:01:51 2023 Received: (at 67452) by debbugs.gnu.org; 26 Nov 2023 11:01:52 +0000 Received: from localhost ([127.0.0.1]:40780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Ctb-0007w6-Hl for submit@debbugs.gnu.org; Sun, 26 Nov 2023 06:01:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7CtZ-0007vq-J5 for 67452@debbugs.gnu.org; Sun, 26 Nov 2023 06:01:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7CtN-000251-RZ; Sun, 26 Nov 2023 06:01:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h4ILDf0cCNREZJh7OQDlu2ZKsP+O5ws6ShndLVovoK0=; b=Q1i+0DVjAgMi KajEx8fpmGoOVH89BEerNgBMF0Ag21BAOYYC5epzODNHYHtjMPIHTP16ePuHEzIFMEIb+1dAQKPFW HB5BWLcgYY5WtCkcFGYN84Wc8UdPqxuOEoHGKA5F6fYZ0EKIUZQ0g+Z1TOikAqmnJvNELB0nWqgkz RksjSrvqBkBg7lJtTefg/+90XeQQ0luSnwL0/s8YBM42fjl+9S3Sfjth88MRq+mLvoP5TPRngBi+m 7EyRNqE+kbamsZSx6LYJm/Hp5dLFmbtx1tFxnHlv2eeE2jowE0Jm8cEFXxrK8m8s+G6iegN6q5vXU RvH5iw0ng6vLKkPW0QDizQ==; Date: Sun, 26 Nov 2023 13:01:19 +0200 Message-Id: <831qccbwxs.fsf@gnu.org> From: Eli Zaretskii To: Cy , martin rudalics In-Reply-To: (message from Cy on Sun, 26 Nov 2023 00:42:54 -0800) Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67452 Cc: 67452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Nov 2023 00:42:54 -0800 > From: Cy > > I noticed the split-root-window-below and split-root-window-right > commands fail when passing an argument using C-u: > > split-root-window-right: Wrong type argument: number-or-marker-p, (4) > > I have edited these functions to remedy this error, and attached a > patch. I hope that the changes are satisfactory. I guess we should do this for consistency with other split-window-* commands? Martin, any reasons the split-root-window-* commands didn't follow the example of the corresponding split-window-* commands? In any case, to make the split-root-window-* commands support C-u we just need to change the interactive spec from "P" to "p", there's no need for anything more complex. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 27 04:21:35 2023 Received: (at 67452) by debbugs.gnu.org; 27 Nov 2023 09:21:35 +0000 Received: from localhost ([127.0.0.1]:43270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Xo7-0006oo-HW for submit@debbugs.gnu.org; Mon, 27 Nov 2023 04:21:35 -0500 Received: from mout.gmx.net ([212.227.17.21]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Xo4-0006oa-PZ for 67452@debbugs.gnu.org; Mon, 27 Nov 2023 04:21:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1701076838; x=1701681638; i=rudalics@gmx.at; bh=1V4Qz3j7xnjnK6iD1h0/19woAHMamssoHaYbU2l1pO4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=fZCX2nqlYtRzHS4t8HmaPIewcBHSTKldNICyWpbZaarCana5ESam7yiczlYW7Qvy 4F/wzg3URBdqcvoXJ3f/2Hg2KvKYzqf51XDaE+L0riOgBI2kcvUigaB2XRT1hZQLv I5M/drZ93JG0RjJfP4XvifyiReV9yhpe1RcrAXM+IjiHeHf2TRYFO/7797RShHFxP aBqufzs0rakx+4zOGzzuMgJqrI6DjFzedr7Yp2t6s2an3Y/vhloteWhKXIs8cVcTq heT/K4YqwczgK09V5pTeTDHN12Yf6vpWWA2wuHz/eQg2nvGMWMZs9SrLvAOMUzQYA nXqfND5f03XHzgkSjA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.96.139]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAci-1rj4TG1dWq-00beDs; Mon, 27 Nov 2023 10:20:38 +0100 Message-ID: <7a547440-ddc7-cdf6-2394-e006964285c1@gmx.at> Date: Mon, 27 Nov 2023 10:20:36 +0100 MIME-Version: 1.0 Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Content-Language: en-US To: Eli Zaretskii , Cy References: <831qccbwxs.fsf@gnu.org> From: martin rudalics In-Reply-To: <831qccbwxs.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:03w8cbhexE05LnI1S7EnhkwAUb+yi6fDOpLuJIGBTvRaSqQo9nH AnMRirc+OXXnzppdovFeObNTP9h6dzffS/OiavijB9/ewWxsZ+xQpY/wsK4HfPq96OYfMpD z4zKWMJnX51PyAzP6F4F+0YaDWLVx2oYHnTMEuqP0OS1htuoZS4l0mfpf6STJ2pGXcfgNDD PPX0Trfd/7Y7rWRCIg1+w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bYdNWJPqius=;CmveuHT70LqJNQXv44BQR2DOHEY T9JEDdUafYhRBUZ4dpTC43dP2ml418Bvw+tf7z6z4jSTbJUkDhDrsm2x6qAxsuT8cMUuJm62m nlPnqUPetTepYSEIKawvmnaGfqNDEsPcNP0DHTJmSq37SDbguvkEZ6RwElFc2vikE0vrKYiRt iQmi+iJ4f7lbIWaggAHAwRRPlNWyLNJtlorb9eTQRfp094adn61Ib89IzAHv7Q1bLus8XrkL7 GuEMSklXNlB6715PfAPm0fFKRW2VfEPPZdeXJbDgd7a3mAup2I+NI+D33r7vmA8o9cmORF5jd GUHvXG3ff/PlFTk9p/5Ucr9cM+v8ZuAY3HQ5G+gfPjUpBJsxAJma+8k41S48URQkNWM66zWsp 76v90O13Ob2gLMFE5wXKldOLdM/jngFqtHp3phaf9V838bxIZ5lmXpCX+y3+e0z5DEnFnhrOu NIDd7Fi3pNUCDVG23ij9inDl/TH3NomYVHbg7AnEX91jv90D4xjlbBia4QCv4CvygefX7b9kE ICpb3zyKLbmixavA6/w5JD6rhXp3ePoZ5gngHk4AVAwh8K+o7p5+3CKClSALHUOEuaOC77etu z0B1xxwJoqK2QyhQJQeNKypPLa1oZ2vOaPtSDCTvIfVaVwUVvdxjW36w+7etRREKSXJIlQVKu 7xuARJsj/AxX70p2hH2ijumzoQz1/nZMIj1fUBh3roA8Z7dUKFSyT22xrpwCkhbFOzQhdftNs tb99MLZ4Id5kzhKWyDOsN8z/Fp+yL4pkYUmJb0MZYTKKGMiVRiH/90p63u8aKHDd9kE/O25+2 IvBv6keqXhJKGwJYReucxfjB/k4g932qxW1WkgPBHq4qLTbLXUpWX1g4EWgF+jnxY3Y8ebNc2 nourDYtmNOVNAQJqCOlbylUnhb+csZ1mDY8xcZ5qaKJKVJ8/oMpUeiDEQPytfmtS80qjHFts+ 03p6vzLjUPyQ72YJQoldq/bbDpY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67452 Cc: 67452@debbugs.gnu.org, hugo@heagren.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I guess we should do this for consistency with other split-window-* > commands? Martin, any reasons the split-root-window-* commands didn't > follow the example of the corresponding split-window-* commands? No idea. Maybe Hugo Heagren can tell. > In any case, to make the split-root-window-* commands support C-u we > just need to change the interactive spec from "P" to "p", there's no > need for anything more complex. I think so. Here 'split-window-below' and 'split-window-right' use (let* ((size (and size (prefix-numeric-value size))) maybe to "just work" when being passed an invalid SIZE argument but I don't remember the details. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 09:16:47 2023 Received: (at 67452-done) by debbugs.gnu.org; 29 Nov 2023 14:16:47 +0000 Received: from localhost ([127.0.0.1]:49205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LMt-0002H4-1p for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:16:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LMp-0002Gq-UB for 67452-done@debbugs.gnu.org; Wed, 29 Nov 2023 09:16:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8LMc-00081X-3S; Wed, 29 Nov 2023 09:16:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZlM8t0N2hWJza7O6y+FwyYBmJt1bYq1s0rRljqt7W24=; b=OlWBu2o2ds32 N/MKLcdbrzYN412JDZxgr0xyNwzp0KMm67QE4tJBUvHBMlVPfwGR3Z6DxSkNqKQABeUFP+SkFKHQN GgpKQiohc3uf+yahUe1nrycXOkb/c2DqA5Tnb4XvdyokzBFCUU54+sDbKJSdyMCXOAPf5hz3uKI1w TH7UAbCSiBNtecmqRZRCch3/LUmD/aqEGLu9TWMyDkAnPab0iQHBuNsIZWlfBUjJb0mtYNbGwRzkH 1c4h0jan55EM+HMamhDqweElb/sqvHKAvaWQTqjOMxuVO+U0QNkPV+I8V5Puq2+Eqj8rUqm81RA9M wOlLfEAznbK9m/Eljs1muw==; Date: Wed, 29 Nov 2023 16:16:19 +0200 Message-Id: <838r6g7ih8.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <7a547440-ddc7-cdf6-2394-e006964285c1@gmx.at> (message from martin rudalics on Mon, 27 Nov 2023 10:20:36 +0100) Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument References: <831qccbwxs.fsf@gnu.org> <7a547440-ddc7-cdf6-2394-e006964285c1@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67452-done Cc: hugo@heagren.com, 67452-done@debbugs.gnu.org, cycoding23@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 27 Nov 2023 10:20:36 +0100 > Cc: 67452@debbugs.gnu.org, hugo@heagren.com > From: martin rudalics > > > I guess we should do this for consistency with other split-window-* > > commands? Martin, any reasons the split-root-window-* commands didn't > > follow the example of the corresponding split-window-* commands? > > No idea. Maybe Hugo Heagren can tell. > > > In any case, to make the split-root-window-* commands support C-u we > > just need to change the interactive spec from "P" to "p", there's no > > need for anything more complex. > > I think so. Here 'split-window-below' and 'split-window-right' use > > (let* ((size (and size (prefix-numeric-value size))) > > maybe to "just work" when being passed an invalid SIZE argument but I > don't remember the details. Thanks, I've now installed the change on the emacs-29 branch, using the "p" interactive spec, and I'm closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 24 12:44:11 2023 Received: (at 67452) by debbugs.gnu.org; 24 Dec 2023 17:44:11 +0000 Received: from localhost ([127.0.0.1]:53489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHSWJ-0002D5-5b for submit@debbugs.gnu.org; Sun, 24 Dec 2023 12:44:11 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:33425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHSWH-0002Cg-1X for 67452@debbugs.gnu.org; Sun, 24 Dec 2023 12:44:09 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7271260003 for <67452@debbugs.gnu.org>; Sun, 24 Dec 2023 17:43:55 +0000 (UTC) From: Juri Linkov To: 67452@debbugs.gnu.org Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument In-Reply-To: (GNU bug Tracking System's message of "Wed, 29 Nov 2023 14:17:01 +0000") Organization: LINKOV.NET References: <838r6g7ih8.fsf@gnu.org> Date: Sun, 24 Dec 2023 19:41:37 +0200 Message-ID: <86sf3rqyzy.fsf_-_@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67452 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks, I've now installed the change on the emacs-29 branch, using > the "p" interactive spec, and I'm closing this bug. The commit cd477bf07d8 broke normal use of split-root-window commands without arguments: 0. emacs-29 -Q 1. C-x 2 2. C-x w 3 Debugger entered--Lisp error: (error "Window # too small for splitting") error("Window %s too small for splitting" #) split-window(# 1 t) split-window-right(1 #) split-root-window-right(1) funcall-interactively(split-root-window-right 1) command-execute(split-root-window-right) because the "p" interactive spec uses SIZE=1. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 25 08:01:06 2023 Received: (at 67452) by debbugs.gnu.org; 25 Dec 2023 13:01:06 +0000 Received: from localhost ([127.0.0.1]:54129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHkZu-0000ob-2M for submit@debbugs.gnu.org; Mon, 25 Dec 2023 08:01:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHkZs-0000dE-F9 for 67452@debbugs.gnu.org; Mon, 25 Dec 2023 08:01:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHkZg-0006za-8m; Mon, 25 Dec 2023 08:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h2pn51IY4qRTlgW8NlhlJ68br3krFH/2/gPhHBBb8YY=; b=AXKkV/3j4AjH jIKehv1azgbjAVchIYfpyN1Lg2BycvaDGKWOHF7vkvD+2cJXsmMIcW5rLTlZflr8D+muWYl7hpMja ZmP06Ze6ryeBium9/lFcBen4/Wun2TJkyqcO1jfYELVZB4kg9VqPLLVTuqb9l0Ht93p+EEAbvU3tN Ry8EZp6T0iHbrSqySW7h9IzRNHdnoZijvK+7qI8e609e53DfcXZU+pbNkPs2IicmvtjAVNvce37Ua O0ocT8RBMBXgBStUYqvcGU12jWpixc5DTvMBHNXh76iqTowZIYIv4qUNrLBsw/70SL6yveYKasjCb kPy8LISv98bSF1DhIfcilA==; Date: Mon, 25 Dec 2023 15:00:49 +0200 Message-Id: <831qbabfni.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86sf3rqyzy.fsf_-_@mail.linkov.net> (message from Juri Linkov on Sun, 24 Dec 2023 19:41:37 +0200) Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument References: <838r6g7ih8.fsf@gnu.org> <86sf3rqyzy.fsf_-_@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67452 Cc: 67452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Sun, 24 Dec 2023 19:41:37 +0200 > > > Thanks, I've now installed the change on the emacs-29 branch, using > > the "p" interactive spec, and I'm closing this bug. > > The commit cd477bf07d8 broke normal use of split-root-window commands > without arguments: > > 0. emacs-29 -Q > 1. C-x 2 > 2. C-x w 3 > > Debugger entered--Lisp error: (error "Window # too small for splitting") > error("Window %s too small for splitting" #) > split-window(# 1 t) > split-window-right(1 #) > split-root-window-right(1) > funcall-interactively(split-root-window-right 1) > command-execute(split-root-window-right) > > because the "p" interactive spec uses SIZE=1. Thanks, should be fixed now on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 02:43:25 2023 Received: (at 67452-done) by debbugs.gnu.org; 30 Dec 2023 07:43:25 +0000 Received: from localhost ([127.0.0.1]:42960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJU0C-0003R5-RP for submit@debbugs.gnu.org; Sat, 30 Dec 2023 02:43:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJU0B-0003Qr-3v for 67452-done@debbugs.gnu.org; Sat, 30 Dec 2023 02:43:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJU05-0001pq-CK; Sat, 30 Dec 2023 02:43:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gnAYkrnn4lbVX//Q3iOilYm7fEYxS5c2JLRwt+x3g9Q=; b=mkf9D8dfwTIB zHjOLb6IsjaGZMXnk8tJgpzig+7W4gno10Z5M7+bThHQpZqTTkb1j9F1a65gmeGE8BVhBTykezKAZ bygoUwfvu9b9gZz3npRwReYknuq0EF4z6MjD8tVOeUPLdB/0Q607GDI6ZEN6Z2rAiXUGkNjzL9Sry JhkybPhmO9xWaWE3xey+x/GwQ2v+seJ5FsufVvLAvgkDtCPFT4lxeu9qzV3Rxu/Q+FDIrFHOJGl/Z 45dA+m/TUs9OlQzQgz3iXSkYx4TSgYuJfeBlY/OCBgTb/194YsjkT5QsepNDBctzh+MJerA98X05G KH7CMJjVsYJ7gEYtfrxHUQ==; Date: Sat, 30 Dec 2023 09:43:07 +0200 Message-Id: <83plyo3zlg.fsf@gnu.org> From: Eli Zaretskii To: juri@linkov.net In-Reply-To: <831qbabfni.fsf@gnu.org> (message from Eli Zaretskii on Mon, 25 Dec 2023 15:00:49 +0200) Subject: Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument References: <838r6g7ih8.fsf@gnu.org> <86sf3rqyzy.fsf_-_@mail.linkov.net> <831qbabfni.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67452-done Cc: 67452-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67452@debbugs.gnu.org > Date: Mon, 25 Dec 2023 15:00:49 +0200 > From: Eli Zaretskii > > > From: Juri Linkov > > Date: Sun, 24 Dec 2023 19:41:37 +0200 > > > > > Thanks, I've now installed the change on the emacs-29 branch, using > > > the "p" interactive spec, and I'm closing this bug. > > > > The commit cd477bf07d8 broke normal use of split-root-window commands > > without arguments: > > > > 0. emacs-29 -Q > > 1. C-x 2 > > 2. C-x w 3 > > > > Debugger entered--Lisp error: (error "Window # too small for splitting") > > error("Window %s too small for splitting" #) > > split-window(# 1 t) > > split-window-right(1 #) > > split-root-window-right(1) > > funcall-interactively(split-root-window-right 1) > > command-execute(split-root-window-right) > > > > because the "p" interactive spec uses SIZE=1. > > Thanks, should be fixed now on the emacs-29 branch. No further comments, so I presume the bug was fixed, and I'm closing it. From unknown Tue Aug 19 02:51:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Jan 2024 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator