GNU bug report logs - #67450
[PATCH] gnu: grep: Fix pcre matching in grep.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67450: closed ([PATCH] gnu: grep: Fix pcre matching in grep.)
Date: Sun, 26 Nov 2023 14:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 Nov 2023 14:59:07 +0100
with message-id <87zfz0lid0.fsf <at> nckx>
and subject line Re: [bug#67450] [PATCH] gnu: grep: Fix pcre matching in grep.
has caused the debbugs.gnu.org bug report #67450,
regarding [PATCH] gnu: grep: Fix pcre matching in grep.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67450: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67450
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: spacecadet <spacecadet <at> purge.sh>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: grep: Fix pcre matching in grep.
Date: Sun, 26 Nov 2023 03:12:08 +0000

Fix grep not building with -P (perl regexp) support.

* gnu/packages/base.scm: Replace grep's pcre input with pcre2.
* gnu/packages/base.scm: Add "--enable-perl-regexp" configure flag to grep.
---
 gnu/packages/base.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 41aff0ca97..feb5ca5746 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -120,9 +120,11 @@ (define-public grep
             (patches (search-patches "grep-timing-sensitive-test.patch"))))
    (build-system gnu-build-system)
    (native-inputs (list perl))                   ;some of the tests require it
-   (inputs (list pcre))
+   (inputs (list pcre2))
    (arguments
-    `(#:phases
+    `(#:configure-flags
+      (list "--enable-perl-regexp")
+      #:phases
       (modify-phases %standard-phases
         (add-after 'install 'fix-egrep-and-fgrep
           ;; Patch 'egrep' and 'fgrep' to execute 'grep' via its

base-commit: 13bc0633e77c73389e530a4c45e2de5a823f106b
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: spacecadet <spacecadet <at> purge.sh>
Cc: 67450-done <at> debbugs.gnu.org
Subject: Re: [bug#67450] [PATCH] gnu: grep: Fix pcre matching in grep.
Date: Sun, 26 Nov 2023 14:59:07 +0100

[Message part 4 (text/plain, inline)]

Hi!

(Please don't hesitate to submit bug fixes upstream, especially 
when the breakage is so clearly unintentional :-)

I changed the changelog to better follow our standards

   gnu: grep: Fix PCRE matches (grep -P).

   {{{No blurb here if it only rephrases the title.}}}

   * gnu/packages/base.scm (grep)[inputs]: Replace pcre with 
   pcre2.
   [arguments]: Add "--enable-perl-regexp" to #:configure-flags 
   to
   detect broken PCRE in future.

and pushed this to core-updates as 
5b0cea02358044f0cc695bacc3f44db1e220239b.

Thanks,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.