From unknown Sun Jun 22 11:44:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Resent-From: "Johan Bockg\=e5rd" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jul 2010 00:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6744@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12802761328560 (code B ref -1); Wed, 28 Jul 2010 00:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jul 2010 00:15:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduJ1-0002E1-Th for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:32 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduIz-0002Dv-CD for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:29 -0400 Received: from lists.gnu.org ([199.232.76.165]:60393) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OduJ8-0007QE-DJ for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:38 -0400 Received: from [140.186.70.92] (port=54955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OduJ6-0008Uh-8T for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OduJ5-00068L-1e for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:36 -0400 Received: from smtprelay-h22.telenor.se ([195.54.99.197]:53281) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduJ4-000685-Nk for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:35 -0400 Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id 4658AE9912 for ; Wed, 28 Jul 2010 02:15:33 +0200 (CEST) X-SENDER-IP: [85.228.196.148] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsREAOsST0xV5MSUPGdsb2JhbACHZoszjFAMAQEBATUtwmeFNgQ X-IronPort-AV: E=Sophos;i="4.55,271,1278280800"; d="scan'208";a="553819665" Received: from c-94c4e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.196.148]) by ipb3.telenor.se with ESMTP; 28 Jul 2010 02:15:33 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 12A4B4843CA; Wed, 28 Jul 2010 02:15:32 +0200 (CEST) From: "Johan Bockg\=e5rd" Mail-Copies-To: never Date: Wed, 28 Jul 2010 02:15:32 +0200 Message-ID: <87ocdsxxzv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Found by --enable-checking. (defvar foo nil) (defvaralias 'bar 'foo) (make-local-variable 'bar) (local-variable-p 'bar) returns nil or may crash if checking is enabled. (trunk) 2010-07-27 Johan Bockg=e5rd * data.c (Flocal_variable_p): Handle variable aliases correctly. diff --git a/src/data.c b/src/data.c index 152a888..b78a665 100644 --- a/src/data.c +++ b/src/data.c @@ -1865,6 +1865,7 @@ BUFFER defaults to the current buffer. */) Lisp_Object tail, elt, tmp; struct Lisp_Buffer_Local_Value *blv = SYMBOL_BLV (sym); XSETBUFFER (tmp, buf); + XSETSYMBOL (variable, sym); /* Update in case of aliasing. */ for (tail = buf->local_var_alist; CONSP (tail); tail = XCDR (tail)) { From unknown Sun Jun 22 11:44:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jul 2010 00:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Johan Bockg=e5rd" Cc: 6744@debbugs.gnu.org Received: via spool by 6744-submit@debbugs.gnu.org id=B6744.12802786499673 (code B ref 6744); Wed, 28 Jul 2010 00:58:02 +0000 Received: (at 6744) by debbugs.gnu.org; 28 Jul 2010 00:57:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oduxc-0002Vx-LH for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:57:28 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduxZ-0002Vq-Ur for 6744@debbugs.gnu.org; Tue, 27 Jul 2010 20:57:26 -0400 Received: by bwz7 with SMTP id 7so4005680bwz.3 for <6744@debbugs.gnu.org>; Tue, 27 Jul 2010 17:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=hMHHbJQ7Lg2iWsVXK3nWTLUNDrgd9iZ0P1PVSka5jmE=; b=AXWSocgnm/aEehZ09ZOOpzeTWScNF9EcS+FuRdTnbRZZnf0W+gZEMr2YoBCCZI79F1 ngrjByyVoT5U3EEjydxGmuCpQ/uBdPWxiKslBRMXh5ZIXla4sQFwfNO8KknxQzQQZwMq 6VN4uJ7O2O6hGxSpEbxv30adS5foD0mMAkFZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=fgEAD2yABJ4BKAZHYsjLp5P9dVpNxibcZn7/oFyTG/qtwUWYm09krRiTXkQtpPGAU9 XhWD1ebkEvVr0hS/KLJDcahqPVHvHl9l3CfHnOr+gH3ZACe1WyGjNwTYu6dObvCgjVsB GauVEJLJtwW+1y35d0lr3ojcqlcWtloWFmbbQ= Received: by 10.204.53.211 with SMTP id n19mr7247967bkg.66.1280278654409; Tue, 27 Jul 2010 17:57:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.180.136 with HTTP; Tue, 27 Jul 2010 17:57:14 -0700 (PDT) In-Reply-To: <87ocdsxxzv.fsf@gnu.org> References: <87ocdsxxzv.fsf@gnu.org> From: Juanma Barranquero Date: Wed, 28 Jul 2010 02:57:14 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Jul 28, 2010 at 02:15, Johan Bockg=3De5rd wrote: > =C2=A0 =C2=A0(defvar foo nil) > =C2=A0 =C2=A0(defvaralias 'bar 'foo) > =C2=A0 =C2=A0(make-local-variable 'bar) > =C2=A0 =C2=A0(local-variable-p 'bar) > > returns nil or may crash if checking is enabled. (trunk) On the trunk, setting the forms inside a progn and evaluating it at once with C-x C-e, I get nil on first try, and a crash on second try. On emacs-23 there's no crash, but (local-variable-p 'bar) =3D> nil. > + =C2=A0 =C2=A0 =C2=A0 XSETSYMBOL (variable, sym); /* Update in case of a= liasing. =C2=A0*/ Does this fix work also for emacs-23? =C2=A0 =C2=A0 Juanma From unknown Sun Jun 22 11:44:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Resent-From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jul 2010 03:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juanma Barranquero Cc: 6744@debbugs.gnu.org Received: via spool by 6744-submit@debbugs.gnu.org id=B6744.128028724013397 (code B ref 6744); Wed, 28 Jul 2010 03:21:01 +0000 Received: (at 6744) by debbugs.gnu.org; 28 Jul 2010 03:20:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdxCC-0003U2-76 for submit@debbugs.gnu.org; Tue, 27 Jul 2010 23:20:40 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdxC9-0003Tx-PG for 6744@debbugs.gnu.org; Tue, 27 Jul 2010 23:20:39 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 6FBB3E9397 for <6744@debbugs.gnu.org>; Wed, 28 Jul 2010 05:20:46 +0200 (CEST) X-SENDER-IP: [85.228.196.148] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlU+AII+T0xV5MSUPGdsb2JhbACDFIRSmAMMAQEBATUtsA+RY4Emgx1zBA X-IronPort-AV: E=Sophos;i="4.55,271,1278280800"; d="scan'208";a="111558910" Received: from c-94c4e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.196.148]) by ipb1.telenor.se with ESMTP; 28 Jul 2010 05:20:46 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 45B994843CA; Wed, 28 Jul 2010 05:20:45 +0200 (CEST) From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= References: <87ocdsxxzv.fsf@gnu.org> Date: Wed, 28 Jul 2010 05:20:45 +0200 In-Reply-To: (Juanma Barranquero's message of "Wed, 28 Jul 2010 02:57:14 +0200") Message-ID: <87eieoxpf6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Juanma Barranquero writes: > On Wed, Jul 28, 2010 at 02:15, Johan Bockg=3De5rd wrote: > >> =C2=A0 =C2=A0(defvar foo nil) >> =C2=A0 =C2=A0(defvaralias 'bar 'foo) >> =C2=A0 =C2=A0(make-local-variable 'bar) >> =C2=A0 =C2=A0(local-variable-p 'bar) >> >> returns nil or may crash if checking is enabled. (trunk) > > On the trunk, setting the forms inside a progn and evaluating it at > once with C-x C-e, I get nil on first try, and a crash on second try. > > On emacs-23 there's no crash, but (local-variable-p 'bar) =3D> nil. It is? I thought this problem only existed in the trunk, and I can't reproduce it in the emacs-23 branch. From unknown Sun Jun 22 11:44:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jul 2010 03:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Cc: 6744@debbugs.gnu.org Received: via spool by 6744-submit@debbugs.gnu.org id=B6744.128028805413728 (code B ref 6744); Wed, 28 Jul 2010 03:35:02 +0000 Received: (at 6744) by debbugs.gnu.org; 28 Jul 2010 03:34:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdxPJ-0003ZN-KO for submit@debbugs.gnu.org; Tue, 27 Jul 2010 23:34:13 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdxPH-0003ZI-KA for 6744@debbugs.gnu.org; Tue, 27 Jul 2010 23:34:12 -0400 Received: by bwz7 with SMTP id 7so4043473bwz.3 for <6744@debbugs.gnu.org>; Tue, 27 Jul 2010 20:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=fiGq4/KWT55SjF+9uWh61raRZW14c4BRFDGUw98ndNE=; b=p05C0zw15oQmgYW3TRyDqn+iHhXISCQeJollD4fRGUw+3ks312aYCuNGIpPYSP3HCS EnPMYcPQ9GTs1JzrjEMklH/AO5/G751m1/N3iY8/ZSQs4qOnPqTxrTlQMsn394kOsqzF /lhwHlc8qKeOhkWG91WQunNK6Y86Q1shwpE5M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=s2LLtr8PqfwTF95nBL7FbJig9MkdP9YnSm9fUMAi6wHsWqsWa6A3TMKorrcIkNcXZP yNSsVp/hp3dk7Jp3PgYP7Vl6ap1DaVOhQmTO4aAj+bYO1kcvxGx/QMpHTVgMVsDMd3Er lJAdWS0BkhmrYf6Vof2QVyTYg93AcinF1GieQ= Received: by 10.204.79.223 with SMTP id q31mr7458724bkk.92.1280288059234; Tue, 27 Jul 2010 20:34:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.180.136 with HTTP; Tue, 27 Jul 2010 20:33:59 -0700 (PDT) In-Reply-To: <87eieoxpf6.fsf@gnu.org> References: <87ocdsxxzv.fsf@gnu.org> <87eieoxpf6.fsf@gnu.org> From: Juanma Barranquero Date: Wed, 28 Jul 2010 05:33:59 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Jul 28, 2010 at 05:20, Johan Bockg=C3=A5rd wrote: > It is? I thought this problem only existed in the trunk, and I can't > reproduce it in the emacs-23 branch. You're right, it returns t. Sorry for the noise. =C2=A0 =C2=A0 Juanma From unknown Sun Jun 22 11:44:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Aug 2010 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Johan Bockg=e5rd" Cc: 6744@debbugs.gnu.org Received: via spool by 6744-submit@debbugs.gnu.org id=B6744.128068770816327 (code B ref 6744); Sun, 01 Aug 2010 18:36:02 +0000 Received: (at 6744) by debbugs.gnu.org; 1 Aug 2010 18:35:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfdNM-0004FI-Jx for submit@debbugs.gnu.org; Sun, 01 Aug 2010 14:35:08 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfdNL-0004F0-H6 for 6744@debbugs.gnu.org; Sun, 01 Aug 2010 14:35:08 -0400 Received: by iwn38 with SMTP id 38so3046964iwn.3 for <6744@debbugs.gnu.org>; Sun, 01 Aug 2010 11:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=hGBTGRmuyLcJcOkvFRUIAxBFREO/Xzi8x2U4Fajt7yM=; b=AhgXS+idYXFmuE9VQnEiMybaNO/hzQS4fqhHHSCNUSta4oaV9dqf6Lj4GjBbaKWEsp IDgi4/4F54SdJ8kW40yp6Yu+p89cjSGW8Is0n1LkjOCQbsJsnRNgM4/tzowwXjBWj0yI Tf+0Egp0yQyl83riv4mfm054p0HOyR9godJGo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=DeTXnKOs4X6/XRH/Fn1reb9mNexnlXRZqp2VJ7HyiCwAc/7YUcuFksymSOpMjSKNil 0aDhhhTJUb2wWwEzG2+vDv3kQTAdPPUv07z2PJ1jKttJaPxzzeX1mZVbR5ZNRrhoMhRL 4s+Eg37xvqS1VHG3A7f0de/9wKKI1Pyhp3bXU= Received: by 10.231.182.204 with SMTP id cd12mr5764115ibb.101.1280687728359; Sun, 01 Aug 2010 11:35:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.162.4 with HTTP; Sun, 1 Aug 2010 11:35:07 -0700 (PDT) In-Reply-To: <87ocdsxxzv.fsf@gnu.org> References: <87ocdsxxzv.fsf@gnu.org> From: Juanma Barranquero Date: Sun, 1 Aug 2010 20:35:07 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Jul 28, 2010 at 02:15, Johan Bockg=3De5rd wrote: > 2010-07-27 =C2=A0Johan Bockg=3De5rd =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* data.c (Flocal_variable_p): Handle variable = aliases correctly. > > + =C2=A0 =C2=A0 =C2=A0 XSETSYMBOL (variable, sym); /* Update in case of a= liasing. =C2=A0*/ If you think this is the right fix, please install it. =C2=A0 =C2=A0 Juanma From unknown Sun Jun 22 11:44:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Johan Bockg\=e5rd" Subject: bug#6744: closed (Re: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly) Message-ID: References: <87aap38vqq.fsf@gnu.org> <87ocdsxxzv.fsf@gnu.org> X-Gnu-PR-Message: they-closed 6744 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 6744@debbugs.gnu.org Date: Tue, 03 Aug 2010 17:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1280855642-12668-1" This is a multi-part message in MIME format... ------------=_1280855642-12668-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6744@debbugs.gnu.org. --=20 6744: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6744 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1280855642-12668-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6744-done) by debbugs.gnu.org; 3 Aug 2010 17:13:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OgL3P-0003I7-Si for submit@debbugs.gnu.org; Tue, 03 Aug 2010 13:13:28 -0400 Received: from smtprelay-b11.telenor.se ([62.127.194.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OgL3N-0003I2-SF for 6744-done@debbugs.gnu.org; Tue, 03 Aug 2010 13:13:27 -0400 Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-b11.telenor.se (Postfix) with ESMTP id A70BEE8BAA for <6744-done@debbugs.gnu.org>; Tue, 3 Aug 2010 19:13:51 +0200 (CEST) X-SENDER-IP: [85.228.201.73] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Akk4ADbrV0xV5MlJPGdsb2JhbACDFYRSmCkMAQEBATUtskySDYEmgyBzBA X-IronPort-AV: E=Sophos;i="4.55,311,1278280800"; d="scan'208";a="113246409" Received: from c-49c9e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.201.73]) by ipb2.telenor.se with ESMTP; 03 Aug 2010 19:13:51 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id A91D38A42DE; Tue, 3 Aug 2010 19:13:49 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: Juanma Barranquero Subject: Re: bug#6744: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly References: <87ocdsxxzv.fsf@gnu.org> Mail-Copies-To: never Date: Tue, 03 Aug 2010 19:13:49 +0200 In-Reply-To: (Juanma Barranquero's message of "Sun, 1 Aug 2010 20:35:07 +0200") Message-ID: <87aap38vqq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6744-done Cc: 6744-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Juanma Barranquero writes: > On Wed, Jul 28, 2010 at 02:15, Johan Bockg=3De5rd wrote: > >> 2010-07-27 =C2=A0Johan Bockg=3De5rd =C2=A0 >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0* data.c (Flocal_variable_p): Handle variable= aliases correctly. >> >> + =C2=A0 =C2=A0 =C2=A0 XSETSYMBOL (variable, sym); /* Update in case of = aliasing. =C2=A0*/ > > If you think this is the right fix, please install it. Done. ------------=_1280855642-12668-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jul 2010 00:15:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduJ1-0002E1-Th for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:32 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduIz-0002Dv-CD for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:29 -0400 Received: from lists.gnu.org ([199.232.76.165]:60393) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OduJ8-0007QE-DJ for submit@debbugs.gnu.org; Tue, 27 Jul 2010 20:15:38 -0400 Received: from [140.186.70.92] (port=54955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OduJ6-0008Uh-8T for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OduJ5-00068L-1e for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:36 -0400 Received: from smtprelay-h22.telenor.se ([195.54.99.197]:53281) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OduJ4-000685-Nk for bug-gnu-emacs@gnu.org; Tue, 27 Jul 2010 20:15:35 -0400 Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id 4658AE9912 for ; Wed, 28 Jul 2010 02:15:33 +0200 (CEST) X-SENDER-IP: [85.228.196.148] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsREAOsST0xV5MSUPGdsb2JhbACHZoszjFAMAQEBATUtwmeFNgQ X-IronPort-AV: E=Sophos;i="4.55,271,1278280800"; d="scan'208";a="553819665" Received: from c-94c4e455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.196.148]) by ipb3.telenor.se with ESMTP; 28 Jul 2010 02:15:33 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 12A4B4843CA; Wed, 28 Jul 2010 02:15:32 +0200 (CEST) From: "Johan Bockg\=e5rd" To: bug-gnu-emacs@gnu.org Subject: 24.0.50; [PATCH] local-variable-p: Handle variable aliases correctly Mail-Copies-To: never Date: Wed, 28 Jul 2010 02:15:32 +0200 Message-ID: <87ocdsxxzv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Found by --enable-checking. (defvar foo nil) (defvaralias 'bar 'foo) (make-local-variable 'bar) (local-variable-p 'bar) returns nil or may crash if checking is enabled. (trunk) 2010-07-27 Johan Bockg=e5rd * data.c (Flocal_variable_p): Handle variable aliases correctly. diff --git a/src/data.c b/src/data.c index 152a888..b78a665 100644 --- a/src/data.c +++ b/src/data.c @@ -1865,6 +1865,7 @@ BUFFER defaults to the current buffer. */) Lisp_Object tail, elt, tmp; struct Lisp_Buffer_Local_Value *blv = SYMBOL_BLV (sym); XSETBUFFER (tmp, buf); + XSETSYMBOL (variable, sym); /* Update in case of aliasing. */ for (tail = buf->local_var_alist; CONSP (tail); tail = XCDR (tail)) { ------------=_1280855642-12668-1--