From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#67427] [PATCH] guix-install.sh: Fix sys_create_init_profile. Resent-From: typ22@foxmail.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Nov 2023 06:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67427@debbugs.gnu.org Cc: tiantian X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170080821029003 (code B ref -1); Fri, 24 Nov 2023 06:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Nov 2023 06:43:30 +0000 Received: from localhost ([127.0.0.1]:35517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6PuT-0007Xi-68 for submit@debbugs.gnu.org; Fri, 24 Nov 2023 01:43:29 -0500 Received: from lists.gnu.org ([2001:470:142::17]:34454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6PuO-0007XI-3J for submit@debbugs.gnu.org; Fri, 24 Nov 2023 01:43:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6Ptx-000542-U2 for guix-patches@gnu.org; Fri, 24 Nov 2023 01:42:59 -0500 Received: from out162-62-57-210.mail.qq.com ([162.62.57.210]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6Pts-0006YO-Hf for guix-patches@gnu.org; Fri, 24 Nov 2023 01:42:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1700808165; bh=PRG+83T7LMyspjtY9Y0vyxPhp9VjRpuin1hc4/ZKXMg=; h=From:To:Cc:Subject:Date; b=iBfrkLAfLAq9zpD+OfvPSKDL5BHUEygV8Nwy9DKpCmIBq95QykpFHSzqpJZcjvwP6 c81XoXaVOxUz/oYipgUHOc54qakGVd+OYhqE2nH9IieOpwwMuMOtWkgWPuyhT5ocuH BTgFYTS/p8zMHwVRE35IhBDAojX7qs/yH0nxCuxg= Received: from tt-arch.localdomain ([101.94.248.238]) by newxmesmtplogicsvrszc5-1.qq.com (NewEsmtp) with SMTP id 9DBB1666; Fri, 24 Nov 2023 14:39:27 +0800 X-QQ-mid: xmsmtpt1700807967tw3ei7u5z Message-ID: X-QQ-XMAILINFO: OQhZ3T0tjf0aQbYFlfSbOCYBqKqvkJiv07oA9/wdf2J6FGdp+5oeMXYtT4nhvI tKDeUCFk9zrDQZxzKeEdTV3lh2oeD2K0pjQD5Z6cMASR8zmM2QDC5jr5Vr3SvLdfBVc+qJkdQ6e0 xiBDn0sZnGYOgNlFlottWwg2apmyBPhwt91B7BXZ92OtOwUC66zxGSoveQgUbzUQy3KuNajg/zQF Ql2Mo8BFge8ZtCPzg9CFKHYc274Af6Y/HivhABPz9ZIW5E/vrNDnc9jQTi/WHccopKgOQ5wrREAa eq+UMIeycfMOu/6/xhesXQs/EHmyGWEbJiuU0iVPrOF1X1zEA48/2GX5vQV/w7134Yemcqj7awFr xjYIEA0lbCjFMQHfBES11kekE9piZpYXoyUzp1v21kJtFPfQ+F82WD/6BBn8F0jY0lHKctSgbhTl 2qKUJbB4Ba4+8hBgLzgDHdpZsP15jqTh2iBBHO8tCM4QVJwy2qlfqf9VOd7Kq0PitLwg7FWnyGb2 0MSXCxOc0SMjBdH62B8lbqf64iXLv7dcIaRyCHK9+rGTffVpz2v6scKKxvBkzWPd2TfRxFgahuoH qeH3ELmF/sipdkLHf0u+3ElKn5xGpWAho9q63Me2IEINFipnvkU/BHWmLFsCnVYfcWr5fWLVjEve g9Vvn2CjHxL+PnrEp9NfYixwX+87FnNiIgL7ffAl85Zhghw9QrU3vWZdQV8FaXR9QjIheTAAAuML gtIlQdaaILADwvEMXoNHtmk4cVccLdEB8vEJa1RDZ9/BdSd7nlmcjkzAXFjRKKhAshoYUMT1ryR3 kSlP/5w6DQjYJYe9BsCWtf3AOyWsbhF4nrzr3Tko7TFwXka4Rv0vx2SjGKyeiWy0pMLJ+ESu7E5Q eSkU7hQeXPv2nUvjOebbUa1V0GsLr40v1X1X8/G+6ArqEySG9a0R0= X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= From: typ22@foxmail.com Date: Fri, 24 Nov 2023 14:03:40 +0800 X-OQ-MSGID: <20231124063913.4434-1-typ22@foxmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=162.62.57.210; envelope-from=typ22@foxmail.com; helo=out162-62-57-210.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: tiantian * etc/guix-install.sh (sys_create_init_profile): Remove the redundant colons in GUIX_LOCPATH and change '||' to '&&'. --- etc/guix-install.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions( [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (typ22[at]foxmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (typ22[at]foxmail.com) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) From: tiantian * etc/guix-install.sh (sys_create_init_profile): Remove the redundant colons in GUIX_LOCPATH and change '||' to '&&'. --- etc/guix-install.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 982fb0a266..4715733245 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -547,13 +547,13 @@ export INFOPATH="$_GUIX_PROFILE/share/info:$INFOPATH" # GUIX_PROFILE: User's default profile and home profile GUIX_PROFILE="$HOME/.guix-profile" [ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile" -[ -L "$GUIX_PROFILE" ] || \ -GUIX_LOCPATH="$GUIX_PROFILE/lib/locale:${GUIX_LOCPATH:+:}$GUIX_LOCPATH" +[ -L "$GUIX_PROFILE" ] && \ +GUIX_LOCPATH="$GUIX_PROFILE/lib/locale${GUIX_LOCPATH:+:}$GUIX_LOCPATH" GUIX_PROFILE="$HOME/.guix-home/profile" [ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile" -[ -L "$GUIX_PROFILE" ] || \ -GUIX_LOCPATH="$GUIX_PROFILE/lib/locale:${GUIX_LOCPATH:+:}$GUIX_LOCPATH" +[ -L "$GUIX_PROFILE" ] && \ +GUIX_LOCPATH="$GUIX_PROFILE/lib/locale${GUIX_LOCPATH:+:}$GUIX_LOCPATH" export GUIX_LOCPATH base-commit: d20ece07dbb09382f361c8bbf0bcab9e83d8b73e -- 2.43.0 Hi guix, After source /etc/profile, I got "GUIX_LOCPATH=/home/tt/.guix-home/profile/lib/locale:". Firstly, it has an extra colon at the end. I checked '/etc/zzz-guix.sh' and found an extra colon in GUIX_LOCPATH. Then, I didn't have '.guix-home'. This is an error. I checked '/etc/zzz-guix.sh' again and found that '||' was used incorrectly. The second command will not be executed when '$HOME/.guix-home/profile' exists and is a symbolic link; otherwise, execute the second command. My English is not good. If there are grammar and tone errors, please forgive me. Thanks, tiantian