GNU bug report logs - #67397
[PATCH] gnu: lisp-check: Add lisp-critic

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "jgart" <jgart <at> dismail.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67397: closed ([PATCH] gnu: lisp-check: Add lisp-critic)
Date: Thu, 23 Nov 2023 16:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 23 Nov 2023 16:17:08 +0000
with message-id <bc7c36565ea2871633b9528d828bde5f <at> dismail.de>
and subject line Re: [PATCH] gnu: lisp-check: Add lisp-critic
has caused the debbugs.gnu.org bug report #67397,
regarding [PATCH] gnu: lisp-check: Add lisp-critic
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67397: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67397
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michal Atlas <michal_atlas+git <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Michal Atlas <michal_atlas+git <at> posteo.net>
Subject: [PATCH] gnu: lisp-check: Add lisp-critic
Date: Thu, 23 Nov 2023 09:47:06 +0000

* gnu/packages/lisp-check.scm (sbcl-lisp-critic): New variable
* gnu/packages/lisp-check.scm (cl-lisp-critic): New variable

ecl not included because the build is non-deterministic

Change-Id: I38ed8af8f4316f47695a22e949b931770e350c1e
---
 gnu/packages/lisp-check.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/lisp-check.scm b/gnu/packages/lisp-check.scm
index 63a16d608c..f5c4244108 100644
--- a/gnu/packages/lisp-check.scm
+++ b/gnu/packages/lisp-check.scm
@@ -1149,3 +1149,28 @@ (define-public cl-xlunit
 
 (define-public ecl-xlunit
   (sbcl-package->ecl-package sbcl-xlunit))
+
+(define-public sbcl-lisp-critic
+  (package
+    (name "sbcl-lisp-critic")
+    (version "0.0.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/g000001/lisp-critic")
+             (commit "fb70c69dc61a53fb069b24edebcfb0de813a176b")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "059vfdn8ds44hihhjmylp059zl2gzghiipcigvjd51sb6zc6f0zy"))))
+    (build-system asdf-build-system/sbcl)
+    (synopsis "Common Lisp linter")
+    (description "The Lisp Critic scans your code for
+instances of bad Lisp programming practice")
+    (home-page
+     "https://courses.cs.northwestern.edu/325/exercises/critic.html#critic")
+    (license license:expat)))
+
+(define-public cl-lisp-critic
+  (sbcl-package->cl-source-package sbcl-lisp-critic))
+

base-commit: 5283d24062be62f59ff9f14fa7095ebcfcb7a9a4
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: "jgart" <jgart <at> dismail.de>
To: 67397-done <at> debbugs.gnu.org, michal_atlas+git <at> posteo.net
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: Re: [PATCH] gnu: lisp-check: Add lisp-critic
Date: Thu, 23 Nov 2023 16:17:08 +0000

Hi Michal,

Thanks for the patch.

ecl-lisp-critic seems to be deterministic on my end. I built all three package variants with --rounds=1000

Fun times, pushed!

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.