GNU bug report logs - #67393
29.1; Slow to open file if autosave exists

Previous Next

Full log

Message #90 received at 67393 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: materus213 <at> gmail.com, yantar92 <at> posteo.net, 67393 <at> debbugs.gnu.org,
 stefankangas <at> gmail.com
Subject: Re: bug#67393: 29.1; Slow to open file if autosave exists
Date: Tue, 16 Jan 2024 20:51:49 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: materus213 <at> gmail.com,  yantar92 <at> posteo.net,  67393 <at> debbugs.gnu.org,
>   stefankangas <at> gmail.com
> Date: Tue, 16 Jan 2024 19:43:09 +0200
> 
> >> > A defcustom would be one option.  'set-important-message' like
> >> > implemented by Ihor would be another option.  All this could be
> >> > added after creating the new function 'important-message'.
> >> 
> >> So here is the new function 'important-message' and its calls
> >> in two discussed places.
> >
> > Is this in preparation for some followup?  Because if not, I'm not
> > sure it is justified to add a short function that has just 2 callers.
> > What do we gain, as a counter-weight to the need to document the new
> > function, insist that new code uses it, etc.?
> 
> Indeed, these 2 test cases are for preparation to using it everywhere.

Then I think we should consider all of those changes together.

> >> I'm not sure why 'after-find-file' uses non-nil NODISP arg
> >> in (sit-for 1 t).  This means is that the message is not
> >> displayed?  Then why 'message' is called?
> >
> > I think it means redisplay is not called.  'message' causes redisplay
> > of the echo-area, but we don't need to redisplay the rest.
> 
> Would it be safe to drop NODISP in the new function?
> I see that most calls of 'message' with 'sit-for'
> don't use the NODISP arg.

I don't see a need to remove it, as one caller that uses it is enough
to justify it, and the price is hardly significant.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.