Subject: bug#67388: 30.0.50; Unintended man page buffer-name change?

From: Stephen Berman <[email-masked]>
Date: Wed, 29 Nov 2023 17:59:47 +0100

On Wed, 22 Nov 2023 23:02:25 +0100 Stephen Berman <[email-masked]> wrote:

> 0. emacs -Q
> 1. M-x man RET cat RET
> 2. M-: (buffer-name)
> => "*Man cat *"
>
> If you do the same in emacs-29, the result is:
> "*Man cat*"
>
> AFAICS this change is due to this commit:
>
> commit 861ac933dd8aed1028edc4b9142400e3702874d5
> Author:     Michael Albinus <[email-masked]>
> Commit:     Michael Albinus <[email-masked]>
> CommitDate: Wed Nov 1 16:54:31 2023 +0100
>
>     Run `man' also on remote systems
>
> If the change was intended, it should be called out in NEWS.  If it was
> unintended, this patch restores the previous behavior, at least when
> calling man locally (I currently can't test a remote call):
>
> diff --git a/lisp/man.el b/lisp/man.el
> index f18e2f50b7c..3efa29d7aad 100644
> --- a/lisp/man.el
> +++ b/lisp/man.el
> @@ -1191,8 +1191,8 @@ Man-getpage-in-background
>           (man-args topic)
>  	 (bufname
>            (if (file-remote-p default-directory)
> -              (format "*Man %s %s *" (file-remote-p default-directory) man-args)
> -            (format "*Man %s *" man-args)))
> +              (format "*Man %s %s*" (file-remote-p default-directory) man-args)
> +            (format "*Man %s*" man-args)))
>  	 (buffer (get-buffer bufname)))
>      (if buffer
>  	(Man-notify-when-ready buffer)

Given no reponse in a week, perhaps this fell under the radar, in
particular that of Michael Albinus (added to Cc:).  Michael, if you
confirm this was just a typo, I can install the patch to save you the
effort.  If it's not a typo, then you're in a better position than me to
decide what to do.

Steve Berman