GNU bug report logs - #67365
[PATCH core-updates] gnu: gitless: fix definition.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: bug#67365: closed (Re: [bug#67365] [PATCH core-updates] gnu:
 gitless: fix definition.)
Date: Wed, 22 Nov 2023 12:19:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67365: [PATCH core-updates] gnu: gitless: fix definition.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67365 <at> debbugs.gnu.org.

-- 
67365: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67365
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 67365-done <at> debbugs.gnu.org
Subject: Re: [bug#67365] [PATCH core-updates] gnu: gitless: fix definition.
Date: Wed, 22 Nov 2023 20:17:48 +0800

Hi,

On Wed, 22 Nov 2023 19:00:17 +0800,
Zheng Junjie wrote:
> 
> gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> disable test.
> 
> Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> ---
>  gnu/packages/version-control.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index c366a41342..b687d184c2 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
>  ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
>  ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli <at> disroot.org>
> +;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -776,9 +777,10 @@ (define-public gitless
>         (file-name (git-file-name name version))))
>      (build-system python-build-system)
>      (arguments
> -     #~(list
> -        #:phases
> -        (modify-phases %standard-phases
> +     (list
> +      #:tests? #f ;; FIXME: fix test
> +      #:phases
> +      #~(modify-phases %standard-phases
>            (add-before 'build 'loosen-requirements
>              (lambda _
>                (substitute* "setup.py"
> 
> base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> -- 
> 2.41.0


Applied (without the #:tests? change, I'll address it later), thank you!

[Message part 3 (message/rfc822, inline)]

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] gnu: gitless: fix definition.
Date: Wed, 22 Nov 2023 19:00:17 +0800

gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
disable test.

Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
---
 gnu/packages/version-control.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index c366a41342..b687d184c2 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2023 Bruno Victal <mirai <at> makinata.eu>
 ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli <at> disroot.org>
+;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -776,9 +777,10 @@ (define-public gitless
        (file-name (git-file-name name version))))
     (build-system python-build-system)
     (arguments
-     #~(list
-        #:phases
-        (modify-phases %standard-phases
+     (list
+      #:tests? #f ;; FIXME: fix test
+      #:phases
+      #~(modify-phases %standard-phases
           (add-before 'build 'loosen-requirements
             (lambda _
               (substitute* "setup.py"

base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.