From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 22 03:25:13 2023 Received: (at submit) by debbugs.gnu.org; 22 Nov 2023 08:25:13 +0000 Received: from localhost ([127.0.0.1]:57950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5iXo-00030m-R1 for submit@debbugs.gnu.org; Wed, 22 Nov 2023 03:25:13 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5bR5-0004Yd-Dg for submit@debbugs.gnu.org; Tue, 21 Nov 2023 19:49:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5bQw-0007y9-UO for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2023 19:49:39 -0500 Received: from cliff.cs.toronto.edu ([128.100.3.120]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5bQn-0005v3-RI for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2023 19:49:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cs.toronto.edu; s=cs202005; h=Message-ID:Date:Content-ID:Content-Type: MIME-Version:Subject:cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=PMoIj4I5N6wSVtEcho7eonnFXoozr3hxUx+4Q9FaBGM=; b=XLBayhczBoa4vv8Gd0XbnQ5m49 y6Rdp61udzFj466PxAWBdLaQ1PTp9QFFuDRd69RfSBqnwBSQ9ay1RXdusH7euFnaAPkcz2CB2b3vC uoZNQ9tfZlTF72WDObkIukNKlW3uFtiMgL2Tay6qYQof29FwDafZJyzMbtgn8ZKPNYT1lBT4fzURE mW6apmqwgXTddU8Nvfa/BhDuBAuzybnzoQ9AMbxn7MTsr5tGMULKwaohi4f9FV06uW94C5FOI5NCI kVxxvrKcwYfw+uMLwbtQP3by+cSYakM2u0U2opHsIGCER4BZKmBY19da7f6FTYEHPAGnNsJLQl/3S 1IGXkAtQ==; Received: from apps0.cs.toronto.edu ([128.100.3.40] ident=postfix) by cliff.cs.toronto.edu with esmtp (Exim 4.95) (envelope-from ) id 1r5bSK-009plq-VB; Tue, 21 Nov 2023 19:49:26 -0500 Received: by apps0.cs.toronto.edu (Postfix, from userid 915) id 06CEC60296; Tue, 21 Nov 2023 19:49:25 -0500 (EST) Received: from apps0.cs.toronto.edu (localhost [127.0.0.1]) by apps0.cs.toronto.edu (Postfix) with ESMTP id 046A36023B; Tue, 21 Nov 2023 19:49:25 -0500 (EST) From: Chris Siebenmann To: bug-gnu-emacs@gnu.org Subject: 29.1; MH-E forwarded email has a mangled default Subject header MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2330409.1700614164.1@apps0.cs.toronto.edu> Date: Tue, 21 Nov 2023 19:49:24 -0500 Message-ID: <2330410.1700614164@apps0.cs.toronto.edu> Received-SPF: pass client-ip=128.100.3.120; envelope-from=cks.emacsbugs-01@cs.toronto.edu; helo=cliff.cs.toronto.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 22 Nov 2023 03:25:09 -0500 Cc: cks.emacsbugs-01@cs.toronto.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) If you attempt to forward an email message in MH-E with mh-forward (bound to eg 'f'), then the resulting Subject: of the draft message will be manged and come out as, for example: Subject: test forwarding subject (fwd) Chris Siebenmann: test forwarding subject The original subject of the test message was 'test forwarding subject'. The 'test forwarding subject (forw)' portion of the mh-forward Subject comes from the default Ubuntu 22.04 NMH 1.7.1 /etc/nmh/forwcomps file, used by 'forw' to create the NMH draft, which has: Subject:%<{nmh-subject} %(trim)%(putlit)%?{subject} %(trim)%(putlit) (fwd)%> The portion after it comes from the fact that mh-forward creates its own new Subject: for the forwarded message (using mh-forwarded-letter-subject, which in turn formats with mh-forward-subject-format), and then does: (mh-insert-fields "Subject:" forw-subject) I suspect that the intention is to replace any existing Subject:, or perhaps mh-forward assumes that the draft won't have one. Unfortunately for mh-forward, mh-insert-fields is specifically documented to *append* to the existing header field value, if there is one, not overwrite it, so the resulting Subject: of the draft is as we see here: the original subject created by 'forw', and then an appended Subject from mh-forward. This result is not terribly useful. Reproduction in emacs -Q provided you have NMH and MH-E set up: * enter MH-E with 'M-x mh-rmail' * arrange to have some message in your inbox that you can forward, for example by 'F r' to see all of your inbox. * display your test message to forward, eg cursor to it and hit Return * start to forward with 'f' or 'M-x mh-forward'. NOTE: while I have reproduced this in a clean Emacs (and NMH) environment with 'emacs -Q', this report is being filed from within my regular customized Emacs because life is too short. You can skip over the packages, shadowed load files, and so on. In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-10-30 built on comps3 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix /u/cks/lib/x64-linux/emacs-29.1 --without-gsettings --with-x --with-x-toolkit=gtk3 --with-json --with-tree-sitter --with-native-compilation=aot' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: smartparens-mode: t global-corfu-mode: t corfu-mode: t marginalia-mode: t vertico-mouse-mode: t vertico-multiform-mode: t vertico-mode: t which-key-mode: t global-flycheck-mode: t flycheck-mode: t backward-forward-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /u/cks/.emacs.d/elpa/transient-20231121.1154/transient hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/transient /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-core hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-core /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-diminish hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-diminish /u/cks/.emacs.d/elpa/bind-key-20230203.2004/bind-key hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/bind-key /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-lint hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-lint /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-jump hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-jump /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-delight hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-delight /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-bind-key hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-bind-key /u/cks/.emacs.d/elpa/use-package-20230426.2324/use-package-ensure hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/use-package/use-package-ensure /u/cks/.emacs.d/elpa/project-0.10.0/project hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/progmodes/project /u/cks/.emacs.d/elpa/seq-2.24/seq hides /u/cks/lib/x64-linux/emacs-29.1/share/emacs/29.1/lisp/emacs-lisp/seq Features: (shadow mh-identity mh-letter emacsbug mule-util project consult bookmark mail-extr mh-seq mh-inc hl-line mh-tool-bar flyspell ispell mh-xface mh-cks mh-cks-speed mh-speed speedbar ezimage dframe gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ring org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs format-spec icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs mh-utils mh-mime mh-acros mh-show gnus-cite gnus-art mm-uu mml2015 gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int message yank-media dired dired-loaddefs rfc822 mailabbrev gmm-utils mailheader gnus-win gnus-range gnus nnheader range wid-edit mh-comp sendmail mail-utils mh-gnus mml mm-view mml-smime mml-sec epa derived epg rfc6068 epg-config smime gnutls puny dig mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mh-folder which-func imenu gnus-util text-property-search time-date mh-scan mh-e mh-buffers mh-loaddefs goto-addr comp comp-cstr warnings icons smartparens advice loadhist thingatpt .emacs corfu marginalia vertico-mouse vertico-multiform vertico compat which-key flycheck ansi-color find-func rx dash backward-forward edmacro kmacro cl-extra help-mode pp diminish use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf company-autoloads consult-flycheck-autoloads consult-flyspell-autoloads consult-lsp-autoloads corfu-autoloads embark-consult-autoloads consult-autoloads embark-autoloads evil-autoloads expand-region-autoloads flycheck-golangci-lint-autoloads flycheck-autoloads fold-this-autoloads go-mode-autoloads goto-chg-autoloads lsp-ui-autoloads lsp-mode-autoloads magit-autoloads pcase git-commit-autoloads magit-section-autoloads marginalia-autoloads orderless-autoloads project-autoloads markdown-mode-autoloads f-autoloads rust-mode-autoloads smartparens-autoloads transient-autoloads try-autoloads vertico-autoloads vundo-autoloads which-key-autoloads with-editor-autoloads info compat-autoloads seq-autoloads yaml-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 545270 248252) (symbols 48 33083 301) (strings 32 163048 44156) (string-bytes 1 5324563) (vectors 16 58484) (vector-slots 8 1033146 512517) (floats 8 416 1220) (intervals 56 937 397) (buffers 984 16)) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 22 09:42:51 2023 Received: (at 67360) by debbugs.gnu.org; 22 Nov 2023 14:42:51 +0000 Received: from localhost ([127.0.0.1]:58558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5oRG-0004Oa-GR for submit@debbugs.gnu.org; Wed, 22 Nov 2023 09:42:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5oRE-0004OL-Rr for 67360@debbugs.gnu.org; Wed, 22 Nov 2023 09:42:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5oR6-0007Y2-8r; Wed, 22 Nov 2023 09:42:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YH9e2BaCTNhULTtylZEDYIshtYSa/JsDU/64+SeIQRQ=; b=mpqsaEmowZ4F b+jyDYySuA0hXuECNZ2eGt/AhJcVKcc0Pm2uMpfLTbWHuEzgVyl8pUhtLXEnnWm7yFK0bD2T8KmTP EB7X8fffGlkyOcZLQalvFWvOB6M29noElfYx5pcOiITCUuJQPy1y/uR8aA02dmtSKHnXPvSGgbm9z ZniNH97waI1DRsGECBmXYKnv2SxGAKiVBv+ZbtpqOMmmJrJcFIaRpWxNfkkwt7wkIxvQbjSM7jS38 dlv8Hx6qcpov1dOqRyQcM7ZYiScF/qgRm4lWMSEtxNfe2yFDuR89YmB8oguQRMER9bZoJtv9eJEY1 ztAWR4VxnWSZHA9rlzq+/A==; Date: Wed, 22 Nov 2023 16:42:30 +0200 Message-Id: <83il5thmsp.fsf@gnu.org> From: Eli Zaretskii To: Chris Siebenmann , Bill Wohler In-Reply-To: <2330410.1700614164@apps0.cs.toronto.edu> (message from Chris Siebenmann on Tue, 21 Nov 2023 19:49:24 -0500) Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header References: <2330410.1700614164@apps0.cs.toronto.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67360 Cc: 67360@debbugs.gnu.org, cks.emacsbugs-01@cs.toronto.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: cks.emacsbugs-01@cs.toronto.edu > From: Chris Siebenmann > Date: Tue, 21 Nov 2023 19:49:24 -0500 > > If you attempt to forward an email message in MH-E with mh-forward > (bound to eg 'f'), then the resulting Subject: of the draft message will > be manged and come out as, for example: > > Subject: test forwarding subject (fwd) Chris Siebenmann: test forwarding subject > > The original subject of the test message was 'test forwarding subject'. > The 'test forwarding subject (forw)' portion of the mh-forward Subject > comes from the default Ubuntu 22.04 NMH 1.7.1 /etc/nmh/forwcomps file, > used by 'forw' to create the NMH draft, which has: > > Subject:%<{nmh-subject} %(trim)%(putlit)%?{subject} %(trim)%(putlit) (fwd)%> > > The portion after it comes from the fact that mh-forward creates its own > new Subject: for the forwarded message (using > mh-forwarded-letter-subject, which in turn formats with > mh-forward-subject-format), and then does: > > (mh-insert-fields "Subject:" forw-subject) > > I suspect that the intention is to replace any existing Subject:, or > perhaps mh-forward assumes that the draft won't have one. Unfortunately > for mh-forward, mh-insert-fields is specifically documented to *append* > to the existing header field value, if there is one, not overwrite it, > so the resulting Subject: of the draft is as we see here: the original > subject created by 'forw', and then an appended Subject from mh-forward. > This result is not terribly useful. > > Reproduction in emacs -Q provided you have NMH and MH-E set up: > * enter MH-E with 'M-x mh-rmail' > * arrange to have some message in your inbox that you can forward, for > example by 'F r' to see all of your inbox. > * display your test message to forward, eg cursor to it and hit Return > * start to forward with 'f' or 'M-x mh-forward'. > > NOTE: while I have reproduced this in a clean Emacs (and NMH) > environment with 'emacs -Q', this report is being filed from within my > regular customized Emacs because life is too short. You can skip over > the packages, shadowed load files, and so on. Adding Bill. I'm not sure if it is better to report MH-E-related bugs here or submit the reports to https://sourceforge.net/p/mh-e/bugs/. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 22:50:07 2023 Received: (at 67360) by debbugs.gnu.org; 27 Nov 2023 03:50:07 +0000 Received: from localhost ([127.0.0.1]:43049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7SdK-0006Le-Ry for submit@debbugs.gnu.org; Sun, 26 Nov 2023 22:50:07 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:52527 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7SdH-0006LA-1t for 67360@debbugs.gnu.org; Sun, 26 Nov 2023 22:50:05 -0500 Received: from alto (135-180-173-181.dsl.dynamic.sonic.net [135.180.173.181] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 3AR3nbQo093603 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 26 Nov 2023 19:49:43 -0800 (PST) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-173-181.dsl.dynamic.sonic.net [135.180.173.181] (may be forged) claimed to be alto From: Mike Kupfer To: Eli Zaretskii , Chris Siebenmann Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header In-reply-to: <83il5thmsp.fsf@gnu.org> References: <2330410.1700614164@apps0.cs.toronto.edu> <83il5thmsp.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Wed, 22 Nov 2023 16:42:30 +0200." X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.1.90 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <117575.1701056977.1@alto> Content-Transfer-Encoding: quoted-printable Date: Sun, 26 Nov 2023 19:49:37 -0800 Message-ID: <117576.1701056977@alto> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67360 Cc: 67360@debbugs.gnu.org, Bill Wohler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii wrote: > > From: Chris Siebenmann > > Date: Tue, 21 Nov 2023 19:49:24 -0500 > > = > > If you attempt to forward an email message in MH-E with mh-forward > > (bound to eg 'f'), then the resulting Subject: of the draft message wi= ll > > be manged and come out as, for example: > > = > > Subject: test forwarding subject (fwd) Chris Siebenmann: test forward= ing subject [...] > > I suspect that the intention is to replace any existing Subject:, or > > perhaps mh-forward assumes that the draft won't have one. Unfortunatel= y > > for mh-forward, mh-insert-fields is specifically documented to *append= * > > to the existing header field value, if there is one, not overwrite it, > > so the resulting Subject: of the draft is as we see here: the original > > subject created by 'forw', and then an appended Subject from mh-forwar= d. > > This result is not terribly useful. Indeed. Yeah, mh-insert-fields seems like the wrong choice for Subject. It's more suited for headers like To or Cc, when you might want to add to the existing list of recipients. Replacing mh-insert-fields with mh-modify-header-field works for me. diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el index 92d31bf1826..0d1dcdf626a 100644 --- a/lisp/mh-e/mh-comp.el +++ b/lisp/mh-e/mh-comp.el @@ -574,7 +574,7 @@ mh-forward (setq orig-subject (mh-get-header-field "Subject:"))) (let ((forw-subject (mh-forwarded-letter-subject orig-from orig-subject))) - (mh-insert-fields "Subject:" forw-subject) + (mh-modify-header-field "Subject" forw-subject t) (goto-char (point-min)) ;; Set the local value of mh-mail-header-separator according to w= hat is ;; present in the buffer... > > Reproduction in emacs -Q provided you have NMH and MH-E set up: > > * enter MH-E with 'M-x mh-rmail' > > * arrange to have some message in your inbox that you can forward, for > > example by 'F r' to see all of your inbox. Hide your personal forwcomps if you have one. > > * display your test message to forward, eg cursor to it and hit Return > > * start to forward with 'f' or 'M-x mh-forward'. mike From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 17:05:44 2023 Received: (at 67360) by debbugs.gnu.org; 30 Dec 2023 22:05:44 +0000 Received: from localhost ([127.0.0.1]:45176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJhSh-00013Y-WF for submit@debbugs.gnu.org; Sat, 30 Dec 2023 17:05:44 -0500 Received: from se6c-iad1.servconfig.com ([173.231.241.24]:54455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJhSe-00013I-56 for 67360@debbugs.gnu.org; Sat, 30 Dec 2023 17:05:43 -0500 Received: from ecbiz329.inmotionhosting.com ([209.182.198.38]) by se6-iad1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1rJhSV-00011t-20; Sat, 30 Dec 2023 17:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-Transfer-Encoding:Content-ID: Content-Type:MIME-Version:References:In-reply-to:Subject:From:cc:To:Sender: Reply-To:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=lfquItnC0dKTyLRG5kC5d9cVNpRZ4xsAkWs4PnLZAqM=; b=CZZQs63/9XnaRWP3MfrWxqgCkr 1iUTFlaV0XdYjz+2k8VHcf0+M+1UJ977bLAD5sKrOSEeFc/ciO0QeFZXfx9PI2W6m/Msw4j6MwDXN y7+bhlWybCSqLD3q6hNAh/78uUdzTvcnwTTZpsSAS8sqhmgi74E2ps2gbWqn2OxX9CjzQzQrw8hri 3JmcxoD/kbKOYUDW/3nUHR4rMmgNLxNecmbnMu3OJv7mKyxy6EFOXckXqdk7w89nNwNLifTv+e9+3 RN3J5qmRZBRxVnIRBvYd4RMgNNYx6r3O1/lV8XdRSga7ZisFRfLyYKgaiqebV8YT543Vk6WY7rcXf mXh9d3fQ==; Received: from [24.4.147.188] (port=36890 helo=olgas.newt.com) by ecbiz329.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rJhSU-006HeL-0n; Sat, 30 Dec 2023 17:05:30 -0500 Received: by olgas.newt.com (Postfix, from userid 1000) id 31110381F05; Sat, 30 Dec 2023 14:05:29 -0800 (PST) To: Mike Kupfer From: Bill Wohler Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header In-reply-to: <117576.1701056977@alto> References: <2330410.1700614164@apps0.cs.toronto.edu> <83il5thmsp.fsf@gnu.org> <117576.1701056977@alto> Comments: In-reply-to Mike Kupfer message dated "Sun, 26 Nov 2023 19:49:37 -0800." Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1842252.1703973929.1@olgas.newt.com> Content-Transfer-Encoding: quoted-printable Date: Sat, 30 Dec 2023 14:05:29 -0800 Message-ID: <1842253.1703973929@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz329.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz329.inmotionhosting.com: wohler@newt.com X-Originating-IP: 209.182.198.38 X-SpamExperts-Domain: ecbiz329.inmotionhosting.com X-SpamExperts-Username: 209.182.198.38 Authentication-Results: servconfig.com; auth=pass smtp.auth=209.182.198.38@ecbiz329.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.10) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9i2vNgAiGutxFrqRwvGbEoPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wPNj8CRzrsGB7ugNp6dkMIG6S2l0Sq0XyAP7CL22R+h7Qy nBdRnGcStIJd2ozIafxMBhQwZ4U+dP0cDUdUHxwFkzGIyEDKB5+tuM/BiYkNNtjLQNCIemmyp7tp LvZV4fGqkaWbbOMJrh1zQUl46B+CBBBG5qGJPMemR9//pDmr0QK/NzaQ0kU5LIjXaSmvljzrv6uv y67bPy9KnwerIPD7+EJh3GmpTMtirFB1CX1Gmfdp637QXBUN6CLyeuzX+S3o06Pbn32ePf/zaJyv Vrl2ffwjk2dD8fHm6GckUr6uGMCGpH6KPvCaPYMwmktYRls2JrO8Qv8RArq2MwWaNnh+UuIF2yn0 3s7TS3ghm2vgBpb5Pn6ftQZVK9K8EAjn37sUg69eDYNe2itClT3S7bjQUCo5PZJsLcY5FmNhp+JD xofgBwPJRy2KP3xL3XdLYqV41APOGyRuqKbOun7vlQzhwfhpspQKRAIBFcUdSV85+USmicW4BKeo lukxoVI4SaNoMMMh30z0ou3Uma6ICBqohxGGNNFI1AuNleg/0I92t9xCHahZfsjvoDKdqQReE7op ol7/zxbDwFIVzeFgpWdBcxw3qqhc+N6cuEg4XWh5Fq9D8y81M79IYqpO94EpO3IPWHrVi9hSq7ds FoctQMdxVYl+ooxaD+3vSXb9kO06f9m0ZFmyUDLBGs3sQM5xYpEkNFI/tMRrMWPNph6/qaBnaL3D 5sbF+pWUUp/BhR8+AAGEl7PZ0dsWG6iBa8n1i8HWakst2jby0UsGB5R1mddSrw06R6bxmsiw7FIm j0yCe/SV7qfAyoFNk+hjpTJZ+zgMwU1g8WYBo6W51IeP9+b1ZbHDgsqdwaZf23a6lzktcAoajDGz WO/VAWt0oHJ3kVp+WYf4gjH0PJSt9lIAK173fqb5R4VemuUI6bcEARsm0Bx+YfQxD05kZ/5CdLXw M5e0rIpjO6/1LqHA1UlOUbsqSf1rWt8UKdIyxz68TCs2yzahPNebM0eA0S1caiFAuv8VvNhbhjDA Mfwc73Zerz7WDNGLDks/HA6rfffkatcUurc61rZLkY0bbNc8GDWT+KeIeWUAb0ifz++E9zZf1mla X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67360 Cc: Chris Siebenmann , Eli Zaretskii , 67360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, Mike! My forwcomps only injects one header field so I never saw this before. Uncommenting the Subject field made it possible to reproduce this issue. Yes, I agree that the code clearly wants to replace the Subject field, not append to it, and this patch works for me as well. Please feel free to commit the patch and resolve the issue. Thanks again! Mike Kupfer wrote: > Eli Zaretskii wrote: > = > > > From: Chris Siebenmann > > > Date: Tue, 21 Nov 2023 19:49:24 -0500 > > > = > > > If you attempt to forward an email message in MH-E with mh-forward > > > (bound to eg 'f'), then the resulting Subject: of the draft message = will > > > be manged and come out as, for example: > > > = > > > Subject: test forwarding subject (fwd) Chris Siebenmann: test forwa= rding subject > [...] > > > I suspect that the intention is to replace any existing Subject:, or > > > perhaps mh-forward assumes that the draft won't have one. Unfortunat= ely > > > for mh-forward, mh-insert-fields is specifically documented to *appe= nd* > > > to the existing header field value, if there is one, not overwrite i= t, > > > so the resulting Subject: of the draft is as we see here: the origin= al > > > subject created by 'forw', and then an appended Subject from mh-forw= ard. > > > This result is not terribly useful. > = > Indeed. > = > Yeah, mh-insert-fields seems like the wrong choice for Subject. It's > more suited for headers like To or Cc, when you might want to add to the > existing list of recipients. Replacing mh-insert-fields with > mh-modify-header-field works for me. > = > diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el > index 92d31bf1826..0d1dcdf626a 100644 > --- a/lisp/mh-e/mh-comp.el > +++ b/lisp/mh-e/mh-comp.el > @@ -574,7 +574,7 @@ mh-forward > (setq orig-subject (mh-get-header-field "Subject:"))) > (let ((forw-subject > (mh-forwarded-letter-subject orig-from orig-subject))) > - (mh-insert-fields "Subject:" forw-subject) > + (mh-modify-header-field "Subject" forw-subject t) > (goto-char (point-min)) > ;; Set the local value of mh-mail-header-separator according to= what is > ;; present in the buffer... > = > > > Reproduction in emacs -Q provided you have NMH and MH-E set up: > > > * enter MH-E with 'M-x mh-rmail' > > > * arrange to have some message in your inbox that you can forward, f= or > > > example by 'F r' to see all of your inbox. > = > Hide your personal forwcomps if you have one. > = > > > * display your test message to forward, eg cursor to it and hit Retu= rn > > > * start to forward with 'f' or 'M-x mh-forward'. > = > mike > = -- = Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 11:44:54 2023 Received: (at 67360) by debbugs.gnu.org; 31 Dec 2023 16:44:54 +0000 Received: from localhost ([127.0.0.1]:46923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJyvl-0005o6-TP for submit@debbugs.gnu.org; Sun, 31 Dec 2023 11:44:54 -0500 Received: from se4q-iad1.servconfig.com ([199.250.217.82]:37359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJyvj-0005nq-C4 for 67360@debbugs.gnu.org; Sun, 31 Dec 2023 11:44:52 -0500 Received: from ecbiz329.inmotionhosting.com ([209.182.198.38]) by se4-iad1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1rJyva-000Atw-Av; Sun, 31 Dec 2023 11:44:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-Transfer-Encoding:Content-ID: Content-Type:MIME-Version:References:In-reply-to:Subject:From:cc:to:Sender: Reply-To:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=9dAbrS5LZcFhILPk6v7IiC5zatKQLyMhuCcWjXwkJfc=; b=spX3D1OEE93vz0ItMN/qNYYv/8 WZ9V8QseWMUdT3n8Qh/eSdzjh2l3Nv5kQ2yeRRTpGt05rHkILnFGkT3uA2WCYfpWf34ojdqgN7c4F RmM9MOHFBMH2jAalfnb4DwSrrc3JrsxRdpSiFtQPUA1pn6TCa1N8BRBCMTdnFpAhZayqMxZjt06NF Q7WJKrgvmf8JeFV6B/qQDxuogJa1OruUyOBLO17+XZ/YoKtjTOPFhMrScwsw/zMZocuTTIduUSDU2 dcNAX1oENjEAy3rROHgCXvT42234+qqVaNnw+6pZaXNZbAZ/Aayf2uoz2wvPJhXjUpkgxsE0PZqZG VGUTZKEQ==; Received: from [24.4.147.188] (port=36144 helo=olgas.newt.com) by ecbiz329.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rJyvZ-007cxP-1h; Sun, 31 Dec 2023 11:44:41 -0500 Received: by olgas.newt.com (Postfix, from userid 1000) id A27A7381F0B; Sun, 31 Dec 2023 08:44:40 -0800 (PST) to: Eli Zaretskii From: Bill Wohler Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header In-reply-to: <1842253.1703973929@olgas.newt.com> References: <2330410.1700614164@apps0.cs.toronto.edu> <83il5thmsp.fsf@gnu.org> <117576.1701056977@alto> <1842253.1703973929@olgas.newt.com> Comments: In-reply-to Bill Wohler message dated "Sat, 30 Dec 2023 14:05:29 -0800." Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1955034.1704041080.1@olgas.newt.com> Content-Transfer-Encoding: quoted-printable Date: Sun, 31 Dec 2023 08:44:40 -0800 Message-ID: <1955035.1704041080@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz329.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz329.inmotionhosting.com: wohler@newt.com X-Originating-IP: 209.182.198.38 X-SpamExperts-Domain: ecbiz329.inmotionhosting.com X-SpamExperts-Username: 209.182.198.38 Authentication-Results: servconfig.com; auth=pass smtp.auth=209.182.198.38@ecbiz329.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.10) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT/kWzy+/wHRdL8Ec0fp3zO1PUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wPNj8CRzrsGB7ugNp6dkMIG6S2l0Sq0XyAP7CL22R+h7Qy nBdRnGcStIJd2ozIafxMBhQwZ4U+dP0cDUdUHxwFkzGIyEDKB5+tuM/BiYkNNtjLQNCIemmyp7tp LvZV4fGqkaWbbOMJrh1zQUl46B+CqlX864Kii7zhVFtfF/BW3QK/NzaQ0kU5LIjXaSmvljzrv6uv y67bPy9KnwerIPD7+EJh3GmpTMtirFB1CX1Gmfdp637QXBUN6CLyeuzX+S3o06Pbn32ePf/zaJyv Vrl2JjoOGLTNO2+ha6tRjO/eIsCGpH6KPvCaPYMwmktYRls2JrO8Qv8RArq2MwWaNnh+UuIF2yn0 3s7TS3ghm2vgBpb5Pn6ftQZVK9K8EAjn37sUg69eDYNe2itClT3S7bjQUCo5PZJsLcY5FmNhp+JD xofgBwPJRy2KP3xL3XdLYqV41APOGyRuqKbOun7vlQzhwfhpspQKRAIBFcUdSV85+USmicW4BKeo lukxoVI4SaNoMMMh30z0ou3Uma6ICBqohxGGNNFI1AuNleg/0I92t9xCHahZfsjvoDKdqQReE7op ol7/zxbDwFIVzeFgpWdBcxw3qqhc+N6cuEg4XWh5Fq9D8y81M79IYqpO94EpO3J1Sa95X7KslAQd 00yE9RPO/TiLAZRMv2batgSscFTnztm0ZFmyUDLBGs3sQM5xYpEkNFI/tMRrMWPNph6/qaBnaL3D 5sbF+pWUUp/BhR8+AAGEl7PZ0dsWG6iBa8n1i8HWakst2jby0UsGB5R1mddSrw06R6bxmsiw7FIm j0yCe/SV7qfAyoFNk+hjpTJZ+zhfLVyQrw5ox/CjD8YbCiyt8kSvSqQ/fsFrZqvoxPBl+QoajDGz WO/VAWt0oHJ3kVp+WYf4gjH0PJSt9lIAK173fqb5R4VemuUI6bcEARsm0Bx+YfQxD05kZ/5CdLXw M5e0rIpjO6/1LqHA1UlOUbsqSf1rWt8UKdIyxz68TCs2yzahPNebM0eA0S1caiFAuv8VvNhbhjDA Mfwc73Zerz7WDNGLDks/HA6rfffkatcUurc61rZLkY0bbNc8GDWT+KeIeWUAb0ifz++E9zZf1mla X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67360 Cc: Chris Siebenmann , Mike Kupfer , 67360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli, Would you prefer that I apply Mike's patch to emacs-29 or master? > diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el > index 92d31bf1826..0d1dcdf626a 100644 > --- a/lisp/mh-e/mh-comp.el > +++ b/lisp/mh-e/mh-comp.el > @@ -574,7 +574,7 @@ mh-forward > (setq orig-subject (mh-get-header-field "Subject:"))) > (let ((forw-subject > (mh-forwarded-letter-subject orig-from orig-subject))) > - (mh-insert-fields "Subject:" forw-subject) > + (mh-modify-header-field "Subject" forw-subject t) > (goto-char (point-min)) > ;; Set the local value of mh-mail-header-separator according to= what is > ;; present in the buffer... -- = Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 14:18:21 2023 Received: (at 67360) by debbugs.gnu.org; 31 Dec 2023 19:18:21 +0000 Received: from localhost ([127.0.0.1]:47038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK1KH-0004cl-3Z for submit@debbugs.gnu.org; Sun, 31 Dec 2023 14:18:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK1KE-0004cW-EW for 67360@debbugs.gnu.org; Sun, 31 Dec 2023 14:18:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rK1K1-0000JK-NR; Sun, 31 Dec 2023 14:18:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sMKEWLgAL43m5U2kGX1XAAW5NG5gLYHCgWocWh2/9Tk=; b=RTLSJEVYgHLS BJwMCx2FahPOEiVH1FvWj5MwfQz0TsNgexGLIe1u0RFooXQM8RSaOy6eaN1sMYE1/2dWAUTOv6XtB 0HAjonWKGvwddTvJTX2F8SjUcnb6nL7AxsPLcj8KFMCzHbkqHG7AiGXD/JzOjr/WzDNbbQPpzIu5X 5KHrqb4KcM6oYOOEx7I8L8OOlrPleI0TkC1lgZWEx0GUBMPw3T9jSlA6MeH+5JXvlrhc/0Ws3YHHI ieTq+0pwL2H5VExs+4XexJrD/wCfawpVMwtdOLQGlODKwDDAXcKOqhHkP2UgAQnf0KKTMvJmrD0LH lHwosc+xKLX9Qc468xF5VA==; Date: Sun, 31 Dec 2023 21:17:59 +0200 Message-Id: <834jfy2nbs.fsf@gnu.org> From: Eli Zaretskii To: Bill Wohler In-Reply-To: <1955035.1704041080@olgas.newt.com> (message from Bill Wohler on Sun, 31 Dec 2023 08:44:40 -0800) Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header References: <2330410.1700614164@apps0.cs.toronto.edu> <83il5thmsp.fsf@gnu.org> <117576.1701056977@alto> <1842253.1703973929@olgas.newt.com> <1955035.1704041080@olgas.newt.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67360 Cc: cks.emacsbugs-01@cs.toronto.edu, kupfer@rawbw.com, 67360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > cc: Mike Kupfer , > Chris Siebenmann , > 67360@debbugs.gnu.org > From: Bill Wohler > Comments: In-reply-to Bill Wohler > message dated "Sat, 30 Dec 2023 14:05:29 -0800." > Date: Sun, 31 Dec 2023 08:44:40 -0800 > > Eli, > > Would you prefer that I apply Mike's patch to emacs-29 or master? > > > diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el > > index 92d31bf1826..0d1dcdf626a 100644 > > --- a/lisp/mh-e/mh-comp.el > > +++ b/lisp/mh-e/mh-comp.el > > @@ -574,7 +574,7 @@ mh-forward > > (setq orig-subject (mh-get-header-field "Subject:"))) > > (let ((forw-subject > > (mh-forwarded-letter-subject orig-from orig-subject))) > > - (mh-insert-fields "Subject:" forw-subject) > > + (mh-modify-header-field "Subject" forw-subject t) > > (goto-char (point-min)) > > ;; Set the local value of mh-mail-header-separator according to what is > > ;; present in the buffer... If you think it's safe enough for the release branch, emacs-29 is fine with me. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 01 13:33:40 2024 Received: (at 67360-done) by debbugs.gnu.org; 1 Jan 2024 18:33:41 +0000 Received: from localhost ([127.0.0.1]:48747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKN6a-0005Rs-IS for submit@debbugs.gnu.org; Mon, 01 Jan 2024 13:33:40 -0500 Received: from se3o-lax1.servconfig.com ([23.235.223.125]:52957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKN6X-0005Rb-Pt for 67360-done@debbugs.gnu.org; Mon, 01 Jan 2024 13:33:39 -0500 Received: from ecbiz329.inmotionhosting.com ([209.182.198.38]) by se3-lax1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1rKN6I-0003au-5m for 67360-done@debbugs.gnu.org; Mon, 01 Jan 2024 13:33:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-ID:Content-Type:MIME-Version:Subject:To: From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=N2lTsgkI0D08zq/pXpM3lpfiE+x8YCyUNsUWwB6YjHM=; b=3TYiQ3jKtsYqsLiOJHpIsZVG35 Cgi0RO6c/S6rPpsR2x2gvb7A7M+VMc//D8KZ+Ax0oow2CgjtxWZuVbT3lD+4dOzegJY2Wj0tUFbUk CYCcYvCLNTiazKeOImdvTYMdMtojoVTwIwPj0lZWQlvSI9YKa8b/RdluFAmVFhxJUdo4oVqtyqquZ V1ZKzt2L20WDuQyEqRQdZSdeyAib8065tyTMRIvTyfjZg0QIEjWllDGDnUiAp9PoJg+RsEGSsO2lF uS5Kqs8RdS4Px/LQ6NIlFqsfr8GH1e1rZSqeYIaxfwA3rsots8aIX05mFsMftLQQ9D1BDX2vuK0Tu /iNiFFKw==; Received: from [24.4.147.188] (port=56392 helo=olgas.newt.com) by ecbiz329.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rKN6G-005LpP-37 for 67360-done@debbugs.gnu.org; Mon, 01 Jan 2024 13:33:21 -0500 Received: by olgas.newt.com (Postfix, from userid 1000) id 25F48381F11; Mon, 1 Jan 2024 10:33:20 -0800 (PST) From: Bill Wohler To: 67360-done@debbugs.gnu.org Subject: Re: 29.1; MH-E forwarded email has a mangled default Subject header Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2129121.1704134000.1@olgas.newt.com> Date: Mon, 01 Jan 2024 10:33:20 -0800 Message-ID: <2129122.1704134000@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz329.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz329.inmotionhosting.com: wohler@newt.com X-Originating-IP: 209.182.198.38 X-SpamExperts-Domain: ecbiz329.inmotionhosting.com X-SpamExperts-Username: 209.182.198.38 Authentication-Results: servconfig.com; auth=pass smtp.auth=209.182.198.38@ecbiz329.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.16) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8xrKmgYzZ4bYMX/tnJZfTuPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wEkK5XLowmnLYpG0UG5Lj9YvMFnPuMgj79LvD6ghYhJw/C h5SE4jAyhe1COeASyU/64xLne1FKFCCLDHOjJfaS4ld5rdi2ZxohSIq+dqifZozu9Nwh/xstdQA8 sCQtVLuEFaMMKomeDPbrnc0Jxb68Q9hzkz5ZeTm3rO7dI0tXHJ2v+pRozglpVhwZR7RBQ3+Zj8Ty GIwVhAUnJQfEfde8R86t2EiC6GwMws7GvvozwDFCU0tibMaZMfiByLA2q5t1dWsXYVVLEMRCdm4l UeyS5kbV9R37OxW/QKNPRzlK0m7EdPKvbRAIxZtm8n/jc7R4UKCObeQdNllr+FgloJnx9w1QRMFF YsS09B601QkU+xUdFqkFA+YKkUlydLh5cSaHt73jJKU44zPi+Pzpc9G5Gex4jnDCeqaOZuXaPySz /uhEQjf02DvD6NbBWC62Maf+rgVEacJBv1CPC7fpONadtHUijJVykBfF9R5cnDw9IpnLGL9oVuhN QBoDT12SU/9oh9VoIekQHpwUfpYnEThmlLNLHjpoXgYj9qOD6ZmFjVUxylBLDqZD0d0t+PO0UXS7 bEhNu+cvAbm169GqGZc4st9Mi1VatnDWqsVLC6TX+Vk6ecMluxcznMZmUruMO3YzOD3nwgVsoqU1 zQ3lxqBCERWeKKG4PAQYNyavp7c49IXzXYq0N6t1rX1Hpv7otFeci8JLiiOdckUewCJrmQRc2XKT 4BCSi2w8mgvy3S772AufRTEBut1YSGlWV7oDW/36VQfb/c2NIfGrBGJmxhrC3TKWikiMlzjtH0TH H5hrVEw7WYx9HlUM7KUsrDls9EuH89YGxhIys8Db039VSMJv5s7F/buaIJ7SljFaZYu4pHJKOgFs pV+/j+XQytwM7jsWM6T6hgb0dJLNfyKLko5LrPbo/GzqhPc1ScKmLJN6KwBbDwFMTAwlABgWsArP ZLb9BpOGIxeRAh3wCs/9s4wTbY5+JSHeAZ7cPoLzCYxe5/YBQtRmKJ7fBub5rs3FipM= X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67360-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 67360 fixed 29.2 thanks * lisp/mh-e/mh-comp.el (mh-forward): Overwrite subject when forwarding. -- Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 01 13:35:39 2024 Received: (at 67360) by debbugs.gnu.org; 1 Jan 2024 18:35:39 +0000 Received: from localhost ([127.0.0.1]:48754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKN8V-0005Vw-2O for submit@debbugs.gnu.org; Mon, 01 Jan 2024 13:35:39 -0500 Received: from se1-lax1.servconfig.com ([104.244.124.86]:34093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKN8S-0005Vf-AX for 67360@debbugs.gnu.org; Mon, 01 Jan 2024 13:35:37 -0500 Received: from ecbiz329.inmotionhosting.com ([209.182.198.38]) by se1-lax1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1rKN89-0002WU-GE; Mon, 01 Jan 2024 13:35:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-Transfer-Encoding:Content-ID: Content-Type:MIME-Version:References:In-reply-to:Subject:From:cc:To:Sender: Reply-To:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=H4wL/F1/idVuTe7MmjxMxu/asamwJCvnDVvmEN3n6JY=; b=BUpQleh2PZ8GGhX6i1JjKPDK2o 2nOt0pMqFq4lGxNMYvqr+3k9V8vghRPMNLs4nfXuU9pSVFpLvtKe/LB+pbFEVcVPN8cmcx8A32Nf7 XO90LE8s6LEQiCDKar14lca8x+3xmlqaEQk4IgLlhZVxuZ0Kv3WxcfMYJoeNzJm8QquOMt9/f+lAD kDZzJ+OkDfxNL9AmxuptXTfBaJF9qFj8EA4WyCg4LalQPrB3QyxnMGGvThcVYxmcx84mWCk+Izlkg VYNkPSAcp0Nn9/fsZpRAYxdvYNn3z6WWjRzWPNUI14au/4KIw+CnnFDvqOeUfOh7fa3ekClSpxXYx A+ghQN+w==; Received: from [24.4.147.188] (port=60038 helo=olgas.newt.com) by ecbiz329.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rKN86-005R8i-2S; Mon, 01 Jan 2024 13:35:14 -0500 Received: by olgas.newt.com (Postfix, from userid 1000) id B59CA381F11; Mon, 1 Jan 2024 10:35:13 -0800 (PST) To: Eli Zaretskii From: Bill Wohler Subject: Re: bug#67360: 29.1; MH-E forwarded email has a mangled default Subject header In-reply-to: <834jfy2nbs.fsf@gnu.org> References: <2330410.1700614164@apps0.cs.toronto.edu> <83il5thmsp.fsf@gnu.org> <117576.1701056977@alto> <1842253.1703973929@olgas.newt.com> <1955035.1704041080@olgas.newt.com> <834jfy2nbs.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Sun, 31 Dec 2023 21:17:59 +0200." Organization: Newt Software X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2129282.1704134113.1@olgas.newt.com> Content-Transfer-Encoding: quoted-printable Date: Mon, 01 Jan 2024 10:35:13 -0800 Message-ID: <2129283.1704134113@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz329.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz329.inmotionhosting.com: wohler@newt.com X-Originating-IP: 209.182.198.38 X-SpamExperts-Domain: ecbiz329.inmotionhosting.com X-SpamExperts-Username: 209.182.198.38 Authentication-Results: servconfig.com; auth=pass smtp.auth=209.182.198.38@ecbiz329.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8xBlqTZ7/B/khwP5QcyWHTPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wPNj8CRzrsGB7ugNp6dkMIG6S2l0Sq0XyAP7CL22R+h7Qy nBdRnGcStIJd2ozIafxMBhQwZ4U+dP0cDUdUHxwFkzGIyEDKB5+tuM/BiYkNNtjLQNCIemmyp7tp LvZV4fGqkaWbbOMJrh1zQUl46B+CDHghAQfwdFoNaOK2Pa0lHAK/NzaQ0kU5LIjXaSmvljzrv6uv y67bPy9KnwerIPD7+EJh3GmpTMtirFB1CX1Gmfdp637QXBUN6CLyeuzX+S3o06Pbn32ePf/zaJyv Vrl22Fq4PIYRM2YjdL8S1nd55uhEQjf02DvD6NbBWC62Mac2JrO8Qv8RArq2MwWaNnh+UuIF2yn0 3s7TS3ghm2vgBpb5Pn6ftQZVK9K8EAjn37sUg69eDYNe2itClT3S7bjQUCo5PZJsLcY5FmNhp+JD xofgBwPJRy2KP3xL3XdLYqV41APOGyRuqKbOun7vlQzhwfhpspQKRAIBFcUdSV85+USmicW4BKeo lukxoVI4SaNoMMMh30z0ou3Uma6ICBqohxGGNNFI1AuNleg/0I92t9xCHahZfsjvoDKdqQReE7op ol7/zxbDwFIVzeFgpWdBcxw3qqhc+N6cuEg4XWh5FmwDHksXVSYHnWJnNJ3cIlQ4Zf/SGelsYnKQ +6ldPmIawbI0Ck5enN+yaOB3a/3pPNm0ZFmyUDLBGs3sQM5xYpEkNFI/tMRrMWPNph6/qaBnaL3D 5sbF+pWUUp/BhR8+AAGEl7PZ0dsWG6iBa8n1i8HWakst2jby0UsGB5R1mddSrw06R6bxmsiw7FIm j0yCe/SV7qfAyoFNk+hjpTJZ+zgQn6v6J+i/12PPrLdRhzajXZcb+br0gWccRQ5uwiGhxQoajDGz WO/VAWt0oHJ3kVp+WYf4gjH0PJSt9lIAK173fqb5R4VemuUI6bcEARsm0Bx+YfQxD05kZ/5CdLXw M5e0rIpjO6/1LqHA1UlOUbsqSf1rWt8UKdIyxz68TCs2yzahPNebM0eA0S1caiFAuv8VvNhbhjDA Mfwc73Zerz7WDNGLDks/HA6rfffkatcUurc61rZLkY0bbNc8GDWT+KeIeWUAb0ifz++E9zZf1mla X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67360 Cc: cks.emacsbugs-01@cs.toronto.edu, kupfer@rawbw.com, 67360@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii wrote: > > cc: Mike Kupfer , > > Chris Siebenmann , > > 67360@debbugs.gnu.org > > From: Bill Wohler > > Comments: In-reply-to Bill Wohler > > message dated "Sat, 30 Dec 2023 14:05:29 -0800." > > Date: Sun, 31 Dec 2023 08:44:40 -0800 > > = > > Eli, > > = > > Would you prefer that I apply Mike's patch to emacs-29 or master? > > = > > > diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el > > > index 92d31bf1826..0d1dcdf626a 100644 > > > --- a/lisp/mh-e/mh-comp.el > > > +++ b/lisp/mh-e/mh-comp.el > > > @@ -574,7 +574,7 @@ mh-forward > > > (setq orig-subject (mh-get-header-field "Subject:"))) > > > (let ((forw-subject > > > (mh-forwarded-letter-subject orig-from orig-subject))) > > > - (mh-insert-fields "Subject:" forw-subject) > > > + (mh-modify-header-field "Subject" forw-subject t) > > > (goto-char (point-min)) > > > ;; Set the local value of mh-mail-header-separator accordin= g to what is > > > ;; present in the buffer... > = > If you think it's safe enough for the release branch, emacs-29 is fine > with me. I think so, yes. I've pushed the fix and sent what may be my first message to a *-done email address. It's never too late to start. -- = Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD From unknown Sun Jul 20 19:15:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator