GNU bug report logs - #6736
Windows: make maintainer-clean does not restore fully clean bzr tree

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6736 in the body.
You can then email your comments to 6736 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Windows: make maintainer-clean does not restore fully clean bzr tree
Date: Mon, 26 Jul 2010 20:28:39 -0600

According to the documentation in nt/INSTALL, `make maintainer-clean' is 
supposed to "Remove everything that can be recreated, including compiled 
lisp files, to get back to the state of a fresh Bazaar tree."

Running `mingw32-make maintainer-clean' on Windows 7, GnuWin32 and MinGW 
does not seem to do exactly that.

Per Juanma's suggestion I ran

bzr clean-tree --unknown --ignored --detritus --force

and it produced the following output:

deleting paths:
  bin
  site-lisp
  admin/unidata/makefile
  lisp/cedet/ede/loaddefs.el~
  lisp/cedet/semantic/loaddefs.el~
  lisp/cedet/srecode/loaddefs.el~

This was right after a `mingw32-make maintainer-clean'.

The bin/ directory still contained the following files: cmdproxy.exe
The site-lisp/ directory contained: subdirs.el

`make realclean' deletes ../bin eventually. Shouldn't `maintainer-clean' 
do the same if it claims to restore the fresh tree checkout?

Christoph

Message #8 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6736 <at> debbugs.gnu.org
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully
	clean bzr tree
Date: Tue, 27 Jul 2010 21:16:00 +0800

Christoph <cschol2112 <at> googlemail.com> writes:

> The bin/ directory still contained the following files: cmdproxy.exe
> The site-lisp/ directory contained: subdirs.el
>
> `make realclean' deletes ../bin eventually. Shouldn't
> maintainer-clean' do the same if it claims to restore the fresh tree
> checkout?

I'm not sure.

Anything in ../bin is put there by "make install". I'm pretty sure make
maintainer-clean doesn't uninstall installed executables on other platforms
either, but then those platforms will also have installed copies of
other things that maintainer-clean does delete. Also if cmdproxy.exe is
the only file left in ../bin, then that seems more like a buggy
oversight than deliberately leaving the installed files alone.

Message #11 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jason Rumney <jasonr <at> gnu.org>
Cc: cschol2112 <at> googlemail.com, 6736 <at> debbugs.gnu.org
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore
	fully	clean bzr tree
Date: Tue, 27 Jul 2010 20:02:10 +0300

> From: Jason Rumney <jasonr <at> gnu.org>
> Date: Tue, 27 Jul 2010 21:16:00 +0800
> Cc: 6736 <at> debbugs.gnu.org
> 
> Christoph <cschol2112 <at> googlemail.com> writes:
> 
> > The bin/ directory still contained the following files: cmdproxy.exe
> > The site-lisp/ directory contained: subdirs.el
> >
> > `make realclean' deletes ../bin eventually. Shouldn't
> > maintainer-clean' do the same if it claims to restore the fresh tree
> > checkout?
> 
> I'm not sure.
> 
> Anything in ../bin is put there by "make install". I'm pretty sure make
> maintainer-clean doesn't uninstall installed executables on other platforms
> either, but then those platforms will also have installed copies of
> other things that maintainer-clean does delete. Also if cmdproxy.exe is
> the only file left in ../bin, then that seems more like a buggy
> oversight than deliberately leaving the installed files alone.

I agree with Jason, FWIW.

Message #14 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Jason Rumney <jasonr <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 6736 <at> debbugs.gnu.org
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully
	clean bzr tree
Date: Sun, 01 Aug 2010 19:39:06 -0600

On 7/27/2010 7:16 AM, Jason Rumney wrote:

> Anything in ../bin is put there by "make install".

Actually, cmdproxy.exe is copied to bin by `make bootstrap', since 
(according to a comment in the makefile) it needs it during the 
bootstrap process.

> I'm pretty sure make
> maintainer-clean doesn't uninstall installed executables on other platforms
> either, but then those platforms will also have installed copies of
> other things that maintainer-clean does delete. Also if cmdproxy.exe is
> the only file left in ../bin, then that seems more like a buggy
> oversight than deliberately leaving the installed files alone.

OK. What about the site-lisp directory? Is it safe to delete it too or 
could the user have files in it that he does not want to loose?

Christoph

Message #17 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6736 <at> debbugs.gnu.org, Jason Rumney <jasonr <at> gnu.org>
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully 
	clean bzr tree
Date: Mon, 2 Aug 2010 04:42:14 +0200

On Mon, Aug 2, 2010 at 03:39, Christoph <cschol2112 <at> googlemail.com> wrote:

> OK. What about the site-lisp directory? Is it safe to delete it too or could
> the user have files in it that he does not want to loose?

Isn't that the whole point of site-lisp?

    Juanma

Message #20 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6736 <at> debbugs.gnu.org, Jason Rumney <jasonr <at> gnu.org>
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully
	clean bzr tree
Date: Sun, 01 Aug 2010 21:58:03 -0600

On 8/1/2010 8:42 PM, Juanma Barranquero wrote:

>> OK. What about the site-lisp directory? Is it safe to delete it too or could
>> the user have files in it that he does not want to loose?
>
> Isn't that the whole point of site-lisp?

Right. I guess I will rephrase the question: is there ever a situation 
where we SHOULD delete the site-lisp directory, specifically with `make 
maintainer-clean'?

Message #23 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6736 <at> debbugs.gnu.org, Jason Rumney <jasonr <at> gnu.org>
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully 
	clean bzr tree
Date: Mon, 2 Aug 2010 06:10:26 +0200

On Mon, Aug 2, 2010 at 05:58, Christoph <cschol2112 <at> googlemail.com> wrote:

> Right. I guess I will rephrase the question: is there ever a situation where
> we SHOULD delete the site-lisp directory, specifically with `make
> maintainer-clean'?

Should? I don't think so. Could? If you can determine that it has
nothing of value. But I don't think it's worth the trouble.

    Juanma

Message #28 received at 6736-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 6736-done <at> debbugs.gnu.org
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully
 clean bzr tree
Date: Tue, 06 Dec 2016 22:57:58 -0500

I believe this report is not relevant any more,
eg w32-specific makefiles were removed some time ago.

Message #31 received at 6736 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: cschol2112 <at> googlemail.com, rgm <at> gnu.org, 6736 <at> debbugs.gnu.org
Subject: Re: bug#6736: Windows: make maintainer-clean does not restore fully
 clean bzr tree
Date: Wed, 07 Dec 2016 18:02:47 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Tue, 06 Dec 2016 22:57:58 -0500
> 
> I believe this report is not relevant any more,
> eg w32-specific makefiles were removed some time ago.

Indeed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.