GNU bug report logs - #67350
[PATCH] gnu: emacs-blight: Update to 1.1.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67350: closed ([PATCH] gnu: emacs-blight: Update to 1.1.)
Date: Thu, 04 Jan 2024 11:32:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 04 Jan 2024 12:30:29 +0100
with message-id <87plyhjpyi.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#67350] [PATCH] gnu: emacs-blight: Update to 1.1.
has caused the debbugs.gnu.org bug report #67350,
regarding [PATCH] gnu: emacs-blight: Update to 1.1.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67350: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67350
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ian Eure <ian <at> retrospec.tv>
To: guix-patches <at> gnu.org
Cc: Ian Eure <ian <at> retrospec.tv>
Subject: [PATCH] gnu: emacs-blight: Update to 1.1.
Date: Tue, 21 Nov 2023 14:31:19 -0800

*  (emacs-blight): Update to 1.1.

Include udev rules granting access to the backlight.

Change-Id: If277c0845845555d99b9fc55c908ffcea6ea56e6
---
 gnu/packages/emacs-xyz.scm | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 90fe9fceeb..0159b2875d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6031,11 +6031,11 @@ (define-public emacs-inflections
     (license license:gpl3+)))
 
 (define-public emacs-blight
-  (let ((commit "6bf9c6192d2bf979eebbfae1963401ef3ff4ef5d")
+  (let ((commit "3fc2f1ef73de0c2b22a4db72adc4c4b051b34ea0")
         (revision "0"))
     (package
       (name "emacs-blight")
-      (version (git-version "0" revision commit))
+      (version (git-version "1.1" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -6044,8 +6044,22 @@ (define-public emacs-blight
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "1x7s1fcva5kkl9iyb5grd6crf38rrz3zb0c6wb85khi9far10vgq"))))
+          (base32 "1k1w1jr56pp8dgcpdxrymiam1hxsdy7nh6gi5l17pimwba3r4wbm"))))
       (build-system emacs-build-system)
+      (arguments
+       (list
+        #:phases #~(modify-phases %standard-phases
+                     (add-after 'unpack 'patch-udev-rules-absolute-path-bins
+                       (lambda* (#:key inputs #:allow-other-keys)
+                         (substitute* "20-backlight.rules"
+                           (("/bin/chgrp") (which "chgrp"))
+                           (("/bin/chmod") (which "chmod")))
+                         #t))
+                     (add-after 'install 'install-udev-rules
+                       (lambda* (#:key inputs outputs #:allow-other-keys)
+                         (install-file "20-backlight.rules"
+                                       (string-append (assoc-ref outputs "out")
+                                                      "/lib/udev/rules.d")))))))
       (home-page "https://codeberg.org/emacs-weirdware/blight")
       (synopsis "Control display brightness")
       (description

base-commit: 42be8fa560a7554ac35801b46c3a0a007fd742ce
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ian Eure <ian <at> retrospec.tv>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 67350-done <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67350] [PATCH] gnu: emacs-blight: Update to 1.1.
Date: Thu, 04 Jan 2024 12:30:29 +0100

Hello,

Ian Eure <ian <at> retrospec.tv> writes:

> *  (emacs-blight): Update to 1.1.
>
> Include udev rules granting access to the backlight.

Applied, thank you.

I also normalized the commit message, removed unnecessary arguments in
phases (such as `inputs' and `outputs'), and used a tag instead of
a commit hash.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.