GNU bug report logs - #67343
[PATCH] Add fftw-cmake

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67343: closed ([PATCH] Add fftw-cmake)
Date: Fri, 29 Mar 2024 16:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 29 Mar 2024 16:47:22 +0000
with message-id <87r0ftc7dx.fsf <at> gmail.com>
and subject line [PATCH] Add fftw-cmake
has caused the debbugs.gnu.org bug report #67343,
regarding [PATCH] Add fftw-cmake
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67343: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67343
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mehmet Tekman <mtekman89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add fftw-cmake
Date: Tue, 21 Nov 2023 21:56:36 +0100

[Message part 3 (text/plain, inline)]

This patch is a dependency of krita 5.2.1, and is a clone of the fftw
gnu-build which does not provide a required CMake file for krita.

It is not clear if the CMake build provides the target optimizations, so
it does replace the existing fftw variable.

[0002-gnu-Add-fftw-cmake.patch (text/x-patch, inline)]

From 70fc6c6ada030c7b5d4d35da6da8a2f4f018ff74 Mon Sep 17 00:00:00 2001
From: mtekman <mtekman89 <at> gmail.com>
Date: Tue, 21 Nov 2023 21:35:56 +0100
Subject: [PATCH] gnu: Add fftw-cmake

* gnu/packages/algebra.scm (fftw-cmake): New variable

  This is a clone of the fftw function, but uses cmake to build in order for
  the FFTW3LibraryDepends.cmake file to be built, neccesary for packages with
  cmake builds that depend on fftw3.

  See: https://bugzilla.redhat.com/show_bug.cgi?id=1729652#c5

  This variable is cloned from the existing fftw3 in order to not break any
  downstream packages that make use of the target optimizations given by the
  gnu build.

Change-Id: Ied7920beae0494350445d3a1905fa37b2b83976a
---
 gnu/packages/algebra.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index c0fe75ddfd..a31338ff6f 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -778,6 +778,33 @@ (define-public fftw
 cosine/ sine transforms or DCT/DST).")
     (license license:gpl2+)))
 
+(define-public fftw-cmake
+  (package
+    ;; Cmake compiling is experimental since 2017, and it is not clear if this
+    ;; build has the same target-specific optimizations as the fftw gnu build.
+    ;; See: https://fftw.org/release-notes.html
+    (name "fftw-cmake")
+    (version "3.3.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "ftp://ftp.fftw.org/pub/fftw/fftw-" version
+                           ".tar.gz"))
+       (sha256
+        (base32 "00z3k8fq561wq2khssqg0kallk0504dzlx989x3vvicjdqpjc4v1"))))
+    (build-system cmake-build-system)
+    (native-inputs (list perl))
+    (home-page "https://fftw.org")
+    (synopsis "Computing the discrete Fourier transform")
+    (description
+     "FFTW is a C subroutine library for computing the discrete Fourier
+transform (DFT) in one or more dimensions, of arbitrary input size, and of
+both real and complex data (as well as of even/odd data---i.e. the discrete
+cosine/ sine transforms or DCT/DST).  This CMake build offers the file
+FFTW3LibraryDepends.cmake required by some dependent packages, absent in the
+gnu build version.")
+    (license license:gpl2+)))
+
 (define-public fftwf
   (package/inherit fftw
     (name "fftwf")
-- 
2.41.0

[Message part 5 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 67343-done <at> debbugs.gnu.org
Subject: [PATCH] Add fftw-cmake
Date: Fri, 29 Mar 2024 16:47:22 +0000

[Message part 6 (text/plain, inline)]

Pushed as 74d2c8304f3839efcbb048d23f366df9f33d7646 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.