Subject: bug#67315: closed (Re: [bug#67315] [PATCH 1/2] gnu: lean: Use G-expressions.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 11 Dec 2023 22:51:02 +0000

Your bug report

#67315: [PATCH 1/2] gnu: lean: Use G-expressions.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
67315: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67315
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#67315] [PATCH 1/2] gnu: lean: Use G-expressions.
From: Ludovic Courtès <[email-masked]>
To: Zhu Zihao <[email-masked]>
Cc: [email-masked]
Date: Mon, 11 Dec 2023 23:49:59 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Zhu Zihao <[email-masked]> skribis:

> * gnu/packages/lean.scm (lean)[arguments]: Use G-expressions.

[...]

> * gnu/packages/lean.scm (lean): Update to 3.51.1.
> [home-page]: Use new home page.
> [arguments]<#:phases>: Remove stale phase 'patch-tests-shebangs'.
> [inputs]: Remove bash-minimal.
>
> Change-Id: Ib90a124b4a6b06fb30223ad4b9254249e56dd086

Applied, thanks!

Ludo’.

Subject: [PATCH 1/2] gnu: lean: Use G-expressions.
From: Zhu Zihao <[email-masked]>
To: [email-masked]
Cc: Zhu Zihao <[email-masked]>
Date: Tue, 21 Nov 2023 11:54:38 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/lean.scm (lean)[arguments]: Use G-expressions.
---
 gnu/packages/lean.scm | 49 +++++++++++++++++++++++--------------------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/lean.scm b/gnu/packages/lean.scm
index 12c1849cdb..a8ad085d7e 100644
--- a/gnu/packages/lean.scm
+++ b/gnu/packages/lean.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2020 Brett Gilio <[email-masked]>
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2022 Pradana Aumars <[email-masked]>
+;;; Copyright © 2023 Zhu Zihao <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25,6 +26,7 @@ (define-module (gnu packages lean)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system python)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix download)
@@ -52,29 +54,30 @@ (define-public lean
     (inputs
      (list bash-minimal gmp))
     (arguments
-     `(#:build-type "Release"           ; default upstream build type
-       ;; XXX: Test phases currently fail on 32-bit sytems.
-       ;; Tests for those architectures have been temporarily
-       ;; disabled, pending further investigation.
-       #:tests? ,(and (not (%current-target-system))
-                      (let ((arch (%current-system)))
-                        (not (or (string-prefix? "i686" arch)
-                                 (string-prefix? "armhf" arch)))))
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'patch-source-shebangs 'patch-tests-shebangs
-           (lambda _
-             (let ((sh (which "sh"))
-                   (bash (which "bash")))
-               (substitute* (find-files "tests/lean" "\\.sh$")
-                 (("#![[:blank:]]?/bin/sh")
-                  (string-append "#!" sh))
-                 (("#![[:blank:]]?/bin/bash")
-                  (string-append "#!" bash))
-                 (("#![[:blank:]]?usr/bin/env bash")
-                  (string-append "#!" bash))))))
-         (add-before 'configure 'chdir-to-src
-           (lambda _ (chdir "src"))))))
+     (list
+      #:build-type "Release"            ; default upstream build type
+      ;; XXX: Test phases currently fail on 32-bit sytems.
+      ;; Tests for those architectures have been temporarily
+      ;; disabled, pending further investigation.
+      #:tests? (and (not (%current-target-system))
+                    (let ((arch (%current-system)))
+                      (not (or (string-prefix? "i686" arch)
+                               (string-prefix? "armhf" arch)))))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'patch-source-shebangs 'patch-tests-shebangs
+            (lambda _
+              (let ((sh (which "sh"))
+                    (bash (which "bash")))
+                (substitute* (find-files "tests/lean" "\\.sh$")
+                  (("#![[:blank:]]?/bin/sh")
+                   (string-append "#!" sh))
+                  (("#![[:blank:]]?/bin/bash")
+                   (string-append "#!" bash))
+                  (("#![[:blank:]]?usr/bin/env bash")
+                   (string-append "#!" bash))))))
+          (add-before 'configure 'chdir-to-src
+            (lambda _ (chdir "src"))))))
     (synopsis "Theorem prover and programming language")
     (description
      "Lean is a theorem prover and programming language with a small trusted

base-commit: d20ece07dbb09382f361c8bbf0bcab9e83d8b73e
-- 
2.41.0