GNU bug report logs - #67310
[PATCH] Include the project--list as history when prompting for a project

Previous Next

Full log

Message #17 received at 67310 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 67310 <at> debbugs.gnu.org, eliz <at> gnu.org, juri <at> linkov.net
Subject: Re: bug#67310: [PATCH] Include the project--list as history when
 prompting for a project
Date: Wed, 22 Nov 2023 03:40:28 +0200

On 21/11/2023 17:17, Spencer Baugh wrote:
>       (if (equal pr-dir dir-choice)
>           (read-directory-name "Select directory: " default-directory nil t)
> +      (project--add-dir pr-dir)
>         pr-dir)))
> ...
>       (if (equal pr-name dir-choice)
>           (read-directory-name "Select directory: " default-directory nil t)
> -      (let ((proj (assoc pr-name choices)))
> -        (if (stringp proj) proj (project-root (cdr proj)))))))
> +      (let* ((proj (assoc pr-name choices))
> +             (root (project-root (cdr proj))))
> +        (project--add-dir root)
> +        root))))

I think in the (equal pr-dir dir-choice) case we want to add the 
directory name entered by the user into the "history" anyway, don't we?

Though perhaps there's no need to do it here: 'project-current' calls 
'project-remember-project' anyway when maybe-prompt is non-nil.

So what happens if you drop both of the above 'project--add-dir' calls?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.