GNU bug report logs - #67284
[PATCH] guix: meson: Add #:substitutable? argument to build system.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Skyler Ferris <skyvine <at> protonmail.com>
Subject: bug#67284: closed (Re: [bug#67284] [PATCH] guix: meson: Add
 #:substitutable? argument to build system.)
Date: Sat, 25 Nov 2023 16:32:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67284: [PATCH] guix: meson: Add #:substitutable? argument to build system.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67284 <at> debbugs.gnu.org.

-- 
67284: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67284
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Skyler Ferris <skyvine <at> protonmail.com>
Cc: 67284-done <at> debbugs.gnu.org
Subject: Re: [bug#67284] [PATCH] guix: meson: Add #:substitutable? argument
 to build system.
Date: Sat, 25 Nov 2023 17:31:29 +0100

Skyler Ferris <skyvine <at> protonmail.com> skribis:

> This implemented the same as in gnu-build-system. The gexp->derivation
> calls did not need to be modified because they already
> passed #:substitutable?, which did not cause an error due to the
> procedure exported by the (guix store) module with the same name.

Heh, fun.  :-)

> * guix/build-system/meson.scm (meson-build, meson-cross-build): Add
>   #:substitutable? argument
>
> Change-Id: I2d56c8130f785a2d6af456ef9f9bfc1b10dc2a50

Applied, thanks!

[Message part 3 (message/rfc822, inline)]

From: Skyler Ferris <skyvine <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Skyler Ferris <skyvine <at> protonmail.com>
Subject: [PATCH] guix: meson: Add #:substitutable? argument to build system.
Date: Sun, 19 Nov 2023 09:14:39 -0800

This implemented the same as in gnu-build-system. The gexp->derivation
calls did not need to be modified because they already
passed #:substitutable?, which did not cause an error due to the
procedure exported by the (guix store) module with the same name.

* guix/build-system/meson.scm (meson-build, meson-cross-build): Add
  #:substitutable? argument

Change-Id: I2d56c8130f785a2d6af456ef9f9bfc1b10dc2a50
---
 guix/build-system/meson.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm
index 7c617bffb0..2d14016b94 100644
--- a/guix/build-system/meson.scm
+++ b/guix/build-system/meson.scm
@@ -182,6 +182,7 @@ (define* (meson-build name inputs
                       (imported-modules %meson-build-system-modules)
                       (modules '((guix build meson-build-system)
                                  (guix build utils)))
+                      (substitutable? #t)
                       allowed-references
                       disallowed-references)
   "Build SOURCE using MESON, and with INPUTS, assuming that SOURCE
@@ -266,6 +267,7 @@ (define* (meson-cross-build name
                             (imported-modules %meson-build-system-modules)
                             (modules '((guix build meson-build-system)
                                        (guix build utils)))
+                            (substitutable? #t)
                             allowed-references
                             disallowed-references)
   "Cross-build SOURCE for TARGET using MESON, and with INPUTS, assuming that

base-commit: cd82ddd15c28b4f4690255b11a1ce6dcac7c166d
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.