GNU bug report logs - #67283
[PATCH] guix: guile: Add #:substitutable? argument to build system.

Previous Next

Package: guix-patches;

Reported by: Skyler Ferris <skyvine <at> protonmail.com>

Date: Sun, 19 Nov 2023 17:12:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Skyler Ferris <skyvine <at> protonmail.com>
Subject: bug#67283: closed (Re: [bug#67283] [PATCH] guix: guile: Add
 #:substitutable? argument to build system.)
Date: Sat, 25 Nov 2023 15:28:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#67283: [PATCH] guix: guile: Add #:substitutable? argument to build system.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67283 <at> debbugs.gnu.org.

-- 
67283: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67283
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Skyler Ferris <skyvine <at> protonmail.com>
Cc: 67283-done <at> debbugs.gnu.org
Subject: Re: [bug#67283] [PATCH] guix: guile: Add #:substitutable? argument
 to build system.
Date: Sat, 25 Nov 2023 16:26:48 +0100
Skyler Ferris <skyvine <at> protonmail.com> skribis:

> This is implemented the same as in gnu-build-system.
>
> * guix/build-system/guile.scm (guile-build, guile-cross-build): Add
>   #:substitutable? argument
>
> Change-Id: I04babb81ff1f322833f7ff22cd7580c048b26102

Tweaked the commit log and applied it, thanks!

[Message part 3 (message/rfc822, inline)]
From: Skyler Ferris <skyvine <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Skyler Ferris <skyvine <at> protonmail.com>
Subject: [PATCH] guix: guile: Add #:substitutable? argument to build system.
Date: Sun, 19 Nov 2023 09:10:36 -0800
This is implemented the same as in gnu-build-system.

* guix/build-system/guile.scm (guile-build, guile-cross-build): Add
  #:substitutable? argument

Change-Id: I04babb81ff1f322833f7ff22cd7580c048b26102
---
 guix/build-system/guile.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm
index 1bd292e267..bd3bb1c870 100644
--- a/guix/build-system/guile.scm
+++ b/guix/build-system/guile.scm
@@ -88,7 +88,8 @@ (define* (guile-build name inputs
                       (compile-flags %compile-flags)
                       (imported-modules %guile-build-system-modules)
                       (modules '((guix build guile-build-system)
-                                 (guix build utils))))
+                                 (guix build utils)))
+                      (substitutable? #t))
   "Build SOURCE using Guile taken from the native inputs, and with INPUTS."
   (define builder
     (with-imported-modules imported-modules
@@ -114,6 +115,7 @@ (define* (guile-build name inputs
                       #:system system
                       #:target #f
                       #:graft? #f
+                      #:substitutable? substitutable?
                       #:guile-for-build guile)))
 
 (define* (guile-cross-build name
@@ -133,7 +135,8 @@ (define* (guile-cross-build name
                             (compile-flags %compile-flags)
                             (imported-modules %guile-build-system-modules)
                             (modules '((guix build guile-build-system)
-                                       (guix build utils))))
+                                       (guix build utils)))
+                            (substitutable? #t))
   (define builder
     (with-imported-modules imported-modules
       #~(begin
@@ -173,6 +176,7 @@ (define* (guile-cross-build name
                       #:system system
                       #:target target
                       #:graft? #f
+                      #:substitutable? substitutable?
                       #:guile-for-build guile)))
 
 (define guile-build-system

base-commit: cd82ddd15c28b4f4690255b11a1ce6dcac7c166d
prerequisite-patch-id: d25067ea4ec0e23744f2dca853c7e9f7b9ab4a9d
-- 
2.41.0




This bug report was last modified 1 year and 237 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.