GNU bug report logs - #67260
[PATCH emacs-team 0/2] Think ahead when compiling

Previous Next

Full log

View this message in rfc822 format

From: Suhail <suhail <at> bayesians.ca>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: cox.katherine.e+guix <at> gmail.com, 67260 <at> debbugs.gnu.org, Suhail <suhail <at> bayesians.ca>, andrew <at> trop.in
Subject: [bug#67260] [PATCH emacs-team v10 0/7] Preload most of the things
Date: Tue, 20 Feb 2024 18:41:50 +0000

[Message part 1 (text/plain, inline)]

"Liliana Marie Prikler" <liliana.prikler <at> gmail.com> writes:

> We still only have 97 tests squashed to 5 cases IIUC.

Yes.

> There's some 1000 files in the native-lisp directory.  What I was
> actually hoping for is more or less one test per feature.

Yes, I agree that that would be useful, but doing so was (is) more than
what I was (am) able to do in the time I was (am) able to commit (at
present).

I believe it would be valuable to have such an exhaustive test included
as part of the patch submission to prevent future regressions.

> That is not a good way of checking whether it's Guix' emacs or not.

What would be a better way?  Matching against the --prefix value in the
output of emacs-build-description function?

> I propose doing a per-file deftest instead.

I don't understand the connection between a per-file deftest and the
manner in which guix-emacs-or-not is tested, but otherwise agree on the
utility of per-feature deftests.

> Could you do a MIME attachment next time?

Sure.  For now, for what it's worth and in case it helps, please see
attached a copy of the same file as before.


-- 
Suhail

[test-native-comp-p.el (text/x-emacs-lisp, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.