Subject: [bug#67257] [PATCH v2 2/2] gnu: Add x2goclient.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 27 Feb 2024 11:02:41 +0100

Steve George <[email-masked]> skribis:

> From: nicodebo <[email-masked]>
>
> * gnu/packages/nx.scm (x2goclient): New variable.
>
> Reviewed-by: Steve George <[email-masked]>
>
> Change-Id: Ib0ff6328ede3fb4a0b48462ac1a003438c53c862

[...]

> +                        (substitute* "src/onmainwindow.cpp"
> +                          (("/usr/sbin/sshd")
> +                           (which "sshd"))))))

Rather use ‘search-input-file’ here, as mentioned in my other message.

> +    (native-inputs (list pkg-config
> +                         qttools-5
> +                         qtbase-5
> +                         qtx11extras
> +                         qtsvg-5
> +                         libssh
> +                         cups
> +                         libxpm
> +                         openldap
> +                         gcc-toolchain))

You can omit ‘gcc-toolchain’.  Most likely, everything but ‘pkg-config’
and ‘qttools-5’ shold be in ‘inputs’ rather than ‘native-inputs’.

> +    (propagated-inputs (list nx-libs
> +                             openssh))

Don’t propagate OpenSSH: it should be up to the user to install it if
they want it, to avoid being too intrusive.

‘nx-libs’ probably doesn’t need to be propagated either and can be in
‘inputs’, no?

Could you send updated patches?

Thanks!

Ludo’.