Subject: [bug#67257] [PATCH v2 1/2] gnu: Add nx-libs.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 27 Feb 2024 10:59:14 +0100

Hi!

Thank you Steve for shepherding this patch set!  Here are some comments
on minor issues.

Steve George <[email-masked]> skribis:

> From: nicodebo <[email-masked]>
>
> * gnu/packages/nx.scm: New file.
> * gnu/packages/nx.scm (nx-libs): New variable.

The second line is unnecessary.

Please make sure to add the file to ‘gnu/local.mk’.

> +++ b/gnu/packages/nx.scm
> @@ -0,0 +1,141 @@
> +;;; This file is part of GNU Guix.

Looks like a couple of lines are missing from the usual header.

> +                  (add-before 'build 'replace-shebang-nxdialog
> +                    (lambda _
> +                      (substitute* "nxdialog/bin/nxdialog"
> +                        (("#!/usr/bin/env python")
> +                         (string-append "#!"
> +                                        (which "python3"))))))

‘which’ returns ‘python3’ as found in $PATH—i.e., the native python.

To do the right thing in a cross-compilation context (for example, pick
the AArch64 ‘python3’ binary if you’re cross-compiling to AArch64), it
should be written like this:

  (lambda* (#:key inputs #:allow-other-keys)
    (substitute* …
      (… … (search-input-file inputs "/bin/python3"))))

> +    (synopsis "NX remote desktop library")
> +    (description
> +     "NX technology also known as NX or NoMachine is a protocol that enables
> +remote desktop access.  It's maintained by the artica project, x2go
> +developers and TheQVD.")

Please describe that the package does; who maintains it is usually not
relevant here:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

Thanks,
Ludo’.