GNU bug report logs - #67198
[PATCH] gnu: Add emacs-adwaita-dark-theme

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tristan Cottam <tristan <at> cott.am>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 67198 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67198] [PATCH] gnu: Add emacs-adwaita-dark-theme
Date: Wed, 15 Nov 2023 18:11:19 +0100

Hello,

Tristan Cottam via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-adwaita-dark-theme): New variable.

Thank you.

> +(define-public emacs-adwaita-dark-theme
> +  (let ((commit "a97d5d5f5657a52c3b4c4b146b4d307dfb1a7a74")
> +        (revision "0"))
> +    (package
> +      (name "emacs-adwaita-dark-theme")
> +      (version (git-version "1.1.0" revision commit))

The last commit is actually a version bump to "1.1.1", so you can bind
`version' to "1.1.1", drop `revision' and use that commit instead.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://gitlab.com/jessieh/adwaita-dark-theme")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0g8fjqmz805fhqspbzmpvb90kpzwigl4z56bkykywgy2cwb9ljzh"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://gitlab.com/jessieh/adwaita-dark-theme")
> +      (synopsis "Adwaita-inspired dark color scheme for Emacs")
> +      (description
> +       "adwaita-dark-theme is an Adwaita-inspired dark color scheme for
> +Emacs.")

Nitpick: "Adwaita Dark is an Adwaita-inspired…"

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.