From unknown Mon Jun 23 14:59:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67180 <67180@debbugs.gnu.org> To: bug#67180 <67180@debbugs.gnu.org> Subject: Status: 30.0.50; 'pp-to-string' emits extra newline Reply-To: bug#67180 <67180@debbugs.gnu.org> Date: Mon, 23 Jun 2025 21:59:48 +0000 retitle 67180 30.0.50; 'pp-to-string' emits extra newline reassign 67180 emacs submitter 67180 Eshel Yaron severity 67180 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 15:13:29 2023 Received: (at submit) by debbugs.gnu.org; 14 Nov 2023 20:13:29 +0000 Received: from localhost ([127.0.0.1]:34212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2zmr-0006qa-4Q for submit@debbugs.gnu.org; Tue, 14 Nov 2023 15:13:29 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2zmp-0006qL-0k for submit@debbugs.gnu.org; Tue, 14 Nov 2023 15:13:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2zm3-0008DR-9l for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 15:12:39 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2zm1-0007Vr-Qc for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 15:12:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1699992756; bh=jH1rRRw8SUBWwvo3nYth47JYNrBZJXnZuIbDbMf8mak=; h=From:To:Subject:Date:From; b=rYchmj5CiPe7BZXtwiskyCBP3YImHgnK4PcZti4k3Y7tyDNpwXdDWR5X+R4LBwtnE 57/af1qx4Elx2Amj3v15gl13vP9vT7lZq7HhvWo8t7HYDtFhldDy7uQAmS+jjWCPkl NBJm7prrBc518m09OzXT9Pq3OkoOzgHOclMZ0bVtLmh50SIJs7WBXdp09mKnOxBdGe Z8SFK7P+71YErxyvFt7HVuIXiEy8BzFTcAYVBqIOqkGlajr4YukmfH3HCtAZl+aLSX W51ebiwEZK/A1KJpdgV39RQBDtVPIdfiMnAaLCSSR0PfKRfySlugUDBH+0tselfVpN U+ScWovwKYA1Q== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: 30.0.50; 'pp-to-string' emits extra newline Date: Tue, 14 Nov 2023 21:12:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On Emacs 29 and earlier, with `-Q`, we have: (pp-to-string "foo") => "\"foo\"" On master with `-Q`, we get an extra newline at the end of the string: (pp-to-string "foo") => "\"foo\" " AFAICT this change in behavior breaks `agda2-mode` completely on master. This happens because apparently `agda2-mode` uses `pp-to-string` to quote strings before sending them to a REPL (that doesn't expect the newline the middle of a command): --8<---------------cut here---------------start------------->8--- (defun agda2-string-quote (s) "..." (let ((pp-escape-newlines t) (s2 (copy-sequence s))) (set-text-properties 0 (length s2) nil s2) (mapconcat 'agda2-char-quote (pp-to-string s2) ""))) ^^^^^^^^^^^^^^^^^ --8<---------------cut here---------------end--------------->8--- In GNU Emacs 30.0.50 (build 24, x86_64-apple-darwin23.0.0, NS appkit-2487.00 Version 14.0 (Build 23A344)) of 2023-11-13 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 15:38:00 2023 Received: (at submit) by debbugs.gnu.org; 14 Nov 2023 20:38:00 +0000 Received: from localhost ([127.0.0.1]:34229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r30Aa-0007R0-Ea for submit@debbugs.gnu.org; Tue, 14 Nov 2023 15:38:00 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r30AZ-0007Qn-4g for submit@debbugs.gnu.org; Tue, 14 Nov 2023 15:37:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r309k-0006sp-OA for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 15:37:08 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r309h-0003Ed-NP for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 15:37:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1699994224; bh=sAKNnbwmVGOnNEMqOhC5tLb006R6GWftI2owGiFHlW8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mr0+K0whnyIGZJ1ag2r+0BMgXDRgedjZSFx18+iW43zcWrqe4jLDzbcm5KwUj0iAr nfR3mIGzPonWM8lNJXyYSk/MAIlVVS7rx3uFv22cOvQU2anV3jT4ZFHgQfLdtQQr6n mKFPPvvZ3nJMY6Y02RSlUMXYFKsggKa0E5tYeNGpGJl35MXcueOl2a9IxSvuwTvu1i AowkcIT8d6fodL5YwDFG21ZK4kNRyjYtqmiOGzPSRM4+l4c37x5rEKoJlSkcHmLPBS 7HHIkqZXSFVPY3q59dNl3qGvC7OL+zIcrNaPrn4U6ovIqEB6MWT5CaL60o3n9Qo9jS wJZ/GFNFpQ63A== From: Eshel Yaron To: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: (Eshel Yaron via's message of "Tue, 14 Nov 2023 21:12:34 +0100") References: X-Hashcash: 1:20:231114:67180@debbugs.gnu.org::ntaxpgsypAMcq8VC:dFN X-Hashcash: 1:20:231114:bug-gnu-emacs@gnu.org::dWEc294ytqFf2jId:mdu Date: Tue, 14 Nov 2023 21:37:02 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 67180@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Eshel Yaron writes: > On Emacs 29 and earlier, with `-Q`, we have: > > (pp-to-string "foo") > => "\"foo\"" > > On master with `-Q`, we get an extra newline at the end of the string: > > (pp-to-string "foo") > => "\"foo\" > " > > AFAICT this change in behavior breaks `agda2-mode` completely on master... I see that the Agda developers worked around[0] this in the development version of `agda2-mode`, but of course more code out there may be affected by this change. Perhaps it's worth mentioning in NEWS? Best, Eshel [0] https://github.com/agda/agda/pull/6954 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 10:37:13 2023 Received: (at 67180) by debbugs.gnu.org; 15 Nov 2023 15:37:13 +0000 Received: from localhost ([127.0.0.1]:52897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Hx0-0000TO-1U for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:37:11 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:41350 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Hwq-0000Sm-5x for 67180@debbugs.gnu.org; Wed, 15 Nov 2023 10:37:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700053841; bh=IIfZLLYCcymAO/Ff+LWP1KKCdSWTKczFeRXrNVB31ZI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oG1QUWuV1ohPOaddnKYVyVHrLGNhK/p7BQycMQZvt3cu8uWa/DY4yjgjBuulVDfXX mHBETIhhm4YQhJeZBP8lF9z1Vdd1CQ6Gu6S2ZoC7GhzV8kbwYoYe2N2XRS+Y9+/yiv bGBhMN2IZhNfhQuO4S7X6WKY2Zxvp3RIKaYDIQR5OdPWof852DJP9qVyGFJ9Yi2DNb d3Tt2rnPfqDErIjMOHmADPvwcxNQ2b5fwBdEQAkA9ND7813HjVVyv0xi5nd7BWz8V6 RC3b/0TanRwJw57GjV1r2VZ9c5YrKEFOxlkIZxjhtrgLkQLdAqwICaCYz4Hki+BtQY CdUP4nMdsj2TQ== From: Eshel Yaron To: Stefan Monnier Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: (Stefan Monnier's message of "Wed, 15 Nov 2023 07:52:50 -0500") References: <83il63rzrt.fsf@gnu.org> Date: Wed, 15 Nov 2023 14:10:39 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67180 Cc: 67180@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> On Emacs 29 and earlier, with `-Q`, we have: >>> >>> (pp-to-string "foo") >>> => "\"foo\"" >>> >>> On master with `-Q`, we get an extra newline at the end of the string: >>> >>> (pp-to-string "foo") >>> => "\"foo\" >>> " > > Is that a problem? FWIW, I think that this change is for the better, but it is incompatible, and sadly it broke `agda2-mode`. (In some sense this probably Agda's "fault", because I don't really understand why they're using `pp-to-string` the way they do.) My suggestion was simply to explicitly mention this new behavior in NEWS or some such. > I also see that the old `pp-to-string` added that same extra newline for > slightly more complex input: > > ELISP> (pp-to-string '("foo")) > "(\"foo\") > " > ELISP> > >> Stefan, is this due to your changes in pp? > > Yes. > > > Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:28:12 2023 Received: (at 67180) by debbugs.gnu.org; 15 Nov 2023 16:28:12 +0000 Received: from localhost ([127.0.0.1]:53134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkO-00028v-8J for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQk-0001QS-F0 for 67180@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Eaf-0007ll-W2; Wed, 15 Nov 2023 07:01:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yq1DuwuxiDhg6piamSRwrdD++IlT0ksn5ET1/172cuc=; b=T8zDfcdoI0Er G9l/GR3QwdTlj3UGy3nGgvVYiXhxFfZzw5GgdjGyusZbn346P3ZP/5TsEz7gbE0x8Bp7BXkECnu/L cP94rPphiKycRuLTL3zOGZKID6ksPWg+7KCEFJ088Me6AvqREAzGVeGd3XTfMtGL/CUy5I3zMRZyd AhcZj0CQGsWnpvl3pZraCGlrODOzjlrc3mUKI3tJoL+BIP84KALptnBkNbnnp289hEeNTQ6k+yTrs 8WASadlZB8UHO1Ht7MW/NX8HP0rk2KoFqxLzQ3p8hLclCAoND3F+/co/zkpcccScZfMMDS+HL49jR NiZevJlmpm7ME3ZabGV1hg==; Date: Wed, 15 Nov 2023 14:01:42 +0200 Message-Id: <83il63rzrt.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron , Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67180 Cc: 67180@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 14 Nov 2023 21:12:34 +0100 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > On Emacs 29 and earlier, with `-Q`, we have: > > (pp-to-string "foo") > => "\"foo\"" > > On master with `-Q`, we get an extra newline at the end of the string: > > (pp-to-string "foo") > => "\"foo\" > " Stefan, is this due to your changes in pp? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:32:24 2023 Received: (at 67180) by debbugs.gnu.org; 15 Nov 2023 16:32:24 +0000 Received: from localhost ([127.0.0.1]:53176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IoS-0002Ka-82 for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:32:24 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IoQ-0002KM-QC for 67180@debbugs.gnu.org; Wed, 15 Nov 2023 11:32:23 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2D23F100126; Wed, 15 Nov 2023 07:52:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700052770; bh=yHDRJIAyPaP52uLgqPG3Js19IF8lmlNYH5I77apH0r0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TjBzvUGVBLz5x8dZEqfpuZ04pjgS3VjejazlNY48SLOuWOOzuHJxqQ1kwLDEZZ5b+ c163IxL1Vmu+Wv/Jm/B3G/M0RDVdALh8n27hYwKGqjYIHVXYYDr70/UpFf2Nr38Ore 7V7t5vOrTa5J5I+gBaQytlQ6CnSIK3gbGEsLpNG4bqCS0Xz6cZ93FQp/rHRtLmBZst B9v3N3X72T8GTLOfUiHRlUxwRDaSnuh7X5KcDXYijgt9DAuzB8hp/Hokc+gNH4kHvH eJjp4DvvAcFJqqm2wtxzZH40V4qzl9bQEaZ6IJ7jwJAwEOzArdQAKwoSb2xEhU1HL/ b7xs21LAG31zg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6F3C4100061; Wed, 15 Nov 2023 07:52:50 -0500 (EST) Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 488071201B6; Wed, 15 Nov 2023 07:52:50 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: <83il63rzrt.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Nov 2023 14:01:42 +0200") Message-ID: References: <83il63rzrt.fsf@gnu.org> Date: Wed, 15 Nov 2023 07:52:50 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.133 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67180 Cc: 67180@debbugs.gnu.org, Eshel Yaron X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> On Emacs 29 and earlier, with `-Q`, we have: >> >> (pp-to-string "foo") >> => "\"foo\"" >> >> On master with `-Q`, we get an extra newline at the end of the string: >> >> (pp-to-string "foo") >> => "\"foo\" >> " Is that a problem? I also see that the old `pp-to-string` added that same extra newline for slightly more complex input: ELISP> (pp-to-string '("foo")) "(\"foo\") " ELISP> > Stefan, is this due to your changes in pp? Yes. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 09:16:28 2023 Received: (at 67180) by debbugs.gnu.org; 16 Nov 2023 14:16:28 +0000 Received: from localhost ([127.0.0.1]:54829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dAR-0004nH-TA for submit@debbugs.gnu.org; Thu, 16 Nov 2023 09:16:28 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dAM-0004mx-G5 for 67180@debbugs.gnu.org; Thu, 16 Nov 2023 09:16:26 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 61A8944231E; Thu, 16 Nov 2023 09:16:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700144176; bh=iKI+TsgVeg7ghQUapUKimBam1+oA0y3fUZAjrERCPcI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OIH/7uxuvtvs7fGkbEuBKLEZ45ZCUKjHApdvb5/iJlBRIW/SVgaYAeck023V2XV2n 8p7sm5NTyfoNlRYV7u/6tHNOfHPqfCah6T6fVcRy3oXgRxjkWrCkZ0PspIk6l+uqLu CuT9JlQ71oe33uGL/aUrXsUJOIjxXPYu5TM2v/tqDhOGg18OzOQuVJbePUtogwn9Ah zA38eJlh9k/JqhrgUH0gtG0l8Zp2Zok/aGE1pCxDcJ/a9mb7lZVSE2slr7N8gcXWyh eHIlvjnnQp+uHYMXP+hlxVzncicxtajVyoGdSKeT21UcCZTUyB1XfTbWgkBiyAFmgR kxmslxQ7ZLD0g== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5965D441158; Thu, 16 Nov 2023 09:16:16 -0500 (EST) Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D9C31201B4; Thu, 16 Nov 2023 09:16:16 -0500 (EST) From: Stefan Monnier To: Eshel Yaron Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: (Eshel Yaron's message of "Wed, 15 Nov 2023 14:10:39 +0100") Message-ID: References: <83il63rzrt.fsf@gnu.org> Date: Thu, 16 Nov 2023 09:16:02 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67180 Cc: 67180@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eshel Yaron [2023-11-15 14:10:39] wrote: > Stefan Monnier writes: > >>>> On Emacs 29 and earlier, with `-Q`, we have: >>>> >>>> (pp-to-string "foo") >>>> => "\"foo\"" >>>> >>>> On master with `-Q`, we get an extra newline at the end of the string: >>>> >>>> (pp-to-string "foo") >>>> => "\"foo\" >>>> " >> >> Is that a problem? > > FWIW, I think that this change is for the better, but it is > incompatible, and sadly it broke `agda2-mode`. (In some sense this > probably Agda's "fault", because I don't really understand why they're > using `pp-to-string` the way they do.) My suggestion was simply to > explicitly mention this new behavior in NEWS or some such. Like this? diff --git a/etc/NEWS b/etc/NEWS index 23f4a8b5311..2dcb2f5664e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1099,6 +1099,9 @@ showcases all their customization options. * Incompatible Lisp Changes in Emacs 30.1 +** 'pp' and 'pp-to-string' now always include a terminating newline. +In the past they included a terminating newline in most cases but not all. + ** 'buffer-match-p' and 'match-buffers' take '&rest args'. They used to take a single '&optional arg' and were documented to use an unreliable hack to try and support condition predicates that -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 10:34:42 2023 Received: (at 67180) by debbugs.gnu.org; 16 Nov 2023 15:34:42 +0000 Received: from localhost ([127.0.0.1]:57430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3eOA-0007qL-IA for submit@debbugs.gnu.org; Thu, 16 Nov 2023 10:34:42 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:45838 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3eO7-0007qC-OW for 67180@debbugs.gnu.org; Thu, 16 Nov 2023 10:34:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700148879; bh=NtTMZPzwdqSxSwIEMrUJh4/V8JobQDAu3C9/+Jz6eLc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=giYx2Zu9Ae/TmStzjuQD9u8HyuGhSq77odwKxM476Vt4QHQraw7GLrb1K93kRxiJC oBI8DQrFnV/2LNys5mO8qtFtfX7N4qQpjTIZDbEfICCua+m23EQAKuPXdZGftHgXaw BzZs3P2wBse3ZloFOlcfZ3kqBR4vD0FM34222c3HxrMsNzBlxhTpCuiQz4Hs6QfgRn NJDTqt8vIFmuJBHlG8XWWv42rRNksiT5dFW2b1nISMSRyBT/NFYeKYG2GfI+8iOqnD t3li9ALaCOcIi4ObMyrk9umnc7Lhu+bRevzwQklj8/E0Io9hRVUSuCFEWNBUx2VMmC HNiXG+IRr3WfQ== From: Eshel Yaron To: Stefan Monnier Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: (Stefan Monnier's message of "Thu, 16 Nov 2023 09:16:02 -0500") References: <83il63rzrt.fsf@gnu.org> X-Hashcash: 1:20:231116:monnier@iro.umontreal.ca::bRyBnhO1XstjHBIW:0Xlv X-Hashcash: 1:20:231116:eliz@gnu.org::zkhCNPjmI5+heftv:3eEU X-Hashcash: 1:20:231116:67180@debbugs.gnu.org::B9+X2ebQDFbzxqw6:26Vl Date: Thu, 16 Nov 2023 16:34:37 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67180 Cc: 67180@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Eshel Yaron [2023-11-15 14:10:39] wrote: > >> ...My suggestion was simply to explicitly mention this new behavior >> in NEWS or some such. > > Like this? > > diff --git a/etc/NEWS b/etc/NEWS > index 23f4a8b5311..2dcb2f5664e 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1099,6 +1099,9 @@ showcases all their customization options. > > * Incompatible Lisp Changes in Emacs 30.1 > > +** 'pp' and 'pp-to-string' now always include a terminating newline. > +In the past they included a terminating newline in most cases but not all. > + > ** 'buffer-match-p' and 'match-buffers' take '&rest args'. > They used to take a single '&optional arg' and were documented to use > an unreliable hack to try and support condition predicates that > Exactly, yes. Thanks! Eshel From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 11:20:53 2023 Received: (at 67180-done) by debbugs.gnu.org; 16 Nov 2023 16:20:53 +0000 Received: from localhost ([127.0.0.1]:57476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3f6q-0000gR-Lg for submit@debbugs.gnu.org; Thu, 16 Nov 2023 11:20:52 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3f6p-0000gE-82 for 67180-done@debbugs.gnu.org; Thu, 16 Nov 2023 11:20:51 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2A9DC1000AD; Thu, 16 Nov 2023 11:20:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700151645; bh=MFVqhMSDssBV48boUVxDQKMiRkmV79ne3TGkovttrzY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=o2OumtGA9xSf0Ym03t7GNHnonZIvNEwePtdIuMjyjsUiM9EJf6cO5wZxPh3s6+6LV ir8A8DhD3W/kuJSY8e6QOyU2sQuyEXdxCWcLBooSq3gGhN1bUQOA/0Ks0gtCBkP3va iaCNRrMOheJyVyrUwnxK59FKZBGfxS32JpjhaM4SL8EPeTlwHSBhmHMTLxrIWoEWME DhadPIkVGACIj4UVmgm+seYxFuQEcxAW/dFggKVEcRJOGreGmKAkW4Upky0wl/nSh5 lPQvaDsvQT3S9ewmGdoJUsaszgfJWvJlVdR/CzoPST49uHHvfcPlXwai/286hficqJ bGx77XcDR1KkQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 86CBF100043; Thu, 16 Nov 2023 11:20:45 -0500 (EST) Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5D49112040A; Thu, 16 Nov 2023 11:20:45 -0500 (EST) From: Stefan Monnier To: Eshel Yaron Subject: Re: bug#67180: 30.0.50; 'pp-to-string' emits extra newline In-Reply-To: (Eshel Yaron's message of "Thu, 16 Nov 2023 16:34:37 +0100") Message-ID: References: <83il63rzrt.fsf@gnu.org> Date: Thu, 16 Nov 2023 11:20:44 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.132 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67180-done Cc: Eli Zaretskii , 67180-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Like this? >> >> diff --git a/etc/NEWS b/etc/NEWS >> index 23f4a8b5311..2dcb2f5664e 100644 >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -1099,6 +1099,9 @@ showcases all their customization options. >> >> * Incompatible Lisp Changes in Emacs 30.1 >> >> +** 'pp' and 'pp-to-string' now always include a terminating newline. >> +In the past they included a terminating newline in most cases but not all. >> + >> ** 'buffer-match-p' and 'match-buffers' take '&rest args'. >> They used to take a single '&optional arg' and were documented to use >> an unreliable hack to try and support condition predicates that >> > > Exactly, yes. Thanks! Thanks, pushed to `master`. Closing, Stefan From unknown Mon Jun 23 14:59:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Dec 2023 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator