Subject: [bug#67175] [PATCH 7/9] services: jami: Use ‘least-authority-wrapper’.

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 03 Dec 2023 20:38:45 -0500

Hi,

Ludovic Courtès <[email-masked]> writes:

> * gnu/services/telephony.scm (jami-configuration->command-line-arguments)
> [wrapper]: New procedure.

nitpick: Should be <wrapper>, according to 'info (standards) Indicating
the Part Changed'

> Use it.
> (jami-shepherd-services): In ‘start’ method of ‘jami’ service, use
> ‘fork+exec-command’ instead of ‘make-forkexec-constructor/container’.
> Remove use of (gnu build shepherd).
>
> Change-Id: Ic71c0c88477d92bf137d9d0a5832bae8721cc210
> ---
>  gnu/services/telephony.scm | 66 +++++++++++++++++++++-----------------
>  1 file changed, 37 insertions(+), 29 deletions(-)
>
> diff --git a/gnu/services/telephony.scm b/gnu/services/telephony.scm
> index 832470527d..16d109b8b1 100644
> --- a/gnu/services/telephony.scm
> +++ b/gnu/services/telephony.scm
> @@ -261,9 +261,37 @@ (define %jami-accounts
>  (define (jami-configuration->command-line-arguments config)
>    "Derive the command line arguments to used to launch the Jami daemon from
>  CONFIG, a <jami-configuration> object."
> +  (define (wrapper libjami)
> +    (least-authority-wrapper
> +     ;; XXX: 'gexp-input' is needed as the outer layer so that
> +     ;; 'references-file' picks the right output of LIBJAMI.

It seems clearer to me to stick to the current #~(string-append
#$libjami:bin "/libexec/jamid") until file-append can handle non-default
outputs more elegantly (did we have a bug for that? -- I couldn't find
one).

The rest LGTM, if both jami system tests pass.

-- 
Thanks,
Maxim