From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 17:32:43 2023 Received: (at submit) by debbugs.gnu.org; 13 Nov 2023 22:32:43 +0000 Received: from localhost ([127.0.0.1]:59451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2fU2-0005YS-U5 for submit@debbugs.gnu.org; Mon, 13 Nov 2023 17:32:43 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2fTz-0005YB-UH for submit@debbugs.gnu.org; Mon, 13 Nov 2023 17:32:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2fTD-0004Oz-BY for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 17:31:51 -0500 Received: from out-189.mta1.migadu.com ([95.215.58.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2fTB-0001cr-Ay for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 17:31:50 -0500 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1699914701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PCB1ffgTUULdxYDUP4g1RJxknpdpfP7cQlqZ9gp7Msc=; b=oG+aeDYYiUo6bK8iJwuNuKTwguj1KDYF41JXmA20h9C5X8NqpMjeBpn8w7qXZezrpPf2Db RdKg8iQ1oIJHliBxZF7AKgDvxuRO4y9CKaHlSojH8fBy/TXCgYryDu8vcaIr1QIcaboCxZ i73DUPp8JKb8GpqTRgo0uy39nWFxJnI= Date: Mon, 13 Nov 2023 22:31:40 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jm@pub.pink Message-ID: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> TLS-Required: No Subject: [PATCH] Fix flymake integration in lua-ts-mode To: bug-gnu-emacs@gnu.org X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.189; envelope-from=jm@pub.pink; helo=out-189.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) If a file has an error on the last line flymake gets an invalid position for the overlay and raises the error: error in process sentinel: Wrong type argument: integer-or-marker-p, ni= l From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 17:41:23 2023 Received: (at 67152) by debbugs.gnu.org; 13 Nov 2023 22:41:23 +0000 Received: from localhost ([127.0.0.1]:59456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2fcQ-0005lo-VJ for submit@debbugs.gnu.org; Mon, 13 Nov 2023 17:41:23 -0500 Received: from out-189.mta0.migadu.com ([91.218.175.189]:40670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2fcP-0005lf-9Z for 67152@debbugs.gnu.org; Mon, 13 Nov 2023 17:41:22 -0500 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1699915237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QZuNyUKBOgMjKU8SMCugOXkH7PwBysLjoc8M/fUEuSg=; b=wrlyQLyiW9VtejhK5eYdXPp3VfeKMRw03aVCMFR0q5GoGcbypMnmdF1WWq8rkoQQMof+Bg htK8hVUmtbzuNr1z3i2eQ3KhV4KPpgt2jr2JQzt3q+AILMUtawGsA8wXyA2WK8EADLXdjS yeXJOCnX9q7U/1e5BuKttLm7XGFsrTM= Date: Mon, 13 Nov 2023 22:40:36 +0000 Content-Type: multipart/mixed; boundary="1933b576-fa5e-4d13-aba3-c7c11abada60-1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jm@pub.pink Message-ID: TLS-Required: No Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: 67152@debbugs.gnu.org In-Reply-To: References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67152 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --1933b576-fa5e-4d13-aba3-c7c11abada60-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable --1933b576-fa5e-4d13-aba3-c7c11abada60-1 Content-Type: text/x-diff; name="0001-Fix-flymake-integration-in-lua-ts-mode-Bug-67152.patch" Content-Disposition: attachment; filename="0001-Fix-flymake-integration-in-lua-ts-mode-Bug-67152.patch" Content-Transfer-Encoding: base64 RnJvbSBhYjNlY2VkYjllNGVkNDgxODYwMzI0OWU3NzRkZDhhMWU2ZGFlMjhiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqb2huIG11aGwgPGptQHB1Yi5waW5rPgpEYXRlOiBN b24sIDEzIE5vdiAyMDIzIDE2OjA2OjA3IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGZs eW1ha2UgaW50ZWdyYXRpb24gaW4gbHVhLXRzLW1vZGUgKEJ1ZyM2NzE1MikKCiogbGlzcC9w cm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgKGx1YS10cy1mbHltYWtlLWx1YWNoZWNrKTogVXNl CmZseW1ha2UtZGlhZy1yZWdpb24gdG8gbWFyayBoaWdobGlnaHRlZCByZWdpb24uCi0tLQog bGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgfCAxMCArKysrKystLS0tCiAxIGZpbGUg Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvcHJvZ21vZGVzL2x1YS10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvbHVhLXRz LW1vZGUuZWwKaW5kZXggYmI2ZDVjYjhjOTEuLmFkNzUzMjEwZGQ0IDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9sdWEt dHMtbW9kZS5lbApAQCAtNTA4LDE2ICs1MDgsMTggQEAgbHVhLXRzLWZseW1ha2UtbHVhY2hl Y2sKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW9sKSkK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsIHQpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZm9yIGxpbmUgPSAoc3RyaW5nLXRvLW51bWJlciAobWF0Y2gt c3RyaW5nIDEpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvciBiZWcgPSAoc3Ry aW5nLXRvLW51bWJlciAobWF0Y2gtc3RyaW5nIDIpKQotICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGZvciBlbmQgPSAoc3RyaW5nLXRvLW51bWJlciAobWF0Y2gtc3RyaW5nIDMpKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvciAoYmVnIC4gZW5kKSA9IChmbHltYWtl LWRpYWctcmVnaW9uCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHNvdXJjZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoc3RyaW5nLXRvLW51bWJlciAobWF0Y2gtc3RyaW5nIDEpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLXRvLW51bWJl ciAobWF0Y2gtc3RyaW5nIDIpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3Ig bXNnID0gKG1hdGNoLXN0cmluZyA0KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZv ciB0eXBlID0gKGlmIChzdHJpbmctbWF0Y2ggIl4oVyIgbXNnKQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDp3YXJuaW5nCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDplcnJvcikKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB3aGVuIChhbmQgYmVnIGVuZCkKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb2xsZWN0IChmbHltYWtlLW1ha2UtZGlhZ25vc3RpYyBzb3VyY2UKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29u cyBsaW5lIGJlZykKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoY29ucyBsaW5lICgxKyBlbmQpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJlZwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGVuZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHR5cGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtc2cpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW50byBkaWFncwotLSAKMi40MS4wCgo= --1933b576-fa5e-4d13-aba3-c7c11abada60-1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:14:41 2023 Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 14:14:41 +0000 Received: from localhost ([127.0.0.1]:60630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uBd-0005je-EX for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:14:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uBc-0005jR-2u for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 09:14:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2uAo-0002np-C2; Tue, 14 Nov 2023 09:13:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dV3VUwVlVF7YK0J5bwqG/pAjfBEevuu8YiNPUA7OxQw=; b=H+qSsztXBfEnkC/gec3L nGEfpCMg6uyrVTuH/UWor/53SSfNYoWLi8H2aOQT1OJ93alHDIko03QXyUfIOfsD+Ikjih/icwN6I s5Z2RZugBfv7veBqDpKnARZ+yJeLEAgVxob05aVOwLJZq9kTS+wvIMxl2KVfSh04gX3V36+L/ZMXG 4N7ZZDdmXZXI9iixyQulXaSoDzJ41U80hpih6p/cWYO6Y7DAOXflvN/uDf1g+PjmpLM4Dnd9G6Yua zSsxUVVHYYctlmN/HsZmof1zSTK8Pbs7yHGsZXdYHZnTTzHvwlrFQlmQ80oCr0Kc+8zJsbLsWt0oJ W9wvSY4QAd2R3Q==; Date: Tue, 14 Nov 2023 16:13:29 +0200 Message-Id: <83wmuks9rq.fsf@gnu.org> From: Eli Zaretskii To: jm@pub.pink, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 13 Nov 2023 22:40:36 +0000 > TLS-Required: No > From: jm--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" João, is this OK? > From ab3ecedb9e4ed4818603249e774dd8a1e6dae28b Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Mon, 13 Nov 2023 16:06:07 -0600 > Subject: [PATCH] Fix flymake integration in lua-ts-mode (Bug#67152) > > * lisp/progmodes/lua-ts-mode.el (lua-ts-flymake-luacheck): Use > flymake-diag-region to mark highlighted region. > --- > lisp/progmodes/lua-ts-mode.el | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el > index bb6d5cb8c91..ad753210dd4 100644 > --- a/lisp/progmodes/lua-ts-mode.el > +++ b/lisp/progmodes/lua-ts-mode.el > @@ -508,16 +508,18 @@ lua-ts-flymake-luacheck > eol)) > nil t) > for line = (string-to-number (match-string 1)) > - for beg = (string-to-number (match-string 2)) > - for end = (string-to-number (match-string 3)) > + for (beg . end) = (flymake-diag-region > + source > + (string-to-number (match-string 1)) > + (string-to-number (match-string 2))) > for msg = (match-string 4) > for type = (if (string-match "^(W" msg) > :warning > :error) > when (and beg end) > collect (flymake-make-diagnostic source > - (cons line beg) > - (cons line (1+ end)) > + beg > + end > type > msg) > into diags > -- > 2.41.0 > From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:24:32 2023 Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 14:24:32 +0000 Received: from localhost ([127.0.0.1]:60644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uLA-0005yn-E0 for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:24:32 -0500 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:44351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uL7-0005yV-QU for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 09:24:31 -0500 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507f1c29f25so7770678e87.1 for <67152@debbugs.gnu.org>; Tue, 14 Nov 2023 06:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699971821; x=1700576621; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=agvgmt2LN567Ba9b8B95KlbztuboEhZqrIm9oGFtdnw=; b=Gq344DN4RxVfYtMa/LG6BxJvExQzpd25IZu31T1wKiF9ySUHMFyZbFsPMZyMPgke7l kZRP89pY7Xw4Ieskupl4CkRdYhk9s5sJ8baLJbPqqGeTX7OlRTrYfl+pRIhtlY7cbnp4 a1Y4/jtoOOg7b9mHjnT4jqnc6faHCsT1l8o8rIAMEHfPSvjfLJKOYnFWf+vmuSFMgbqX O3RA/gHWPwfi8aIY16WqDaO5af+UfMT0xMLaulyhrzDSOJE56fA1TVa3f7qIUul82H1o CYYfp3+HgWS+eVCTk80uBMx6jDcj0IJ+RQrx9N67W67hCwA+8YWD6p+0FRKhZ+3F9ylL C5dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699971821; x=1700576621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=agvgmt2LN567Ba9b8B95KlbztuboEhZqrIm9oGFtdnw=; b=Aa5WBuzdZMSRVS2P/uIpaoYP3xvExg6UGKrbKFdcrwWtd6J6ikzpn8AMoLiViHtuX/ N3da2twX89Pk4BzzOiF9W+BaQeEiPbAj+BpjE+wFf/9si3jwSb2EU1QINXdE4qmvHwnQ +NrViPehzObpmX042o6a2AWQTxiNsrPMXZ2Z4WO/EUdRbAuzT9+NDAy/w1Mb8jhj/DZx 5z63aFOqGSDHLy7jPh34NyMQIfbcP6xlUzcZwRjcnuRvVOTAhVIVbH7ByMFOYZyMtv18 hQh5EtkjB7pBK8e021RvI9lrq7C7q/bGHEypmG5uzaBXSlfr6ruDkcZOSYeTR4hTchPa J9qQ== X-Gm-Message-State: AOJu0Yyc0B1Qw8O4Wl6i9Mn3P9YH88yFakMVDMTVZ04wezZJoVV8izF5 dA/40X6iATNGj7Bzyoo3pSW7HqxA3r9U3FcWaKU= X-Google-Smtp-Source: AGHT+IEw0vCZroCl7fDiE2iwrbxMxbJESOOGFuz42uCpBqJZEZq5RWXUnVKiWAJmC8MEIuCAPqR+QISVCetX0CsRmII= X-Received: by 2002:a05:6512:b82:b0:503:8fa:da21 with SMTP id b2-20020a0565120b8200b0050308fada21mr8930501lfv.43.1699971821266; Tue, 14 Nov 2023 06:23:41 -0800 (PST) MIME-Version: 1.0 References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> In-Reply-To: <83wmuks9rq.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 14 Nov 2023 14:23:29 +0000 Message-ID: Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000088ebe9060a1d8802" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org, jm@pub.pink X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000088ebe9060a1d8802 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 14, 2023 at 2:13=E2=80=AFPM Eli Zaretskii wrote: > > Date: Mon, 13 Nov 2023 22:40:36 +0000 > > TLS-Required: No > > From: jm--- via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > Jo=C3=A3o, is this OK? > Oooof hard to say. But no I don't think so. You see the type of the object changing in the call to flymake-make-diagnostic? That could be seriously problematic for non-buffer-local diagnostics of some backends. And another call to flymake-diag-region? Can you point me to the first message in this thread via a debbugs URL, or to one where a clear Emacs -Q recipe is given? Thanks, Jo=C3=A3o --00000000000088ebe9060a1d8802 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 14, 2023 at 2:13=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
= > Date: Mon, 13 Nov 2023 22:40:36 +0000
> TLS-Required: No
> From: jm--- via "Bug reports for GNU Emacs,
>=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>

Jo=C3=A3o, is this OK?

Oooof hard to sa= y.=C2=A0 But no I don't think so.=C2=A0 You see the type
of t= he object changing in the call to flymake-make-diagnostic?
That could be seriousl= y problematic for non-buffer-local diagnostics of=C2=A0
some=C2=A0=C2=A0backends.

<= /div>
And another call to flymake-diag-region?

Can you = point me to the first message in this thread via a debbugs
URL, o= r to one where a clear Emacs -Q recipe is given?

T= hanks,
Jo=C3=A3o
--00000000000088ebe9060a1d8802-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:27:32 2023 Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 14:27:32 +0000 Received: from localhost ([127.0.0.1]:60649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uO4-00062w-0Q for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:27:32 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:44265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uO1-00062k-V1 for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 09:27:30 -0500 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-507b9408c61so7776353e87.0 for <67152@debbugs.gnu.org>; Tue, 14 Nov 2023 06:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699972002; x=1700576802; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w4wdGDNkyIumDFii0GkkGcaC4QQptwWSAyvxo8vNEXQ=; b=b+i176ldBh5BejtyDV7sKamRwnNaAajeCItU5NlQPRLYEbMuBWMVh0dWpMfP1pAbYy u1DXQdXb9mG2jGEskzPlfNNVhVUUgxwvyH7c+I5f2LT6rLDZFluQL9tFSt0wUwITuM+r HRHR/5oYJTi3TItkbiHfJKM2urhT7TPjCMVXdEYTQ0ULp3k8AcyTs5iGPG8SHrrNgym1 Ucw9lf9h2y1Gm6rN7dtDk0oXV+6/pjP+UmJzCsjgXqdsYu5NIw8gbfoA2E83each7ihL /d015CSU1xkP4Dmg0MM133lD9y8u7qRVHhxO8UAsoSl9rZHonvzkgZ3dlKbNHVgx3Pxg 5a4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699972002; x=1700576802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w4wdGDNkyIumDFii0GkkGcaC4QQptwWSAyvxo8vNEXQ=; b=XJKuLTDI3adwzfAPUg9VrbFVr0/aRvi9CLabiZZiiwBfGlB2k4RZINt8raF++E/3Js Eu3L8150z8IxKdBH8YIFsBNlAwI9Zc3TFHk+1AhthXkSmN6+v065uvchKNKe65AejRju RuosRXeV3hsYo795Mh3TLX9VIA4iqF/B/+VBaTz0TDrG7SWkAwHBOJE6gOHb9KijsHno ocGq/DLsPDVfDbw/IGDyuh1VfGMdPpv89gbtD56l0ZfMKf8m/S7qnWS/9oOA3MxJDFC+ 4h9Wh926hKGITexpWD9P1aEa2bg32a6jlBrnylUVALjBu4Q5gQlMMfCzUqTqBN5XBqQa HrPA== X-Gm-Message-State: AOJu0Yxkafz9xo9OQandl5ZYQ0qHCGDWK4LF9ethbLwfMaOt79HvBOvz tGBzNACrRQOdVlBMGB3yhO4kNDFxOPfDL+xgIJjQ1403zsciPw== X-Google-Smtp-Source: AGHT+IE4fS/ibskO+S1Rt3ytu9MgpuS/AN5u3kmrjEO7U94GLI8usk5qqchxOfjL1aaTflxcCwxT4oOSEA8xSWP0Qc0= X-Received: by 2002:a05:6512:280c:b0:509:4a02:1205 with SMTP id cf12-20020a056512280c00b005094a021205mr8437049lfb.46.1699972001598; Tue, 14 Nov 2023 06:26:41 -0800 (PST) MIME-Version: 1.0 References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 14 Nov 2023 14:26:30 +0000 Message-ID: Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org, jm@pub.pink X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Nov 14, 2023 at 2:23=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Tue, Nov 14, 2023 at 2:13=E2=80=AFPM Eli Zaretskii wrot= e: >> >> > Date: Mon, 13 Nov 2023 22:40:36 +0000 >> > TLS-Required: No >> > From: jm--- via "Bug reports for GNU Emacs, >> > the Swiss army knife of text editors" >> >> Jo=C3=A3o, is this OK? > > Oooof hard to say. But no I don't think so. Oh no! Silly me, this isn't flymake.el at all!! I saw a fragment of a loop and thought it was my code :-), i.e. a framework problem. Well, then in this case, I think it should be OK, though users should test. Backends are indeed expected to call flymake-diag-region to get the region to highlight, as the manual and docstrings explain (I think). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:38:48 2023 Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 14:38:48 +0000 Received: from localhost ([127.0.0.1]:60660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uYy-0006IP-HL for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:38:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uYw-0006ID-9M for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 09:38:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2uYA-0007er-1o; Tue, 14 Nov 2023 09:37:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9wPx2J4W9EbKOBE6+PR0a6Jj+HdUcN0zP847PtzMK/U=; b=N5YJB6bRVcD9fbWpSmD3 e8+phpWkLJin5baD8gLvYoReJ1c8mAusnzurTlqJ+Jk/kCC6QL0CoDCYh8UAplOXG3oTFO4xJbO1g 7xxXw+EWmATvFgzgF687GLJorMpJoLUKT+/8OOgRxJd9XFix2ZKriCvkZyvL9zcb9BAtPif+bJ5JK FeZHZ7rBiXE8B3RmCMuYCVKxWwGNvXkT2Z4B8HioTo8Ymj9Zwz7Ogf5/goh8kLtmfGxcAyTKDLmyy 3QlqhYAAoQvQoIrk/e744B6GT4giatOhDDNDiKq3crReg4o3XVwlc4V9YpnAmZV+Z0fCLssJzz0mS cGlQdlEg9Dutqw==; Date: Tue, 14 Nov 2023 16:37:43 +0200 Message-Id: <83pm0cs8nc.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Tue, 14 Nov 2023 14:23:29 +0000) Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org, jm@pub.pink X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Tue, 14 Nov 2023 14:23:29 +0000 > Cc: jm@pub.pink, 67152@debbugs.gnu.org > > Can you point me to the first message in this thread via a debbugs > URL, or to one where a clear Emacs -Q recipe is given? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67152#5 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 13:09:18 2023 Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 18:09:18 +0000 Received: from localhost ([127.0.0.1]:34154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2xqg-0003fO-8N for submit@debbugs.gnu.org; Tue, 14 Nov 2023 13:09:18 -0500 Received: from out-187.mta1.migadu.com ([2001:41d0:203:375::bb]:13537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2xqc-0003fE-UG for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 13:09:16 -0500 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1699985310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sM4EYUyBwboXC5BEvwm5jRYFn0m1NWmY5hyw5TYPJVg=; b=Yj7P3qCJwFEwO7025VzFkoOYT0UTspKjN6SF8L5lMStKl1TYjbH84vhUDy2AxfW+Pi5Hrr z4lkDBVkChfy5yhZzg7MGy44NxTYJAVw+ZpU2lpw0XZGh8eyBScZCber0s8hqKC9EHvJjW v4MnUYoGBA1hlgY/y/vjqtx2iloD20Y= Date: Tue, 14 Nov 2023 18:08:28 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jm@pub.pink Message-ID: <1ed27e2fe45fc117376415bb1a2dbffcb8f69903@pub.pink> TLS-Required: No Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: "=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=" , "Eli Zaretskii" In-Reply-To: References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) November 14, 2023 at 2:26 PM, "Jo=C3=A3o T=C3=A1vora" wrote: > Oh no! Silly me, this isn't flymake.el at all!! I saw a fragment > of a loop and thought it was my code :-), i.e. a framework problem. Right. The problem is the code in lua-ts-mode. Here is the full recipe just in case (you need the tree-sitter-lua grammar and luacheck in PATH or set lua-ts-luacheck-program): src/emacs test.lua --init-directory=3D. M-x lua-ts-mode # test.lua print(1) print(2 # init.el (add-hook 'lua-ts-mode-hook #'flymake-mode) (add-to-list 'treesit-extra-load-path "~/.guix-profile/lib/tree-sitter"= ) (setopt lua-ts-luacheck-program "~/.luarocks/bin/luacheck") (toggle-debug-on-error) The error only shows up when the highlighted region is on the last line. > Well, then in this case, I think it should be OK, Thanks for confirming. > though users should test. What kind of test do you mean? > Backends are indeed expected to call flymake-diag-region to > get the region to highlight, as the manual and docstrings explain > (I think). I agree the docs are clear. I even used the example from the manual as a template. Now I can=E2=80=99t remember why I originally deviated from it on the region handling but I=E2=80=99m sure it was caused by a misunderstanding on my part. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 19:10:10 2023 Received: (at 67152) by debbugs.gnu.org; 15 Nov 2023 00:10:10 +0000 Received: from localhost ([127.0.0.1]:34300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r33Tu-0004R4-36 for submit@debbugs.gnu.org; Tue, 14 Nov 2023 19:10:10 -0500 Received: from out-185.mta1.migadu.com ([2001:41d0:203:375::b9]:32616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r33Tr-0004Qw-9X for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 19:10:08 -0500 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1700006961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w+GmywNd12EWovk7uM/a4MyuydXwqOh/C0k+kUjD3ck=; b=kvftEUryEBaq5hQlANfRvms9u5L7dfDEOH93v9LplRa1+C6zaFaCSIaOVCLywq9WxAFvYa Nt53t5op0ypXQWwMuykA7T5dy73VU89i+X1iMIY2HKAUa3qnwQYUpmXmoQwwrai7zadIQP 1vv3ikdMJQV1KTdvNAtGWhtv4hriM7E= Date: Wed, 15 Nov 2023 00:09:20 +0000 Content-Type: multipart/mixed; boundary="de4df1bb-6ba4-4f7f-9078-5bc6f3768597-1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jm@pub.pink Message-ID: <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> TLS-Required: No Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: 67152@debbugs.gnu.org In-Reply-To: <83pm0cs8nc.fsf@gnu.org> References: <83pm0cs8nc.fsf@gnu.org> <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67152 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --de4df1bb-6ba4-4f7f-9078-5bc6f3768597-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Updated to remove a compiler warning about the unused 'line' variable. --de4df1bb-6ba4-4f7f-9078-5bc6f3768597-1 Content-Type: text/x-diff; name="0001-Fix-flymake-integration-in-lua-ts-mode-Bug-67152.patch" Content-Disposition: attachment; filename="0001-Fix-flymake-integration-in-lua-ts-mode-Bug-67152.patch" Content-Transfer-Encoding: base64 RnJvbSBjNmE0NDMyMTYwNzViYTJmMmY2MWQ1MmIzMjYxZDczZmFjN2QzZDlhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqb2huIG11aGwgPGptQHB1Yi5waW5rPgpEYXRlOiBN b24sIDEzIE5vdiAyMDIzIDE2OjA2OjA3IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGZs eW1ha2UgaW50ZWdyYXRpb24gaW4gbHVhLXRzLW1vZGUgKEJ1ZyM2NzE1MikKCiogbGlzcC9w cm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgKGx1YS10cy1mbHltYWtlLWx1YWNoZWNrKTogVXNl CmZseW1ha2UtZGlhZy1yZWdpb24gdG8gbWFyayBoaWdobGlnaHRlZCByZWdpb24uCi0tLQog bGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgfCAxMSArKysrKystLS0tLQogMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9saXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2x1YS10 cy1tb2RlLmVsCmluZGV4IGJiNmQ1Y2I4YzkxLi5hOTEwZDc1OWM4MyAxMDA2NDQKLS0tIGEv bGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvbHVh LXRzLW1vZGUuZWwKQEAgLTUwNywxNyArNTA3LDE4IEBAIGx1YS10cy1mbHltYWtlLWx1YWNo ZWNrCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChncm91 cCAoMCsgbm9ubCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGVvbCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCB0KQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvciBsaW5lID0gKHN0cmluZy10by1udW1i ZXIgKG1hdGNoLXN0cmluZyAxKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3Ig YmVnID0gKHN0cmluZy10by1udW1iZXIgKG1hdGNoLXN0cmluZyAyKSkKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICBmb3IgZW5kID0gKHN0cmluZy10by1udW1iZXIgKG1hdGNoLXN0 cmluZyAzKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKGJlZyAuIGVuZCkg PSAoZmx5bWFrZS1kaWFnLXJlZ2lvbgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzb3VyY2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHN0cmluZy10by1udW1iZXIgKG1hdGNoLXN0cmluZyAxKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmlu Zy10by1udW1iZXIgKG1hdGNoLXN0cmluZyAyKSkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZm9yIG1zZyA9IChtYXRjaC1zdHJpbmcgNCkKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmb3IgdHlwZSA9IChpZiAoc3RyaW5nLW1hdGNoICJeKFciIG1zZykKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6d2FybmluZwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ZXJyb3IpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgd2hlbiAoYW5kIGJlZyBlbmQpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29sbGVjdCAoZmx5bWFrZS1tYWtlLWRpYWdub3N0aWMgc291cmNlCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGNvbnMgbGluZSBiZWcpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgbGluZSAoMSsgZW5kKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBiZWcKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBlbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0eXBlCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXNnKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGludG8gZGlhZ3MKLS0gCjIuNDEuMAoK --de4df1bb-6ba4-4f7f-9078-5bc6f3768597-1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:26:18 2023 Received: (at 67152) by debbugs.gnu.org; 15 Nov 2023 16:26:18 +0000 Received: from localhost ([127.0.0.1]:53102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IiY-00022m-EC for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:26:18 -0500 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:47531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IiV-00022X-VW for 67152@debbugs.gnu.org; Wed, 15 Nov 2023 11:26:16 -0500 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9d10f94f70bso1013938166b.3 for <67152@debbugs.gnu.org>; Wed, 15 Nov 2023 08:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700065571; x=1700670371; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+8Wao9EdHf9l78tYKbtZGjydK5fAX95oq8NGdcaj1hk=; b=aZOxzgbRa4YDlplTOBfVIITp8/lIknXlhgVZuXHIDVpPoV/dL7yKc68VFImT75EEZ3 IAqkMy5xzwGS5Q/H1Z5ZaF9L4Q0eXvaPAUyIZSNp445hqH1xZXY6cH8kYEoKaDpTuPcY 3MnnHuZLcCXOhc8NMLDpLrlkj8msYf19LDMzcXta2TFUVgoNr1lWVw8RSU3UlHCuyoo8 xL1VPAAB9m4YrscgHBSXM7FMZNaJlnMqB4e/Or1GqzFI/NSvKF1cezIxHADfFLI1guv9 rJrDOaiIfKhb/KcIH8kKNXtaJpZCUDggNbhy2Bovp4dJ8WdrBQf0QiPlDZLU4PIpnlQL BITQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700065571; x=1700670371; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8Wao9EdHf9l78tYKbtZGjydK5fAX95oq8NGdcaj1hk=; b=u9rogemkd0F0VOvvvSvBdXCsWOEbW5Pdxr/Yg+EUgc1TSMu5zX0bb0+YNwtbGP4N+J QNu9YFXhtTh2Iz4H/jTdOGmNDmG/m7mziCgdm4N+TfCUCFnYPgFszf1b/iXtDBxqHR37 hYyBH0c1eAsv2IRL856rEvSyALqMTQvePXuOYryQ7rI9rvDjdVW83kGx9vQjidZBl9/a yHrTM6XdMkUXTkxpDqHKiyyoKI9WIvjevmrR9tc+4procIxsGgz74/P34aFH+TYpPsxy 0rI4wvqf9fOefzxh54q3ZKcH8wYvP9GvcRzUZT16Ur+9zON/IWjavbvAumtwC60K8Ono JzeQ== X-Gm-Message-State: AOJu0YzbqHXfldJ/bUCmg7/u+xo223rbnD84akeEtIfYDwT1k4jKHavI 3Mbw5w3pkPEqggvBZhPSFdlqnwAphvgzMRlW9ck+I8LQwKhBCw== X-Google-Smtp-Source: AGHT+IF9MEy6zRLrZ7gdy12V5RnZtQmQnm+TP1ablCQfzfDYCWikm0ADJYsPNEh2VldR82Hie1keD8if3LjpHHsBgZc= X-Received: by 2002:a05:6512:b05:b0:503:3816:c42c with SMTP id w5-20020a0565120b0500b005033816c42cmr11187611lfu.41.1700051059809; Wed, 15 Nov 2023 04:24:19 -0800 (PST) MIME-Version: 1.0 References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> <83pm0cs8nc.fsf@gnu.org> <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> In-Reply-To: <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 15 Nov 2023 12:24:08 +0000 Message-ID: Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode To: jm@pub.pink Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Just a note that in the recent patch you provided, (match-string 3) isn't being used. If is is a useful "end column" identifier, you might want to call flymake-diag-region again to get the the corresp [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:631 listed in] [list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67152 Cc: 67152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Just a note that in the recent patch you provided, (match-string 3) isn't being used. If is is a useful "end column" identifier, you might want to call flymake-diag-region again to get the the corresponding buffer position. flymake-diag-region could see some docstring improvements. It gets a line and optionally a column, whidh defines a single point. It then tries to guess a region, because it's impossible to form a region from just a point. The guess is based on thing-at-point. This guess _may_ be worse than whatever the backend supplied in (match-string 3) so passing that number to flymake-diag-region again to obtain a second point may be a good idea to compose the two buffer positions to give to flymake-make-diagnostic. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:28:10 2023 Received: (at 67152-done) by debbugs.gnu.org; 15 Nov 2023 16:28:10 +0000 Received: from localhost ([127.0.0.1]:53128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkM-00028R-0q for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQg-0001QS-6H for 67152-done@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3FXY-0001KO-Kc; Wed, 15 Nov 2023 08:02:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1bMs9Yz3puu7XaET9v+nwKla9AyIya6ktnQHshO4tDc=; b=EHfedtHYWqJM EJseMjWY/FBqvPvpVEg6z+7Z7xm4Bt6KR7tQhWx2ebXXJAN/KQB6guG7DQTG+95vVXtMbkL6IRXhy rQQVcaGdMybBJe2CWfTB0eqLqD+l87XdqykvVhZM0JpfN3ste/hbsbcz/fbdCDADghDja7OWGheRO 2DLoQaZC7J9chvTF7tOESegFQtjgFzzhPdOs0ivz5O7YfwXhAxeQ6M4MzqdZHcbuWSWHB0+QgZgkn RFa6oo2B2rCHTiJIvRe0cl4h/iAVcEERdVVQVDFLruvRPdFDhI5A189Vp5gWomGAEl3gCzavM/NOD kgzpoxtXxypSq5jTk9OeTw==; Date: Wed, 15 Nov 2023 15:02:34 +0200 Message-Id: <837cmjrwyd.fsf@gnu.org> From: Eli Zaretskii To: jm@pub.pink In-Reply-To: <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> (bug-gnu-emacs@gnu.org) Subject: Re: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode References: <83pm0cs8nc.fsf@gnu.org> <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> <789f237e8ac62415aa6ed81b5530e21a50dacda5@pub.pink> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67152-done Cc: 67152-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 15 Nov 2023 00:09:20 +0000 > TLS-Required: No > From: jm--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Updated to remove a compiler warning about the unused 'line' variable. Thanks, installed on the master branch, and closing the bug. From unknown Fri Aug 15 15:56:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Dec 2023 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator