GNU bug report logs - #67150
eglot with typescript language server >= 4.1.0

Previous Next

Full log

Message #40 received at 67150 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Simon Pugnet <simon <at> polaris64.net>
Cc: 67150 <at> debbugs.gnu.org, contact <at> sivalik.com
Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0
Date: Wed, 15 Nov 2023 10:29:16 +0000

On Wed, Nov 15, 2023 at 10:28 AM Simon Pugnet <simon <at> polaris64.net> wrote:
>
>
> João Távora <joaotavora <at> gmail.com> writes:
>
> >> I'm not sure if this fix is correct. In the documentation for
> >> `eglot-server-programs' it says: -
> >>
> >> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where
> >>   MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a
> >>   string identifying the language to the server;
> >>
> >> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets
> >> the
> >> `:language-id' to symbols. So I think these should be strings
> >> instead,
> >> e.g. "javascript".
> >
> > Yup, that was a mistake, guess I should have tested, but I don't
> > have this language server.  Keywords would probably work too,
> > but I fixed them to strings as you suggest.  Pushed to master
> > and cherry-picked to emacs-29.
>
> Perfect, I can confirm that this now works correctly in emacs-29.
>
> Thanks for the quick fix!

Thank you for the heads up!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.