From unknown Fri Aug 15 04:04:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67150 <67150@debbugs.gnu.org> To: bug#67150 <67150@debbugs.gnu.org> Subject: Status: eglot with typescript language server >= 4.1.0 Reply-To: bug#67150 <67150@debbugs.gnu.org> Date: Fri, 15 Aug 2025 11:04:07 +0000 retitle 67150 eglot with typescript language server >=3D 4.1.0 reassign 67150 emacs submitter 67150 Rajeev N severity 67150 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 10:25:17 2023 Received: (at submit) by debbugs.gnu.org; 13 Nov 2023 15:25:18 +0000 Received: from localhost ([127.0.0.1]:59177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2YoP-0002cq-3d for submit@debbugs.gnu.org; Mon, 13 Nov 2023 10:25:17 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2V8p-0007JW-0f for submit@debbugs.gnu.org; Mon, 13 Nov 2023 06:30:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2V82-0002gk-KB for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 06:29:18 -0500 Received: from vr0.sivalik.com ([104.238.130.12] helo=smtp.sivalik.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2V7z-0005Vf-Up for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 06:29:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sivalik.com; s=svlk; t=1699874947; bh=LPlSbS5oXyIiPAfZCQBswXLioHn9iY2wZOF5a8vqVTY=; h=From:To:Subject:Date:From; b=UPqLt+T1jGYBgMclUPzScGFEP4JI2PcOEAlP7/7fdji0JzbEBzBlDX1+K8t3A71vd 97pAF2H+5JWUstQ4DRcXnzCIZcc9KVYXaWKZOvoKnWWHWlAs9tF4U6t0HE46cI7gKN 1Ks79THzRCfsKZFL+TiuD8nrGckO+IFqXvFY3M8A= Received: from hp (unknown [IPv6:2600:4040:a891:fe00:6eb:9e89:b3ad:8f8f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: rajeev@sivalik.com) by smtp.sivalik.com (Postfix) with ESMTPSA id 6CA904ABE; Mon, 13 Nov 2023 06:29:07 -0500 (EST) X-No-Archive: yes From: Rajeev N To: bug-gnu-emacs@gnu.org Subject: eglot with typescript language server >= 4.1.0 Date: Mon, 13 Nov 2023 11:29:06 +0000 Message-ID: <87edgt7uyl.fsf@hm.sivalik.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-=-=" Received-SPF: pass client-ip=104.238.130.12; envelope-from=contact@sivalik.com; helo=smtp.sivalik.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 13 Nov 2023 10:25:15 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline typescript language server didOpen fails for .tsx with "Cannot open document" - https://github.com/typescript-language-server/typescript-language-server/issues/794 --=-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline

typescript language server didOpen fails for .tsx with "Cannot open document"

--=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 11:38:37 2023 Received: (at 67150) by debbugs.gnu.org; 13 Nov 2023 16:38:37 +0000 Received: from localhost ([127.0.0.1]:59224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2ZxN-0004hM-2p for submit@debbugs.gnu.org; Mon, 13 Nov 2023 11:38:37 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:43516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2ZxK-0004h8-Ao for 67150@debbugs.gnu.org; Mon, 13 Nov 2023 11:38:36 -0500 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c51682fddeso61369311fa.1 for <67150@debbugs.gnu.org>; Mon, 13 Nov 2023 08:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699893467; x=1700498267; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zidJ4DTtzHK1v3Hsby7FR9dM/5tqA7T4BxOUE+WWCs8=; b=WnaAXohxVlnN4TKUySeMW2fo6BaUZptaFRAiMeDGVYtHhcR+JJ6DWvR9NaGVlTQMpF lJo6VfSBv56VKLyoCJh59t5BMV2i4/Av7939p/Sq9GMcNVmVj18M8M3E8oIyakf5aq/S fkYoB/YBykwxqsGIMwxwTtjbBd5v9Z4LGTDDcFUEToPBWFVqQyilr1twjzWysH1IW+5/ VOQN2N2TZPGQ+3sDEjSp1yoCmdTL87lO5zg4Z8uVxLdFnjSOFefb0peZJqmKMWOlr6PQ ZtJDjm1Z9Gz8CV9y7dQc8QkEUYDrzKcRMALxJZcGnWfVnzEW6/EO8ajv/4/Maiilo0yr 44AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699893467; x=1700498267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zidJ4DTtzHK1v3Hsby7FR9dM/5tqA7T4BxOUE+WWCs8=; b=Djeb0wahaQuzjtTt3fki9vHNkddWQfqdcgvrcrY6gPgBOYQow1/wni8tMxvCWIdfWc m4F0dxgmY+fARr1Fiwb8VKgNSWu47EyTKnomUNksbvqZDD5REHuXOcLRP/fkELu9kYKy iAdJ+UqiiW/3nLwHLXXOiPOYlf0E3mrnZuDNkgPwNzjFAKdchP8wu4CUwIFMLg1RtvwA E8KpLVKJQksLw1q/cf7kJSyyz+aa8zP4p7Q7HB1TA/zAGdbVGvOgJvF3TQrHHpnuLV45 N5yKwdtXgYcCkEWzevnDVo7lJJVMtcjZRwG4WM73xuNo/ZRV2Xa2y7t+aCBETCOmkklN G6QQ== X-Gm-Message-State: AOJu0YyvKh0ZEEoZV5SrAIkVzMReDmu0WMyED7w2LeG0TJ3Gfeuu4oV+ hOMCGYN+eo9G/JyDPQ+52aaWVTa0bka/M3uAbHU= X-Google-Smtp-Source: AGHT+IEDxJ8uJExXqKoODRnjmrWM2POMUCZ+drPyKxLRbKFFIb7NjK9jz/i3ZUS5gEEQ6oZO47s4lntxlfpUbIbWqfg= X-Received: by 2002:a05:6512:1383:b0:509:1467:5f18 with SMTP id fc3-20020a056512138300b0050914675f18mr6858lfb.5.1699893466364; Mon, 13 Nov 2023 08:37:46 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> In-Reply-To: <87edgt7uyl.fsf@hm.sivalik.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 13 Nov 2023 16:37:35 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Rajeev N Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Rajeev, You need to provide more information about this problem. See https://joaotavora.github.io/eglot/#Troubleshooting-Eglot I read that thread and the server author thinks is it "likely" that Eglot sent the wrong language ID. That may be, but even if so, there may be many reasons why it happened. >From what I can tell in the code, the language id for .tsx files in tsx-mod= e or tsx-ts-mode is correctly calculated. But I don't even know what version of Emacs you have, what your configuration is, etc... All these things are described in the link above. Jo=C3=A3o On Mon, Nov 13, 2023 at 3:25=E2=80=AFPM Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > > typescript language server didOpen fails for .tsx with "Cannot open docum= ent" > > https://github.com/typescript-language-server/typescript-language-server/= issues/794 --=20 Jo=C3=A3o T=C3=A1vora From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 11:50:35 2023 Received: (at 67150) by debbugs.gnu.org; 13 Nov 2023 16:50:35 +0000 Received: from localhost ([127.0.0.1]:59246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2a8w-00055X-Rk for submit@debbugs.gnu.org; Mon, 13 Nov 2023 11:50:35 -0500 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:59672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2a8u-00055I-Go for 67150@debbugs.gnu.org; Mon, 13 Nov 2023 11:50:33 -0500 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-507adc3381cso6167580e87.3 for <67150@debbugs.gnu.org>; Mon, 13 Nov 2023 08:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699894184; x=1700498984; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=igCpeBFiYrgNayH8fYwRSncj6boNuWJQburmoNRulOo=; b=aRpmWkZtuVchzL/+dYb/I4IDzVXimEjenIiQi2+SoC0nfoeKucDtKyxJ0DM0y0Qp3r dVHjeU5RfKCwp5bYbgenwnqH5nnL7jE8VHfhKdurxkijSUoHACIjqtd2Npn5TUu6BAcj kKsTlWRYwlp3RfFMhD/trd0lDRk3YjzpsFB4it85yg0v0IPy5PDflmds/pGhPWGlf6+U +MyNi9BKO+B3aRKg9H/eAfIuVNR2VWu3fO0IYhMfoLY+fCPmQWmcKozSjdzMTev1WKG4 M3casCQ98+uNyj9/NxQADER40msvyDe3wooNwGNVxaM6w31AUvkauvwJWWw4Fp463N3h RS4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699894184; x=1700498984; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igCpeBFiYrgNayH8fYwRSncj6boNuWJQburmoNRulOo=; b=H7ZG8w5//t0Wxgrly+W/AbUwIbAoaz7QKzuvqb1BBfLq1iYsBZVCITqIMGjgcG6jRE PAAp6OPbtPKdy/GMdwIhJQrfkaKUitGhR1emSOJu/8eiKVUxcEadjot5bWcHkyop5LPs kqQYssI6AVt1rN0z2O8DleqEBAz9F+bDc2c3kgs5eeZdkMejp1ilRd3MyGYhGbNN4ReV oxaSCO9AAZtFYXfk2brhSD1n1udLNTel7NHMtBkxqvbb/5hKWO4pxA9yrHc28hGpQn79 4LBzu8gPZO5HQ2xSu1Ri1M1BwQNuJgB417edkXUA27Ti8YmWDSizgh+NZMMvcT5kKI67 F59Q== X-Gm-Message-State: AOJu0Yyrx0v5lZ6BWjxoNVdYze4/kbrrFB6BbLp7mrX8BnmF+Mr0ne84 KHfEBnarHqFWWRTGZEdau0cMle3tF8c3uC0FNG6OyiQELmmUpw== X-Google-Smtp-Source: AGHT+IEEdX9nWJdsIqOUURXS8IexRl0X//CzK6rj4thtmODOATPf0jTWIdROm8k50PZ/0wTgnQ+eKNU0FTpxBeMHQdA= X-Received: by 2002:a05:6512:554:b0:508:126a:751e with SMTP id h20-20020a056512055400b00508126a751emr4945326lfl.36.1699894184230; Mon, 13 Nov 2023 08:49:44 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> In-Reply-To: <87msvh4nbw.fsf@hm.sivalik.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 13 Nov 2023 16:49:32 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Rajeev N Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Nov 13, 2023 at 4:42=E2=80=AFPM Rajeev N wrot= e: > > I am running the latest stable branch of emacs with the latest eglot from= stable. I'm sorry I don't know what "latest eglot from stable" is. M-x emacs-version and the contents of the Version: header in the eglot.el file are what's needed usually. > The following fixed the issue for me. > > (add-to-list 'eglot-server-programs > `(((js-mode :language-id "javascript") > (js-ts-mode :language-id "javascript") > (tsx-ts-mode :language-id "typescriptreact") > typescript-ts-mode typescript-mode) > . > ("typescript-language-server" "--stdio"))) Oh, so "tsx" is not a valid language ID? For this particular server, this particular server version, or universally? How the heck are clients supposed to know that? IOW where did you glean this information about language ids from? Anyway, I think your modification makes sense regardless. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 12:14:36 2023 Received: (at 67150) by debbugs.gnu.org; 13 Nov 2023 17:14:36 +0000 Received: from localhost ([127.0.0.1]:59277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2aWB-0005fS-Qt for submit@debbugs.gnu.org; Mon, 13 Nov 2023 12:14:36 -0500 Received: from vr0.sivalik.com ([104.238.130.12]:36770 helo=smtp.sivalik.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2a1b-0004nd-Gt for 67150@debbugs.gnu.org; Mon, 13 Nov 2023 11:43:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sivalik.com; s=svlk; t=1699893732; bh=42+LrGa+TrcsoMPCg3TwoJp0FhtcB2pn/kf8nDUO0rw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PaN97dWfGJ901+MfbRt4q4Wklgr1PkOOFjcielZdMPuzp/QsvVm7FywHe+miSZ5Oe uI5MRZxSFDsBA5E8r2suz1o0YP1JFFPaEZWiS/ROa/nENt25jh8QxQpSdrkPd7zbBH EP3xWu4NKDpATGL2EED3n8fD/phU619FMLic+LkA= Received: from hp (unknown [IPv6:2600:4040:a891:fe00:6eb:9e89:b3ad:8f8f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: rajeev@sivalik.com) by smtp.sivalik.com (Postfix) with ESMTPSA id EDF9B2E39; Mon, 13 Nov 2023 11:42:11 -0500 (EST) X-No-Archive: yes From: Rajeev N To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 13 Nov 2023 16:37:35 +0000") References: <87edgt7uyl.fsf@hm.sivalik.com> Date: Mon, 13 Nov 2023 16:42:11 +0000 Message-ID: <87msvh4nbw.fsf@hm.sivalik.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150 X-Mailman-Approved-At: Mon, 13 Nov 2023 12:14:33 -0500 Cc: 67150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline I am running the latest stable branch of emacs with the latest eglot from stable. The following fixed the issue for me. #+begin_src elisp (add-to-list 'eglot-server-programs `(((js-mode :language-id "javascript") (js-ts-mode :language-id "javascript") (tsx-ts-mode :language-id "typescriptreact") typescript-ts-mode typescript-mode) . ("typescript-language-server" "--stdio"))) #+end_src --=-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline

I am running the latest stable branch of emacs with the latest eglot from stable.

The following fixed the issue for me. 

(add-to-list 'eglot-server-programs
             `(((js-mode :language-id "javascript")
                (js-ts-mode :language-id "javascript")
                (tsx-ts-mode  :language-id "typescriptreact")
                typescript-ts-mode typescript-mode)
               .
               ("typescript-language-server" "--stdio")))
--=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 12:14:36 2023 Received: (at 67150) by debbugs.gnu.org; 13 Nov 2023 17:14:37 +0000 Received: from localhost ([127.0.0.1]:59279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2aWC-0005fb-Mm for submit@debbugs.gnu.org; Mon, 13 Nov 2023 12:14:36 -0500 Received: from vr0.sivalik.com ([104.238.130.12]:33028 helo=smtp.sivalik.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2aGj-0005GW-Ak for 67150@debbugs.gnu.org; Mon, 13 Nov 2023 11:58:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sivalik.com; s=svlk; t=1699894670; bh=ExIl9RJcaxX5o8BtZWUwyY8fvA/uerGfqE6QffRrOig=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZaE4lLzDzolOOehZlNjp/QWNlnkrau1uDB+ruTc72TSTOyoekn6MIrA+JRqbbKQ16 iFP2jpftoyo2rExfr0ptOB8fPMYL+koua7QAKIVnhxCWJuf119PehTT6j5POvpBZLX lG4xPNwLNyCUQgMoh1nYH+K6tTbO5FJ0RIdvV7LA= Received: from hp (unknown [IPv6:2600:4040:a891:fe00:6eb:9e89:b3ad:8f8f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: rajeev@sivalik.com) by smtp.sivalik.com (Postfix) with ESMTPSA id 4D25A2E39; Mon, 13 Nov 2023 11:57:50 -0500 (EST) X-No-Archive: yes From: Rajeev N To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 13 Nov 2023 16:49:32 +0000") References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> Date: Mon, 13 Nov 2023 16:57:49 +0000 Message-ID: <87cywd4mlu.fsf@hm.sivalik.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150 X-Mailman-Approved-At: Mon, 13 Nov 2023 12:14:33 -0500 Cc: 67150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline GNU Emacs 29.1.90 (build 7, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2023-11-10 ;;; eglot.el --- Version: 1.15 I got the info about language Ids from: https://github.com/typescript-language-server/typescript-language-server/issues/794#issuecomment-1807613575 Best, --=-=-= Content-Type: text/html; charset=utf-8 Content-Disposition: inline

GNU Emacs 29.1.90 (build 7, x8664-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2023-11-10

;;; eglot.el — Version: 1.15

I got the info about language Ids from:

https://github.com/typescript-language-server/typescript-language-server/issues/794#issuecomment-1807613575

Best,

--=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 19:10:19 2023 Received: (at 67150-done) by debbugs.gnu.org; 14 Nov 2023 00:10:19 +0000 Received: from localhost ([127.0.0.1]:59525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2h0V-0008FV-Dx for submit@debbugs.gnu.org; Mon, 13 Nov 2023 19:10:19 -0500 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:54372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2h0T-0008FG-M3 for 67150-done@debbugs.gnu.org; Mon, 13 Nov 2023 19:10:18 -0500 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-507a3b8b113so7076186e87.0 for <67150-done@debbugs.gnu.org>; Mon, 13 Nov 2023 16:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699920570; x=1700525370; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=iBuD0sYObiX/cnEL96mSMKbM47xhjomI1L5GZs/tiC8=; b=ez7GAJUQtVtVdUixhEzB8d2ACPDkjVh7yPaoQH0Rx6P8wl8wniByScMeGwOBkNJtHW uzUNKP8j2zguaisIiGhNVNLB5c8hsmotDnS6UTK50H3F3QfLTbHcB2H1g75IBT//E9Bk /uK7Q2On6Yh5sr9L8l8puVnWkBeU85W1twHQ3gdfoBp4mOmMuGfFllWCYlkwXVY+CF5r HBGnval3vs9ztF1IYw9cSg0FC9WnTXDNcYGS+64oInzrHH9IvEdGZ5dt+Ub0tVJVSslE P+cm1YdC799wHW5LCevmfD65r66nNk+EKLlcTM5DItoNaMrl1mdZ09jmfhQCfe29P03h GstQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699920570; x=1700525370; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iBuD0sYObiX/cnEL96mSMKbM47xhjomI1L5GZs/tiC8=; b=cikAwJfjzw/USDvvD6DqNed0/4yyHMuUqtXIq7BYg4TSyv9PIWz/+H65iy54HvrSS2 1dpXH9PwO7xnSYijJCBXwK5pgKhpAz+uypLVe9FowCGjN76pzwjJU4xMxcFi0lrP7c73 m8t5KYSm+2ZySs7VfvhTwhx9/7cUDnQ1nF2/Ke7eloa4onMbjpZnMokTxzTaHrI+Tv1q TcexFeZunx3LkzMOc2eXQ8Cs3kZEwmBk29a/GzFn0ePE/GLbH0qz49yoCPdHKcrCLv5V wAO3SiVdSpPUkOCE+jAGc/RLqdEkyI/93QwRJYHLKef1gu5H7VLPB5KDD9awJcjNIjCB kqHg== X-Gm-Message-State: AOJu0YxWEA3nlvVdRARqTSYjBCk7PWXBbJ8NTT2NdD2V2Irq46WK5wa+ eCIcfjVrN291Jlzefxf58nlv4cKsG6CB+E87H3Y= X-Google-Smtp-Source: AGHT+IFvZipJ5OdMXuGhAYS5BZit5RkCfUwF5lmBVKn16m89zpUd1xI8Zjp7n2Q112u3I7/Nt/iNMCzjBvKTI8Vd7Z0= X-Received: by 2002:a05:6512:48ce:b0:509:7302:2122 with SMTP id er14-20020a05651248ce00b0050973022122mr5143469lfb.66.1699920569474; Mon, 13 Nov 2023 16:09:29 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> In-Reply-To: <87cywd4mlu.fsf@hm.sivalik.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 14 Nov 2023 00:12:24 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Rajeev N , 67150-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000b0a1dd060a119995" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b0a1dd060a119995 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2023 at 4:57=E2=80=AFPM Rajeev N wrot= e: > GNU Emacs 29.1.90 (build 7, x8664-pc-linux-gnu, GTK+ Version 3.24.38, > cairo version 1.16.0) of 2023-11-10 > > ;;; eglot.el =E2=80=94 Version: 1.15 > > I got the info about language Ids from: > > > https://github.com/typescript-language-server/typescript-language-server/= issues/794#issuecomment-1807613575 > Thanks. In the meantime I asked the server author some questions and it seems the change has been rolled back, with the server accepting the old language-ids again. But I've pushed the change to eglot.el anyway. I think this bug can be closed, but let me know if you disagree. Jo=C3=A3o --000000000000b0a1dd060a119995 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Nov 13, 2023 at 4:57=E2=80=AFPM Rajeev N <contact@sivalik.com> wrote:

GNU Emacs 29.1.90 (build 7, x8664-pc-linux-gnu, GTK+ Version 3.2= 4.38, cairo version 1.16.0) of 2023-11-10

;;; eglot.el =E2=80=94 Version: 1.15

I got the info about language Ids from:

https://gith= ub.com/typescript-language-server/typescript-language-server/issues/794#iss= uecomment-1807613575


Thanks.=C2=A0 In the= meantime I asked the server author some questions and
it seems t= he change has been rolled back, with the server accepting=C2=A0
t= he old language-ids again.=C2=A0 But I've pushed the change to eglot.el=
anyway.=C2=A0 I think this bug can be closed, but let me know if= you=C2=A0
disagree.

Jo=C3=A3o
=
--000000000000b0a1dd060a119995-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 07:08:33 2023 Received: (at 67150) by debbugs.gnu.org; 14 Nov 2023 12:08:33 +0000 Received: from localhost ([127.0.0.1]:60208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sDZ-0005TK-50 for submit@debbugs.gnu.org; Tue, 14 Nov 2023 07:08:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sDU-0005T0-1W for 67150@debbugs.gnu.org; Tue, 14 Nov 2023 07:08:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2sCi-0003BR-BI; Tue, 14 Nov 2023 07:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=e0Bd7TqYwKuosU74OB5NjBNg1kdeWV5ozVAk0p/BZqY=; b=GrXwl1e5l2A+eIK9A9iC jzRui8RP0bJtt66TGGZ6PJfwxY2F4xx7ZF/k6iHiZJFE5Hh61aiWyC74NNTcdiO8mDMPw7cNazCgQ 2BHcVHsncI+Hx/TwrAqULWXDZbwjw6bYmZ0pt1G8oxunwnFk5bnXhVsz2LSVyb8glE4/gmyLluXnK wHBeeOzwKDuXAYpg3mTZ1TCiM6h/02BWgPay8lSuG1/Nvtohqje36r5XNj0JZp7r27NI/hoO5Xoe7 IU3nHMrKgAnzD0/mWmZceKkmpGCsPBX+HZeXezfgtQeXuMRSChXneUjsXTQl3qKRtCq5Pqinuxh9L N+NE2EkdWDyQQA==; Date: Tue, 14 Nov 2023 14:07:05 +0200 Message-Id: <83cywctu6u.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Tue, 14 Nov 2023 00:12:24 +0000) Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-To: bug-gnu-emacs@gnu.org > From: João Távora > Date: Tue, 14 Nov 2023 00:12:24 +0000 > > Thanks. In the meantime I asked the server author some questions and > it seems the change has been rolled back, with the server accepting > the old language-ids again. But I've pushed the change to eglot.el > anyway. I think this bug can be closed, but let me know if you > disagree. Any reasons not to backport this to the emacs-29 branch? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 07:20:17 2023 Received: (at 67150) by debbugs.gnu.org; 14 Nov 2023 12:20:17 +0000 Received: from localhost ([127.0.0.1]:60225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sOu-0008LX-KG for submit@debbugs.gnu.org; Tue, 14 Nov 2023 07:20:16 -0500 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:59495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sOt-0008LK-Cn for 67150@debbugs.gnu.org; Tue, 14 Nov 2023 07:20:15 -0500 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-507cee17b00so7388022e87.2 for <67150@debbugs.gnu.org>; Tue, 14 Nov 2023 04:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699964367; x=1700569167; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vc10QyR1OjoI4fLm2KK4K/z8KELtdi2pVql8XOSiZvU=; b=VUAPdPBcFvOLcATLA6ib/Rl8APx/1KUcekgkmpd6PCB9ZwmjOaLpK2P7qT++k2PVrj 3ZL9NrI4tJtbUZoY33pp8qUmR86vT3nFl34NA799TteH+lN5TXrjsG06tb69WFRzXTHM acRCfLug+eq42ScqxsV5LHUpTAcW5umTdRdYju/bL+oqJlJ0OETelcA2Lti94mUGyaBV Oh9E9fkBf/zvNPfzU3D4rOftMfHfg71z5s+O5Y1DeDuW4fCk/L07GvZYniyeFY8UzvWg jvf4bnFlTUK3MYNu8LmDgfZg1rrpq6M5FcNS9+Yttmu55VgZuzKUyibjiji6hDkwquvS e5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699964367; x=1700569167; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vc10QyR1OjoI4fLm2KK4K/z8KELtdi2pVql8XOSiZvU=; b=H5EhOITFTXsfueA1ye8vlcmaEzjc8jrWvsRgJgidPMoPq6e0gUpIc7QK+SUGbgvnQA 61xMLuYs1AeE0o/q6z8xDKXSt1mT5WkPgpbHoKTmd+C3WlJPrC4des0krf1wlOQ+2L+h fHzjvDUCo7Yk47dttt/JSYXs1ZNPXiATQPEa2/1d4/LpIJ6JUvumGWssEMAr7lm1Gh8K Ghu+bOFjicdwtWeKh5H6RHVzfbVBIrJCXyB0BE73S2lktNLIC8WJixYvhPrHs51689Qr 4dLoJJrFbMEFkiCKuHFcjMxhO/TjYbwjivzlLyF+cbiZsuHkXxzI7a6xkTLB0gcPIFIq regg== X-Gm-Message-State: AOJu0YxrosPv0RIpVUdbsO8X0OOpC6ZQZJm62NfUY7DzSRhW3R3b3gDY wYI5Pot4keIXcL/kalCIpGl1RgXGGX4fLYLR7Qc= X-Google-Smtp-Source: AGHT+IGOcozrNbgVB3LsGrebE8DgyGhvMSLGZqbLY+HZyuE5aT1BtXyXYcwtO2+1P/TrVaZG+ukU5QBOGbK8aJ1BFFg= X-Received: by 2002:a19:5e19:0:b0:500:b42f:1830 with SMTP id s25-20020a195e19000000b00500b42f1830mr6361401lfb.63.1699964367074; Tue, 14 Nov 2023 04:19:27 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <83cywctu6u.fsf@gnu.org> In-Reply-To: <83cywctu6u.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 14 Nov 2023 12:19:15 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Nov 14, 2023 at 12:07=E2=80=AFPM Eli Zaretskii wrote= : > > > Resent-To: bug-gnu-emacs@gnu.org > > From: Jo=C3=A3o T=C3=A1vora > > Date: Tue, 14 Nov 2023 00:12:24 +0000 > > > > Thanks. In the meantime I asked the server author some questions and > > it seems the change has been rolled back, with the server accepting > > the old language-ids again. But I've pushed the change to eglot.el > > anyway. I think this bug can be closed, but let me know if you > > disagree. > > Any reasons not to backport this to the emacs-29 branch? No, go right ahead, though this isn't really a bug, people will probably want to update Eglot from ELPA, and the language server author has reverted the breaking change as well. Anyway I forget the emacs-29 is still a thing. Are bugfixes _always_ to go release branch N-1 if they are applicable there (where N is whatever master is going to become). Was it always so? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:30:00 2023 Received: (at 67150) by debbugs.gnu.org; 14 Nov 2023 14:30:01 +0000 Received: from localhost ([127.0.0.1]:60655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uQS-00065v-EP for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:30:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uQQ-00065h-6F for 67150@debbugs.gnu.org; Tue, 14 Nov 2023 09:29:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2uPe-00061E-At; Tue, 14 Nov 2023 09:29:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=E0YVS6RYQJgIpASqAoFsWHC14kZOvB9RxARVmH1wNBM=; b=BFa37Pv4z0g7L/XmUQO2 PBxVPHdQS3TmLcSYD3D1ibjTEfV+VnSIIeAubr4TVDhMkfAgorZ1KtwgXJhKoE22FVDv2DYo+4hk6 ZVffxM0yBxQ8rQVaj+VVlyRGRqrGwilDRbpPXpKgGzK49o+f5laMOjG4wS2kL9kaxRdiUXZta/lNt CNvvaxd6gSDWG1zmfUCRC0mb1vB00C8dEeWMKD22jvtdA2SNX8LTn9ThZm8SSqIaaS5nkAqls2gRe FEme0d3Q6f8yexySfDgmThsmTbdTTgKQ4ErbPeXqbW2XHdl+m/qFAoPMlNbqy+X9rnYA7L7c+g4b6 Was9SaukAv8nnA==; Date: Tue, 14 Nov 2023 16:28:56 +0200 Message-Id: <83r0kss91z.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Tue, 14 Nov 2023 12:19:15 +0000) Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <83cywctu6u.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Tue, 14 Nov 2023 12:19:15 +0000 > Cc: 67150@debbugs.gnu.org, contact@sivalik.com > > On Tue, Nov 14, 2023 at 12:07 PM Eli Zaretskii wrote: > > > > Any reasons not to backport this to the emacs-29 branch? > > No, go right ahead, though this isn't really a bug, > people will probably want to update Eglot from ELPA, and the > language server author has reverted the breaking change > as well. Done. > Anyway I forget the emacs-29 is still a thing. Are bugfixes _always_ > to go release branch N-1 if they are applicable there (where N is > whatever master is going to become). Was it always so? In general, yes, but the bugfix should be safe enough, or the bug grave enough, to be eligible for the release branch after N.1 version was released. If in doubt, please ask. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 10:43:34 2023 Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 15:43:35 +0000 Received: from localhost ([127.0.0.1]:52929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I39-0000fB-Py for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:43:33 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:42038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I32-0000eq-Rx for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 10:43:26 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9df8d0c2505so203135366b.0 for <67150@debbugs.gnu.org>; Wed, 15 Nov 2023 07:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700062999; x=1700667799; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EQJm7HoYwFzA5CdVDgUb3cY+I2GhTwyU4Njf9PWFU7o=; b=ZoZgOOl+EaWLUkqTP0vv2jmbiIhPJ8DAy8lz2Dwk0qJtV7jDX1jrquQ1ylTri1XZxA mtIFDNhVpa7hyB8XgTHvzskgZz+z6Tt7SGgp0TXRf79timUtqvvQPCzSIpFRTWrz41U2 cJBMlAgYv8IErBhUfxE3m76s2hDJ+YUhwcvUnRFeCNe4gQFQ4UERx2sBw6Kwegi4Q+PM HtY1YwaID2MqAHwhdeZ38kgUWq2n5ZguKp+TYbWQ6QzKl7GAkZbe4lcmAVau2XZm6397 luIJfTPJNGyI4Qxa7Akx+XjewEZLMRmjMAmLNmfNVnzdMxTIuaJulOLUlOArLPFRLGdv 4m5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700062999; x=1700667799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EQJm7HoYwFzA5CdVDgUb3cY+I2GhTwyU4Njf9PWFU7o=; b=AE90wI9XFL+ItTRWi6KKJOaoYp8HVZWqtYt7/fLckXy5gz0ikaywURxtMdbNu0oHZv AhUxOWgOa6pNEHsfy88k17kCNbiQ+6pTauKLfML7X1eiX3EG8Igltngdw6mkAXDFhJeX oh/Mq9zvvsGQFg5cEfFGCfPcg84XYAyhUIt5Jg3OPi01ab7x1E3BxJF7aKh4dYEUUkJ4 fx2JxfvEhjh6p2bI0Ptu43yameoCRMZY0ymnMj5Jpm+s70pYDO68snfLqyXFKUFUUgRL cM7B3xRtwbbp9sSPRDLXJmu+CZEpGPpqfsS0hkUYyEun56SXgTzLae6RacwaT/+pK8tv WdBA== X-Gm-Message-State: AOJu0Yzcaqv8AWvq+fAsXdmuigKmD8aNrIToXXPMJYcquRawfn1r8lrj EU5tnQ1Vv0j4GuJFafmvw9HzfUvK1BU35TcI2aq1E24JOZc= X-Google-Smtp-Source: AGHT+IEYjwq+RqJMYBcoc1hR46qaRgjDoO/9O4biNLKxvuyTKaDZdmJ/94bY8+RenF/dUA9DpWsDY+WMeXQ779T5hRI= X-Received: by 2002:ac2:46f6:0:b0:507:bd5f:a40a with SMTP id q22-20020ac246f6000000b00507bd5fa40amr1802242lfo.23.1700043547951; Wed, 15 Nov 2023 02:19:07 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <87o7fvfip4.fsf@polaris64.net> In-Reply-To: <87o7fvfip4.fsf@polaris64.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 15 Nov 2023 10:18:56 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Simon Pugnet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Nov 15, 2023 at 9:51 AM Simon Pugnet wrote: > > > Thanks. In the meantime I asked the server author some questions and > > it seems the change has been rolled back, with the server accepti [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:636 listed in] [list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) On Wed, Nov 15, 2023 at 9:51=E2=80=AFAM Simon Pugnet = wrote: > > > Thanks. In the meantime I asked the server author some questions and > > it seems the change has been rolled back, with the server accepting > > the old language-ids again. But I've pushed the change to eglot.el > > anyway. I think this bug can be closed, but let me know if you > > disagree. > > I'm not sure if this fix is correct. In the documentation for > `eglot-server-programs' it says: - > > * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where > MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a > string identifying the language to the server; > > However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets the > `:language-id' to symbols. So I think these should be strings instead, > e.g. "javascript". Yup, that was a mistake, guess I should have tested, but I don't have this language server. Keywords would probably work too, but I fixed them to strings as you suggest. Pushed to master and cherry-picked to emacs-29. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 10:47:56 2023 Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 15:47:56 +0000 Received: from localhost ([127.0.0.1]:52942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I7Q-0000ou-FJ for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:47:56 -0500 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:49016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3I7N-0000np-Br for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 10:47:55 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SVdj61j48z9t21; Wed, 15 Nov 2023 10:51:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polaris64.net; s=MBO0001; t=1700041882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sRapsE5pAw7tuyiLvw4kyu2IyW9sIljJgt2rtDAV4eg=; b=NId0PFiQNkfYSrQvAOCo5NtssRh4/aFWQ48N2yEUBZ7ZFmt7E5ISVXL2UD/COe6YoITsAL /DZoqeTCle1DQKjzUlZJF/3ju6vCtv6qQd4isQHuDMDmCnEOpVEeKJH0h8QdMnLsIugqsj VJhEhI7VA3QBuvdI4wmqybSr21Th4gc/bdNcho4gODruzp/4H3/T+6zF3T5k2NWnTRbaZF WOkjuHHhKHGfl0+ltHHg3bajw30hD2XWcfE6uSohadn0G680gC1gEfKaOQiz/6Atgnsu2V vkLj47LhYp4F1FPCHLekYKMOh5D7dAa6OPTa2kKSx8qUabkBZ58oA8mbhKA2cg== From: Simon Pugnet To: 67150@debbugs.gnu.org Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 14 Nov 2023 00:12:24 +0000") References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> Date: Wed, 15 Nov 2023 09:51:19 +0000 Message-ID: <87o7fvfip4.fsf@polaris64.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 4SVdj61j48z9t21 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67150 Cc: contact@sivalik.com, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > Thanks. In the meantime I asked the server author some questions and > it seems the change has been rolled back, with the server accepting=20 > the old language-ids again. But I've pushed the change to eglot.el > anyway. I think this bug can be closed, but let me know if you=20 > disagree. I'm not sure if this fix is correct. In the documentation for `eglot-server-programs' it says: - * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a string identifying the language to the server; However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets the `:language-id' to symbols. So I think these should be strings instead, e.g. "javascript". Kind regards, Simon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCAAyFiEEO/eF3hYsAMj7Tab9uhNZqCwLPvkFAmVUlJcUHHNpbW9uQHBv bGFyaXM2NC5uZXQACgkQuhNZqCwLPvmiBw//UbPRqVQ8Hh92jA30NQdzPgEwijYZ mQIXdYB8/O8GKBqFdE5n2kK3CMSIPXAvducTdL0S1A5DOckypDGUGwdwPhTu0bj5 5GTE22oA68F4P/AHzjU1JTrrgkg+VEJ3SukxXWkFh0343RTh6axquWMiIeebabm5 RUmKwThVmxmMpQXUBDy23NUoaEle+c1yIxkjouYQitXQhkbOOG2MEasD41bqkDr8 rP7TaAod4hU7+OFUpQXuBDrdxecJ44ulJFd351GxPq3qr5Dgl80ONq+PGxMxK6DB u7AnVvgGYSErBUpFJD9xV3/Ku1YScv8f68GB/Mqv9QnNpOh7SzEtop2AQq/eVAu/ wQuqM2kAJrwxRx8EA3tXMfSWnMb/9i0ciVt6ncyJ1Cih0lYxLcH3xm+6SzcXEevH wfABWahAgzUWGP3u5I59JC3WDmZqRxLsm5hg8AZGK2Eu2CY4mMRoehPSagy+aW7V EaPQeqrdqN7vkiTpQeG/ZTiZ7H801USLHR0uua5253B4tA/5RS04m5aTxtmcvUI1 yCfky/HtUMmWkr9kYYIkwAhKiIksGPRv+AQLp4g/XopkCPAEUV4QrOQniLj1QU5l hVtWzNwjtZw7+naE1W+5SQYyBnNtoUksW2dst9ffo3OQaeeQPDyVTMjGRh7/5aIG +4qgc8q1OH1i/po= =GrPf -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:17:16 2023 Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 16:17:16 +0000 Received: from localhost ([127.0.0.1]:53084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IZo-0001mP-8V for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:17:16 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:53283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IZl-0001m9-WB for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 11:17:14 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-543c3756521so10491438a12.2 for <67150@debbugs.gnu.org>; Wed, 15 Nov 2023 08:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700065029; x=1700669829; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fsq5Q7SgjHi6H+yI/mAaP+0zyVo29IqMp8h0ZTTgg7A=; b=VsRmUSzRb7SqlOC+bonKpGXweI/SRz+URpnhh9cjdHxawPEvx7lbFgbeaaaM9imilH UOF7z+yNG38TFfP+fCw21/k5A0Fecgl8G46ns5hIscS+CC3+IsLJ1EVACEzKAtrENMS5 gCz7b2KmAOtRiADWXTc2u5y9JGfF47CBKcnS3HyazpdbsSr/yfvq5uPEw/CAB0cq2n/L NGwXV3vkneh0/y1LuUcFFBI9ViZdbBUUsxDpOqY1wzfC+MCxvodJfIynfXxiUX+tjRne WNv5tK/tbyydsjJe7f5D4BjBzpLcLzfB3kPRWuVxtIKLYKLBPkw0YxIG92R+wFua+huL nP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700065029; x=1700669829; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fsq5Q7SgjHi6H+yI/mAaP+0zyVo29IqMp8h0ZTTgg7A=; b=QdNtEa9PlE3pCEvf4zFHXOYhGoFlTtDMwlpEPeHS8IeNMc+8rf3fwMY6VkccpVpRFE 3mOdB2PzFNj1BhH5ndpG4wSnfhvsqGgG1xY90pHoX7/ZutLGPhG3ydUwnC/CVTwfZ5xG CmtdT3YGLtJ9nVNs6joOs4uM/SO30Ilw7V+IC7BqPqfMk8XrTPn7zV4QVtmCCiME295T ASGxTPtyQNx+Zj/sz5u2SjQVFSxK8vkItBka0beSL6HAk80T4PLSWetDfxbtCtGuZ2wM 9ZZhkSCdLIMQKyh6Viqfckip/VTfIoCSsD4nIeQxZrZ0NCV7Z0QFrP4txmc1iA+AWHf7 /atg== X-Gm-Message-State: AOJu0Yx4snTyMqTULkXfbhJhPNdfnwnuckexY6B68A1y+qz/uDM2Fvfp 6UT6w4SMgGbdomEGTDbopc+Qj9dUrv/Qm86a+T0tvW3e1CM= X-Google-Smtp-Source: AGHT+IGq3nVoomvvGGvgYliMg9k9ynGDt7PdPRNrsfqU2wc3FHBJ/loSfvDcfTWz0Ra6HGPFHRe3mlNxgHFeAsfyqLI= X-Received: by 2002:ac2:4e6f:0:b0:503:3421:4ebd with SMTP id y15-20020ac24e6f000000b0050334214ebdmr6716224lfs.63.1700044168045; Wed, 15 Nov 2023 02:29:28 -0800 (PST) MIME-Version: 1.0 References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <87o7fvfip4.fsf@polaris64.net> <87r0krpayw.fsf@polaris64.net> In-Reply-To: <87r0krpayw.fsf@polaris64.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 15 Nov 2023 10:29:16 +0000 Message-ID: Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 To: Simon Pugnet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Nov 15, 2023 at 10:28 AM Simon Pugnet wrote: > > > João Távora writes: > > >> I'm not sure if this fix is correct. In the documentation for > >> `eglot-server-programs' it says: - > >> [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:532 listed in] [list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) On Wed, Nov 15, 2023 at 10:28=E2=80=AFAM Simon Pugnet = wrote: > > > Jo=C3=A3o T=C3=A1vora writes: > > >> I'm not sure if this fix is correct. In the documentation for > >> `eglot-server-programs' it says: - > >> > >> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where > >> MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a > >> string identifying the language to the server; > >> > >> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets > >> the > >> `:language-id' to symbols. So I think these should be strings > >> instead, > >> e.g. "javascript". > > > > Yup, that was a mistake, guess I should have tested, but I don't > > have this language server. Keywords would probably work too, > > but I fixed them to strings as you suggest. Pushed to master > > and cherry-picked to emacs-29. > > Perfect, I can confirm that this now works correctly in emacs-29. > > Thanks for the quick fix! Thank you for the heads up! From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:27:55 2023 Received: (at 67150) by debbugs.gnu.org; 15 Nov 2023 16:27:55 +0000 Received: from localhost ([127.0.0.1]:53107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ik6-00025b-S7 for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:27:55 -0500 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]:39332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ik3-00025C-U4 for 67150@debbugs.gnu.org; Wed, 15 Nov 2023 11:27:53 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SVfWY5hCPz9sqY; Wed, 15 Nov 2023 11:28:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polaris64.net; s=MBO0001; t=1700044089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IlBf5grCy27vU/rt2AvW91HYWlr2Wnk81cw0J/GUosw=; b=rRS1YrLunzOFk2101Dq1Bby/IS50+BDhxTrkYHAFmYFoYRfvvLGAy5Apw812Hw6uXfwpS5 GWfYn4guH+TfbAs90Te6m22kwp3k0lGraOn/iLIaomDwYxIHKl7Ukc+p1mko08L5DwBPQD Sgxh9aKyPNrIGVRAf5T6ivL8c7SFMLxVSEVBdrzbk6obO43cYezDqUKqt+T3BhAvNJ6RDN GbCsNBiKfBpk+iHtyX/7Dc0+noVvrvkRL4yPb1YMM7RykEBMGCs5FAIUBW/1I2CBLDYZSm +1hRUAURhyt/D2Nn3mK26p78i8inednLqcBGLhNA8JQD/vXVlX/yjSx1WQwX1A== References: <87edgt7uyl.fsf@hm.sivalik.com> <87msvh4nbw.fsf@hm.sivalik.com> <87cywd4mlu.fsf@hm.sivalik.com> <87o7fvfip4.fsf@polaris64.net> From: Simon Pugnet To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#67150: eglot with typescript language server >= 4.1.0 Date: Wed, 15 Nov 2023 10:27:04 +0000 In-reply-to: Message-ID: <87r0krpayw.fsf@polaris64.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67150 Cc: 67150@debbugs.gnu.org, contact@sivalik.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: >> I'm not sure if this fix is correct. In the documentation for >> `eglot-server-programs' it says: - >> >> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where >> MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a >> string identifying the language to the server; >> >> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets=20 >> the >> `:language-id' to symbols. So I think these should be strings=20 >> instead, >> e.g. "javascript". > > Yup, that was a mistake, guess I should have tested, but I don't > have this language server. Keywords would probably work too, > but I fixed them to strings as you suggest. Pushed to master > and cherry-picked to emacs-29. Perfect, I can confirm that this now works correctly in emacs-29. Thanks for the quick fix! Kind regards, =2D-=20 Simon Pugnet https://www.polaris64.net/ PGP key fingerprint: 3BF7 85DE 162C 00C8 FB4D A6FD BA13 59A8 2C0B=20 3EF9 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCAAyFiEEO/eF3hYsAMj7Tab9uhNZqCwLPvkFAmVUnTcUHHNpbW9uQHBv bGFyaXM2NC5uZXQACgkQuhNZqCwLPvn4mBAAjK0rfqTZcHB2oLUtZn0EerljXC4P RwWr2WPfjsLO9+ZrUe1RMOxPwfswDOCqfZpcPmyFfYjtF8zPCGrVO0Pj97f+Fiac EHdt3YJhymCInIU0lnvhH/UljnyoaLnOPUa1CJYLUuU0AHNMJc1gC4h7tC582zcM rLqmFn4lDXT7lmncGsbH1KxjOmxvQp7ljNijDoh2NmfFIX4NpmI/oPlhSKplmJvn BgsiOjrPABcTHzcTD32+zk+wFNy9mOCji3ah/P9IGzU0kCsISeIsIAY4OQbcwFxv i1SHq3Bf1LGLKNIvHhT5/7R4n27n+5HZb89ujeV/WShP1goGC1wbTxJJP52tXMR+ BNaM2XhVwbSKKqfB0rTIoWqqy8L5MXyUJRpnWZ+vJOtEMAozHgwP+QNiXOYG84sU GBuksoNUZ5tnfylPSxT1iMjfaESfiEDruCdROjKswZeMCgym3mj1Uo6kYqCsCp9L 4AGFUXNpphzbU9VWo5L+Q+EzxfNNhupoFHkNKGZlT/LPQQP13tvbvIRdE7zbbu+O ojZ4DRUX95uwEKbTcU+Ca+LHsd6vDkWimno7RezkbX13ZS1CN91TOEGxxxe4AvP5 9d197MJ6+mZQ/w5MGNB88TiqZC4wViN3V99nEuuBwOOT7WW9hTIzcv8C2HwTVkwq ppJqUUkVkbx3XMs= =W8Lv -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 04:04:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Dec 2023 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator