GNU bug report logs - #6715
24.0.50; [PATCH] Cygwin build should use pre-crt0.c

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6715 in the body.
You can then email your comments to 6715 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Fri, 23 Jul 2010 18:44:57 -0400

The conclusion of

  http://lists.gnu.org/archive/html/emacs-devel/2010-07/msg00398.html

was that the Cygwin build of Emacs should use pre-crt0.c instead of 
ecrt0.c.  The following patch accomplishes this:

--- configure.in.orig	2010-07-12 10:39:38.000000000 -0400
+++ configure.in	2010-07-23 17:01:00.468750000 -0400
@@ -1060,7 +1060,7 @@
 case $opsys in
   cygwin )
     LIB_MATH=
-    START_FILES='ecrt0.o'
+    START_FILES='pre-crt0.o'
     ;;
   darwin )
     ## Adding -lm confuses the dynamic linker, so omit it.

I'm sending this as a bug report so it doesn't get forgotten.  Please 
apply it to the trunk.

Thanks.

Ken

Message #10 received at 6715-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 6715-done <at> debbugs.gnu.org
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Fri, 23 Jul 2010 21:23:27 -0400

Ken Brown <kbrown <at> cornell.edu> writes:

> The conclusion of
>
>   http://lists.gnu.org/archive/html/emacs-devel/2010-07/msg00398.html
>
> was that the Cygwin build of Emacs should use pre-crt0.c instead of
> ecrt0.c.  The following patch accomplishes this:
>
> I'm sending this as a bug report so it doesn't get forgotten.  Please
> apply it to the trunk.

Applied, thanks.

Message #11 received at 6715-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: "6715-done <at> debbugs.gnu.org" <6715-done <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Fri, 23 Jul 2010 21:56:41 -0400

On 7/23/2010 9:23 PM, Chong Yidong wrote:
> Ken Brown<kbrown <at> cornell.edu>  writes:
>
>> The conclusion of
>>
>>    http://lists.gnu.org/archive/html/emacs-devel/2010-07/msg00398.html
>>
>> was that the Cygwin build of Emacs should use pre-crt0.c instead of
>> ecrt0.c.  The following patch accomplishes this:
>>
>> I'm sending this as a bug report so it doesn't get forgotten.  Please
>> apply it to the trunk.
>
> Applied, thanks.

Thanks for the quick response.  BTW, you don't have to annotate my 
contributions as tiny changes, even though most of them are.  I took 
care of the copyright assignment paperwork last January.

Ken

Message #14 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 6715 <at> debbugs.gnu.org
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 01:13:28 -0400

Ken Brown <kbrown <at> cornell.edu> writes:

> The conclusion of
>
>   http://lists.gnu.org/archive/html/emacs-devel/2010-07/msg00398.html
>
> was that the Cygwin build of Emacs should use pre-crt0.c instead of
> ecrt0.c.  The following patch accomplishes this:

BTW, it would be good if you could look at configure.in and see if the
line:

  cygwin) LINKER="\$(CC)" ;;

[Just trying to remove special cases from the build system to simplify it...]



>
> --- configure.in.orig	2010-07-12 10:39:38.000000000 -0400
> +++ configure.in	2010-07-23 17:01:00.468750000 -0400
> @@ -1060,7 +1060,7 @@
>  case $opsys in
>    cygwin )
>      LIB_MATH=
> -    START_FILES='ecrt0.o'
> +    START_FILES='pre-crt0.o'
>      ;;
>    darwin )
>      ## Adding -lm confuses the dynamic linker, so omit it.
>
> I'm sending this as a bug report so it doesn't get forgotten.  Please
> apply it to the trunk.
>
> Thanks.
>
> Ken

Message #17 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 08:22:40 -0400

[Message part 1 (text/plain, inline)]

On 7/24/2010 1:13 AM, Dan Nicolaescu wrote:
> BTW, it would be good if you could look at configure.in and see if the
> line:
>
>    cygwin) LINKER="\$(CC)" ;;
>
> [Just trying to remove special cases from the build system to simplify it...]

There's no need for cygwin to be a special case here.  Fixing this also 
makes the cygwin case irrelevant in the code that sets LIB_GCC a little 
further down in configure.in.  Please apply the attached patch.

Thanks.

Ken

[cygwin_cleanup.patch (text/plain, attachment)]

Message #20 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 14:48:42 -0400

On 7/24/2010 8:22 AM, Ken Brown wrote:
> On 7/24/2010 1:13 AM, Dan Nicolaescu wrote:
>> BTW, it would be good if you could look at configure.in and see if the
>> line:
>>
>>     cygwin) LINKER="\$(CC)" ;;
>>
>> [Just trying to remove special cases from the build system to simplify it...]
>
> There's no need for cygwin to be a special case here.  Fixing this also
> makes the cygwin case irrelevant in the code that sets LIB_GCC a little
> further down in configure.in.  Please apply the attached patch.

Never mind.  I was just given access to the repository, and I applied 
the patch myself.  I didn't regenerate configure.  I wasn't sure if I 
should do that or not.

Since this is my first commit, I would appreciate it if one of the 
experienced people would check that I did it right.

Thanks.

Ken

Message #23 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: dann <at> gnu.org, 6715 <at> debbugs.gnu.org
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 23:26:14 +0300

> Date: Sat, 24 Jul 2010 14:48:42 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
> 
> I didn't regenerate configure.  I wasn't sure if I should do that or
> not.

Yes, you should.  But please make sure you do that with the same
version of Autoconf that was used to generate the current one.

Also, when src/config.in is affected as well (not in this case, I
think), it, too, should be regenerated.

Thanks.

Message #26 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "dann <at> gnu.org" <dann <at> gnu.org>,
	"6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 17:33:11 -0400

On 7/24/2010 4:26 PM, Eli Zaretskii wrote:
>> Date: Sat, 24 Jul 2010 14:48:42 -0400
>> From: Ken Brown<kbrown <at> cornell.edu>
>> Cc: "6715 <at> debbugs.gnu.org"<6715 <at> debbugs.gnu.org>
>>
>> I didn't regenerate configure.  I wasn't sure if I should do that or
>> not.
>
> Yes, you should.  But please make sure you do that with the same
> version of Autoconf that was used to generate the current one.

The current one was generated with Autoconf 2.66, but the latest version 
I have access to is 2.65.  Any suggestions?

Ken

Message #29 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 17:34:21 -0400

Ken Brown <kbrown <at> cornell.edu> writes:

> On 7/24/2010 8:22 AM, Ken Brown wrote:
>> On 7/24/2010 1:13 AM, Dan Nicolaescu wrote:
>>> BTW, it would be good if you could look at configure.in and see if the
>>> line:
>>>
>>>     cygwin) LINKER="\$(CC)" ;;
>>>
>>> [Just trying to remove special cases from the build system to simplify it...]
>>
>> There's no need for cygwin to be a special case here.  Fixing this also
>> makes the cygwin case irrelevant in the code that sets LIB_GCC a little
>> further down in configure.in.  Please apply the attached patch.
>
> Never mind.  I was just given access to the repository, and I applied
> the patch myself.  I didn't regenerate configure.  I wasn't sure if I
> should do that or not.

Please do, use autoconf-2.65 and look at the diff for configure, only
the few lines that you touched should change.  There's no need for a
ChangeLog entry for regenerating configure,

> Since this is my first commit, I would appreciate it if one of the
> experienced people would check that I did it right.

The patch looks fine.  Thanks!

Here's some other cygwin related cleanups:

- remove this:

#ifdef CYGWIN
#define BSD4_2
#endif

and instead add defined(CYGWIN) in the right place in the only user: vm-limit.c

- in configure.in the setting for lastfile.o 
cygwin is the only platform that uses different linking order.
If the "normal" linking order works on cygwin too, it would simplify the build a bit.

Message #32 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sun, 25 Jul 2010 10:38:10 -0400

On 7/24/2010 5:34 PM, Dan Nicolaescu wrote:
> Here's some other cygwin related cleanups:
>
> - remove this:
>
> #ifdef CYGWIN
> #define BSD4_2
> #endif
>
> and instead add defined(CYGWIN) in the right place in the only user: vm-limit.c

Done.

>
> - in configure.in the setting for lastfile.o
> cygwin is the only platform that uses different linking order.
> If the "normal" linking order works on cygwin too, it would simplify the build a bit.

No, the "normal" linking order doesn't work on cygwin; 
bootstrap-emacs.exe gets built, but it hangs when trying to byte compile 
the .el files.  What about turning the question around?  Would the 
linking order that works on cygwin also work on other platforms?  Or is 
it safer to just leave this alone?

Ken

Message #35 received at 6715 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "6715 <at> debbugs.gnu.org" <6715 <at> debbugs.gnu.org>
Subject: Re: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sun, 25 Jul 2010 16:39:17 -0400

Ken Brown <kbrown <at> cornell.edu> writes:

> On 7/24/2010 5:34 PM, Dan Nicolaescu wrote:
>> Here's some other cygwin related cleanups:
>>
>> - remove this:
>>
>> #ifdef CYGWIN
>> #define BSD4_2
>> #endif
>>
>> and instead add defined(CYGWIN) in the right place in the only user: vm-limit.c
>
> Done.

Thanks.

>
>>
>> - in configure.in the setting for lastfile.o
>> cygwin is the only platform that uses different linking order.
>> If the "normal" linking order works on cygwin too, it would simplify the build a bit.
>
> No, the "normal" linking order doesn't work on cygwin;
> bootstrap-emacs.exe gets built, but it hangs when trying to byte
> compile the .el files.  What about turning the question around?  Would
> the linking order that works on cygwin also work on other platforms?

It would have to be tested on all platforms, and that's not trivial.

> Or is it safer to just leave this alone?

Most likeley.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.