GNU bug report logs - #67145
Modes in vc-deduce-backend

Previous Next

Full log

Message #11 received at 67145 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 67145 <at> debbugs.gnu.org
Subject: Re: bug#67145: Modes in vc-deduce-backend
Date: Mon, 13 Nov 2023 19:29:00 +0200

>> Here is a patch that avoids hard-coding the modes in vc-deduce-backend.
>> For example, it makes possible to replace shell-mode with comint-mode, etc.
>
> Look good, although it would be great to find a more meaningful name:
> what kind of modes exactly should be in that list. Non-file-visiting?

These modes are non-file-visiting as well:

   (cond ((derived-mode-p 'vc-dir-mode)   vc-dir-backend)
         ((derived-mode-p 'log-view-mode) log-view-vc-backend)
         ((derived-mode-p 'log-edit-mode) log-edit-vc-backend)
         ((derived-mode-p 'diff-mode)     diff-vc-backend)

What distinguishes these modes is that they are non-vc modes:

  '(dired-mode shell-mode eshell-mode compilation-mode)

Then maybe

  (defvar vc-deduce-backend-nonvc-modes

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.