GNU bug report logs - #67143
[PATCH] gnu: Add python-pyreadstat 1.2.4.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67143: closed ([PATCH] gnu: Add python-pyreadstat 1.2.4.)
Date: Tue, 09 Jan 2024 09:16:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 09 Jan 2024 10:14:58 +0100
with message-id <87mstedg19.fsf <at> gnu.org>
and subject line Re: [bug#67143] [PATCH v2] gnu: Add python-pyreadstat.
has caused the debbugs.gnu.org bug report #67143,
regarding [PATCH] gnu: Add python-pyreadstat 1.2.4.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67143: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67143
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-pyreadstat 1.2.4.
Date: Sun, 12 Nov 2023 19:35:44 +0100

* gnu/packages/statistics.scm (python-pyreadstat): New variable.

Change-Id: I81ad6bf6a5644b783143a97466e12e1a127a7b9e
---
 gnu/local.mk                                  |  2 +
 .../python-pyreadstat-link-libiconv.patch     | 15 +++++++
 gnu/packages/statistics.scm                   | 45 +++++++++++++++++++
 3 files changed, 62 insertions(+)
 create mode 100644 gnu/packages/patches/python-pyreadstat-link-libiconv.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index e90df30068..734bec57c1 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -61,6 +61,7 @@
 # Copyright © 2023 Andy Tai <atai <at> atai.org>
 # Copyright © 2023 B. Wilson <elaexuotee <at> wilsonb.com>
 # Copyright © 2023 gemmaro <gemmaro.dev <at> gmail.com>
+# Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
 #
 # This file is part of GNU Guix.
 #
@@ -1759,6 +1760,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/python-louvain-fix-test.patch		\
   %D%/packages/patches/python-random2-getrandbits-test.patch		\
   %D%/packages/patches/python-poppler-qt5-fix-build.patch	\
+  %D%/packages/patches/python-pyreadstat-link-libiconv.patch	\
   %D%/packages/patches/python-pypdf-annotate-tests-appropriately.patch	\
   %D%/packages/patches/python-sip-include-dirs.patch	\
   %D%/packages/patches/python-sgmllib3k-assertions.patch	\
diff --git a/gnu/packages/patches/python-pyreadstat-link-libiconv.patch b/gnu/packages/patches/python-pyreadstat-link-libiconv.patch
new file mode 100644
index 0000000000..7efd71faeb
--- /dev/null
+++ b/gnu/packages/patches/python-pyreadstat-link-libiconv.patch
@@ -0,0 +1,15 @@
+To ensure libiconv can be found by Guix, we need to link the library.
+
+--- a/setup.py
++++ b/setup.py
+@@ -81,8 +81,7 @@ else:
+     libraries.extend(["m", "z"])
+     _platform = sys.platform
+     # Mac: iconv needs to be linked statically
+-    if _platform.lower().startswith("darwin"):
+-        libraries.append("iconv")
++    libraries.append("iconv")
+ 
+ # Extensions
+ sources.sort()
+
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index d15732c839..4280906d2a 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Frank Pursel <frank.pursel <at> gmail.com>
 ;;; Copyright © 2022 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2023 gemmaro <gemmaro.dev <at> gmail.com>
+;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7019,6 +7020,50 @@ (define-public readstat
 popular stats packages like SAS, Stata and SPSS.")
     (license license:expat)))
 
+(define-public python-pyreadstat
+  (package
+    (name "python-pyreadstat")
+    (version "1.2.4")
+    ;; No tests in the PyPI tarball.
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Roche/pyreadstat")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0zysrzixvqw2lwwykxqg5yj8a0zyv5s2bmk22x30f4rj2hgvq1pv"))
+       (patches (search-patches "python-pyreadstat-link-libiconv.patch"))))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-before 'check 'change-home-dir
+                    (lambda _
+                      ;; test_sav_expand and test_sav_write_basic_expanduser need a
+                      ;; home directory with write permissions.
+                      (setenv "HOME" "/tmp")))
+                  (replace 'check
+                    (lambda* (#:key tests? #:allow-other-keys)
+                      (when tests?
+                        ;; The source also contains tests/test_version.py
+                        ;; which checks the version in __init__.py against the
+                        ;; one in setup.py. Since this requires texlive
+                        ;; dependencies to run and is also not mentioned in
+                        ;; how_to_test.md, this test is skipped.
+                        (invoke "python" "tests/test_basic.py")))))))
+    (build-system python-build-system)
+    (propagated-inputs (list python-pandas))
+    (inputs (list libiconv zlib))
+    (native-inputs (list python-cython-3))
+    (home-page "https://github.com/Roche/pyreadstat")
+    (synopsis
+     "Read and write SAS, SPSS and Stata files into/from pandas data frames")
+    (description
+     "A Python package to read and write SAS (sas7bdat, sas7bcat, xport/xpt),
+SPSS (sav, zsav, por) and Stata (dta) files into/from pandas data frames.  It
+is a wrapper around the C library readstat.")
+    (license license:asl2.0)))
+
 (define-public r-quantpsyc
   (package
     (name "r-quantpsyc")
-- 
2.40.1

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Troy Figiel <troy <at> troyfigiel.com>
Cc: 67143-done <at> debbugs.gnu.org
Subject: Re: [bug#67143] [PATCH v2] gnu: Add python-pyreadstat.
Date: Tue, 09 Jan 2024 10:14:58 +0100

Hello,

> * gnu/packages/statistics.scm (python-pyreadstat): New variable.
> ---
>  gnu/local.mk                                  |  2 +
>  .../python-pyreadstat-link-libiconv.patch     | 15 +++++++

You need to comment those in the commit message as well.

I fixed that and applied,

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.