From unknown Thu Aug 14 21:54:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67138 <67138@debbugs.gnu.org> To: bug#67138 <67138@debbugs.gnu.org> Subject: Status: [PATCH] ; Fix 'add-face-text-property' shortdoc Reply-To: bug#67138 <67138@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:54:58 +0000 retitle 67138 [PATCH] ; Fix 'add-face-text-property' shortdoc reassign 67138 emacs submitter 67138 Eshel Yaron severity 67138 normal tag 67138 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 15:50:20 2023 Received: (at submit) by debbugs.gnu.org; 12 Nov 2023 20:50:20 +0000 Received: from localhost ([127.0.0.1]:57124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2HPQ-0001Ck-2L for submit@debbugs.gnu.org; Sun, 12 Nov 2023 15:50:20 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2HPN-0001CW-2f for submit@debbugs.gnu.org; Sun, 12 Nov 2023 15:50:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2HOc-00064y-LE for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:49:30 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2HOb-00072v-5y for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:49:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1699822167; bh=GyhzQO7cdiVeE7iH9GD7N+Q9FDQrp+tC/92s4Pi1tPQ=; h=From:To:Subject:Date:From; b=Cf5Yx7z26BWXimokS+eH76uzW1ZBnZ3TlECqpBmqza8bwNZ9XdS/d04+H81ytgeNd v6/xRKirY+wtxn2OU2FIhDur9vaBkNe3nbZ0f4h+1jNv3fz8WakpkaDGLB5DjvGPJI M15ThvYg0JqvZJwMZqKkCf301fhW0wKfbyCF8TWGxMp+gsmmpqqlz/a8TOuFrWHrAR JDvoanlT3TfqTS2F5OqajvcPFCrqBIUUvy7rZ+JF6DVrC88zsUXYXuwIF6+qUZc1d/ lhSZ4CDSP7eXNEF2yJCQ2vHjUYTZe1m6lO4OqvjCIKRN5KMm7lUzIg/WMoIEEGIMlf PFiBsa2IKaNtw== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Fix 'add-face-text-property' shortdoc X-Hashcash: 1:20:231112:bug-gnu-emacs@gnu.org::nUMHXZevvBnd6fdq:2Ifw Date: Sun, 12 Nov 2023 21:49:24 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, This fixes an omission in shortdoc.el that causes the following to emit an error instead of showing the *Help* buffer: 1. emacs -Q 2. (add-hook 'help-fns-describe-function-functions #'shortdoc-help-fns-examples-function) 3. C-h f add-face-text-property RET 4. Emacs says "Wrong type argument: prop-match, nil" --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-add-face-text-property-shortdoc.patch >From 2d79dcd386e0ac5f1b72d3df7d770b7615dae8c8 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sun, 12 Nov 2023 21:42:25 +0100 Subject: [PATCH] ; Fix 'add-face-text-property' shortdoc * lisp/emacs-lisp/shortdoc.el (text-properties): Add missing ':no-eval' keyword. --- lisp/emacs-lisp/shortdoc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/shortdoc.el b/lisp/emacs-lisp/shortdoc.el index dbc061d8a70..1fa798beae1 100644 --- a/lisp/emacs-lisp/shortdoc.el +++ b/lisp/emacs-lisp/shortdoc.el @@ -1388,7 +1388,7 @@ text-properties (set-text-properties :no-eval (set-text-properties (point) (1+ (point)) '(face error))) (add-face-text-property - (add-face-text-property START END '(:foreground "green"))) + :no-eval (add-face-text-property START END '(:foreground "green"))) (propertize :eval (propertize "foo" 'face 'italic 'mouse-face 'bold-italic)) "Searching for Text Properties" -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 09:13:00 2023 Received: (at 67138-done) by debbugs.gnu.org; 14 Nov 2023 14:13:00 +0000 Received: from localhost ([127.0.0.1]:60623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2u9z-0005ge-Vl for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:13:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2u9y-0005gT-HM for 67138-done@debbugs.gnu.org; Tue, 14 Nov 2023 09:12:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2u9C-0002Xh-U3; Tue, 14 Nov 2023 09:12:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pLU3hgJ+vR2FPR7jJLsbK1/L0uXz2QQZ7bf80T7N8qs=; b=SW0wblUmn6iA EWBrAcqeDgIu+FuJJr0YVXjPVQfwJosMjiryRNG6cQ3OMppxLk6RKTRntXaQrOLAnGN0j1JTTPDDo g+pT/NnRpILu6s5bmNF1U2d67zYr11wmfB0nWcJzfLMsI8itm81dNNuh3CXKFGhessKWQKiz0tgsW bRClLrVJMN4PTEwAbxQnO26TzQ3f0/Gp3J5CbCrYZoavHwmTuR2K2QNT8QpWg74S6RlHIE8lRsCHy 6uyoufthxfGNU9tfZN9JjN8IfqNvfkzBt5/gWBVuWXcWDGOUz1fcds6D0gPPqq1kz/waFC4caaDP7 5L0TGmGmEPsZzZNlAMdfow==; Date: Tue, 14 Nov 2023 16:11:56 +0200 Message-Id: <83y1f0s9ub.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#67138: [PATCH] ; Fix 'add-face-text-property' shortdoc References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67138-done Cc: 67138-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 12 Nov 2023 21:49:24 +0100 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This fixes an omission in shortdoc.el that causes the following to emit > an error instead of showing the *Help* buffer: > > 1. emacs -Q > 2. (add-hook 'help-fns-describe-function-functions > #'shortdoc-help-fns-examples-function) > 3. C-h f add-face-text-property RET > 4. Emacs says "Wrong type argument: prop-match, nil" It also shows the example if one just does "C-h f" without any hooks. Thanks, installed on the emacs-29 branch, and closing the bug. From unknown Thu Aug 14 21:54:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Dec 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator