GNU bug report logs - #67135
[PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Noah Peart <noah.v.peart <at> gmail.com>
Subject: bug#67135: closed (Re: bug#67135: [PATCH] Fix font-lock for
 string escapes in lua-ts--font-lock-settings)
Date: Wed, 15 Nov 2023 16:29:08 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67135 <at> debbugs.gnu.org.

-- 
67135: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67135
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: jm <at> pub.pink
Cc: noah.v.peart <at> gmail.com, 67135-done <at> debbugs.gnu.org
Subject: Re: bug#67135: [PATCH] Fix font-lock for string escapes in
 lua-ts--font-lock-settings
Date: Wed, 15 Nov 2023 15:08:40 +0200

> Date: Sun, 12 Nov 2023 22:26:16 +0000
> TLS-Required: No
> From: jm--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> November 12, 2023 at 7:45 PM, "Noah Peart" <noah.v.peart <at> gmail.com> wrote:
> > 
> > Tags: patch
> > 
> > * lisp/progmodes/lua-ts-mode.el
> > (lua-ts-mode--font-lock-settings): fix font-locking for string escapes
> > 
> > Bug: Strings aren't fontified when they have escape sequences in them.
> > 
> > Recipe to reproduce:
> > In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to
> > include escapes,
> > 
> >  "foo\nbar"
> > 
> > font-locks '\n' but not "foo" or "bar".
> > 
> > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD
> > Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
> > Repository branch: master
> > Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
> > System Description: Ubuntu 22.04.3 LTS
> > 
> > Configured using:
> >  'configure --prefix=/usr/local --with-modules --with-tree-sitter
> > --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
> > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
> > CXX=gcc-12'
> 
> Thanks.
> 
> I updated the commit message to include the bug number and
> match the format used in Emacs.

Thanks, installed on master, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings
Date: Sun, 12 Nov 2023 11:45:32 -0800

[Message part 4 (text/plain, inline)]

Tags: patch

* lisp/progmodes/lua-ts-mode.el
(lua-ts-mode--font-lock-settings): fix font-locking for string escapes

Bug: Strings aren't fontified when they have escape sequences in them.

Recipe to reproduce:
In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to
include escapes,

    "foo\nbar"

font-locks '\n' but not "foo" or "bar".

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD
Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 5 (text/html, inline)]

[lua-ts-string-escapes.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.