From unknown Mon Aug 18 09:04:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings Resent-From: Noah Peart Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2023 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67135 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 67135@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169981840729457 (code B ref -1); Sun, 12 Nov 2023 19:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Nov 2023 19:46:47 +0000 Received: from localhost ([127.0.0.1]:57047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2GPu-0007f3-JS for submit@debbugs.gnu.org; Sun, 12 Nov 2023 14:46:46 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2GPr-0007eZ-KJ for submit@debbugs.gnu.org; Sun, 12 Nov 2023 14:46:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2GP5-0000uT-Ty for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 14:45:56 -0500 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2GOv-0000IB-1Q for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 14:45:55 -0500 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3b6a837a2e1so2198144b6e.0 for ; Sun, 12 Nov 2023 11:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699818343; x=1700423143; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FEGA/iYN9Z6cG4dmzYirHcgiAsyoaMVRJY+xZa+s+Mk=; b=VZjZo5l0rkxOCmyhdfYxeMX1SnwTIWePpu9rP2bKxQ2fe6FSZWlSx43vHVu9LadsK9 fG9WqJUhVCPu/S+YN/0VMaFjD1XmM7XK1dkfai5oUsqIvQugoqQfWm75uCWxPjgBP0m0 4RC3us2YCjnYHXYUOqgEqBYhgkgMLGUZJvqm9PAl5ntYvD/TFmjBy9a9qA1dmGIvVjMG GsPm7dLO+Ilekh0IwFcMgPwogKzp+vPteCH2+4C6GSZZlpMxq47l2ks08J+0CkSjZBSA wsSEBsBiVrI2Y0u7BPtSF5L0Rwn3VSINg27124/kZu1fC+7smrv+ivc3oVQaZIoZCCGa QUDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699818343; x=1700423143; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FEGA/iYN9Z6cG4dmzYirHcgiAsyoaMVRJY+xZa+s+Mk=; b=kjDR89BUcGoE9pEEmpQYip9HRW+VbkMqcpdaIAD8AbFfj0N+MwgUiUUT6OFDebkiBc FA+t8+QQBaajUOvlXEleKxRw8aqDVqm2bazHG6VowXXaYYizGSD0dbtoR2tqo4AmwLbB s5yfMbpY60D27SlcBdSa3no8J9QvoVPM4IxOWG3e7EIB/Hv+xih4ynq0L0dere7JtH8l NK9kC7Wcip0SCxfXUGq5n9L1BKOxnR10m7MtOj5l2ilJ8kPSkhxMG6RqdyeUlizgmA+H 8HHlncN/kf80co9F66aHb3R/sjEAhOy7gGD/L6M58xCb/8Es9ZQYp2QqT+hAQ7Gl9tbP GsKQ== X-Gm-Message-State: AOJu0YzLCU0xqTQnAlf4a0zaYkBfQ6LE1PZC8MQIzdhx62FdAuWGtyyy 7IENJCsQoUtKpzasCsul4Ub8iNrrQ4AU1Nr9GSRgiSFUpiSPKsGe X-Google-Smtp-Source: AGHT+IEvNeFlXNSLVVlQeUPUWUVpXyTLk0YUVW5kRfDLFXKeefTQ+8kD85VIPjRFpbYz/NV9UT2IjWi6bplxcgUIhxY= X-Received: by 2002:a05:6870:14c2:b0:1e9:b653:94d with SMTP id l2-20020a05687014c200b001e9b653094dmr6133480oab.1.1699818342972; Sun, 12 Nov 2023 11:45:42 -0800 (PST) MIME-Version: 1.0 From: Noah Peart Date: Sun, 12 Nov 2023 11:45:32 -0800 Message-ID: Content-Type: multipart/mixed; boundary="000000000000843d660609f9ccb3" Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=noah.v.peart@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000843d660609f9ccb3 Content-Type: multipart/alternative; boundary="000000000000843d650609f9ccb1" --000000000000843d650609f9ccb1 Content-Type: text/plain; charset="UTF-8" Tags: patch * lisp/progmodes/lua-ts-mode.el (lua-ts-mode--font-lock-settings): fix font-locking for string escapes Bug: Strings aren't fontified when they have escape sequences in them. Recipe to reproduce: In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to include escapes, "foo\nbar" font-locks '\n' but not "foo" or "bar". In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000843d650609f9ccb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch

* lisp/progmodes/lua-ts-mode.el
(lua= -ts-mode--font-lock-settings): fix font-locking for string escapes

B= ug: Strings aren't fontified when they have escape sequences in them.
Recipe to reproduce:
In a `lua-ts-mode` buffer, with `treesit-font= -lock-level` set to 4 to
include escapes,

=C2=A0 =C2=A0 "foo= \nbar"

font-locks '\n' but not "foo" or "= ;bar".

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+= Version
3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580= VD
Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
Repo= sitory branch: master
Windowing system distributor 'The X.Org Founda= tion', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS<= br>
Configured using:
=C2=A0'configure --prefix=3D/usr/local --wi= th-modules --with-tree-sitter
--with-threads --with-x-toolkit=3Dgtk3 --w= ith-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --wi= th-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick= CC=3Dgcc-12
CXX=3Dgcc-12'
--000000000000843d650609f9ccb1-- --000000000000843d660609f9ccb3 Content-Type: text/x-patch; charset="US-ASCII"; name="lua-ts-string-escapes.patch" Content-Disposition: attachment; filename="lua-ts-string-escapes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lovvxio70 RnJvbSAzNGNmYjkzOTkyZmMwN2Q2ZGMxZDJkOWNiMjdlNGQyYjI2NGNiY2ZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IFN1biwgMTIgTm92IDIwMjMgMTE6MzY6MDkgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGaXggZm9u dC1sb2NrIGZvciBzdHJpbmcgZXNjYXBlcyBpbgogbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MK Ci0tLQogbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgfCA5ICsrKysrLS0tLQogMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2x1YS10cy1tb2Rl LmVsCmluZGV4IDIxOTM3NzliNzU5Li5iYjZkNWNiOGM5MSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9n bW9kZXMvbHVhLXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwK QEAgLTE0OCwxMCArMTQ4LDYgQEAgbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0 dXJlICdkZWxpbWl0ZXIKICAgICcoWyIsIiAiOyJdIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2Up CiAKLSAgIDpsYW5ndWFnZSAnbHVhCi0gICA6ZmVhdHVyZSAnZXNjYXBlCi0gICAnKChlc2NhcGVf c2VxdWVuY2UpIEBmb250LWxvY2stZXNjYXBlLWZhY2UpCi0KICAgIDpsYW5ndWFnZSAnbHVhCiAg ICA6ZmVhdHVyZSAnY29uc3RhbnQKICAgICcoKHZhcmlhYmxlX2xpc3QKQEAgLTIxMyw2ICsyMDks MTEgQEAgbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdzdHJpbmcKICAg ICcoKHN0cmluZykgQGZvbnQtbG9jay1zdHJpbmctZmFjZSkKIAorICAgOmxhbmd1YWdlICdsdWEK KyAgIDpmZWF0dXJlICdlc2NhcGUKKyAgIDpvdmVycmlkZSB0CisgICAnKChlc2NhcGVfc2VxdWVu Y2UpIEBmb250LWxvY2stZXNjYXBlLWZhY2UpCisKICAgIDpsYW5ndWFnZSAnbHVhCiAgICA6ZmVh dHVyZSAnY29tbWVudAogICAgJygoY29tbWVudCkgQGZvbnQtbG9jay1jb21tZW50LWZhY2UKLS0g CjIuMzQuMQoK --000000000000843d660609f9ccb3-- From unknown Mon Aug 18 09:04:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings References: In-Reply-To: Resent-From: jm@pub.pink Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2023 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67135 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: noah.v.peart@gmail.com, 67135@debbugs.gnu.org Received: via spool by 67135-submit@debbugs.gnu.org id=B67135.169982802524368 (code B ref 67135); Sun, 12 Nov 2023 22:28:01 +0000 Received: (at 67135) by debbugs.gnu.org; 12 Nov 2023 22:27:05 +0000 Received: from localhost ([127.0.0.1]:57210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2Iv2-0006Ky-NN for submit@debbugs.gnu.org; Sun, 12 Nov 2023 17:27:05 -0500 Received: from out-171.mta0.migadu.com ([91.218.175.171]:65208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2Iuy-0006KU-Lo for 67135@debbugs.gnu.org; Sun, 12 Nov 2023 17:27:03 -0500 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1699827977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=v0uE+0T/9ZzYdFYYMnQHCphEgr0suW14i+9Rs54KZB0=; b=oCzMhNB71QyTnl4i/PakiZXw+641KWH7KZlasy3wpMIsq8nhPqZ3bbwezKLsexyb+xhrtJ 0Fmm+AatYygEPAgIeb68TjDsGVzWtaAZOzcE9m535K8V6HvksggDJMHaWU6O68R+OabNDX Lmk+MDH0MuqQFI6TcyStDKPuX8kfslc= Date: Sun, 12 Nov 2023 22:26:16 +0000 Content-Type: multipart/mixed; boundary="23a7922e-794d-4f46-a554-e8ac443d3014-1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jm@pub.pink Message-ID: <077404d22f497a0f32db70a374c7c9d36c925404@pub.pink> TLS-Required: No X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --23a7922e-794d-4f46-a554-e8ac443d3014-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable November 12, 2023 at 7:45 PM, "Noah Peart" wrote= : >=20 >=20Tags: patch >=20 >=20* lisp/progmodes/lua-ts-mode.el > (lua-ts-mode--font-lock-settings): fix font-locking for string escapes >=20 >=20Bug: Strings aren't fontified when they have escape sequences in them= . >=20 >=20Recipe to reproduce: > In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to > include escapes, >=20 >=20 "foo\nbar" >=20 >=20font-locks '\n' but not "foo" or "bar". >=20 >=20In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD > Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12101= 004 > System Description: Ubuntu 22.04.3 LTS >=20 >=20Configured using: > 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter > --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12 > CXX=3Dgcc-12' Thanks. I updated the commit message to include the bug number and match the format used in Emacs. --23a7922e-794d-4f46-a554-e8ac443d3014-1 Content-Type: text/x-diff; name="0001-Fix-font-lock-for-string-escapes-in-lua-ts-mode.patch" Content-Disposition: attachment; filename="0001-Fix-font-lock-for-string-escapes-in-lua-ts-mode.patch" Content-Transfer-Encoding: base64 RnJvbSBkYjc2NTVlZjJkYmNkNjhlZjI1OWRhZDExMThmZDIxZjE1MmRkMDVhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMTIgTm92IDIwMjMgMTE6MzY6MDkgLTA4MDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9udC1sb2NrIGZvciBzdHJpbmcgZXNjYXBlcyBpbiBsdWEtdHMtbW9kZQoKKiBs dWEtdHMtbW9kZS5lbCAobHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MpOiBBcHBseSBmb250 LWxvY2sKdG8gdGhlIGVudGlyZSBzdHJpbmcgY29udGFpbmluZyBhbiBlc2NhcGUgc2VxdWVu Y2UuIChCdWcjNjcxMzUpCi0tLQogbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgfCA5 ICsrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbCBiL2xp c3AvcHJvZ21vZGVzL2x1YS10cy1tb2RlLmVsCmluZGV4IDIxOTM3NzliNzU5Li5iYjZkNWNi OGM5MSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwKKysrIGIv bGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwKQEAgLTE0OCwxMCArMTQ4LDYgQEAgbHVh LXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdkZWxpbWl0ZXIKICAgICco WyIsIiAiOyJdIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UpCiAKLSAgIDpsYW5ndWFnZSAn bHVhCi0gICA6ZmVhdHVyZSAnZXNjYXBlCi0gICAnKChlc2NhcGVfc2VxdWVuY2UpIEBmb250 LWxvY2stZXNjYXBlLWZhY2UpCi0KICAgIDpsYW5ndWFnZSAnbHVhCiAgICA6ZmVhdHVyZSAn Y29uc3RhbnQKICAgICcoKHZhcmlhYmxlX2xpc3QKQEAgLTIxMyw2ICsyMDksMTEgQEAgbHVh LXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdzdHJpbmcKICAgICcoKHN0 cmluZykgQGZvbnQtbG9jay1zdHJpbmctZmFjZSkKIAorICAgOmxhbmd1YWdlICdsdWEKKyAg IDpmZWF0dXJlICdlc2NhcGUKKyAgIDpvdmVycmlkZSB0CisgICAnKChlc2NhcGVfc2VxdWVu Y2UpIEBmb250LWxvY2stZXNjYXBlLWZhY2UpCisKICAgIDpsYW5ndWFnZSAnbHVhCiAgICA6 ZmVhdHVyZSAnY29tbWVudAogICAgJygoY29tbWVudCkgQGZvbnQtbG9jay1jb21tZW50LWZh Y2UKLS0gCjIuNDEuMAoK --23a7922e-794d-4f46-a554-e8ac443d3014-1-- From unknown Mon Aug 18 09:04:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Noah Peart Subject: bug#67135: closed (Re: bug#67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings) Message-ID: References: <8334x7rwo7.fsf@gnu.org> X-Gnu-PR-Message: they-closed 67135 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 67135@debbugs.gnu.org Date: Wed, 15 Nov 2023 16:29:08 +0000 Content-Type: multipart/mixed; boundary="----------=_1700065748-8421-1" This is a multi-part message in MIME format... ------------=_1700065748-8421-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-setti= ngs which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 67135@debbugs.gnu.org. --=20 67135: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67135 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1700065748-8421-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 67135-done) by debbugs.gnu.org; 15 Nov 2023 16:28:12 +0000 Received: from localhost ([127.0.0.1]:53132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkM-00028g-Sn for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQd-0001QS-SX for 67135-done@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3FdT-0004Oj-1o; Wed, 15 Nov 2023 08:08:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zDo6kTBBdW//fulXkF3kYgRyDiNCePgpBOi9FXS0Iws=; b=JBT9AuJAPDYW 5zwGSSqGezmaEjeDtYdh0ezqMv3hfGrys66hvq1zyWB2e+d94+rDmIizc6TX6TOsPFvFg0tx9pSkj sPkhfCnEsRfI2L+WXHkvAz1J9Rj2djvwA8G4MLnzCjGB7v2mkX7cb0sOkUgMEsrlpewSRi6mMVxsR DoaWj4pDAAjb5aAcBn9mbxe5URV/BEmWnOdVBbQ2fRu0TiHXrGa6JDDzCa13pJgEOYGxvuZEraiV3 5xx236A+p2C88s+THepd/bBcNFDjRL779kDklOPYeunvnxUx7efkJmPfFuWLuMghyjyap0mwLwtny 01Vk2tjeCCBmsBGuMKVEaQ==; Date: Wed, 15 Nov 2023 15:08:40 +0200 Message-Id: <8334x7rwo7.fsf@gnu.org> From: Eli Zaretskii To: jm@pub.pink In-Reply-To: <077404d22f497a0f32db70a374c7c9d36c925404@pub.pink> (bug-gnu-emacs@gnu.org) Subject: Re: bug#67135: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings References: <077404d22f497a0f32db70a374c7c9d36c925404@pub.pink> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67135-done Cc: noah.v.peart@gmail.com, 67135-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 12 Nov 2023 22:26:16 +0000 > TLS-Required: No > From: jm--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > November 12, 2023 at 7:45 PM, "Noah Peart" wrote: > > > > Tags: patch > > > > * lisp/progmodes/lua-ts-mode.el > > (lua-ts-mode--font-lock-settings): fix font-locking for string escapes > > > > Bug: Strings aren't fontified when they have escape sequences in them. > > > > Recipe to reproduce: > > In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to > > include escapes, > > > > "foo\nbar" > > > > font-locks '\n' but not "foo" or "bar". > > > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > > 3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD > > Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24 > > Repository branch: master > > Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 > > System Description: Ubuntu 22.04.3 LTS > > > > Configured using: > > 'configure --prefix=/usr/local --with-modules --with-tree-sitter > > --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls > > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg > > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 > > CXX=gcc-12' > > Thanks. > > I updated the commit message to include the bug number and > match the format used in Emacs. Thanks, installed on master, and closing the bug. ------------=_1700065748-8421-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Nov 2023 19:46:47 +0000 Received: from localhost ([127.0.0.1]:57047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2GPu-0007f3-JS for submit@debbugs.gnu.org; Sun, 12 Nov 2023 14:46:46 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2GPr-0007eZ-KJ for submit@debbugs.gnu.org; Sun, 12 Nov 2023 14:46:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2GP5-0000uT-Ty for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 14:45:56 -0500 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2GOv-0000IB-1Q for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 14:45:55 -0500 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3b6a837a2e1so2198144b6e.0 for ; Sun, 12 Nov 2023 11:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699818343; x=1700423143; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FEGA/iYN9Z6cG4dmzYirHcgiAsyoaMVRJY+xZa+s+Mk=; b=VZjZo5l0rkxOCmyhdfYxeMX1SnwTIWePpu9rP2bKxQ2fe6FSZWlSx43vHVu9LadsK9 fG9WqJUhVCPu/S+YN/0VMaFjD1XmM7XK1dkfai5oUsqIvQugoqQfWm75uCWxPjgBP0m0 4RC3us2YCjnYHXYUOqgEqBYhgkgMLGUZJvqm9PAl5ntYvD/TFmjBy9a9qA1dmGIvVjMG GsPm7dLO+Ilekh0IwFcMgPwogKzp+vPteCH2+4C6GSZZlpMxq47l2ks08J+0CkSjZBSA wsSEBsBiVrI2Y0u7BPtSF5L0Rwn3VSINg27124/kZu1fC+7smrv+ivc3oVQaZIoZCCGa QUDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699818343; x=1700423143; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FEGA/iYN9Z6cG4dmzYirHcgiAsyoaMVRJY+xZa+s+Mk=; b=kjDR89BUcGoE9pEEmpQYip9HRW+VbkMqcpdaIAD8AbFfj0N+MwgUiUUT6OFDebkiBc FA+t8+QQBaajUOvlXEleKxRw8aqDVqm2bazHG6VowXXaYYizGSD0dbtoR2tqo4AmwLbB s5yfMbpY60D27SlcBdSa3no8J9QvoVPM4IxOWG3e7EIB/Hv+xih4ynq0L0dere7JtH8l NK9kC7Wcip0SCxfXUGq5n9L1BKOxnR10m7MtOj5l2ilJ8kPSkhxMG6RqdyeUlizgmA+H 8HHlncN/kf80co9F66aHb3R/sjEAhOy7gGD/L6M58xCb/8Es9ZQYp2QqT+hAQ7Gl9tbP GsKQ== X-Gm-Message-State: AOJu0YzLCU0xqTQnAlf4a0zaYkBfQ6LE1PZC8MQIzdhx62FdAuWGtyyy 7IENJCsQoUtKpzasCsul4Ub8iNrrQ4AU1Nr9GSRgiSFUpiSPKsGe X-Google-Smtp-Source: AGHT+IEvNeFlXNSLVVlQeUPUWUVpXyTLk0YUVW5kRfDLFXKeefTQ+8kD85VIPjRFpbYz/NV9UT2IjWi6bplxcgUIhxY= X-Received: by 2002:a05:6870:14c2:b0:1e9:b653:94d with SMTP id l2-20020a05687014c200b001e9b653094dmr6133480oab.1.1699818342972; Sun, 12 Nov 2023 11:45:42 -0800 (PST) MIME-Version: 1.0 From: Noah Peart Date: Sun, 12 Nov 2023 11:45:32 -0800 Message-ID: Subject: [PATCH] Fix font-lock for string escapes in lua-ts--font-lock-settings To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000843d660609f9ccb3" Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=noah.v.peart@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000843d660609f9ccb3 Content-Type: multipart/alternative; boundary="000000000000843d650609f9ccb1" --000000000000843d650609f9ccb1 Content-Type: text/plain; charset="UTF-8" Tags: patch * lisp/progmodes/lua-ts-mode.el (lua-ts-mode--font-lock-settings): fix font-locking for string escapes Bug: Strings aren't fontified when they have escape sequences in them. Recipe to reproduce: In a `lua-ts-mode` buffer, with `treesit-font-lock-level` set to 4 to include escapes, "foo\nbar" font-locks '\n' but not "foo" or "bar". In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000843d650609f9ccb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch

* lisp/progmodes/lua-ts-mode.el
(lua= -ts-mode--font-lock-settings): fix font-locking for string escapes

B= ug: Strings aren't fontified when they have escape sequences in them.
Recipe to reproduce:
In a `lua-ts-mode` buffer, with `treesit-font= -lock-level` set to 4 to
include escapes,

=C2=A0 =C2=A0 "foo= \nbar"

font-locks '\n' but not "foo" or "= ;bar".

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+= Version
3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580= VD
Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
Repo= sitory branch: master
Windowing system distributor 'The X.Org Founda= tion', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS<= br>
Configured using:
=C2=A0'configure --prefix=3D/usr/local --wi= th-modules --with-tree-sitter
--with-threads --with-x-toolkit=3Dgtk3 --w= ith-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --wi= th-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick= CC=3Dgcc-12
CXX=3Dgcc-12'
--000000000000843d650609f9ccb1-- --000000000000843d660609f9ccb3 Content-Type: text/x-patch; charset="US-ASCII"; name="lua-ts-string-escapes.patch" Content-Disposition: attachment; filename="lua-ts-string-escapes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lovvxio70 RnJvbSAzNGNmYjkzOTkyZmMwN2Q2ZGMxZDJkOWNiMjdlNGQyYjI2NGNiY2ZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IFN1biwgMTIgTm92IDIwMjMgMTE6MzY6MDkgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGaXggZm9u dC1sb2NrIGZvciBzdHJpbmcgZXNjYXBlcyBpbgogbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MK Ci0tLQogbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwgfCA5ICsrKysrLS0tLQogMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2x1YS10cy1tb2Rl LmVsCmluZGV4IDIxOTM3NzliNzU5Li5iYjZkNWNiOGM5MSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9n bW9kZXMvbHVhLXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwK QEAgLTE0OCwxMCArMTQ4LDYgQEAgbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0 dXJlICdkZWxpbWl0ZXIKICAgICcoWyIsIiAiOyJdIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2Up CiAKLSAgIDpsYW5ndWFnZSAnbHVhCi0gICA6ZmVhdHVyZSAnZXNjYXBlCi0gICAnKChlc2NhcGVf c2VxdWVuY2UpIEBmb250LWxvY2stZXNjYXBlLWZhY2UpCi0KICAgIDpsYW5ndWFnZSAnbHVhCiAg ICA6ZmVhdHVyZSAnY29uc3RhbnQKICAgICcoKHZhcmlhYmxlX2xpc3QKQEAgLTIxMyw2ICsyMDks MTEgQEAgbHVhLXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdzdHJpbmcKICAg ICcoKHN0cmluZykgQGZvbnQtbG9jay1zdHJpbmctZmFjZSkKIAorICAgOmxhbmd1YWdlICdsdWEK KyAgIDpmZWF0dXJlICdlc2NhcGUKKyAgIDpvdmVycmlkZSB0CisgICAnKChlc2NhcGVfc2VxdWVu Y2UpIEBmb250LWxvY2stZXNjYXBlLWZhY2UpCisKICAgIDpsYW5ndWFnZSAnbHVhCiAgICA6ZmVh dHVyZSAnY29tbWVudAogICAgJygoY29tbWVudCkgQGZvbnQtbG9jay1jb21tZW50LWZhY2UKLS0g CjIuMzQuMQoK --000000000000843d660609f9ccb3-- ------------=_1700065748-8421-1--