GNU bug report logs - #67134
[PATCH] gnu: Add camelia-girls

Previous Next

Full log

Message #11 received at 67134 <at> debbugs.gnu.org (full text, mbox):

From: hrn <hrn <at> posteo.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 67134 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add camelia-girls
Date: Wed, 15 Nov 2023 20:07:21 +0000

Thanks for reviewing!

>    +       (snippet '(begin

> Use #~ instead of ': The former also allows you to pull in other
> packages, should you ever need to.

Ok I'll test.

>    +     `(#:phases (modify-phases %standard-phases

> Same as above, prefer (list #:phases #~(...))

Ok will try, I thought it was the other way around.

>    +                             (font-path-bi (string-append 
> (assoc-ref
>    inputs
>    +                                                           "font-
>    dejavu")
>    +                                            
> "/share/fonts/truetype/"
>    +                                            font-name-bi))

> Prefer search-input-file.

Ok, sounds better.

>    +                        (symlink font-path-bi target-bi))))

> Instead of symlinking, hard-code the file name where it's used?

Symlinking avoids changing the source files. Isn't that better?

> We have a dedicated procedure for generating .desktop files.  Use that.

I would have used that if it wasn't for the builder already having 
created the
desktop file. I didn't want to change the builder so I ended up with 
this solution. In
case the builder can do more automatically in the future we can remove 
the extra code.
Or do you want me to overwrite the desktop file created by the builder 
entirely?


> The credits are, as far as I can see, a little unclear about some
> included assets – I only see some Wikimedia links, and that's it.  I'd
> be happy to be proven wrong, though, we desperately need a package to
> make use of renpy-build-system :)

I checked the licenses to the best of my best ability from the 
information in license.txt.
The in game credits with more detailed license information can be found 
in the
games/scripts/credits?.txt.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.