GNU bug report logs - #67133
[PATCH] Fix CBZ file detection in doc-view-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67133: closed ([PATCH] Fix CBZ file detection in doc-view-mode)
Date: Wed, 15 Nov 2023 17:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 15 Nov 2023 19:10:03 +0200
with message-id <83edgrq6xg.fsf <at> gnu.org>
and subject line Re: bug#67133: [PATCH] Fix CBZ file detection in doc-view-mode
has caused the debbugs.gnu.org bug report #67133,
regarding [PATCH] Fix CBZ file detection in doc-view-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67133: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67133
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix CBZ file detection in doc-view-mode
Date: Sun, 12 Nov 2023 12:40:35 -0500

[Message part 3 (text/plain, inline)]

Tags: patch

When opening a CBZ file I get the message "doc-view-set-doc-type:
Conflicting types: name says (cbz) but content says (epub odf)".

Looking at the end of `doc-view-set-doc-type` (lisp/doc-view.el:2141)
it's pretty obvious why and it has an easy fix.  In fact we already did
this fix once before for ODF files as you can see at bug#54947 which
resulted in commit b3ff4905388834994ff26d9d033d6bc62b094c1c



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.37, cairo version 1.16.0)
System Description: Guix System

Configured using:
 'configure
CONFIG_SHELL=/gnu/store/v9p25q9l5nnaixkhpap5rnymmwbhf9rp-bash-minimal-5.1.16/bin/bash
SHELL=/gnu/store/v9p25q9l5nnaixkhpap5rnymmwbhf9rp-bash-minimal-5.1.16/bin/bash
--prefix=/gnu/store/zfggiiqcxwzb5v48fb6cjkznvcwa12v8-emacs-next-pgtk-git.2117490
--enable-fast-install --with-pgtk --with-cairo --with-modules
--with-native-compilation=aot --disable-build-details'

[0001-Fix-CBZ-file-detection-in-doc-view-mode.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Morgan.J.Smith <at> outlook.com, 67133-done <at> debbugs.gnu.org
Subject: Re: bug#67133: [PATCH] Fix CBZ file detection in doc-view-mode
Date: Wed, 15 Nov 2023 19:10:03 +0200

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> Date: Wed, 15 Nov 2023 16:43:53 +0100
> 
> Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:
> 
> Hi Morgan & Eli,
> 
> > Tags: patch
> >
> > When opening a CBZ file I get the message "doc-view-set-doc-type:
> > Conflicting types: name says (cbz) but content says (epub odf)".
> 
> I approve this patch.  Feel free to commit it where you see fit.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.