GNU bug report logs - #67118
[PATCH] Change "tabulation" to "tabulation character" in linter & manual

Previous Next

Full log

Message #11 received at 67118 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 67118 <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#67118] [PATCH] Change "tabulation" to "tabulation
 character" in linter & manual
Date: Sat, 13 Jan 2024 13:25:46 -0800

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> On Sat, 11 Nov 2023 at 15:54, Ian Eure <ian <at> retrospec.tv> wrote:
>
>> diff --git a/doc/guix.texi b/doc/guix.texi
>> index 94903fb5e2..6396f129a1 100644
>> --- a/doc/guix.texi
>> +++ b/doc/guix.texi
>> @@ -119,6 +119,7 @@
>>  Copyright @copyright{} 2023 Zheng Junjie@*
>>  Copyright @copyright{} 2023 Brian Cully@*
>>  Copyright @copyright{} 2023 Felix Lechner@*
>> +Copyright @copyright{} 2023 Ian Eure@*
>
> I am not sure that a oneline change implies a Copyright 
> header. :-)
>

Sure, I can remove that.


> And other change neither, I guess.
>   
>> -		     make-flags #:allow-other-keys)
>> +                     make-flags #:allow-other-keys)
>>               (define make-flags/sexp
>>                 (if (gexp? make-flags/sexp)
>>                     (gexp->approximate-sexp make-flags)
>>                     make-flags))
>> -	     ;; Some packages like 'tzdata' are never 
>> cross-compiled;
>> -	     ;; the compilers are only used to build tools for
>> -	     ;; compiling the rest of the package.
>> -	     (if (eq? target '#false)
>> -		 '()
>> -		 (find-incorrect-compilers make-flags/sexp)))
>> +             ;; Some packages like 'tzdata' are never 
>> cross-compiled;
>> +             ;; the compilers are only used to build tools for
>> +             ;; compiling the rest of the package.
>> +             (if (eq? target '#false)
>> +                 '()
>> +                 (find-incorrect-compilers make-flags/sexp)))
>>             (package-arguments package))))
>
> There is no change here, right?
>

I believe the whitespace changes were a result of running `guix 
style' or similar, I definitely didn’t intend for the patch to 
contain all that.  I’ll back those out and send a new one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.