From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Denis Zubarev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 23:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 67117@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169974599112230 (code B ref -1); Sat, 11 Nov 2023 23:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2023 23:39:51 +0000 Received: from localhost ([127.0.0.1]:54658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xZv-0003BA-14 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 18:39:51 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xZt-0003As-RX for submit@debbugs.gnu.org; Sat, 11 Nov 2023 18:39:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1xYu-0004UV-3c for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:38:50 -0500 Received: from forward100c.mail.yandex.net ([178.154.239.211]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1xYp-000855-92 for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:38:45 -0500 Received: from mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:2087:0:640:7bf5:0]) by forward100c.mail.yandex.net (Yandex) with ESMTP id 65B9E60917 for ; Sun, 12 Nov 2023 02:38:39 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id ccqrv9QSruQ0-RNtiU6kR; Sun, 12 Nov 2023 02:38:39 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1699745919; bh=RGeyzpKkrW0/YXwKmGxjyZPboqOEXsdP9CLu3v+OaqE=; h=Message-ID:Date:Subject:To:From; b=ZsaRlMwWRE/j3NY9+k5IwBaqwwogVNB/zBPCKKrMUNrr+jzdd5E+oCGPRpY04iLcT AAOa9TOEy1FwuhlyhKLN+JDlwUB2AwT/bzDOvsWQGLH+lKGi1EPaXGP3pvsv77GANX z4eYTD3CLJrAPV2nyNQMZiz5LYFbdAaZy3Ar3Im0= Authentication-Results: mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Denis Zubarev Date: Sun, 12 Nov 2023 02:38:33 +0300 Message-ID: <87h6lruah2.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.154.239.211; envelope-from=dvzubarev@yandex.ru; helo=forward100c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch Steps to reproduce the issue: 1. emacs -Q 2. M-x find-file /tmp/t.py 3. paste to the buffer Temp(1, 2) Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dvzubarev[at]yandex.ru) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Steps to reproduce the issue: 1. emacs -Q 2. M-x find-file /tmp/t.py 3. paste to the buffer Temp(1, 2) 4. M-x python-ts-mode 5. Call search-subtree with backward flag M-x eval-expression (treesit-search-subtree (treesit--thing-at (point) "call") (lambda (n) (equal (treesit-node-type n ) "integer")) t) It should return the second int node (#), but it returns nil. I fixed it in treesit_traverse_child_helper. Do not call treesit_traverse_sibling_helper when the named node is required and the last child is the named node. Otherwise treesit_traverse_sibling_helper will move cursor to the previous sibling and the last node will be skipped. I've added test for this bug. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-11-12 built on NUC-here Repository revision: 400a71b8f2c5a49dce4f542adfd2fdb59eb34243 Repository branch: search-subtree-bacward-fix Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --with-modules --with-native-compilation=aot --with-imagemagick --with-json --with-tree-sitter --with-xft' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-an-issue-when-searching-subtree-backward.patch >From 88e913940cdd3c82afbdf2ad6520e1a1b9c2797b Mon Sep 17 00:00:00 2001 From: Denis Zubarev Date: Sun, 12 Nov 2023 01:42:42 +0300 Subject: [PATCH] Fix an issue when searching subtree backward * src/treesit.c (treesit_traverse_child_helper): Do not call treesit_traverse_sibling_helper when the named node is required and the last child is the named node. Otherwise treesit_traverse_sibling_helper will move cursor to the previous sibling and last node will be skipped. * test/src/treesit-tests.el (treesit-search-subtree-forward-1): (treesit-search-subtree-backward-1): Add tests --- src/treesit.c | 4 ++-- test/src/treesit-tests.el | 30 ++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/treesit.c b/src/treesit.c index 69b59fca11..4dcad751f4 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -3247,9 +3247,9 @@ treesit_traverse_child_helper (TSTreeCursor *cursor, /* First go to the last child. */ while (ts_tree_cursor_goto_next_sibling (cursor)); - if (!named) + if (!named || (named && ts_node_is_named (ts_tree_cursor_current_node(cursor)))) return true; - /* Else named... */ + /* Else named is required and last child is not named node */ if (treesit_traverse_sibling_helper(cursor, false, true)) return true; else diff --git a/test/src/treesit-tests.el b/test/src/treesit-tests.el index 791e902bd0..c9b15c618c 100644 --- a/test/src/treesit-tests.el +++ b/test/src/treesit-tests.el @@ -1167,6 +1167,36 @@ treesit-defun-navigation-top-level treesit--ert-defun-navigation-top-level-master 'top-level)) +(ert-deftest treesit-search-subtree-forward-1 () + "Test search subtree forward." + (skip-unless (treesit-language-available-p 'python)) + (require 'python) + (python-ts-mode) + (insert "Temp(1, 2)") + (goto-char (point-min)) + (let ((node (treesit-search-subtree + (treesit--thing-at (point) "call") + (lambda (n) (equal (treesit-node-type n ) "integer"))))) + + (should node) + (should (equal (treesit-node-text node) "1")))) + +(ert-deftest treesit-search-subtree-backward-1 () + "Test search subtree with backward=t." + (skip-unless (treesit-language-available-p 'python)) + (require 'python) + (python-ts-mode) + (insert "Temp(1, 2)") + (goto-char (point-min)) + (let ((node (treesit-search-subtree + (treesit--thing-at (point) "call") + (lambda (n) (equal (treesit-node-type n ) "integer")) + t))) + + (should node) + (should (equal (treesit-node-text node) "2")))) + + ;; TODO ;; - Functions in treesit.el ;; - treesit-load-name-override-list -- 2.34.1 --=-=-=-- From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 16:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Denis Zubarev , Yuan Fu Cc: 67117@debbugs.gnu.org Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17000656878168 (code B ref 67117); Wed, 15 Nov 2023 16:29:03 +0000 Received: (at 67117) by debbugs.gnu.org; 15 Nov 2023 16:28:07 +0000 Received: from localhost ([127.0.0.1]:53114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkI-00027a-Lx for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQc-0001QS-UT for 67117@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3FqL-0003M3-Qb; Wed, 15 Nov 2023 08:22:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ui7EUguTunVn+uiTlTg4770I3UHS8zk+i3c1emQGPlw=; b=EXFpj2quaBA0 llE+5SGtXhph1faOW82Vw8aMKKbA5jCuaQ98O0nGZ3ci2OPAaipIFkQL0ir2j3X9i82bZt5uPaATu OKqF/CrC6lCELaSvs2/0MZXNFo3Ef2NnvJZ81z2tImnFV0cf4tLLuDjOjwwvbRTQWyVBtMXLQEFyD /KLDOkeaCA83i10QkWEvH9eF3rLmnAneLSwnQWX+/KEdL7gNIwWd98g4gPddmQzfDb9RDdb2knaH0 bFfrMR32xqqDgJ0eokjdMgG5zqTt5SX5zNESvAWifmNVrnGpn9uIYG98oMxOshW5fhfY4Ih05D4n1 fnmIgNLxreS1Zim6TMZ/Pw==; Date: Wed, 15 Nov 2023 15:21:59 +0200 Message-Id: <83y1ezqhhk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h6lruah2.fsf@yandex.ru> (message from Denis Zubarev on Sun, 12 Nov 2023 02:38:33 +0300) References: <87h6lruah2.fsf@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Denis Zubarev > Date: Sun, 12 Nov 2023 02:38:33 +0300 > > Steps to reproduce the issue: > 1. emacs -Q > 2. M-x find-file /tmp/t.py > 3. paste to the buffer > > Temp(1, 2) > > 4. M-x python-ts-mode > 5. Call search-subtree with backward flag > M-x eval-expression (treesit-search-subtree > (treesit--thing-at (point) "call") > (lambda (n) (equal (treesit-node-type n ) "integer")) > t) > It should return the second int node (#), but it returns nil. Yuan, any comments to the patch and the issue in general? Denis, your changes are too large for us to accept them without a copyright assignment. Would you like to start your assignment paperwork at this time, so that we could accept this contribution, and all your future ones? Thanks. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: dvzubarev@yandex.ru Cc: 67117@debbugs.gnu.org, casouri@gmail.com Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170006770922933 (code B ref 67117); Wed, 15 Nov 2023 17:02:02 +0000 Received: (at 67117) by debbugs.gnu.org; 15 Nov 2023 17:01:49 +0000 Received: from localhost ([127.0.0.1]:53328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3JGv-0005xo-91 for submit@debbugs.gnu.org; Wed, 15 Nov 2023 12:01:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3JGt-0005xY-JL for 67117@debbugs.gnu.org; Wed, 15 Nov 2023 12:01:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3JGo-0002hM-ML; Wed, 15 Nov 2023 12:01:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JeX1G5VBK5gpcw6VYTg3UYuSYTVf4+OV8B98Gq6QqAA=; b=e6vjsF+SczUl rxEYl2Zf92hgwAzcNV1VlRU5RFqmR9gGZOVX9+tIPoiw3L/BeiCb4nIns+Zgj+Lw/1xL9nylJEiYp w4jjkVpQFo0/ylC2XVNfo/7CDEzlcz9HU4hE/zXDKUgU+o2mBxgFqdVMyQyxeRgLpz0HyIxGr85a1 Dh+vaMbWMvQ98uiN40l4TuJeohwWE9WcsVov1OWmmqa58RrOvN5xBeHmYscN9TRvAvHRCIXALpowz RAJYX7Zlf6EZWoQhXTVUZI57Y56nE37pYGSEw++RJBFCJZ3etr12O91h5kAcX3CNgzm7ijSdduQAY IHCeucn55E28BNqjCbwciw==; Date: Wed, 15 Nov 2023 19:01:28 +0200 Message-Id: <83fs17q7br.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <83y1ezqhhk.fsf@gnu.org> (message from Eli Zaretskii on Wed, 15 Nov 2023 15:21:59 +0200) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67117@debbugs.gnu.org > Date: Wed, 15 Nov 2023 15:21:59 +0200 > From: Eli Zaretskii > > Denis, your changes are too large for us to accept them without a > copyright assignment. Would you like to start your assignment > paperwork at this time, so that we could accept this contribution, and > all your future ones? Oops, I see that you already started the paperwork. So let's wait for it to run to completion. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2023 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 67117@debbugs.gnu.org, Denis Zubarev Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17003332942629 (code B ref 67117); Sat, 18 Nov 2023 18:49:02 +0000 Received: (at 67117) by debbugs.gnu.org; 18 Nov 2023 18:48:14 +0000 Received: from localhost ([127.0.0.1]:49521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4QMW-0000gA-3g for submit@debbugs.gnu.org; Sat, 18 Nov 2023 13:48:13 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:42229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4QMQ-0000em-Ap for 67117@debbugs.gnu.org; Sat, 18 Nov 2023 13:48:10 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1ce618b7919so10412645ad.0 for <67117@debbugs.gnu.org>; Sat, 18 Nov 2023 10:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700333279; x=1700938079; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gg6GJJzZ4S0cCdwn0z24CEOxCkHZCWWl12wwaMwLkuQ=; b=cMKfQe31X92lWr1HD31ObG/vLwEh8LB/5nLnAtahpfAAPeBKAI4z16g3girMQ3wdHl xcetrAP60HMebsxO3O5bi0K04uX+X5QjC9p+lmFF9aOtCdQMj0mi5DQ9tyxpd4Ja3Ovw x/hxHmP96dzmhgiOjidzBz/MWuqMeFCHQr8kVcHku/KL/Vh5cUEA0daMkRjMWd7F7UUp JJTJBRiGxgwIJ9/g3mJVwr3tkgq0ZPYgh6CjOSCbBznXMrH8MIJWCfC9SqIPniEZpnBj hrxn5QB+gZsQi7Yht8W2hsNCgk7jXOmak0hWrj++mfRHZYYZW17ctCzcCFgTT+Ol1xb5 BxDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700333279; x=1700938079; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gg6GJJzZ4S0cCdwn0z24CEOxCkHZCWWl12wwaMwLkuQ=; b=iVISn8i1pBg/TtpMHPDvlZ0oxwqyVDnEdVocGKzDNKD9Alv+SYgtfnCYQx3HqjVN4C AxZO6unKWwODxzxmRVw75HP0jkhRE6Pkw+Zpba8/W1Brx5ajtzG8KeXC8BZ+bM83LN30 fGBxSWt//GEgKRVo+Ybvh+cKNecZ5879bzo8X/AnGMTdeXYXqT1kqHsieSkZhrQLw3Aa dQiauJz+C1nxMT2afLNSjpqXiOoTHGdKI6XZQarxUQwuRiftDVaQ/fkss2NBCeLuiQd1 zOZKaismt39DoTDD0z2xaXS2V18Cf1VX164Sas+sSwH9slLdr+fe9pm0C6gRnq1NK19F 2DtQ== X-Gm-Message-State: AOJu0YwJDaoip9KlOL72uwBGfP0FkTDZJ81mQtPYasTSNw1JqsVEIfW0 EJGIpAIiwuWo8sO/4U3gQPM= X-Google-Smtp-Source: AGHT+IHHDP0wnXwE59G/H07sO0VhOxX21qUNV7ow8F0YHZSGEyJ4pX22RUH41UsaPC6ya1apYVKSsA== X-Received: by 2002:a17:902:db07:b0:1c7:5776:a30f with SMTP id m7-20020a170902db0700b001c75776a30fmr3825742plx.12.1700333279360; Sat, 18 Nov 2023 10:47:59 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j21-20020a170902759500b001cf57ea953csm306581pll.290.2023.11.18.10.47.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 10:47:58 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <83y1ezqhhk.fsf@gnu.org> Date: Sat, 18 Nov 2023 10:47:47 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 15, 2023, at 5:21 AM, Eli Zaretskii wrote: >=20 >> From: Denis Zubarev >> Date: Sun, 12 Nov 2023 02:38:33 +0300 >>=20 >> Steps to reproduce the issue: >> 1. emacs -Q >> 2. M-x find-file /tmp/t.py >> 3. paste to the buffer >>=20 >> Temp(1, 2)=20 >>=20 >> 4. M-x python-ts-mode >> 5. Call search-subtree with backward flag >> M-x eval-expression (treesit-search-subtree >> (treesit--thing-at (point) "call") >> (lambda (n) (equal (treesit-node-type n ) "integer")) >> t) >> It should return the second int node (#), but it returns nil. >=20 > Yuan, any comments to the patch and the issue in general? LGTM. Thanks Denis, and Eli :-) Yuan= From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 05:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17003728645528 (code B ref 67117); Sun, 19 Nov 2023 05:48:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 05:47:44 +0000 Received: from localhost ([127.0.0.1]:49767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4aek-0001R0-V9 for submit@debbugs.gnu.org; Sun, 19 Nov 2023 00:47:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4aej-0001QY-2o for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 00:47:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4aec-0006oh-8z; Sun, 19 Nov 2023 00:47:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v5x5u8l7Q2x0iUMmhL7Ufj1J/4ZRA8OQrqOhAGHCMIc=; b=OjOYe7vbpi0D Y74/N+VtgqMGVCm29SG2XhLokunVgylQ+JGEHUZZnEE6jHPmm2/om582o9thFq3tXnDyhkQPuMQxb WmPx0rHI78IuYN3FVMJRjCxQjblhnDopcQT1KMFswGysbDA0HqzmEUAnfA3mUVs/Rp2Bj6SEfKQRK UMrcwCAhOl06KOeAo8A4lIdOkxyEg63kWRxjQjR8pmFkY+0n3Kv+MNC+faIeeEbyNXA9cckAldhoT UnBl01ej1nqHvdoirgUikaXaZzzK+wl7ug5t/XCbTGsq5JzMHJ7dVZZDwiQ8RMwRzqRu+5o2GhyKV KvALwpfPk5cAwAVok1+QdA==; Date: Sun, 19 Nov 2023 07:47:13 +0200 Message-Id: <831qcmmh0e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> (message from Yuan Fu on Sat, 18 Nov 2023 10:47:47 -0800) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 18 Nov 2023 10:47:47 -0800 > Cc: Denis Zubarev , > 67117@debbugs.gnu.org > > > >> Steps to reproduce the issue: > >> 1. emacs -Q > >> 2. M-x find-file /tmp/t.py > >> 3. paste to the buffer > >> > >> Temp(1, 2) > >> > >> 4. M-x python-ts-mode > >> 5. Call search-subtree with backward flag > >> M-x eval-expression (treesit-search-subtree > >> (treesit--thing-at (point) "call") > >> (lambda (n) (equal (treesit-node-type n ) "integer")) > >> t) > >> It should return the second int node (#), but it returns nil. > > > > Yuan, any comments to the patch and the issue in general? > > LGTM. Thanks Denis, and Eli :-) Should we install this on the emacs-29 branch or on master? From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 06:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17003744519369 (code B ref 67117); Sun, 19 Nov 2023 06:15:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 06:14:11 +0000 Received: from localhost ([127.0.0.1]:49801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4b4N-0002R3-Gv for submit@debbugs.gnu.org; Sun, 19 Nov 2023 01:14:11 -0500 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]:46342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4b4K-0002Qj-R6 for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 01:14:10 -0500 Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3b6ce6fac81so2210822b6e.1 for <67117@debbugs.gnu.org>; Sat, 18 Nov 2023 22:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700374442; x=1700979242; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=suGCEoyWkcYjmah6kgM1+fR0q9bAkGqeef4oSblnVhQ=; b=KQdV7+YfiIUhgzM8tDPkff1cXRm+xvwG1yVXB+VVB5I+EXJAriE9YrvstFiDOfNqhf vbZ3KkTLC5Mh3wG+2EJPlV9pC2ppbBMalhQ1YxRpj/qoGjpzuolui55+p6G7HtfyCgKu wfTqmLxUD57Gmvq7YNxDRbEesnbjGn38VhrfhWzNxPvpm7aeEiB5wVpMcT/t/hk3Kjc8 dzCp9dXEr/N0bQrTc/3RrMzTELmhmE52ymuDkQhz7XutJ3ESyciBTY22KpDzjhPvjAPf B1ryXaNlWAiHBqPgiUkccy3uASEvw3sFXDA0Vht1z+ZOHP4Y/SJFtIyVERX1MzmSo0ZF PTrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700374442; x=1700979242; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suGCEoyWkcYjmah6kgM1+fR0q9bAkGqeef4oSblnVhQ=; b=KbPNqi/AaQ2etBNI1c7vBYdI70m5OVuB+IJNZ8BORLRHeap0bKqNHdck84Q+iNleme M5d88i/pGtSe78W8sZOILhtPTRiSoAtFwht8AhqX4Tvt0/al5hpMT/KQX0tH8VTQ8ci5 a8q7gI2ZZjcxsBabDptQcmVRMkBJgmfewK55zGZ2znBiTWgjl6ZLIPgCK1qvE2AAK5T5 WKx/thMw/ujCk0P7gVNZVHURU5XwnQZ7lcfz2aHSZAHOocFZGQnclMYsyEB2/J7lWshJ Xxt4461es9IWv+Iz3imUNCR5bkom003+RFT0lfKTP04WBLMQQyqQ9YrA1wMp/+ep1Yja Ls5w== X-Gm-Message-State: AOJu0Yx7CL2nfkNmGPlR3/uAs421VxaKsTl3X+dxX8cySToBoXqXf4sW gMNUj63cQGxlM2zxl8dvlH4= X-Google-Smtp-Source: AGHT+IHbEBF87C34u4PJPLrvV0t2Ottd3YJKmgatHwndKhp1OZIoWZsGovZWahk3YQJuryq4IAKS/A== X-Received: by 2002:a05:6808:3026:b0:3b6:cd77:552e with SMTP id ay38-20020a056808302600b003b6cd77552emr5633679oib.10.1700374441911; Sat, 18 Nov 2023 22:14:01 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id c3-20020aa781c3000000b006cb7b0c2503sm569659pfn.95.2023.11.18.22.14.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 22:14:01 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <831qcmmh0e.fsf@gnu.org> Date: Sat, 18 Nov 2023 22:13:49 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 18, 2023, at 9:47 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 18 Nov 2023 10:47:47 -0800 >> Cc: Denis Zubarev , >> 67117@debbugs.gnu.org >>=20 >>=20 >>>> Steps to reproduce the issue: >>>> 1. emacs -Q >>>> 2. M-x find-file /tmp/t.py >>>> 3. paste to the buffer >>>>=20 >>>> Temp(1, 2)=20 >>>>=20 >>>> 4. M-x python-ts-mode >>>> 5. Call search-subtree with backward flag >>>> M-x eval-expression (treesit-search-subtree >>>> (treesit--thing-at (point) "call") >>>> (lambda (n) (equal (treesit-node-type n ) "integer")) >>>> t) >>>> It should return the second int node (#), but it returns nil. >>>=20 >>> Yuan, any comments to the patch and the issue in general? >>=20 >> LGTM. Thanks Denis, and Eli :-) >=20 > Should we install this on the emacs-29 branch or on master? Emacs-29, I=E2=80=99d say, since it=E2=80=99s a bug fix. Why do you ask? Yuan From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170037608123158 (code B ref 67117); Sun, 19 Nov 2023 06:42:02 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 06:41:21 +0000 Received: from localhost ([127.0.0.1]:49819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4bUe-00061S-Sc for submit@debbugs.gnu.org; Sun, 19 Nov 2023 01:41:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4bUc-00061B-Og for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 01:41:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4bUV-00031O-HD; Sun, 19 Nov 2023 01:41:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8HdgjnSxAInC1UmDuvkTMA7BikKKaXpPK2W5E5Z7aes=; b=OT1Z/li6LH6C4B9OWa75 cMaQ6EhrDuKnA+Oc6x42Q9NOWBgknt0xBae/CopKrBCZTG27TjOnWVARITmDgGx9LKelQB1l+Uxsq +eLRznALu8QyVH8h7OhUZQ1eS1lYEEKcwrF+wCBEwnMLtRngJWnpkMzDr48qyHr8KHSQ2oMgUYNux UmdyQxc3y8ITZyTAW21XOjnZ3S8T/nT5D3bXy4WN2oriko5OU9qETpQ3wWvwVqu9Zpv7JrIJVqzOW 9RmMgI6w9VOKqz0wv5sDziPqMdN4v8FUCL8CEQM7jqM+fdTNX96xrBwIaMWYilGCGBZ5+UJjCMLJJ LRJcPvZ441XiKw==; Date: Sun, 19 Nov 2023 08:40:51 +0200 Message-Id: <83jzqekzyk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> (message from Yuan Fu on Sat, 18 Nov 2023 22:13:49 -0800) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 18 Nov 2023 22:13:49 -0800 > Cc: dvzubarev@yandex.ru, > 67117@debbugs.gnu.org > > > > > On Nov 18, 2023, at 9:47 PM, Eli Zaretskii wrote: > > > >> From: Yuan Fu > >> Date: Sat, 18 Nov 2023 10:47:47 -0800 > >> Cc: Denis Zubarev , > >> 67117@debbugs.gnu.org > >> > >> > >>>> Steps to reproduce the issue: > >>>> 1. emacs -Q > >>>> 2. M-x find-file /tmp/t.py > >>>> 3. paste to the buffer > >>>> > >>>> Temp(1, 2) > >>>> > >>>> 4. M-x python-ts-mode > >>>> 5. Call search-subtree with backward flag > >>>> M-x eval-expression (treesit-search-subtree > >>>> (treesit--thing-at (point) "call") > >>>> (lambda (n) (equal (treesit-node-type n ) "integer")) > >>>> t) > >>>> It should return the second int node (#), but it returns nil. > >>> > >>> Yuan, any comments to the patch and the issue in general? > >> > >> LGTM. Thanks Denis, and Eli :-) > > > > Should we install this on the emacs-29 branch or on master? > > Emacs-29, I’d say, since it’s a bug fix. Why do you ask? Because I want to install it, obviously. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: dvzubarev@yandex.ru, Yuan Fu Cc: 67117@debbugs.gnu.org Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170038538518572 (code B ref 67117); Sun, 19 Nov 2023 09:17:02 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 09:16:25 +0000 Received: from localhost ([127.0.0.1]:49933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4duj-0004pU-Cg for submit@debbugs.gnu.org; Sun, 19 Nov 2023 04:16:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4duh-0004pG-P0 for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 04:16:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4dua-0005sm-Sx; Sun, 19 Nov 2023 04:16:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=42kX4se2DAc5/CHOlZB6Y1HTYfQOwLe5ISN3Q13s+H4=; b=Pz/PIJ39FfnQmzc+orcY xVVtL6PsYbocJ00/luKwVopvqN96gX6WiObOIBZ3Y4dql/G6vGtf19idMB/XNDvamxkS6IkWTQzr4 pIn+mjeyqrKvfXsoVJE8g6oDPTPtThfCLtwyoLgWIrVT16F2Ki6FpcbPW5fYUZLIwMj4sWfwbfhS/ G4WevkXjKqv6IpqyY3CuMpufRw50p4/g7/TLuO7xCfmZg70ZEc3EH+Gb9x95lYXjY//dc4V656c4b z6QrFzkVdf7P0iz8UlJkkqDENq70chUKOpLg0TuVQ/DvUXAoQ2L5Nv0GGNMESfcFlRX5i50Q+ymEr ioglsJGLTpnotw==; Date: Sun, 19 Nov 2023 11:15:58 +0200 Message-Id: <838r6ukss1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> (message from Yuan Fu on Sat, 18 Nov 2023 22:13:49 -0800) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 18 Nov 2023 22:13:49 -0800 > Cc: dvzubarev@yandex.ru, > 67117@debbugs.gnu.org > > > > > On Nov 18, 2023, at 9:47 PM, Eli Zaretskii wrote: > > > >> From: Yuan Fu > >> Date: Sat, 18 Nov 2023 10:47:47 -0800 > >> Cc: Denis Zubarev , > >> 67117@debbugs.gnu.org > >> > >> > >>>> Steps to reproduce the issue: > >>>> 1. emacs -Q > >>>> 2. M-x find-file /tmp/t.py > >>>> 3. paste to the buffer > >>>> > >>>> Temp(1, 2) > >>>> > >>>> 4. M-x python-ts-mode > >>>> 5. Call search-subtree with backward flag > >>>> M-x eval-expression (treesit-search-subtree > >>>> (treesit--thing-at (point) "call") > >>>> (lambda (n) (equal (treesit-node-type n ) "integer")) > >>>> t) > >>>> It should return the second int node (#), but it returns nil. > >>> > >>> Yuan, any comments to the patch and the issue in general? > >> > >> LGTM. Thanks Denis, and Eli :-) > > > > Should we install this on the emacs-29 branch or on master? > > Emacs-29, I’d say, since it’s a bug fix. I see that the added tests use treesit--thing-at, which is not available on the emacs-29 branch. So either we install the tests on master, or we replace treesit--thing-at in the tests with its body. WDYT? From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Denis Zubarev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 11:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Yuan Fu Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org> Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.1700393128432 (code B ref 67117); Sun, 19 Nov 2023 11:26:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 11:25:28 +0000 Received: from localhost ([127.0.0.1]:50117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4fvb-00006p-62 for submit@debbugs.gnu.org; Sun, 19 Nov 2023 06:25:27 -0500 Received: from forward100a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:d100]:49548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4fvW-00005p-UE for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 06:25:25 -0500 Received: from mail-nwsmtp-mxback-production-main-70.vla.yp-c.yandex.net (mail-nwsmtp-mxback-production-main-70.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:121:0:640:55a5:0]) by forward100a.mail.yandex.net (Yandex) with ESMTP id E4F3046CED; Sun, 19 Nov 2023 14:25:14 +0300 (MSK) Received: from mail.yandex.ru (2a02:6b8:c1f:1284:0:640:3d6a:0 [2a02:6b8:c1f:1284:0:640:3d6a:0]) by mail-nwsmtp-mxback-production-main-70.vla.yp-c.yandex.net (mxback/Yandex) with HTTP id fOJI8m35amI0-gZq7Ov2j; Sun, 19 Nov 2023 14:25:14 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1700393114; bh=BXNSGvgbSz18cC1BtkfevIDUNE8oaUk26lYai8VM3lc=; h=Message-Id:References:Date:Cc:Subject:In-Reply-To:To:From; b=FJ5lTV6IB5vJD9lJAG4eNigLDnPhEqduEgfh6mIxpF2cXQ+GVZOgteaWpiBIFplS6 FfZkPgzLo73vHt+FD+RGva4jf6IQtIVkizeTWA5f9uK9ETf43lde0PhF+hcLOhJ+P2 rwCfea6XWtNPCJw661RbbM+rltbczceyhWwQsHIM= Authentication-Results: mail-nwsmtp-mxback-production-main-70.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by keakpixodwq4ggpb.vla.yp-c.yandex.net with HTTP; Sun, 19 Nov 2023 14:25:14 +0300 From: Denis Zubarev In-Reply-To: <838r6ukss1.fsf@gnu.org> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sun, 19 Nov 2023 14:25:14 +0300 Message-Id: <87051700392856@mail.yandex.ru> Content-Type: multipart/mixed; boundary="----==--bound.283064.keakpixodwq4ggpb.vla.yp-c.yandex.net" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------==--bound.283064.keakpixodwq4ggpb.vla.yp-c.yandex.net Content-Transfer-Encoding: base64 Content-Type: text/html; charset=utf-8 PGRpdj5JIHJlcGxhY2VkIHVzZSBvZiBgdHJlZXNpdC0tdGhpbmctYXRgIHdpdGggYHRyZWVzaXQt cXVlcnktY2FwdHVyZWAsIHNvIGl0IHNob3VsZCBiZSBjb21wYXRpYmxlIHdpdGggZW1hY3MtMjk8 L2Rpdj48ZGl2PsKgPC9kaXY+PGRpdj4xOS4xMS4yMDIzLCAxMjoxNiwgIkVsaSBaYXJldHNraWki ICZsdDtlbGl6QGdudS5vcmcmZ3Q7OjwvZGl2PjxibG9ja3F1b3RlPjxibG9ja3F1b3RlPsKgRnJv bTogWXVhbiBGdSAmbHQ7PGEgaHJlZj0ibWFpbHRvOmNhc291cmlAZ21haWwuY29tIiByZWw9Im5v b3BlbmVyIG5vcmVmZXJyZXIiPmNhc291cmlAZ21haWwuY29tPC9hPiZndDs8YnIgLz7CoERhdGU6 IFNhdCwgMTggTm92IDIwMjMgMjI6MTM6NDkgLTA4MDA8YnIgLz7CoENjOiA8YSBocmVmPSJtYWls dG86ZHZ6dWJhcmV2QHlhbmRleC5ydSIgcmVsPSJub29wZW5lciBub3JlZmVycmVyIj5kdnp1YmFy ZXZAeWFuZGV4LnJ1PC9hPiw8YnIgLz7CoMKgPGEgaHJlZj0ibWFpbHRvOjY3MTE3QGRlYmJ1Z3Mu Z251Lm9yZyIgcmVsPSJub29wZW5lciBub3JlZmVycmVyIj42NzExN0BkZWJidWdzLmdudS5vcmc8 L2E+PGJyIC8+wqA8YnIgLz7CoDxiciAvPsKgPGJyIC8+wqAmZ3Q7IE9uIE5vdiAxOCwgMjAyMywg YXQgOTo0NyBQTSwgRWxpIFphcmV0c2tpaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOmVsaXpAZ251Lm9y ZyIgcmVsPSJub29wZW5lciBub3JlZmVycmVyIj5lbGl6QGdudS5vcmc8L2E+Jmd0OyB3cm90ZTo8 YnIgLz7CoCZndDs8YnIgLz7CoCZndDsmZ3Q7IEZyb206IFl1YW4gRnUgJmx0OzxhIGhyZWY9Im1h aWx0bzpjYXNvdXJpQGdtYWlsLmNvbSIgcmVsPSJub29wZW5lciBub3JlZmVycmVyIj5jYXNvdXJp QGdtYWlsLmNvbTwvYT4mZ3Q7PGJyIC8+wqAmZ3Q7Jmd0OyBEYXRlOiBTYXQsIDE4IE5vdiAyMDIz IDEwOjQ3OjQ3IC0wODAwPGJyIC8+wqAmZ3Q7Jmd0OyBDYzogRGVuaXMgWnViYXJldiAmbHQ7PGEg aHJlZj0ibWFpbHRvOmR2enViYXJldkB5YW5kZXgucnUiIHJlbD0ibm9vcGVuZXIgbm9yZWZlcnJl ciI+ZHZ6dWJhcmV2QHlhbmRleC5ydTwvYT4mZ3Q7LDxiciAvPsKgJmd0OyZndDsgPGEgaHJlZj0i bWFpbHRvOjY3MTE3QGRlYmJ1Z3MuZ251Lm9yZyIgcmVsPSJub29wZW5lciBub3JlZmVycmVyIj42 NzExN0BkZWJidWdzLmdudS5vcmc8L2E+PGJyIC8+wqAmZ3Q7Jmd0OzxiciAvPsKgJmd0OyZndDs8 YnIgLz7CoCZndDsmZ3Q7Jmd0OyZndDsgU3RlcHMgdG8gcmVwcm9kdWNlIHRoZSBpc3N1ZTo8YnIg Lz7CoCZndDsmZ3Q7Jmd0OyZndDsgMS4gZW1hY3MgLVE8YnIgLz7CoCZndDsmZ3Q7Jmd0OyZndDsg Mi4gTS14IGZpbmQtZmlsZSAvdG1wL3QucHk8YnIgLz7CoCZndDsmZ3Q7Jmd0OyZndDsgMy4gcGFz dGUgdG8gdGhlIGJ1ZmZlcjxiciAvPsKgJmd0OyZndDsmZ3Q7Jmd0OzxiciAvPsKgJmd0OyZndDsm Z3Q7Jmd0OyBUZW1wKDEsIDIpPGJyIC8+wqAmZ3Q7Jmd0OyZndDsmZ3Q7PGJyIC8+wqAmZ3Q7Jmd0 OyZndDsmZ3Q7IDQuIE0teCBweXRob24tdHMtbW9kZTxiciAvPsKgJmd0OyZndDsmZ3Q7Jmd0OyA1 LiBDYWxsIHNlYXJjaC1zdWJ0cmVlIHdpdGggYmFja3dhcmQgZmxhZzxiciAvPsKgJmd0OyZndDsm Z3Q7Jmd0OyBNLXggZXZhbC1leHByZXNzaW9uICh0cmVlc2l0LXNlYXJjaC1zdWJ0cmVlPGJyIC8+ wqAmZ3Q7Jmd0OyZndDsmZ3Q7ICh0cmVlc2l0LS10aGluZy1hdCAocG9pbnQpICJjYWxsIik8YnIg Lz7CoCZndDsmZ3Q7Jmd0OyZndDsgKGxhbWJkYSAobikgKGVxdWFsICh0cmVlc2l0LW5vZGUtdHlw ZSBuICkgImludGVnZXIiKSk8YnIgLz7CoCZndDsmZ3Q7Jmd0OyZndDsgdCk8YnIgLz7CoCZndDsm Z3Q7Jmd0OyZndDsgSXQgc2hvdWxkIHJldHVybiB0aGUgc2Vjb25kIGludCBub2RlICgjJmx0O3Ry ZWVzaXQtbm9kZSBpbnRlZ2VyIGluIDktMTAmZ3Q7KSwgYnV0IGl0IHJldHVybnMgbmlsLjxiciAv PsKgJmd0OyZndDsmZ3Q7PGJyIC8+wqAmZ3Q7Jmd0OyZndDsgWXVhbiwgYW55IGNvbW1lbnRzIHRv IHRoZSBwYXRjaCBhbmQgdGhlIGlzc3VlIGluIGdlbmVyYWw/PGJyIC8+wqAmZ3Q7Jmd0OzxiciAv PsKgJmd0OyZndDsgTEdUTS4gVGhhbmtzIERlbmlzLCBhbmQgRWxpIDotKTxiciAvPsKgJmd0Ozxi ciAvPsKgJmd0OyBTaG91bGQgd2UgaW5zdGFsbCB0aGlzIG9uIHRoZSBlbWFjcy0yOSBicmFuY2gg b3Igb24gbWFzdGVyPzxiciAvPsKgPGJyIC8+wqBFbWFjcy0yOSwgSeKAmWQgc2F5LCBzaW5jZSBp dOKAmXMgYSBidWcgZml4LjwvYmxvY2txdW90ZT48cD48YnIgLz5JIHNlZSB0aGF0IHRoZSBhZGRl ZCB0ZXN0cyB1c2UgdHJlZXNpdC0tdGhpbmctYXQsIHdoaWNoIGlzIG5vdDxiciAvPmF2YWlsYWJs ZSBvbiB0aGUgZW1hY3MtMjkgYnJhbmNoLiBTbyBlaXRoZXIgd2UgaW5zdGFsbCB0aGUgdGVzdHMg b248YnIgLz5tYXN0ZXIsIG9yIHdlIHJlcGxhY2UgdHJlZXNpdC0tdGhpbmctYXQgaW4gdGhlIHRl c3RzIHdpdGggaXRzIGJvZHkuPGJyIC8+V0RZVD88L3A+PC9ibG9ja3F1b3RlPg== ------==--bound.283064.keakpixodwq4ggpb.vla.yp-c.yandex.net Content-Disposition: attachment; filename="0002-Fix-an-issue-when-searching-subtree-backward.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="0002-Fix-an-issue-when-searching-subtree-backward.patch" RnJvbSAwNDBhOGFkNzU2MjVlYTRlNDI3N2ZiY2U5MjBmODRhODNlMTUxOTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEZW5pcyBadWJhcmV2IDxkdnp1YmFyZXZAeWFuZGV4LnJ1PgpE YXRlOiBTdW4sIDEyIE5vdiAyMDIzIDAxOjQyOjQyICswMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGFuIGlzc3VlIHdoZW4gc2VhcmNoaW5nIHN1YnRyZWUgYmFja3dhcmQKCiogc3JjL3RyZWVzaXQu YyAodHJlZXNpdF90cmF2ZXJzZV9jaGlsZF9oZWxwZXIpOgpEbyBub3QgY2FsbCB0cmVlc2l0X3Ry YXZlcnNlX3NpYmxpbmdfaGVscGVyIHdoZW4gdGhlIG5hbWVkIG5vZGUgaXMKcmVxdWlyZWQgYW5k IHRoZSBsYXN0IGNoaWxkIGlzIHRoZSBuYW1lZCBub2RlLgpPdGhlcndpc2UgdHJlZXNpdF90cmF2 ZXJzZV9zaWJsaW5nX2hlbHBlciB3aWxsIG1vdmUgY3Vyc29yIHRvIHRoZQpwcmV2aW91cyBzaWJs aW5nIGFuZCBsYXN0IG5vZGUgd2lsbCBiZSBza2lwcGVkLgoqIHRlc3Qvc3JjL3RyZWVzaXQtdGVz dHMuZWwgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUtZm9yd2FyZC0xKToKKHRyZWVzaXQtc2VhcmNo LXN1YnRyZWUtYmFja3dhcmQtMSk6CkFkZCB0ZXN0cwotLS0KIHNyYy90cmVlc2l0LmMgICAgICAg ICAgICAgfCAgNCArKy0tCiB0ZXN0L3NyYy90cmVlc2l0LXRlc3RzLmVsIHwgMzQgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90cmVlc2l0LmMgYi9zcmMvdHJl ZXNpdC5jCmluZGV4IDY5YjU5ZmNhMTEuLjRkY2FkNzUxZjQgMTAwNjQ0Ci0tLSBhL3NyYy90cmVl c2l0LmMKKysrIGIvc3JjL3RyZWVzaXQuYwpAQCAtMzI0Nyw5ICszMjQ3LDkgQEAgdHJlZXNpdF90 cmF2ZXJzZV9jaGlsZF9oZWxwZXIgKFRTVHJlZUN1cnNvciAqY3Vyc29yLAogICAgICAgLyogRmly c3QgZ28gdG8gdGhlIGxhc3QgY2hpbGQuICAqLwogICAgICAgd2hpbGUgKHRzX3RyZWVfY3Vyc29y X2dvdG9fbmV4dF9zaWJsaW5nIChjdXJzb3IpKTsKIAotICAgICAgaWYgKCFuYW1lZCkKKyAgICAg IGlmICghbmFtZWQgfHwgKG5hbWVkICYmIHRzX25vZGVfaXNfbmFtZWQgKHRzX3RyZWVfY3Vyc29y X2N1cnJlbnRfbm9kZShjdXJzb3IpKSkpCiAJcmV0dXJuIHRydWU7Ci0gICAgICAvKiBFbHNlIG5h bWVkLi4uICovCisgICAgICAvKiBFbHNlIG5hbWVkIGlzIHJlcXVpcmVkIGFuZCBsYXN0IGNoaWxk IGlzIG5vdCBuYW1lZCBub2RlICovCiAgICAgICBpZiAodHJlZXNpdF90cmF2ZXJzZV9zaWJsaW5n X2hlbHBlcihjdXJzb3IsIGZhbHNlLCB0cnVlKSkKIAlyZXR1cm4gdHJ1ZTsKICAgICAgIGVsc2UK ZGlmZiAtLWdpdCBhL3Rlc3Qvc3JjL3RyZWVzaXQtdGVzdHMuZWwgYi90ZXN0L3NyYy90cmVlc2l0 LXRlc3RzLmVsCmluZGV4IDc5MWU5MDJiZDAuLjZjM2IxZWVkOTggMTAwNjQ0Ci0tLSBhL3Rlc3Qv c3JjL3RyZWVzaXQtdGVzdHMuZWwKKysrIGIvdGVzdC9zcmMvdHJlZXNpdC10ZXN0cy5lbApAQCAt MTE2Nyw2ICsxMTY3LDQwIEBAIHRyZWVzaXQtZGVmdW4tbmF2aWdhdGlvbi10b3AtbGV2ZWwKICAg IHRyZWVzaXQtLWVydC1kZWZ1bi1uYXZpZ2F0aW9uLXRvcC1sZXZlbC1tYXN0ZXIKICAgICd0b3At bGV2ZWwpKQogCisoZXJ0LWRlZnRlc3QgdHJlZXNpdC1zZWFyY2gtc3VidHJlZS1mb3J3YXJkLTEg KCkKKyAgIlRlc3Qgc2VhcmNoIHN1YnRyZWUgZm9yd2FyZC4iCisgIChza2lwLXVubGVzcyAodHJl ZXNpdC1sYW5ndWFnZS1hdmFpbGFibGUtcCAncHl0aG9uKSkKKyAgKHJlcXVpcmUgJ3B5dGhvbikK KyAgKHB5dGhvbi10cy1tb2RlKQorICAoaW5zZXJ0ICJUZW1wKDEsIDIpIikKKyAgKGdvdG8tY2hh ciAocG9pbnQtbWluKSkKKyAgKHBjYXNlLWxldCogKChgKCgsXyAuICxjYWxsLW5vZGUpKSAodHJl ZXNpdC1xdWVyeS1jYXB0dXJlICh0cmVlc2l0LWJ1ZmZlci1yb290LW5vZGUpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKChjYWxs KSBAYykpKQorICAgICAgICAgICAgICAgKG5vZGUgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUKKyAg ICAgICAgICAgICAgICAgICAgICBjYWxsLW5vZGUKKyAgICAgICAgICAgICAgICAgICAgICAobGFt YmRhIChuKSAoZXF1YWwgKHRyZWVzaXQtbm9kZS10eXBlIG4pICJpbnRlZ2VyIikpKSkpCisKKyAg ICAoc2hvdWxkIG5vZGUpCisgICAgKHNob3VsZCAoZXF1YWwgKHRyZWVzaXQtbm9kZS10ZXh0IG5v ZGUpICIxIikpKSkKKworKGVydC1kZWZ0ZXN0IHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUtYmFja3dh cmQtMSAoKQorICAiVGVzdCBzZWFyY2ggc3VidHJlZSB3aXRoIGJhY2t3YXJkPXQuIgorICAoc2tp cC11bmxlc3MgKHRyZWVzaXQtbGFuZ3VhZ2UtYXZhaWxhYmxlLXAgJ3B5dGhvbikpCisgIChyZXF1 aXJlICdweXRob24pCisgIChweXRob24tdHMtbW9kZSkKKyAgKGluc2VydCAiVGVtcCgxLCAyKSIp CisgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgIChwY2FzZS1sZXQqICgoYCgoLF8gLiAsY2Fs bC1ub2RlKSkgKHRyZWVzaXQtcXVlcnktY2FwdHVyZSAodHJlZXNpdC1idWZmZXItcm9vdC1ub2Rl KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJygoY2FsbCkgQGMpKSkKKyAgICAgICAgICAgICAgIChub2RlICh0cmVlc2l0LXNlYXJj aC1zdWJ0cmVlCisgICAgICAgICAgICAgICAgICAgICAgY2FsbC1ub2RlCisgICAgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAobikgKGVxdWFsICh0cmVlc2l0LW5vZGUtdHlwZSBuKSAiaW50ZWdl ciIpKQorICAgICAgICAgICAgICAgICAgICAgIHQpKSkKKworICAgIChzaG91bGQgbm9kZSkKKyAg ICAoc2hvdWxkIChlcXVhbCAodHJlZXNpdC1ub2RlLXRleHQgbm9kZSkgIjIiKSkpKQorCisKIDs7 IFRPRE8KIDs7IC0gRnVuY3Rpb25zIGluIHRyZWVzaXQuZWwKIDs7IC0gdHJlZXNpdC1sb2FkLW5h bWUtb3ZlcnJpZGUtbGlzdAotLSAKMi4zNC4xCgo= ------==--bound.283064.keakpixodwq4ggpb.vla.yp-c.yandex.net-- From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 11:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Denis Zubarev Cc: 67117@debbugs.gnu.org, casouri@gmail.com Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17003943333088 (code B ref 67117); Sun, 19 Nov 2023 11:46:02 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Nov 2023 11:45:33 +0000 Received: from localhost ([127.0.0.1]:50130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4gF3-0000nk-Dy for submit@debbugs.gnu.org; Sun, 19 Nov 2023 06:45:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4gF0-0000nS-D7 for 67117@debbugs.gnu.org; Sun, 19 Nov 2023 06:45:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4gEt-0006qb-Ft; Sun, 19 Nov 2023 06:45:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N5MJwU7gIjwrNJgBJ+F4qJ/Z7XkEQAqfVgcEsaecCgM=; b=E3P5wysiUxSM p7ypvbu85eZESzktsd3PVB5lk1XdEXZaFMv2mhy/BpWWZSBezt3kjNvkHeDBBCHZkRX68i/sFCoYD 95UaMY1MLa3QJ+chJp+haJt5aODJizj8q10DoPYnWJj66lvsYha0tlj2VRl+lNlOMq0frMOw2IzbT W3ibulKpp/oe6GW4kAVik6H+pZRT0iSjhbOkLCyHIooGL9S+RVaeKN6W1i0SAnA1YiSh4iewHKvYY +oP8J+o5x6erPA52ZSWX/9WuheyetbE4r640Ox8kgeCMGRBGVOq784f+kE/PLBWTM5sbusEQeFZ8Z PRFhk6z7XVIimNeF2DNyLg==; Date: Sun, 19 Nov 2023 13:45:03 +0200 Message-Id: <83zfzaj7b4.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87051700392856@mail.yandex.ru> (message from Denis Zubarev on Sun, 19 Nov 2023 14:25:14 +0300) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Denis Zubarev > Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org> > Date: Sun, 19 Nov 2023 14:25:14 +0300 > > I replaced use of `treesit--thing-at` with `treesit-query-capture`, so it should be compatible with > emacs-29 Thanks. Now we need to wait for your copyright assignment paperwork to complete, which I hope will happen soon, and then we can install the changeset. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Nov 2023 04:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17005406377223 (code B ref 67117); Tue, 21 Nov 2023 04:24:02 +0000 Received: (at 67117) by debbugs.gnu.org; 21 Nov 2023 04:23:57 +0000 Received: from localhost ([127.0.0.1]:54943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5IIn-0001sR-1x for submit@debbugs.gnu.org; Mon, 20 Nov 2023 23:23:57 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:43343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5IIk-0001sD-9I for 67117@debbugs.gnu.org; Mon, 20 Nov 2023 23:23:55 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1cf6bdf8274so4226735ad.1 for <67117@debbugs.gnu.org>; Mon, 20 Nov 2023 20:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700540626; x=1701145426; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L55zdDJSGHpWTLyES5UuutwopZhO+eQvo82atjUYTFA=; b=F7heP/6u98F7X5T5piDf19I0iPBj5+4RYzVnMLG/gDzE0NmGc8O1iRSxZqOcOQ3nVZ 1JGp/gvbbNkotw1e6NxO9KXVmaKkplbJVq21RmSi2w75ODbkermZoNRB3xnYAz7/hb/b 14W/Oxsbg4oWjg4zUcRbuB3TEusEfUImazWIkOh+hte9QRncW+Oq7uLHMWXxk7N1Gqu6 rToCMXckD++1tMVgTlGTD6PJ8y3yEgkSb0Mr3UGYvz4Q+cCENoP6YxQCYHtmx2316qKu FbUK6N3c2X/X9WjVGsHY+2VNZWc2oGG0z3gEhuBFIOxUFAIvz+WMSYujH0mnKtqHVAb1 tZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700540626; x=1701145426; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L55zdDJSGHpWTLyES5UuutwopZhO+eQvo82atjUYTFA=; b=eYOv/0cxnT+XRr9GAMASO5oRbcBMTsXmCDCTZ3afNkBZYqRYuJ4Vp4057OXVZWL7xw 0iwcfmmqbbMJNEzOX5W0RkGKaE2p3UAaAkhVod7XcCG/b7ocYNjic9uLbCp1poxZK8E6 sHOZNwmhP3ZZfjRcvR/yGSQiPF6cs88sysh6Hwo6vPyFiI4omPu9WNsTApoTMunFqUKw q76MDTvECXrk0QVkej7ezEtx9eAp2bqwu3D97QZW0+H0oxBW6rl8wywuhQJiuo9P2LVS D4LVxelP0Ycwi+bwP3mOOOrdP32X0JWipUCFjnnl41zrQPakatn9Dy4pE/HcsSjCPKRO yPVA== X-Gm-Message-State: AOJu0YzpsABjbtmOT27lYdLf0H19nmEM3VeQxXNNcljv3M8bfS/PFIFo kBSD+PqRt2XDJwL1UlU0q28= X-Google-Smtp-Source: AGHT+IFiyhKSZw3wuXp0kng/YOv9HBCyyY2p5oU0WCBDL0X/8nUPnQn/4spCkHV1UvyWkNErs7IzRQ== X-Received: by 2002:a17:902:db06:b0:1cc:47e7:5d5e with SMTP id m6-20020a170902db0600b001cc47e75d5emr2454648plx.19.1700540625793; Mon, 20 Nov 2023 20:23:45 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f14-20020a170902ce8e00b001c60c3f9508sm6830018plg.230.2023.11.20.20.23.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2023 20:23:45 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <83jzqekzyk.fsf@gnu.org> Date: Mon, 20 Nov 2023 20:23:33 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <83jzqekzyk.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 18, 2023, at 10:40 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 18 Nov 2023 22:13:49 -0800 >> Cc: dvzubarev@yandex.ru, >> 67117@debbugs.gnu.org >>=20 >>=20 >>=20 >>> On Nov 18, 2023, at 9:47 PM, Eli Zaretskii wrote: >>>=20 >>>> From: Yuan Fu >>>> Date: Sat, 18 Nov 2023 10:47:47 -0800 >>>> Cc: Denis Zubarev , >>>> 67117@debbugs.gnu.org >>>>=20 >>>>=20 >>>>>> Steps to reproduce the issue: >>>>>> 1. emacs -Q >>>>>> 2. M-x find-file /tmp/t.py >>>>>> 3. paste to the buffer >>>>>>=20 >>>>>> Temp(1, 2)=20 >>>>>>=20 >>>>>> 4. M-x python-ts-mode >>>>>> 5. Call search-subtree with backward flag >>>>>> M-x eval-expression (treesit-search-subtree >>>>>> (treesit--thing-at (point) "call") >>>>>> (lambda (n) (equal (treesit-node-type n ) "integer")) >>>>>> t) >>>>>> It should return the second int node (#), but it returns nil. >>>>>=20 >>>>> Yuan, any comments to the patch and the issue in general? >>>>=20 >>>> LGTM. Thanks Denis, and Eli :-) >>>=20 >>> Should we install this on the emacs-29 branch or on master? >>=20 >> Emacs-29, I=E2=80=99d say, since it=E2=80=99s a bug fix. Why do you = ask? >=20 > Because I want to install it, obviously. Of course ;-) I mean you are usually the people who answer this type of = questions, and our convention is to install bug fixes on emacs-29, so I = was wondering if there=E2=80=99s some other considerations that I = don=E2=80=99t know about. Yuan From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Nov 2023 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170056702721767 (code B ref 67117); Tue, 21 Nov 2023 11:44:02 +0000 Received: (at 67117) by debbugs.gnu.org; 21 Nov 2023 11:43:47 +0000 Received: from localhost ([127.0.0.1]:55290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5PAR-0005f1-0w for submit@debbugs.gnu.org; Tue, 21 Nov 2023 06:43:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5PAP-0005ej-Kc for 67117@debbugs.gnu.org; Tue, 21 Nov 2023 06:43:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5PAH-0001kW-3C; Tue, 21 Nov 2023 06:43:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=qTSfOS2CttHH9hLhUu4J7lZeBMqTyixkOZsUhqRTQfY=; b=jdGPBUzJyoNaHzkRjvrO nmgL/vLN3VZWu/zQiBQfQau6TjumwFd+p30nRxFcWanXf7qLUZFkHUs54EA0AbUuGRNUpSW6YiTW3 7W4pL4GRW8a3FdpOsryk+rA+hoiv0FK/jzqgNZn22bjy5GWh+tXofvLM85ZsBqnRN95ZXamlHPYv1 aMsdcd4digsVg0JGf+0mc6q3vvpz1eA7FDhWWfOUdAObKuYZPkFKseTURllKuVoydGGFmVqEBqxLB Xj43QX0UMcsIuMzK5iMx8nJIx8HwBiG1E9lu04d5EABp76NuAfbh8Z9rn8WDMTnTtLAJsuww9EVCZ H0bm6xpOG6Dtmw==; Date: Tue, 21 Nov 2023 13:43:10 +0200 Message-Id: <83edgjib75.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Yuan Fu on Mon, 20 Nov 2023 20:23:33 -0800) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <83jzqekzyk.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Mon, 20 Nov 2023 20:23:33 -0800 > Cc: dvzubarev@yandex.ru, > 67117@debbugs.gnu.org > > >>> Should we install this on the emacs-29 branch or on master? > >> > >> Emacs-29, I’d say, since it’s a bug fix. Why do you ask? > > > > Because I want to install it, obviously. > > Of course ;-) I mean you are usually the people who answer this type of questions, and our convention is to install bug fixes on emacs-29, so I was wondering if there’s some other considerations that I don’t know about. treesit.c and treesit.el got, and keep getting, significant changes on the master branch, so when people report bugs for Emacs 30, I cannot always be sure that the bug exists on the release branch as well, nor that the patch is appropriate for the release branch (i.e. doesn't modify code that is different on master). That's why I asked. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 03:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 67117@debbugs.gnu.org, Denis Zubarev Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170088391232484 (code B ref 67117); Sat, 25 Nov 2023 03:46:01 +0000 Received: (at 67117) by debbugs.gnu.org; 25 Nov 2023 03:45:12 +0000 Received: from localhost ([127.0.0.1]:37571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6jbT-0008Rs-R7 for submit@debbugs.gnu.org; Fri, 24 Nov 2023 22:45:12 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:48225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6jbP-0008RY-9v for 67117@debbugs.gnu.org; Fri, 24 Nov 2023 22:45:10 -0500 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cf6af8588fso20855255ad.0 for <67117@debbugs.gnu.org>; Fri, 24 Nov 2023 19:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700883896; x=1701488696; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z/W+kFLws5TpjqBI3Aj90dvYOTzJG9G6Z46g9R0Xjr4=; b=Vwfgv+ijldSf4wCOtJna9RBneb2Je0fzuvrLU6SfGjjFtXYNNAIuVONV5ahyOh0i1F hz60tcyDirMRfshgnKnQQq5TMx8EivTFttnnkdhZXFOqqCtMDiW+Vhf+GeJl52qQ8fRD 1EU++1A0Ok81w2dxyMhJv6EfiL97512SfbO/0LSnF6mq4ZopyXgLNdXjkBFZnUtr1yib d65al6c2rEGtYqPgnztW9ZqLAbyLVQ+kw6q7PLlyQa76AnOzvwIqN3b7GD+yVchCkEqs Gi/WxpJHqWV7qIPWVoFC8+ukQeC3zx3uPextJGeKCzxJfVy1GaroR8XY+qFB1NOoCYiq ojCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700883896; x=1701488696; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z/W+kFLws5TpjqBI3Aj90dvYOTzJG9G6Z46g9R0Xjr4=; b=spsaTof717FsZ3r6xgekInpqtJyEC2gYHmN1mG817xxjNtxL/39qhd+NPCD8K1ZEug AQpDiC4E4j5iN3LryUj8sGc5xPJ/6K95cOJjQjM12ez8GFIO/PPc4nYitDGXMhqcAtLv FUKj1d/iH+mzX02jK0Rc0HUdDOIC71Id+hRFGr1RF/cvn90yQes+7ApFCmRGQ4g0Of0U 5rLYdNk1h6uM7BsxsqhI2Ek0rThax8tiU/DqzRWQ8+EO3CqnE/AHQdN0gcEnOS2eocgi 5iv0+k1wGKJABqp3q7Vxo8lErp5L6vz78FGi2jCI6JwSq3vA7TwnnwrgCzbYj9SnSWwG mtoA== X-Gm-Message-State: AOJu0YzGJV9EyItMvqhsSg0c1UF5k9ZZC/84lQKouGIqsnaBvsyVArik ksxpsTE4W8GS92LPvM+Q9EI= X-Google-Smtp-Source: AGHT+IE+9C71ZE/W+wcYoAayFiMuGD9C1sxYumfro/kqNSwan2ziscOGlukanRsZzCpl7Zai12zmwg== X-Received: by 2002:a17:902:db11:b0:1cc:4559:ff with SMTP id m17-20020a170902db1100b001cc455900ffmr6783253plx.13.1700883896457; Fri, 24 Nov 2023 19:44:56 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u10-20020a17090282ca00b001cf65d03cedsm3163467plz.32.2023.11.24.19.44.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Nov 2023 19:44:56 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <83edgjib75.fsf@gnu.org> Date: Fri, 24 Nov 2023 19:44:44 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <83jzqekzyk.fsf@gnu.org> <83edgjib75.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 21, 2023, at 3:43 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Mon, 20 Nov 2023 20:23:33 -0800 >> Cc: dvzubarev@yandex.ru, >> 67117@debbugs.gnu.org >>=20 >>>>> Should we install this on the emacs-29 branch or on master? >>>>=20 >>>> Emacs-29, I=E2=80=99d say, since it=E2=80=99s a bug fix. Why do you = ask? >>>=20 >>> Because I want to install it, obviously. >>=20 >> Of course ;-) I mean you are usually the people who answer this type = of questions, and our convention is to install bug fixes on emacs-29, so = I was wondering if there=E2=80=99s some other considerations that I = don=E2=80=99t know about. >=20 > treesit.c and treesit.el got, and keep getting, significant changes on > the master branch, so when people report bugs for Emacs 30, I cannot > always be sure that the bug exists on the release branch as well, nor > that the patch is appropriate for the release branch (i.e. doesn't > modify code that is different on master). That's why I asked. Ah, right. That makes sense. Yuan= From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Denis Zubarev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 00:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org>, "casouri@gmail.com" Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170294552224677 (code B ref 67117); Tue, 19 Dec 2023 00:26:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Dec 2023 00:25:22 +0000 Received: from localhost ([127.0.0.1]:33813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFNv1-0006PZ-Pr for submit@debbugs.gnu.org; Mon, 18 Dec 2023 19:25:22 -0500 Received: from forward502c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:d502]:60552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFNuz-0006Ov-Im for 67117@debbugs.gnu.org; Mon, 18 Dec 2023 19:25:06 -0500 Received: from mail-nwsmtp-mxback-production-main-42.sas.yp-c.yandex.net (mail-nwsmtp-mxback-production-main-42.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:160a:0:640:4f97:0]) by forward502c.mail.yandex.net (Yandex) with ESMTP id 96FAE60A65; Tue, 19 Dec 2023 03:24:57 +0300 (MSK) Received: from mail.yandex.ru (2a02:6b8:c14:3e1a:0:640:5788:0 [2a02:6b8:c14:3e1a:0:640:5788:0]) by mail-nwsmtp-mxback-production-main-42.sas.yp-c.yandex.net (mxback/Yandex) with HTTP id LO9h7U8OvW20-ZDYoBniv; Tue, 19 Dec 2023 03:24:57 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1702945497; bh=by9CrL+6y/2Vfd6bhI6Q3jPy3KQtimndyY+zG10TYCU=; h=Message-Id:References:Date:Cc:Subject:In-Reply-To:To:From; b=bfEu0711s6rTTEKuuG8h8BtcyL35eHc/CRIXocjRBPKe8YtdZg+u0ad8IREHBLQty oPPZz8TnU7zpp7x275muV52rTfvlIl5mJoIoELVb4iZkI8o6lu7maY4LU+kXAANDEd YLIVJYfs9aMBdLUyrMf7Cg5uE2/LVswE0TMSBSAs= Authentication-Results: mail-nwsmtp-mxback-production-main-42.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by snc7cnj4jrqmj7vs.sas.yp-c.yandex.net with HTTP; Tue, 19 Dec 2023 03:24:57 +0300 From: Denis Zubarev In-Reply-To: <83zfzaj7b4.fsf@gnu.org> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 19 Dec 2023 03:24:57 +0300 Message-Id: <1302931702945138@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/html; charset=utf-8 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/)
Just FYI, my paperwork is done.


19.11.2023, 14:45, "Eli Zaretskii" <eliz@gnu.org>:
 From: Denis Zubarev <dvzubarev@yandex.ru>
 Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org>
 Date: Sun, 19 Nov 2023 14:25:14 +0300
 
 I replaced use of `treesit--thing-at` with `treesit-query-capture`, so it should be compatible with
 emacs-29


Thanks. Now we need to wait for your copyright assignment paperwork
to complete, which I hope will happen soon, and then we can install
the changeset.

From unknown Tue Aug 12 08:33:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Denis Zubarev Subject: bug#67117: closed (Re: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward) Message-ID: References: <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> <87h6lruah2.fsf@yandex.ru> X-Gnu-PR-Message: they-closed 67117 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 67117@debbugs.gnu.org Date: Tue, 19 Dec 2023 02:27:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1702952822-23413-1" This is a multi-part message in MIME format... ------------=_1702952822-23413-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 67117@debbugs.gnu.org. --=20 67117: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67117 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1702952822-23413-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 67117-done) by debbugs.gnu.org; 19 Dec 2023 02:26:52 +0000 Received: from localhost ([127.0.0.1]:33872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFPoq-00064y-CI for submit@debbugs.gnu.org; Mon, 18 Dec 2023 21:26:52 -0500 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:56496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFPoo-00064Y-N4 for 67117-done@debbugs.gnu.org; Mon, 18 Dec 2023 21:26:51 -0500 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6d9f7af8918so3497156a34.0 for <67117-done@debbugs.gnu.org>; Mon, 18 Dec 2023 18:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702952803; x=1703557603; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UoYv0dEZoA7Pd3rNUIe3uBOvdWToyqOYCDAnFIBdMIE=; b=ccNrK52Y5civcHyeBl8fD8QFF1qylVV1ax05H1S4UeNA+VQuimWXA6Sw5yKdasJmCl FNa+ivguhnTK1a+fWYKMInfViLTQbqeObyKbSN0F7kWQfmZRhvMRUrnw+GULoR/afP/j pynJ7I/uflu0yMg9O5qqVU4155BBmwwWUf4t+dvzd/gk3bhDUKFWjc3oA0kMbKbwNKFB ToS59ZBSoHG7j/anyqHAqULVIv4+QdI+4QNie3Grh6VszHXYwsgOsqjdQzaRUxzUTdE5 lDHUZUp1iOJFsZiDKAbpTFRA62dIntkBZiJ5hAAiUj8q34WJ5as68usxO8VsxgU8qBWM uFAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702952803; x=1703557603; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UoYv0dEZoA7Pd3rNUIe3uBOvdWToyqOYCDAnFIBdMIE=; b=XWGVjpLYkcGG2bNKnzjIyeTQkiKjA+M1Ah30lyBop4tZiff4nkRKvDUzTv29RWCpr/ dMbbtMOAI8keSqZDPPSMgB1vMD+bSoi6x+0FEOe0TAJqUNUfNt/jCL8yYTpeUP4o+YD5 IGeMNVuElVrmH0LknNb5oqbVyFqs6cfo8hrpT5MwZ6CfgmbSh2VLO5lGkgG0slzSJTLh k6+bPcmbsM0GXYDmZODKmPuZD/LTo3p6DLrF1hvcWSmpGjJEowgxQjJ2UuOxzt8mEDcN V7VRTpS0xCLSApF/qypc/Q87TZO6LbogM/qjs6d5xS/xQ9Dg9eln5kEcTVHIQQ3fu8N9 iRMQ== X-Gm-Message-State: AOJu0YzIN6kO/kiC32bgnH4gO6ep9wOgTTBCpdryDUybYzsvXxoPNf+n IAaNnn76ii0g9vpzN/CcGvU= X-Google-Smtp-Source: AGHT+IFcL13jeQRRLHmCrlH0oE0OUE+7TU0gHl3KhBa6ZpFDEzTjmKJeq1pilLCKANS4h173/g9osg== X-Received: by 2002:a05:6808:17a6:b0:3b9:de62:3738 with SMTP id bg38-20020a05680817a600b003b9de623738mr22525076oib.26.1702952802848; Mon, 18 Dec 2023 18:26:42 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id s22-20020a170902989600b001ce5b859a59sm19769480plp.305.2023.12.18.18.26.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Dec 2023 18:26:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward From: Yuan Fu In-Reply-To: <1302931702945138@mail.yandex.ru> Date: Mon, 18 Dec 2023 18:26:30 -0800 Content-Transfer-Encoding: 7bit Message-Id: <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> To: Denis Zubarev X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67117-done Cc: Eli Zaretskii , 67117-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 18, 2023, at 4:24 PM, Denis Zubarev wrote: > > Just FYI, my paperwork is done. > Great, applied! Closing this bug. Yuan ------------=_1702952822-23413-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Nov 2023 23:39:51 +0000 Received: from localhost ([127.0.0.1]:54658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xZv-0003BA-14 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 18:39:51 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xZt-0003As-RX for submit@debbugs.gnu.org; Sat, 11 Nov 2023 18:39:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1xYu-0004UV-3c for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:38:50 -0500 Received: from forward100c.mail.yandex.net ([178.154.239.211]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1xYp-000855-92 for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:38:45 -0500 Received: from mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:2087:0:640:7bf5:0]) by forward100c.mail.yandex.net (Yandex) with ESMTP id 65B9E60917 for ; Sun, 12 Nov 2023 02:38:39 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id ccqrv9QSruQ0-RNtiU6kR; Sun, 12 Nov 2023 02:38:39 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1699745919; bh=RGeyzpKkrW0/YXwKmGxjyZPboqOEXsdP9CLu3v+OaqE=; h=Message-ID:Date:Subject:To:From; b=ZsaRlMwWRE/j3NY9+k5IwBaqwwogVNB/zBPCKKrMUNrr+jzdd5E+oCGPRpY04iLcT AAOa9TOEy1FwuhlyhKLN+JDlwUB2AwT/bzDOvsWQGLH+lKGi1EPaXGP3pvsv77GANX z4eYTD3CLJrAPV2nyNQMZiz5LYFbdAaZy3Ar3Im0= Authentication-Results: mail-nwsmtp-smtp-production-main-39.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Denis Zubarev To: bug-gnu-emacs@gnu.org Subject: [PATCH] Tree-sitter: fix an issue when searching subtree backward Date: Sun, 12 Nov 2023 02:38:33 +0300 Message-ID: <87h6lruah2.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.154.239.211; envelope-from=dvzubarev@yandex.ru; helo=forward100c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch Steps to reproduce the issue: 1. emacs -Q 2. M-x find-file /tmp/t.py 3. paste to the buffer Temp(1, 2) Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dvzubarev[at]yandex.ru) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Steps to reproduce the issue: 1. emacs -Q 2. M-x find-file /tmp/t.py 3. paste to the buffer Temp(1, 2) 4. M-x python-ts-mode 5. Call search-subtree with backward flag M-x eval-expression (treesit-search-subtree (treesit--thing-at (point) "call") (lambda (n) (equal (treesit-node-type n ) "integer")) t) It should return the second int node (#), but it returns nil. I fixed it in treesit_traverse_child_helper. Do not call treesit_traverse_sibling_helper when the named node is required and the last child is the named node. Otherwise treesit_traverse_sibling_helper will move cursor to the previous sibling and the last node will be skipped. I've added test for this bug. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-11-12 built on NUC-here Repository revision: 400a71b8f2c5a49dce4f542adfd2fdb59eb34243 Repository branch: search-subtree-bacward-fix Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --with-modules --with-native-compilation=aot --with-imagemagick --with-json --with-tree-sitter --with-xft' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-an-issue-when-searching-subtree-backward.patch >From 88e913940cdd3c82afbdf2ad6520e1a1b9c2797b Mon Sep 17 00:00:00 2001 From: Denis Zubarev Date: Sun, 12 Nov 2023 01:42:42 +0300 Subject: [PATCH] Fix an issue when searching subtree backward * src/treesit.c (treesit_traverse_child_helper): Do not call treesit_traverse_sibling_helper when the named node is required and the last child is the named node. Otherwise treesit_traverse_sibling_helper will move cursor to the previous sibling and last node will be skipped. * test/src/treesit-tests.el (treesit-search-subtree-forward-1): (treesit-search-subtree-backward-1): Add tests --- src/treesit.c | 4 ++-- test/src/treesit-tests.el | 30 ++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/treesit.c b/src/treesit.c index 69b59fca11..4dcad751f4 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -3247,9 +3247,9 @@ treesit_traverse_child_helper (TSTreeCursor *cursor, /* First go to the last child. */ while (ts_tree_cursor_goto_next_sibling (cursor)); - if (!named) + if (!named || (named && ts_node_is_named (ts_tree_cursor_current_node(cursor)))) return true; - /* Else named... */ + /* Else named is required and last child is not named node */ if (treesit_traverse_sibling_helper(cursor, false, true)) return true; else diff --git a/test/src/treesit-tests.el b/test/src/treesit-tests.el index 791e902bd0..c9b15c618c 100644 --- a/test/src/treesit-tests.el +++ b/test/src/treesit-tests.el @@ -1167,6 +1167,36 @@ treesit-defun-navigation-top-level treesit--ert-defun-navigation-top-level-master 'top-level)) +(ert-deftest treesit-search-subtree-forward-1 () + "Test search subtree forward." + (skip-unless (treesit-language-available-p 'python)) + (require 'python) + (python-ts-mode) + (insert "Temp(1, 2)") + (goto-char (point-min)) + (let ((node (treesit-search-subtree + (treesit--thing-at (point) "call") + (lambda (n) (equal (treesit-node-type n ) "integer"))))) + + (should node) + (should (equal (treesit-node-text node) "1")))) + +(ert-deftest treesit-search-subtree-backward-1 () + "Test search subtree with backward=t." + (skip-unless (treesit-language-available-p 'python)) + (require 'python) + (python-ts-mode) + (insert "Temp(1, 2)") + (goto-char (point-min)) + (let ((node (treesit-search-subtree + (treesit--thing-at (point) "call") + (lambda (n) (equal (treesit-node-type n ) "integer")) + t))) + + (should node) + (should (equal (treesit-node-text node) "2")))) + + ;; TODO ;; - Functions in treesit.el ;; - treesit-load-name-override-list -- 2.34.1 --=-=-=-- ------------=_1702952822-23413-1-- From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 03:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Denis Zubarev Cc: 67117@debbugs.gnu.org, casouri@gmail.com Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.17029562809694 (code B ref 67117); Tue, 19 Dec 2023 03:25:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Dec 2023 03:24:40 +0000 Received: from localhost ([127.0.0.1]:33898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFQim-0002WG-22 for submit@debbugs.gnu.org; Mon, 18 Dec 2023 22:24:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFQij-0002Vo-CC for 67117@debbugs.gnu.org; Mon, 18 Dec 2023 22:24:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFQib-0006DG-5Q; Mon, 18 Dec 2023 22:24:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oM0+ajxe2aBVRvwBZnq0o4I46XJZ8AYcQs7HE4L7jUk=; b=rSn/SoKabOap +Dfq9WRFMoQCzzvuZC+6/l4weyRUOn0oWBpLG5fkJhUsO7V9QL3R9Zoky7ibT4XXYT1u9gwPZlxvg okJ7LB057L+NG5NBAEDyYlkEIDRROtb859s4nMRP22J+c+5MY7InxpDZKhRSYEM6bbphqSb57/Ll6 T5+6avaChf5vbCmBgvS4/9XlS23rbsdIVwfu1x3H5ZvnDU+vaf5ROYf0P/q20ie5Gj4EgVa5pJ0gs WrQqpssJFB7Tg1CJx07XPQ/OYIQ9aG97q/aYKl9QpAs9YgQ5CzHEQtK/eiFMAOhkOt64MiI8HTB7v A9SlFFo6IBgEkluQp+dMkA==; Date: Tue, 19 Dec 2023 05:24:16 +0200 Message-Id: <83msu6j2n3.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <1302931702945138@mail.yandex.ru> (message from Denis Zubarev on Tue, 19 Dec 2023 03:24:57 +0300) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Denis Zubarev > Cc: "casouri@gmail.com" , > "67117@debbugs.gnu.org" <67117@debbugs.gnu.org> > Date: Tue, 19 Dec 2023 03:24:57 +0300 > > Just FYI, my paperwork is done. Yes, I know it for quite some time. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170300479716443 (code B ref 67117); Tue, 19 Dec 2023 16:54:01 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Dec 2023 16:53:17 +0000 Received: from localhost ([127.0.0.1]:37198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdLI-0004H9-VS for submit@debbugs.gnu.org; Tue, 19 Dec 2023 11:53:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdLH-0004Gs-Ly for 67117@debbugs.gnu.org; Tue, 19 Dec 2023 11:53:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFdL9-0003Qm-6x; Tue, 19 Dec 2023 11:53:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XNQmT10jDEgocKtGCHIoWA9KnjLRh6cxjJ0UaH2SY54=; b=UD5vk+yfgHww RCmiTkVtChj7m3Ki/+b9afXRBDk7e/4b+S4Wf07RIPHwW1ZqvyUvv59Y0ftMgoTNQ5d3fb7hvHm7b zXuzxzcvMnouHDg9TGfPWkxpECcgvhKTsoLsQsFxeDVH22Wt8gJVro3w/o5CnNSh2Gix9MYO5pqVn RS1xUHpjnu5RJ2kQ3JaDYCmb7v4b9LZVVVN2XXw9NtDWZSP9pJkgXcMhc0LGmnId6/IwV6m52QTQX vtsW+jEwvlUzEB8qK6hrO1cvevNTQlEEji4F7IZl3pvwVIOUH2qKHAVsyaiiJapX8tFUW5XqBtkH4 p6V2JTI+02BBmyo6bEThrA==; Date: Tue, 19 Dec 2023 18:52:47 +0200 Message-Id: <83y1dqgmn4.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> (message from Yuan Fu on Mon, 18 Dec 2023 18:26:30 -0800) References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Mon, 18 Dec 2023 18:26:30 -0800 > Cc: Eli Zaretskii , > 67117-done@debbugs.gnu.org > > > On Dec 18, 2023, at 4:24 PM, Denis Zubarev wrote: > > > > Just FYI, my paperwork is done. > > > > Great, applied! Closing this bug. The new tests fail here: ELC src/treesit-tests.elc In end of data: src/treesit-tests.el:1094:17: Warning: the function `treesit--thing-at' is not known to be defined. [...] Test treesit-search-subtree-backward-1 backtrace: (treesit--thing-at (point) "call") (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda (let ((node (treesit-search-subtree (treesit--thing-at (point) "call (closure (t) nil (let* ((fn-621 #'treesit-language-available-p) (arg ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name treesit-search-subtree-backward-1 :do ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "-- command-line() normal-top-level() Test treesit-search-subtree-backward-1 condition: (void-function treesit--thing-at) FAILED 24/25 treesit-search-subtree-backward-1 (0.000000 sec) at src/treesit-tests.el:1100 Can't guess python-indent-offset, using defaults: 4 Test treesit-search-subtree-forward-1 backtrace: (treesit--thing-at (point) "call") (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda (let ((node (treesit-search-subtree (treesit--thing-at (point) "call (closure (t) nil (let* ((fn-609 #'treesit-language-available-p) (arg ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name treesit-search-subtree-forward-1 :doc ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "-- command-line() normal-top-level() Test treesit-search-subtree-forward-1 condition: (void-function treesit--thing-at) FAILED 25/25 treesit-search-subtree-forward-1 (0.015625 sec) at src/treesit-tests.el:1086 The function treesit--thing-at is only available on master. From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward In-Reply-To: <87h6lruah2.fsf@yandex.ru> Resent-From: Denis Zubarev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Yuan Fu Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org> Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170300569827842 (code B ref 67117); Tue, 19 Dec 2023 17:09:02 +0000 Received: (at 67117) by debbugs.gnu.org; 19 Dec 2023 17:08:18 +0000 Received: from localhost ([127.0.0.1]:37248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdZq-0007Ez-4d for submit@debbugs.gnu.org; Tue, 19 Dec 2023 12:08:18 -0500 Received: from forward502b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:d502]:39026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdZm-0007Ek-Er for 67117@debbugs.gnu.org; Tue, 19 Dec 2023 12:08:16 -0500 Received: from mail-nwsmtp-mxback-production-main-53.iva.yp-c.yandex.net (mail-nwsmtp-mxback-production-main-53.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:b812:0:640:5a61:0]) by forward502b.mail.yandex.net (Yandex) with ESMTP id 75F0B5E81B; Tue, 19 Dec 2023 20:08:05 +0300 (MSK) Received: from mail.yandex.ru (2a02:6b8:c0c:881a:0:640:988:0 [2a02:6b8:c0c:881a:0:640:988:0]) by mail-nwsmtp-mxback-production-main-53.iva.yp-c.yandex.net (mxback/Yandex) with HTTP id v7Qvef8O3mI0-A2FQZt9x; Tue, 19 Dec 2023 20:08:05 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1703005685; bh=avdgmQbazwaoczko8r96WDIYbEL9hbGW5ZXPoYvIGuQ=; h=Message-Id:Date:Subject:References:To:From:Cc; b=GUSIGnzI7GrlOiqw52kbaSuxoXvu7oFfUfv8kC2yv7i+pybVS4d3ipO+onbNdkKGA 5sHgoQMhOQ6x5OgesOodzkOiyx6oUYn+U4390g/180G8UoYjpqQiaVYy4/5Xn6GZiI Em3QB+JtTaDH3TLIJK52EkoGpmvTbOq7vZMqUG4A= Authentication-Results: mail-nwsmtp-mxback-production-main-53.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by wx7plm2fuc5lrqzd.iva.yp-c.yandex.net with HTTP; Tue, 19 Dec 2023 20:08:04 +0300 From: Denis Zubarev References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> <83y1dqgmn4.fsf@gnu.org> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 19 Dec 2023 20:08:04 +0300 Message-Id: <631791703005524@mail.yandex.ru> Content-Type: multipart/mixed; boundary="----==--bound.46275.wx7plm2fuc5lrqzd.iva.yp-c.yandex.net" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------==--bound.46275.wx7plm2fuc5lrqzd.iva.yp-c.yandex.net Content-Transfer-Encoding: base64 Content-Type: text/html; charset=utf-8 PGRpdj5JIHJlcGxhY2VkIHRyZWVzaXQtLXRoaW5nLWF0IHdpdGggdGhlIGZ1bmN0aW9uIGZyb20g ZW1hY3MgMjkuMSBpbiB0aGUgbGFzdCB2ZXJzaW9uIG9mIHRoZSBwYXRjaC48L2Rpdj48ZGl2PsKg PC9kaXY+PGRpdj5BdHRhY2hlZCBpdCBoZXJlLjwvZGl2PjxkaXY+wqA8L2Rpdj48ZGl2PsKgPC9k aXY+PGRpdj7CoDwvZGl2PjxkaXY+MTkuMTIuMjAyMywgMTk6NTMsICJFbGkgWmFyZXRza2lpIiAm bHQ7PGEgaHJlZj0ibWFpbHRvOmVsaXpAZ251Lm9yZyIgcmVsPSJub29wZW5lciBub3JlZmVycmVy Ij5lbGl6QGdudS5vcmc8L2E+Jmd0Ozo8L2Rpdj48YmxvY2txdW90ZT48YmxvY2txdW90ZT7CoEZy b206IFl1YW4gRnUgJmx0OzxhIGhyZWY9Im1haWx0bzpjYXNvdXJpQGdtYWlsLmNvbSIgcmVsPSJu b29wZW5lciBub3JlZmVycmVyIj5jYXNvdXJpQGdtYWlsLmNvbTwvYT4mZ3Q7PGJyIC8+wqBEYXRl OiBNb24sIDE4IERlYyAyMDIzIDE4OjI2OjMwIC0wODAwPGJyIC8+wqBDYzogRWxpIFphcmV0c2tp aSAmbHQ7PGEgaHJlZj0ibWFpbHRvOmVsaXpAZ251Lm9yZyIgcmVsPSJub29wZW5lciBub3JlZmVy cmVyIj5lbGl6QGdudS5vcmc8L2E+Jmd0Oyw8YnIgLz7CoMKgPGEgaHJlZj0ibWFpbHRvOjY3MTE3 LWRvbmVAZGViYnVncy5nbnUub3JnIiByZWw9Im5vb3BlbmVyIG5vcmVmZXJyZXIiPjY3MTE3LWRv bmVAZGViYnVncy5nbnUub3JnPC9hPjxiciAvPsKgPGJyIC8+wqAmZ3Q7IE9uIERlYyAxOCwgMjAy MywgYXQgNDoyNCBQTSwgRGVuaXMgWnViYXJldiAmbHQ7PGEgaHJlZj0ibWFpbHRvOmR2enViYXJl dkB5YW5kZXgucnUiIHJlbD0ibm9vcGVuZXIgbm9yZWZlcnJlciI+ZHZ6dWJhcmV2QHlhbmRleC5y dTwvYT4mZ3Q7IHdyb3RlOjxiciAvPsKgJmd0OzxiciAvPsKgJmd0OyBKdXN0IEZZSSwgbXkgcGFw ZXJ3b3JrIGlzIGRvbmUuPGJyIC8+wqAmZ3Q7PGJyIC8+wqA8YnIgLz7CoEdyZWF0LCBhcHBsaWVk ISBDbG9zaW5nIHRoaXMgYnVnLjwvYmxvY2txdW90ZT48cD48YnIgLz5UaGUgbmV3IHRlc3RzIGZh aWwgaGVyZTo8YnIgLz48YnIgLz7CoMKgwqDCoEVMQyBzcmMvdHJlZXNpdC10ZXN0cy5lbGM8YnIg Lz48YnIgLz7CoMKgSW4gZW5kIG9mIGRhdGE6PGJyIC8+wqDCoHNyYy90cmVlc2l0LXRlc3RzLmVs OjEwOTQ6MTc6IFdhcm5pbmc6IHRoZSBmdW5jdGlvbiBgdHJlZXNpdC0tdGhpbmctYXQnIGlzIG5v dCBrbm93biB0byBiZSBkZWZpbmVkLjxiciAvPsKgwqBbLi4uXTxiciAvPsKgwqBUZXN0IHRyZWVz aXQtc2VhcmNoLXN1YnRyZWUtYmFja3dhcmQtMSBiYWNrdHJhY2U6PGJyIC8+wqDCoMKgwqAodHJl ZXNpdC0tdGhpbmctYXQgKHBvaW50KSAiY2FsbCIpPGJyIC8+wqDCoMKgwqAodHJlZXNpdC1zZWFy Y2gtc3VidHJlZSAodHJlZXNpdC0tdGhpbmctYXQgKHBvaW50KSAiY2FsbCIpICMnKGxhbWJkYTxi ciAvPsKgwqDCoMKgKGxldCAoKG5vZGUgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUgKHRyZWVzaXQt LXRoaW5nLWF0IChwb2ludCkgImNhbGw8YnIgLz7CoMKgwqDCoChjbG9zdXJlICh0KSBuaWwgKGxl dCogKChmbi02MjEgIyd0cmVlc2l0LWxhbmd1YWdlLWF2YWlsYWJsZS1wKSAoYXJnPGJyIC8+wqDC oMKgwqBlcnQtLXJ1bi10ZXN0LWludGVybmFsKCNzKGVydC0tdGVzdC1leGVjdXRpb24taW5mbyA6 dGVzdCAjcyhlcnQtdGVzdDxiciAvPsKgwqDCoMKgZXJ0LXJ1bi10ZXN0KCNzKGVydC10ZXN0IDpu YW1lIHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUtYmFja3dhcmQtMSA6ZG88YnIgLz7CoMKgwqDCoGVy dC1ydW4tb3ItcmVydW4tdGVzdCgjcyhlcnQtLXN0YXRzIDpzZWxlY3RvciAuLi4gOnRlc3RzIC4u LiA6dGVzdC1tPGJyIC8+wqDCoMKgwqBlcnQtcnVuLXRlc3RzKChub3QgKG9yICh0YWcgOnVuc3Rh YmxlKSAodGFnIDpuYXRpdmVjb21wKSkpICNmKGNvbXBpbDxiciAvPsKgwqDCoMKgZXJ0LXJ1bi10 ZXN0cy1iYXRjaCgobm90IChvciAodGFnIDp1bnN0YWJsZSkgKHRhZyA6bmF0aXZlY29tcCkpKSk8 YnIgLz7CoMKgwqDCoGVydC1ydW4tdGVzdHMtYmF0Y2gtYW5kLWV4aXQoKG5vdCAob3IgKHRhZyA6 dW5zdGFibGUpICh0YWcgOm5hdGl2ZWNvPGJyIC8+wqDCoMKgwqBldmFsKChlcnQtcnVuLXRlc3Rz LWJhdGNoLWFuZC1leGl0ICcobm90IChvciAodGFnIDp1bnN0YWJsZSkgKHRhZyA6bjxiciAvPsKg wqDCoMKgY29tbWFuZC1saW5lLTEoKCItTCIgIjsuIiAiLWwiICJlcnQiICItbCIgInNyYy90cmVl c2l0LXRlc3RzLmVsIiAiLS08YnIgLz7CoMKgwqDCoGNvbW1hbmQtbGluZSgpPGJyIC8+wqDCoMKg wqBub3JtYWwtdG9wLWxldmVsKCk8YnIgLz7CoMKgVGVzdCB0cmVlc2l0LXNlYXJjaC1zdWJ0cmVl LWJhY2t3YXJkLTEgY29uZGl0aW9uOjxiciAvPsKgwqDCoMKgwqDCoCh2b2lkLWZ1bmN0aW9uIHRy ZWVzaXQtLXRoaW5nLWF0KTxiciAvPsKgwqDCoMKgwqBGQUlMRUQgMjQvMjUgdHJlZXNpdC1zZWFy Y2gtc3VidHJlZS1iYWNrd2FyZC0xICgwLjAwMDAwMCBzZWMpIGF0IHNyYy90cmVlc2l0LXRlc3Rz LmVsOjExMDA8YnIgLz7CoMKgQ2FuJ3QgZ3Vlc3MgcHl0aG9uLWluZGVudC1vZmZzZXQsIHVzaW5n IGRlZmF1bHRzOiA0PGJyIC8+wqDCoFRlc3QgdHJlZXNpdC1zZWFyY2gtc3VidHJlZS1mb3J3YXJk LTEgYmFja3RyYWNlOjxiciAvPsKgwqDCoMKgKHRyZWVzaXQtLXRoaW5nLWF0IChwb2ludCkgImNh bGwiKTxiciAvPsKgwqDCoMKgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUgKHRyZWVzaXQtLXRoaW5n LWF0IChwb2ludCkgImNhbGwiKSAjJyhsYW1iZGE8YnIgLz7CoMKgwqDCoChsZXQgKChub2RlICh0 cmVlc2l0LXNlYXJjaC1zdWJ0cmVlICh0cmVlc2l0LS10aGluZy1hdCAocG9pbnQpICJjYWxsPGJy IC8+wqDCoMKgwqAoY2xvc3VyZSAodCkgbmlsIChsZXQqICgoZm4tNjA5ICMndHJlZXNpdC1sYW5n dWFnZS1hdmFpbGFibGUtcCkgKGFyZzxiciAvPsKgwqDCoMKgZXJ0LS1ydW4tdGVzdC1pbnRlcm5h bCgjcyhlcnQtLXRlc3QtZXhlY3V0aW9uLWluZm8gOnRlc3QgI3MoZXJ0LXRlc3Q8YnIgLz7CoMKg wqDCoGVydC1ydW4tdGVzdCgjcyhlcnQtdGVzdCA6bmFtZSB0cmVlc2l0LXNlYXJjaC1zdWJ0cmVl LWZvcndhcmQtMSA6ZG9jPGJyIC8+wqDCoMKgwqBlcnQtcnVuLW9yLXJlcnVuLXRlc3QoI3MoZXJ0 LS1zdGF0cyA6c2VsZWN0b3IgLi4uIDp0ZXN0cyAuLi4gOnRlc3QtbTxiciAvPsKgwqDCoMKgZXJ0 LXJ1bi10ZXN0cygobm90IChvciAodGFnIDp1bnN0YWJsZSkgKHRhZyA6bmF0aXZlY29tcCkpKSAj Zihjb21waWw8YnIgLz7CoMKgwqDCoGVydC1ydW4tdGVzdHMtYmF0Y2goKG5vdCAob3IgKHRhZyA6 dW5zdGFibGUpICh0YWcgOm5hdGl2ZWNvbXApKSkpPGJyIC8+wqDCoMKgwqBlcnQtcnVuLXRlc3Rz LWJhdGNoLWFuZC1leGl0KChub3QgKG9yICh0YWcgOnVuc3RhYmxlKSAodGFnIDpuYXRpdmVjbzxi ciAvPsKgwqDCoMKgZXZhbCgoZXJ0LXJ1bi10ZXN0cy1iYXRjaC1hbmQtZXhpdCAnKG5vdCAob3Ig KHRhZyA6dW5zdGFibGUpICh0YWcgOm48YnIgLz7CoMKgwqDCoGNvbW1hbmQtbGluZS0xKCgiLUwi ICI7LiIgIi1sIiAiZXJ0IiAiLWwiICJzcmMvdHJlZXNpdC10ZXN0cy5lbCIgIi0tPGJyIC8+wqDC oMKgwqBjb21tYW5kLWxpbmUoKTxiciAvPsKgwqDCoMKgbm9ybWFsLXRvcC1sZXZlbCgpPGJyIC8+ wqDCoFRlc3QgdHJlZXNpdC1zZWFyY2gtc3VidHJlZS1mb3J3YXJkLTEgY29uZGl0aW9uOjxiciAv PsKgwqDCoMKgwqDCoCh2b2lkLWZ1bmN0aW9uIHRyZWVzaXQtLXRoaW5nLWF0KTxiciAvPsKgwqDC oMKgwqBGQUlMRUQgMjUvMjUgdHJlZXNpdC1zZWFyY2gtc3VidHJlZS1mb3J3YXJkLTEgKDAuMDE1 NjI1IHNlYykgYXQgc3JjL3RyZWVzaXQtdGVzdHMuZWw6MTA4NjxiciAvPjxiciAvPlRoZSBmdW5j dGlvbiB0cmVlc2l0LS10aGluZy1hdCBpcyBvbmx5IGF2YWlsYWJsZSBvbiBtYXN0ZXIuPC9wPjwv YmxvY2txdW90ZT4= ------==--bound.46275.wx7plm2fuc5lrqzd.iva.yp-c.yandex.net Content-Disposition: attachment; filename="0002-Fix-an-issue-when-searching-subtree-backward.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="0002-Fix-an-issue-when-searching-subtree-backward.patch" RnJvbSAwNDBhOGFkNzU2MjVlYTRlNDI3N2ZiY2U5MjBmODRhODNlMTUxOTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEZW5pcyBadWJhcmV2IDxkdnp1YmFyZXZAeWFuZGV4LnJ1PgpE YXRlOiBTdW4sIDEyIE5vdiAyMDIzIDAxOjQyOjQyICswMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGFuIGlzc3VlIHdoZW4gc2VhcmNoaW5nIHN1YnRyZWUgYmFja3dhcmQKCiogc3JjL3RyZWVzaXQu YyAodHJlZXNpdF90cmF2ZXJzZV9jaGlsZF9oZWxwZXIpOgpEbyBub3QgY2FsbCB0cmVlc2l0X3Ry YXZlcnNlX3NpYmxpbmdfaGVscGVyIHdoZW4gdGhlIG5hbWVkIG5vZGUgaXMKcmVxdWlyZWQgYW5k IHRoZSBsYXN0IGNoaWxkIGlzIHRoZSBuYW1lZCBub2RlLgpPdGhlcndpc2UgdHJlZXNpdF90cmF2 ZXJzZV9zaWJsaW5nX2hlbHBlciB3aWxsIG1vdmUgY3Vyc29yIHRvIHRoZQpwcmV2aW91cyBzaWJs aW5nIGFuZCBsYXN0IG5vZGUgd2lsbCBiZSBza2lwcGVkLgoqIHRlc3Qvc3JjL3RyZWVzaXQtdGVz dHMuZWwgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUtZm9yd2FyZC0xKToKKHRyZWVzaXQtc2VhcmNo LXN1YnRyZWUtYmFja3dhcmQtMSk6CkFkZCB0ZXN0cwotLS0KIHNyYy90cmVlc2l0LmMgICAgICAg ICAgICAgfCAgNCArKy0tCiB0ZXN0L3NyYy90cmVlc2l0LXRlc3RzLmVsIHwgMzQgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90cmVlc2l0LmMgYi9zcmMvdHJl ZXNpdC5jCmluZGV4IDY5YjU5ZmNhMTEuLjRkY2FkNzUxZjQgMTAwNjQ0Ci0tLSBhL3NyYy90cmVl c2l0LmMKKysrIGIvc3JjL3RyZWVzaXQuYwpAQCAtMzI0Nyw5ICszMjQ3LDkgQEAgdHJlZXNpdF90 cmF2ZXJzZV9jaGlsZF9oZWxwZXIgKFRTVHJlZUN1cnNvciAqY3Vyc29yLAogICAgICAgLyogRmly c3QgZ28gdG8gdGhlIGxhc3QgY2hpbGQuICAqLwogICAgICAgd2hpbGUgKHRzX3RyZWVfY3Vyc29y X2dvdG9fbmV4dF9zaWJsaW5nIChjdXJzb3IpKTsKIAotICAgICAgaWYgKCFuYW1lZCkKKyAgICAg IGlmICghbmFtZWQgfHwgKG5hbWVkICYmIHRzX25vZGVfaXNfbmFtZWQgKHRzX3RyZWVfY3Vyc29y X2N1cnJlbnRfbm9kZShjdXJzb3IpKSkpCiAJcmV0dXJuIHRydWU7Ci0gICAgICAvKiBFbHNlIG5h bWVkLi4uICovCisgICAgICAvKiBFbHNlIG5hbWVkIGlzIHJlcXVpcmVkIGFuZCBsYXN0IGNoaWxk IGlzIG5vdCBuYW1lZCBub2RlICovCiAgICAgICBpZiAodHJlZXNpdF90cmF2ZXJzZV9zaWJsaW5n X2hlbHBlcihjdXJzb3IsIGZhbHNlLCB0cnVlKSkKIAlyZXR1cm4gdHJ1ZTsKICAgICAgIGVsc2UK ZGlmZiAtLWdpdCBhL3Rlc3Qvc3JjL3RyZWVzaXQtdGVzdHMuZWwgYi90ZXN0L3NyYy90cmVlc2l0 LXRlc3RzLmVsCmluZGV4IDc5MWU5MDJiZDAuLjZjM2IxZWVkOTggMTAwNjQ0Ci0tLSBhL3Rlc3Qv c3JjL3RyZWVzaXQtdGVzdHMuZWwKKysrIGIvdGVzdC9zcmMvdHJlZXNpdC10ZXN0cy5lbApAQCAt MTE2Nyw2ICsxMTY3LDQwIEBAIHRyZWVzaXQtZGVmdW4tbmF2aWdhdGlvbi10b3AtbGV2ZWwKICAg IHRyZWVzaXQtLWVydC1kZWZ1bi1uYXZpZ2F0aW9uLXRvcC1sZXZlbC1tYXN0ZXIKICAgICd0b3At bGV2ZWwpKQogCisoZXJ0LWRlZnRlc3QgdHJlZXNpdC1zZWFyY2gtc3VidHJlZS1mb3J3YXJkLTEg KCkKKyAgIlRlc3Qgc2VhcmNoIHN1YnRyZWUgZm9yd2FyZC4iCisgIChza2lwLXVubGVzcyAodHJl ZXNpdC1sYW5ndWFnZS1hdmFpbGFibGUtcCAncHl0aG9uKSkKKyAgKHJlcXVpcmUgJ3B5dGhvbikK KyAgKHB5dGhvbi10cy1tb2RlKQorICAoaW5zZXJ0ICJUZW1wKDEsIDIpIikKKyAgKGdvdG8tY2hh ciAocG9pbnQtbWluKSkKKyAgKHBjYXNlLWxldCogKChgKCgsXyAuICxjYWxsLW5vZGUpKSAodHJl ZXNpdC1xdWVyeS1jYXB0dXJlICh0cmVlc2l0LWJ1ZmZlci1yb290LW5vZGUpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKChjYWxs KSBAYykpKQorICAgICAgICAgICAgICAgKG5vZGUgKHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUKKyAg ICAgICAgICAgICAgICAgICAgICBjYWxsLW5vZGUKKyAgICAgICAgICAgICAgICAgICAgICAobGFt YmRhIChuKSAoZXF1YWwgKHRyZWVzaXQtbm9kZS10eXBlIG4pICJpbnRlZ2VyIikpKSkpCisKKyAg ICAoc2hvdWxkIG5vZGUpCisgICAgKHNob3VsZCAoZXF1YWwgKHRyZWVzaXQtbm9kZS10ZXh0IG5v ZGUpICIxIikpKSkKKworKGVydC1kZWZ0ZXN0IHRyZWVzaXQtc2VhcmNoLXN1YnRyZWUtYmFja3dh cmQtMSAoKQorICAiVGVzdCBzZWFyY2ggc3VidHJlZSB3aXRoIGJhY2t3YXJkPXQuIgorICAoc2tp cC11bmxlc3MgKHRyZWVzaXQtbGFuZ3VhZ2UtYXZhaWxhYmxlLXAgJ3B5dGhvbikpCisgIChyZXF1 aXJlICdweXRob24pCisgIChweXRob24tdHMtbW9kZSkKKyAgKGluc2VydCAiVGVtcCgxLCAyKSIp CisgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgIChwY2FzZS1sZXQqICgoYCgoLF8gLiAsY2Fs bC1ub2RlKSkgKHRyZWVzaXQtcXVlcnktY2FwdHVyZSAodHJlZXNpdC1idWZmZXItcm9vdC1ub2Rl KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJygoY2FsbCkgQGMpKSkKKyAgICAgICAgICAgICAgIChub2RlICh0cmVlc2l0LXNlYXJj aC1zdWJ0cmVlCisgICAgICAgICAgICAgICAgICAgICAgY2FsbC1ub2RlCisgICAgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAobikgKGVxdWFsICh0cmVlc2l0LW5vZGUtdHlwZSBuKSAiaW50ZWdl ciIpKQorICAgICAgICAgICAgICAgICAgICAgIHQpKSkKKworICAgIChzaG91bGQgbm9kZSkKKyAg ICAoc2hvdWxkIChlcXVhbCAodHJlZXNpdC1ub2RlLXRleHQgbm9kZSkgIjIiKSkpKQorCisKIDs7 IFRPRE8KIDs7IC0gRnVuY3Rpb25zIGluIHRyZWVzaXQuZWwKIDs7IC0gdHJlZXNpdC1sb2FkLW5h bWUtb3ZlcnJpZGUtbGlzdAotLSAKMi4zNC4xCgo= ------==--bound.46275.wx7plm2fuc5lrqzd.iva.yp-c.yandex.net-- From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2023 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Denis Zubarev Cc: "67117@debbugs.gnu.org" <67117@debbugs.gnu.org>, Eli Zaretskii Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170331538924924 (code B ref 67117); Sat, 23 Dec 2023 07:10:02 +0000 Received: (at 67117) by debbugs.gnu.org; 23 Dec 2023 07:09:49 +0000 Received: from localhost ([127.0.0.1]:48416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGw8q-0006Tv-Pd for submit@debbugs.gnu.org; Sat, 23 Dec 2023 02:09:49 -0500 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:50298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGw8o-0006Ti-QE for 67117@debbugs.gnu.org; Sat, 23 Dec 2023 02:09:47 -0500 Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7b7d65d4eecso106656439f.0 for <67117@debbugs.gnu.org>; Fri, 22 Dec 2023 23:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703315376; x=1703920176; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QbJy3Et+ATOKNe8H4c/H59S1x4AWB+tw5/7rf17BQSc=; b=eobSK0cMT4gHzM27+nMjQ/KqdX3BYEk85SjaYoRu2DxQeG2JFdxwXUm1HAFBUaMtTV JIbKUuoZpA0ndRuX9hp0tUJnmGQ5lt7MJ8tovpx5dp+i3cyLPKPB+baP1nVFH9I2x7ZA E/8BKUhA2xyanmvlOzuULUl2vlz1U2Lk37DRYtdBxu+JziknTTyLpToASlohxlc800w7 33ER1z5gZpxvN5QfRxiSnbAzy00nUc3+I5Z29g/dCrZ+YyWTu0mEBAOkV4V8E26Pt7cq /BU0ue2T6mM/1idpgiozkVQV9guBkJP6aqeh9vcp2P8fEIu83frmcJjIm6g76Nb4SgU8 0ZIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703315376; x=1703920176; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QbJy3Et+ATOKNe8H4c/H59S1x4AWB+tw5/7rf17BQSc=; b=QYsZXofHi6I6VLpwJGffUw9EP2b7brP4KpPnm11dhhAcuM26dNO0GFBAAYgZgulJNN 3Un91Ff+G4vCF4IBu3vHvUzUcKp4XjPYtjUYq90xIPaqNd87of9zPH1fYSdjErX/n+RW mnf2LKt9+3ixGter9givbh8nWzpYfimGTI1UHsvB7OCYcQ7XbW/JbkMBLDxmm+uacj7s BG4C33D87+yyo5qbfI5AjHkpWuAnc+/ea6H3C+M2Hy4lIB3ibmUQm+u6ECpRMilHk188 MzPHnAOPvJyCb9hj9vY2dIXr/6Wa70w/w/d6B5I16mX3H0fD6jWA5KzNDUQmujI/D5pe 9tsQ== X-Gm-Message-State: AOJu0YwlC/2qPwWdk/NIYDQmvqnHFfF0n2RpW5EU5A0dpDpM+WuvkFDH QvzOkWHqACV4xsNE1Tfphz8= X-Google-Smtp-Source: AGHT+IEdLSQmY7LOKvh/R846kLX+RaasKIEVkSvsnY+9Y8bfyZVHSXpeoTS1TE1s89Nm/avIRj386w== X-Received: by 2002:a05:6e02:148e:b0:35f:b61f:a8a8 with SMTP id n14-20020a056e02148e00b0035fb61fa8a8mr3772788ilk.26.1703315376014; Fri, 22 Dec 2023 23:09:36 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id m20-20020a170902c45400b001d316770044sm4532665plm.56.2023.12.22.23.09.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2023 23:09:35 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <631791703005524@mail.yandex.ru> Date: Fri, 22 Dec 2023 23:09:24 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> <83y1dqgmn4.fsf@gnu.org> <631791703005524@mail.yandex.ru> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 19, 2023, at 9:08 AM, Denis Zubarev = wrote: >=20 > I replaced treesit--thing-at with the function from emacs 29.1 in the = last version of the patch. > Attached it here. > 19.12.2023, 19:53, "Eli Zaretskii" : > From: Yuan Fu > Date: Mon, 18 Dec 2023 18:26:30 -0800 > Cc: Eli Zaretskii , > 67117-done@debbugs.gnu.org > =20 > > On Dec 18, 2023, at 4:24 PM, Denis Zubarev = wrote: > > > > Just FYI, my paperwork is done. > > > =20 > Great, applied! Closing this bug. >=20 > The new tests fail here: >=20 > ELC src/treesit-tests.elc >=20 > In end of data: > src/treesit-tests.el:1094:17: Warning: the function = `treesit--thing-at' is not known to be defined. > [...] > Test treesit-search-subtree-backward-1 backtrace: > (treesit--thing-at (point) "call") > (treesit-search-subtree (treesit--thing-at (point) "call") = #'(lambda > (let ((node (treesit-search-subtree (treesit--thing-at (point) = "call > (closure (t) nil (let* ((fn-621 #'treesit-language-available-p) = (arg > ert--run-test-internal(#s(ert--test-execution-info :test = #s(ert-test > ert-run-test(#s(ert-test :name treesit-search-subtree-backward-1 = :do > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... = :test-m > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) = #f(compil > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag = :nativeco > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag = :n > command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" = "-- > command-line() > normal-top-level() > Test treesit-search-subtree-backward-1 condition: > (void-function treesit--thing-at) > FAILED 24/25 treesit-search-subtree-backward-1 (0.000000 sec) at = src/treesit-tests.el:1100 > Can't guess python-indent-offset, using defaults: 4 > Test treesit-search-subtree-forward-1 backtrace: > (treesit--thing-at (point) "call") > (treesit-search-subtree (treesit--thing-at (point) "call") = #'(lambda > (let ((node (treesit-search-subtree (treesit--thing-at (point) = "call > (closure (t) nil (let* ((fn-609 #'treesit-language-available-p) = (arg > ert--run-test-internal(#s(ert--test-execution-info :test = #s(ert-test > ert-run-test(#s(ert-test :name treesit-search-subtree-forward-1 = :doc > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... = :test-m > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) = #f(compil > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag = :nativeco > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag = :n > command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" = "-- > command-line() > normal-top-level() > Test treesit-search-subtree-forward-1 condition: > (void-function treesit--thing-at) > FAILED 25/25 treesit-search-subtree-forward-1 (0.015625 sec) at = src/treesit-tests.el:1086 >=20 > The function treesit--thing-at is only available on = master.<0002-Fix-an-issue-when-searching-subtree-backward.patch> Thanks, applied this patch, and all tests pass now. Yuan From unknown Tue Aug 12 08:33:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Dec 2023 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Denis Zubarev Cc: Eli Zaretskii , 67117-done@debbugs.gnu.org Received: via spool by 67117-done@debbugs.gnu.org id=D67117.170355118619788 (code D ref 67117); Tue, 26 Dec 2023 00:40:02 +0000 Received: (at 67117-done) by debbugs.gnu.org; 26 Dec 2023 00:39:46 +0000 Received: from localhost ([127.0.0.1]:55553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHvTz-000593-81 for submit@debbugs.gnu.org; Mon, 25 Dec 2023 19:39:46 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:59589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHvTt-00058n-Vq for 67117-done@debbugs.gnu.org; Mon, 25 Dec 2023 19:39:42 -0500 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5cd8667c59eso3047667a12.2 for <67117-done@debbugs.gnu.org>; Mon, 25 Dec 2023 16:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703551165; x=1704155965; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V9Z58Vl9gHQbnJvzkVGLJ+1hNkwmSat7Pjdd/f0yd+M=; b=f7Uqi+14bnzNlrBzgM/G1zOlNPBNNkmFz+o8OgAP1199AaaVWbwEQuj18MSzzeCn0J T72/kzxflyBRFn7VlswV5EC5C1BugxCXlUSGNo0tmP0XO1ECtlxiRwNe7xAwPTO/njjG 7tUNe//J99rCjI2d63YDGFNO6PGBUyMILYIH/OnVmtCFe/egH4KF2wG7ixWz5xMAWpLe IsDJk0t7t2oneGH6b5ZXD2ba5pGRX0rfU+RFnlEdcQjnYJMSzOi3311dWI7P2Yxtu6Sa /zPuTe6880yXESNlQZpukjrtC/Xmz0KVy839Rj6yKlW0SmNQ4LhcLBiwoKWmUUDpzyJE zadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703551165; x=1704155965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9Z58Vl9gHQbnJvzkVGLJ+1hNkwmSat7Pjdd/f0yd+M=; b=pHpUsG2eNtoHmz95H7bOcrCgd/tLs/uEnP9j9GAu/k/JwecEF9cVulz568S2I2hGmg cHJCE/lN19OIJkhEpCTc1txTH4fU5tWQ0Iz3UFIXxLj+jtZ7K0p7ojbfQ5y7SJfOAvhJ oaGY8bJBirYrvzoHZvg0RWTR0J+GzodbkUHHOEpiTzJO6jEMoCIn/4b0QzzAK/QL/qDk Ep4M4k7wx7Mz3XIwYtmdS7GLw51GBnSNkyIQrUVtxUzz5TUXE019RpXclkOWAnBdR7pJ Qp+BeytiMtrpnbnohXOW2JNJ2zoNTNbheSXapXOn8JVJ+H6tXjSVDvzCW1x0jc9FyIox vwdQ== X-Gm-Message-State: AOJu0YwvAQ3QnfVuTOOIqIRzuuxaVUUcZIZfZPl+pB0E6mKhxVTAXpdh pzQ4oAZfwNJileAP5Uvv4xA= X-Google-Smtp-Source: AGHT+IF7vSmE7fGxeoEJ6saKfVV6f3965ACca6+yvlAe6ZT4hHYXzW7IRaLk5o8Iy1dcI8ahVqjRbA== X-Received: by 2002:a05:6a20:6a23:b0:191:6d96:ffde with SMTP id p35-20020a056a206a2300b001916d96ffdemr8267271pzk.24.1703551165134; Mon, 25 Dec 2023 16:39:25 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v21-20020a634815000000b005c1ce3c960bsm8261091pga.50.2023.12.25.16.39.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Dec 2023 16:39:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: Date: Mon, 25 Dec 2023 16:39:13 -0800 Content-Transfer-Encoding: 7bit Message-Id: <29798869-A2AF-4A0B-88D1-5CB49E49DDB9@gmail.com> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> <83y1dqgmn4.fsf@gnu.org> <631791703005524@mail.yandex.ru> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Thanks, applied this patch, and all tests pass now. > > Yuan > Closing this report. Yuan