From unknown Tue Jun 24 15:44:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67075 <67075@debbugs.gnu.org> To: bug#67075 <67075@debbugs.gnu.org> Subject: Status: [PATCH] build: zig-build-system: Add CPU option Reply-To: bug#67075 <67075@debbugs.gnu.org> Date: Tue, 24 Jun 2025 22:44:05 +0000 retitle 67075 [PATCH] build: zig-build-system: Add CPU option reassign 67075 guix-patches submitter 67075 Ekaitz Zarraga severity 67075 normal tag 67075 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 11 08:10:10 2023 Received: (at submit) by debbugs.gnu.org; 11 Nov 2023 13:10:10 +0000 Received: from localhost ([127.0.0.1]:52312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1nkY-0005qO-5B for submit@debbugs.gnu.org; Sat, 11 Nov 2023 08:10:10 -0500 Received: from lists.gnu.org ([2001:470:142::17]:47242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1nkW-0005qA-3N for submit@debbugs.gnu.org; Sat, 11 Nov 2023 08:10:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1njm-0000aR-8v for guix-patches@gnu.org; Sat, 11 Nov 2023 08:09:22 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1nji-00078i-RB for guix-patches@gnu.org; Sat, 11 Nov 2023 08:09:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1699708154; x=1699967354; bh=2ss1UVI/muZ7yUSSuA6don2f6qvrj4hYNkFZEEx1hHA=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=ehIletj2oy1UbKepxFfxRaC/q6Ei/HNuDTxCkzF+EkcjQZhFCChKjL3DRb6H3o3f1 QSUCwoMSgkdKhgzL4uVvQZurQGdpSVgRRMHS9k9nlOS9SZ/XbKmxR9YC0XxvxxLPtf 08xXS2SUidHjky1gWFj3Gr/BMKPsW17VCGA0bsIegsCl7UlNthF26mWpPBu3k6BM4E CYLoBujdODaSp7GVYyBzMqnQi/7p7q5hTB1Ka42s8FoBmhEZAmwif8VUORwc440m/G nGtwXYNg301l+lnfvsscYdFY4w36tdvaMK8EDliV93VUczNJOaK1yJjrZs9zP08gdU i7l1nhM32aGuQ== Date: Sat, 11 Nov 2023 13:09:07 +0000 To: "guix-patches@gnu.org" From: Ekaitz Zarraga Subject: [PATCH] build: zig-build-system: Add CPU option Message-ID: Feedback-ID: 3263582:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.23; envelope-from=ekaitz@elenq.tech; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >From a647a8ee689022cafef4bab05784b32b1c97bee7 Mon Sep 17 00:00:00 2001 Message-ID: From: Ekaitz Zarraga Date: Sat, 11 Nov 2023 14:05:23 +0100 Subject: [PATCH] build: zig-build-system: Add CPU option Zig packages are optimized by default, adding `-Dcpu=3Dbaseline` to the build command builds them for an standard cpu that should work in every machine. This change sets that by default but also allows users to choose their cpu by the `#:zig-cpu` argument. * guix/build-system/zig.scm (build): add zig-cpu * guix/build/zig-build-system.scm (zig-build) add zig-cpu Change-Id: Ib4b2124179e7b5492e7c77c64e1f8336832032ea --- guix/build-system/zig.scm | 2 ++ guix/build/zig-build-system.scm | 2 ++ 2 files changed, 4 insertions(+) diff --git a/guix/build-system/zig.scm b/guix/build-system/zig.scm index 16b8a712cc..f90e76104e 100644 --- a/guix/build-system/zig.scm +++ b/guix/build-system/zig.scm @@ -47,6 +47,7 @@ (define* (zig-build name inputs source (tests? #t) (test-target #f) + (zig-cpu #f) (zig-build-flags ''()) (zig-test-flags ''()) (zig-release-type #f) @@ -67,6 +68,7 @@ (define* (zig-build name inputs #:source #+source #:system #$system #:test-target #$test-target + #:zig-cpu #$zig-cpu #:zig-build-flags #$zig-build-flags #:zig-test-flags #$zig-test-flags #:zig-release-type #$zig-release-type diff --git a/guix/build/zig-build-system.scm b/guix/build/zig-build-system.= scm index d414ebfb17..99a81314d4 100644 --- a/guix/build/zig-build-system.scm +++ b/guix/build/zig-build-system.scm @@ -44,6 +44,7 @@ (define* (set-zig-global-cache-dir #:rest args) (setenv "ZIG_GLOBAL_CACHE_DIR" global-cache-dir)) =20 (define* (build #:key + zig-cpu zig-build-flags zig-release-type ;; "safe", "fast" or "small" empty = for a ;; debug build" @@ -59,6 +60,7 @@ (define* (build #:key ,@(if zig-release-type (list (string-append "-Drelease-" zig-release-typ= e)) '()) + ,(string-append "-Dcpu=3D" (or zig-cpu "baseline")) ,@zig-build-flags))) (format #t "running: ~s~%" call) (apply invoke call))) base-commit: af6105afc67a15a491a0a4fd18a28c9f801a0b94 --=20 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 09:39:51 2023 Received: (at 67075) by debbugs.gnu.org; 12 Nov 2023 14:39:51 +0000 Received: from localhost ([127.0.0.1]:55293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2Bct-0007OK-1b for submit@debbugs.gnu.org; Sun, 12 Nov 2023 09:39:51 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:47337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2Bcq-0007O5-2G for 67075@debbugs.gnu.org; Sun, 12 Nov 2023 09:39:48 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-32f70391608so2014949f8f.2 for <67075@debbugs.gnu.org>; Sun, 12 Nov 2023 06:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699799941; x=1700404741; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=qK1/V69LmjLNxN8/GWQkACOTnKjqI5XU3InSjC/reTk=; b=gDICZK0DT0rhHSzCXYXc4CzKNdpt5gTbwwNMisPnSC0ae3vgAAJBUTJB68KGE8Kynv uXo6CfW575PGCkltIerj37V2f6W8KPCS612y15hlJgXfAYCNU17ndnjooXcN2FcxN+/h +k7EVEdxmwisvz6W7JG09nvp0zKAiNn3fe3+jfUkRz1DHWxXn8wIyrQB+md6VvAAd5RY WoFA+KF/9dg0K9hnDPAr1bKEybEWkOzTSllEv4o/1VP35OgTxstP00uHFtKOWV4m3LFL n1mVw/rnkDe4nHcX54BsUAGjMhl8D78ZJFPwhc2A1Y36Q6AxEwoXeTSrKKvYT+8HLi+1 146w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699799941; x=1700404741; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qK1/V69LmjLNxN8/GWQkACOTnKjqI5XU3InSjC/reTk=; b=huUlUSTueRXr/ZDngO8iQsO6bqg9uciKcdLe2y6QzT82T+QFuBxfRqw9Wv9znbVoqt IbgOGb8FR308ekzMFoRJ1gjJ3lRNzZc1Mapm1YQKrInXeBo0xmw3vrxYRnQ6tvOUPPgQ wAr5ZaV8YieyZY6lvfn7YqYjm8rq2FRkp15Taa5F97cq16G5+ByViitu6b53VuksgWXY 9tQ7mXDD7Kia5QJyOPqqzbtCxm2JgkPDUqbxMAA6jVUR6xDNXLKdYGbvq7tEOKiwpM3s DPG86sTmj93Z8tPK3KlRNSGZT9OrJ3Yn20X5AgcL8W9JxN+9hQXkBT4E+6xQvIH6krX0 IodQ== X-Gm-Message-State: AOJu0YziDNctUzbeHbw6v0shoPQXKE9E92m8Oikaq/UKq3Kq9tzb7ugf fkMUezUwv6VONgir3RwuB/I= X-Google-Smtp-Source: AGHT+IGWCvWlvYjZFQbmnkMRxWdGYNlLRO2S007eP8U2clmDEOD6878Ny5YqFKORncCd1n8ikOuO/g== X-Received: by 2002:adf:d1e9:0:b0:32f:8024:64f1 with SMTP id g9-20020adfd1e9000000b0032f802464f1mr4636308wrd.2.1699799940773; Sun, 12 Nov 2023 06:39:00 -0800 (PST) Received: from localhost ([176.12.139.99]) by smtp.gmail.com with ESMTPSA id f13-20020a5d4dcd000000b0032f7c563ffasm3423525wru.36.2023.11.12.06.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 06:39:00 -0800 (PST) Date: Sun, 12 Nov 2023 16:38:58 +0200 From: Efraim Flashner To: Ekaitz Zarraga Subject: Re: [bug#67075] [PATCH] build: zig-build-system: Add CPU option Message-ID: Mail-Followup-To: Efraim Flashner , Ekaitz Zarraga , 67075@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bdV4JdJO95MOtt47" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67075 Cc: 67075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --bdV4JdJO95MOtt47 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable What are the values that the compiler can take for this flag? Also, this seems like something that can be addressed with the tuning mechanism, so we can run 'guix build foo --tune' and it'll do The Right Thing=E2=84=A2. Alternatively, if we do go this route, you still need to update the documentation. On Sat, Nov 11, 2023 at 01:09:07PM +0000, Ekaitz Zarraga wrote: > From a647a8ee689022cafef4bab05784b32b1c97bee7 Mon Sep 17 00:00:00 2001 > Message-ID: > From: Ekaitz Zarraga > Date: Sat, 11 Nov 2023 14:05:23 +0100 > Subject: [PATCH] build: zig-build-system: Add CPU option >=20 > Zig packages are optimized by default, adding `-Dcpu=3Dbaseline` to the > build command builds them for an standard cpu that should work in every > machine. >=20 > This change sets that by default but also allows users to choose their > cpu by the `#:zig-cpu` argument. >=20 > * guix/build-system/zig.scm (build): add zig-cpu > * guix/build/zig-build-system.scm (zig-build) add zig-cpu >=20 > Change-Id: Ib4b2124179e7b5492e7c77c64e1f8336832032ea > --- > guix/build-system/zig.scm | 2 ++ > guix/build/zig-build-system.scm | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/guix/build-system/zig.scm b/guix/build-system/zig.scm > index 16b8a712cc..f90e76104e 100644 > --- a/guix/build-system/zig.scm > +++ b/guix/build-system/zig.scm > @@ -47,6 +47,7 @@ (define* (zig-build name inputs > source > (tests? #t) > (test-target #f) > + (zig-cpu #f) > (zig-build-flags ''()) > (zig-test-flags ''()) > (zig-release-type #f) > @@ -67,6 +68,7 @@ (define* (zig-build name inputs > #:source #+source > #:system #$system > #:test-target #$test-target > + #:zig-cpu #$zig-cpu > #:zig-build-flags #$zig-build-flags > #:zig-test-flags #$zig-test-flags > #:zig-release-type #$zig-release-type > diff --git a/guix/build/zig-build-system.scm b/guix/build/zig-build-syste= m.scm > index d414ebfb17..99a81314d4 100644 > --- a/guix/build/zig-build-system.scm > +++ b/guix/build/zig-build-system.scm > @@ -44,6 +44,7 @@ (define* (set-zig-global-cache-dir #:rest args) > (setenv "ZIG_GLOBAL_CACHE_DIR" global-cache-dir)) > =20 > (define* (build #:key > + zig-cpu > zig-build-flags > zig-release-type ;; "safe", "fast" or "small" empt= y for a > ;; debug build" > @@ -59,6 +60,7 @@ (define* (build #:key > ,@(if zig-release-type > (list (string-append "-Drelease-" zig-release-t= ype)) > '()) > + ,(string-append "-Dcpu=3D" (or zig-cpu "baseline")) > ,@zig-build-flags))) > (format #t "running: ~s~%" call) > (apply invoke call))) >=20 > base-commit: af6105afc67a15a491a0a4fd18a28c9f801a0b94 > --=20 > 2.41.0 >=20 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --bdV4JdJO95MOtt47 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVQ44IACgkQQarn3Mo9 g1H87w/+LE72UpunFTnaIl6aUxH1CNZDEUEyhslZhxQO4fRcUDc74irHeMEaRZH7 9uMOjJdYWzrz1YcwmlPt6tlevWSyeYmlnITaxUv8kE95363Pe3tA7vb4fDj+sA7B 3eN1sE1aPJ18DoXBZNHCOiBS6qaHrr0RITqMk0IxeTgZVEfaxziE6ZdhiYKMycHg MkgQqgjHMr+A/5CeY6TKYSqNSWhCFejU417OS41Rw0345zbcRW4R37M3ULgW0Sf4 Mk4XtKSllQOdlW3648J+338M15D8bVkjW+NXlYg9qefglWcWt6bWMgO3SUmhKWku 7yvRglStWGzFIMwUdmemi4+SqDC6/x3fsATWGkhhVZ+flZiA6NUOK2zcDn4pEEup gjBoRY+dikda5FNn2vqVwF8CHkvqfHz8skuPol7Y7FvJjQn30lX/aRZXN4fqFN4H cWXNqMbaqXrnS97RlWzhdwXv+fZXwVmu3rXIFbqLEep62o+C2fyYk1EDYbr2s4B2 HqXHwA6u6lyQCJJxUgcEKhZxrGLYPxV7A0q2GktPsnXO6heRCQ/k2r8Gszyjz1oR GaDUxkA9mKo9DYW/IUjwJCpOJi14ixVkicCZRUddLwG7CeNKSeF0/HF80BIvNrtE Y0o1xieOPfKBykvqwxE17Y4ob5AN8PACCEmMWv4/qkvl/gNXHQk= =x2rU -----END PGP SIGNATURE----- --bdV4JdJO95MOtt47-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 11:39:24 2023 Received: (at 67075) by debbugs.gnu.org; 12 Nov 2023 16:39:24 +0000 Received: from localhost ([127.0.0.1]:56833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2DUa-0002l5-32 for submit@debbugs.gnu.org; Sun, 12 Nov 2023 11:39:24 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:58375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2DUU-0002kp-El for 67075@debbugs.gnu.org; Sun, 12 Nov 2023 11:39:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1699807109; x=1700066309; bh=/yn+fT+AGtcxCxhBKIempQKWWvzefIpAFi+ziXlwj5g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=dZWdc+NeGAJrFpI8zx9hzNd+EJF4aevfux85vvvSZFxKPfA5f/UrVBX6EgQE0ZOc4 kCSsh+afezNW/AvKHcmitasWtY+Ou2WbNar+zqfhtZi3RIgLWPLyhIrN5JfqzBmuBR CySkIVL//YWCz6wZ7pX7KblsB08HNQvPhcU67ERHmHyHDd4ttMBkhztxHsjOFcEbR0 L7R+wFtLD3t0ffbNSOOO94CP1c9i31F/aufycZrJ4RvCwk48F4cjJOtrDDPKBT+uFY MkEF8dboQktH/tWWHiPyoy8XOqhHAr1IfdCrBVXArHkJYk037p06t9N4SuVAzpM3u/ NYE4LtR1KUldQ== Date: Sun, 12 Nov 2023 16:38:10 +0000 To: Efraim Flashner From: Ekaitz Zarraga Subject: Re: [bug#67075] [PATCH] build: zig-build-system: Add CPU option Message-ID: <9H9-d5-fHPyPl1K4orVOGtBJD1l-IkO3i_PliKpymBR4abn8CwidP7hNlaqafHnHBu54egehC0wYtVc-R4azbkd1sjEMPITj9dbUHl8W6dM=@elenq.tech> In-Reply-To: References: Feedback-ID: 3263582:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67075 Cc: 67075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Efraim, On Sunday, November 12th, 2023 at 15:38, Efraim Flashner wrote: > What are the values that the compiler can take for this flag? Also, > this seems like something that can be addressed with the tuning > mechanism, so we can run 'guix build foo --tune' and it'll do The Right > Thing=E2=84=A2. It's not that simple. I talked with Andrew Kelley and he told me the values are obtained from LLVM and they have some patching. I checked the list and= =20 they are similar to those we use in the -march field: https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html#x86-Options The full list is accessible in `zig targets` and it's very extensive. I don't know if we can just rely on that mechanism... > Alternatively, if we do go this route, you still need to update the > documentation. That's very true. I will. > On Sat, Nov 11, 2023 at 01:09:07PM +0000, Ekaitz Zarraga wrote: >=20 > > From a647a8ee689022cafef4bab05784b32b1c97bee7 Mon Sep 17 00:00:00 2001 > > Message-ID: a647a8ee689022cafef4bab05784b32b1c97bee7.1699708101.git.eka= itz@elenq.tech > > From: Ekaitz Zarraga ekaitz@elenq.tech > > Date: Sat, 11 Nov 2023 14:05:23 +0100 > > Subject: [PATCH] build: zig-build-system: Add CPU option > >=20 > > Zig packages are optimized by default, adding `-Dcpu=3Dbaseline` to the > > build command builds them for an standard cpu that should work in every > > machine. > >=20 > > This change sets that by default but also allows users to choose their > > cpu by the `#:zig-cpu` argument. > >=20 > > * guix/build-system/zig.scm (build): add zig-cpu > > * guix/build/zig-build-system.scm (zig-build) add zig-cpu > >=20 > > Change-Id: Ib4b2124179e7b5492e7c77c64e1f8336832032ea > > --- > > guix/build-system/zig.scm | 2 ++ > > guix/build/zig-build-system.scm | 2 ++ > > 2 files changed, 4 insertions(+) > >=20 > > diff --git a/guix/build-system/zig.scm b/guix/build-system/zig.scm > > index 16b8a712cc..f90e76104e 100644 > > --- a/guix/build-system/zig.scm > > +++ b/guix/build-system/zig.scm > > @@ -47,6 +47,7 @@ (define* (zig-build name inputs > > source > > (tests? #t) > > (test-target #f) > > + (zig-cpu #f) > > (zig-build-flags ''()) > > (zig-test-flags ''()) > > (zig-release-type #f) > > @@ -67,6 +68,7 @@ (define* (zig-build name inputs > > #:source #+source > > #:system #$system > > #:test-target #$test-target > > + #:zig-cpu #$zig-cpu > > #:zig-build-flags #$zig-build-flags > > #:zig-test-flags #$zig-test-flags > > #:zig-release-type #$zig-release-type > > diff --git a/guix/build/zig-build-system.scm b/guix/build/zig-build-sys= tem.scm > > index d414ebfb17..99a81314d4 100644 > > --- a/guix/build/zig-build-system.scm > > +++ b/guix/build/zig-build-system.scm > > @@ -44,6 +44,7 @@ (define* (set-zig-global-cache-dir #:rest args) > > (setenv "ZIG_GLOBAL_CACHE_DIR" global-cache-dir)) > >=20 > > (define* (build #:key > > + zig-cpu > > zig-build-flags > > zig-release-type ;; "safe", "fast" or "small" empty for a > > ;; debug build" > > @@ -59,6 +60,7 @@ (define* (build #:key > > ,@(if zig-release-type > > (list (string-append "-Drelease-" zig-release-type)) > > '()) > > + ,(string-append "-Dcpu=3D" (or zig-cpu "baseline")) > > ,@zig-build-flags))) > > (format #t "running: ~s~%" call) > > (apply invoke call))) > >=20 > > base-commit: af6105afc67a15a491a0a4fd18a28c9f801a0b94 > > -- > > 2.41.0 >=20 >=20 > -- > Efraim Flashner efraim@flashner.co.il =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 >=20 > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 11:42:14 2023 Received: (at 67075) by debbugs.gnu.org; 12 Nov 2023 16:42:14 +0000 Received: from localhost ([127.0.0.1]:56842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2DXK-0002q9-6Y for submit@debbugs.gnu.org; Sun, 12 Nov 2023 11:42:14 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:53407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2DXH-0002pt-1k for 67075@debbugs.gnu.org; Sun, 12 Nov 2023 11:42:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1699807283; x=1700066483; bh=8qh+/d0INd9cS6ex4oFDDlubCkdBHNaQPp6gfDN7YB4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=a74J4UxPMOZxx0fvOwpaiCQXznpB2be6Dnh/A4D9ZmnnHHxibwltQPU6EUXiu+/35 IJ+PoFtaRDWlo4EXTepVOBduoV/QGaQcdteVf2nebyAGaCzDwhKJfEZykrzuhJ+NRo eeQC2Sc2tdF15Bck9N8InUQ30jPL7nlLQ1ujPuk6XDp2/exrNPK+++JVtSW+dakr9Z XQ2obitKDppqhx9nIaHs80YgoJGacN8wF1WdKXaZTLqAwjunwmJoxfg6xNI9OZ5Jl1 DtqvB7CmgQTAZy6/GELRW0pyQ+zn/RdfBO/ovjm7GmE5bENzxhb6Z/PEVBriqPor8K yERg6XKNvsu9Q== Date: Sun, 12 Nov 2023 16:41:07 +0000 To: Efraim Flashner From: Ekaitz Zarraga Subject: Re: [bug#67075] [PATCH] build: zig-build-system: Add CPU option Message-ID: In-Reply-To: <9H9-d5-fHPyPl1K4orVOGtBJD1l-IkO3i_PliKpymBR4abn8CwidP7hNlaqafHnHBu54egehC0wYtVc-R4azbkd1sjEMPITj9dbUHl8W6dM=@elenq.tech> References: <9H9-d5-fHPyPl1K4orVOGtBJD1l-IkO3i_PliKpymBR4abn8CwidP7hNlaqafHnHBu54egehC0wYtVc-R4azbkd1sjEMPITj9dbUHl8W6dM=@elenq.tech> Feedback-ID: 3263582:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67075 Cc: 67075@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Extra information I missed in the previous email: > andrewrk: there is close to a 1-1 correspondence. zig uses underscores in= stead of dashes for naming these So we can use a translation function from the tuning capabilites we already= have and see how it goes. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 18 11:53:01 2023 Received: (at 67075) by debbugs.gnu.org; 18 Nov 2023 16:53:01 +0000 Received: from localhost ([127.0.0.1]:49423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4OZ2-0005f7-J6 for submit@debbugs.gnu.org; Sat, 18 Nov 2023 11:53:01 -0500 Received: from dane.soverin.net ([2a10:de80:1:4092:b9e9:2294:0:1]:57363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4OYy-0005er-LG for 67075@debbugs.gnu.org; Sat, 18 Nov 2023 11:52:59 -0500 Received: from smtp.soverin.net (unknown [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4SXfw135fWz2xFP for <67075@debbugs.gnu.org>; Sat, 18 Nov 2023 16:52:49 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4SXfw04wgHz3v for <67075@debbugs.gnu.org>; Sat, 18 Nov 2023 16:52:48 +0000 (UTC) Authentication-Results: smtp.soverin.net; dkim=pass (2048-bit key; unprotected) header.d=elenq.tech header.i=@elenq.tech header.a=rsa-sha256 header.s=soverin1 header.b=EBPGCsWR; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=soverin1; t=1700326368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=SgqBz4J4jx5Wk7X8iUc7hDBdsVHLzqkwaNkvhFJ3GXQ=; b=EBPGCsWRom1u5BD4kOAF6LdopXwg6yWXF/RfKcuK0/MhmTfdSVecSzIAn37Pm0nrMgMUJe 4n2kRWwL2Zczerk4SpOo/HhiQh9peK5hWxJAVvBpIlGKAU3O+8eh9z7xL2fOi6ijKjFnHW 8uJ26mkvQNmA/fP9vzemaM4YYnV7+XgqbYewG6trvn3YPVam2BxaDy5Nvl2ZIxaTR9Wdih Qfsp+iudUUjuFhSuNEUVL5mYu0ONRuVnWhhHeSP/KXE/+TEFWAIoAY3JIQl/A8fYysPAqi X7NqJvTTpZuKUbr4B/chuJ7Yw0+FrWFvRFgRbnRPLFj7CbdtB/Mfu4Z4B1pGiQ== Content-Type: multipart/mixed; boundary="------------io9OgYsFc8uiFk30C0JbjTbP" Message-ID: <85988d3d-2099-ee38-ca5d-b8fcc55dc88c@elenq.tech> Date: Sat, 18 Nov 2023 17:52:48 +0100 MIME-Version: 1.0 From: Ekaitz Zarraga Subject: [PATCH] build: zig-build-system: Add CPU option To: 67075@debbugs.gnu.org Content-Language: en-US, es-ES, eu X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67075 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------io9OgYsFc8uiFk30C0JbjTbP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Following Efraim's suggestion I arranged a new patch around the tuning option. I needed to patch Zig itself to use baseline cpu by default, which is safer in general for us. If anyone need a more specific cpu, can use the tuning option to choose it. Maybe I should split the changes in Zig and the tuning system, but if I do they wont appear together, and they mostly only make sense if applied at once. Please let me know if you like this one better. Hope it's cool. Cheers, Ekaitz --------------io9OgYsFc8uiFk30C0JbjTbP Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-zig-Make-compiler-tunable.patch" Content-Disposition: attachment; filename="0001-gnu-zig-Make-compiler-tunable.patch" Content-Transfer-Encoding: base64 RnJvbSAwMzYxNmI5NzY0Mjc4ZTA1ZDc0ZjhlOGJmNWQ2NWIwNDM2MDNhNDM3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MDM2MTZiOTc2NDI3OGUwNWQ3NGY4ZThi ZjVkNjViMDQzNjAzYTQzNy4xNzAwMzI1NjQwLmdpdC5la2FpdHpAZWxlbnEudGVjaD4KRnJv bTogRWthaXR6IFphcnJhZ2EgPGVrYWl0ekBlbGVucS50ZWNoPgpEYXRlOiBTYXQsIDE4IE5v diAyMDIzIDE3OjI5OjA3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiB6aWc6IE1ha2Ug Y29tcGlsZXIgdHVuYWJsZS4KCkluIG9yZGVyIHRvIG1ha2UgWmlnIHR1bmFibGUsIHdlIGhh dmUgdG8gbWFrZSBzdXJlIGJ5IGRlZmF1bHQgaXQgZG9lcwp0aGUgcmlnaHQgdGhpbmcsIHRo YXQgaXMgdXNlIHRoZSBgYmFzZWxpbmVgIENQVSBpbnN0ZWFkIG9mIHRoZSBgbmF0aXZlYApv bmUgYmVjYXVzZSB0aGUgdHVuaW5nIHN5c3RlbSBvbmx5IGFkZHMgYW4gZXh0cmEgZmxhZyB0 byB0aGUgY29tcGlsZXIKY29tbWFuZCBsaW5lIGV4ZWN1dGlvbi4KCiogZ251L3BhY2thZ2Vz L3BhdGNoZXMvemlnLXVzZS1iYXNlbGluZS1jcHUtYnktZGVmYXVsdC5wYXRjaDogQWRkIGZp bGUuCiogZ251L3BhY2thZ2VzL3ppZy5zY20oemlnLTAuMTAuMSk6IEFwcGx5IHBhdGNoIGFi b3ZlLgoqIGd1aXgvdHJhbnNmb3JtYXRpb25zLnNjbSh0dW5pbmctY29tcGlsZXIpOiBBZGQg c3VwcG9ydCBmb3IgemlnLgoKQ2hhbmdlLUlkOiBJNDBiZDI4MDcxYzk3YzBkZDBhOTA3Yzcw NDA3MmI1MmIyNmQyZGUyOAotLS0KIC4uLi96aWctdXNlLWJhc2VsaW5lLWNwdS1ieS1kZWZh dWx0LnBhdGNoICAgICB8IDM2ICsrKysrKysrKysrKysrKysrKysKIGdudS9wYWNrYWdlcy96 aWcuc2NtICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzICstCiBndWl4L3RyYW5zZm9y bWF0aW9ucy5zY20gICAgICAgICAgICAgICAgICAgICAgfCAyMiArKysrKysrKy0tLS0KIDMg ZmlsZXMgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKIGNyZWF0 ZSBtb2RlIDEwMDY0NCBnbnUvcGFja2FnZXMvcGF0Y2hlcy96aWctdXNlLWJhc2VsaW5lLWNw dS1ieS1kZWZhdWx0LnBhdGNoCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3BhdGNoZXMv emlnLXVzZS1iYXNlbGluZS1jcHUtYnktZGVmYXVsdC5wYXRjaCBiL2dudS9wYWNrYWdlcy9w YXRjaGVzL3ppZy11c2UtYmFzZWxpbmUtY3B1LWJ5LWRlZmF1bHQucGF0Y2gKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uYmU3OGQ5YzZjNwotLS0gL2Rldi9udWxs CisrKyBiL2dudS9wYWNrYWdlcy9wYXRjaGVzL3ppZy11c2UtYmFzZWxpbmUtY3B1LWJ5LWRl ZmF1bHQucGF0Y2gKQEAgLTAsMCArMSwzNiBAQAorRnJvbSAxZGMxODgxMjk5NTAwMzEyNDNj NWEwYzgwZWMyNTYyZmFiOGVjNTQ5IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTog RWthaXR6IFphcnJhZ2EgPGVrYWl0ekBlbGVucS50ZWNoPgorRGF0ZTogU2F0LCAxOCBOb3Yg MjAyMyAxNTowNDoxNiArMDEwMAorU3ViamVjdDogW1BBVENIXSBVc2UgYGJhc2VsaW5lYCBj cHUgYnkgZGVmYXVsdC4KKworVGhpcyBoZWxwcyBHdWl4IHR1bmUgdGhlIHBhY2thZ2UgbGF0 ZXIuIFR1bm5pbmcgd2lsbCBvbmx5IGFkZAorYC1EY3B1PXdoYXRldmVyYCB3aGljaCBzaG91 bGQgb3ZlcnJpZGUgdGhlIHN0YW5kYXJkIGJlaGF2aW91ci4KKworWmlnIGJ5IGRlZmF1bHQg dXNlcyBgbmF0aXZlYCwgd2hpY2ggaW50ZXJmZXJlcyB3aXRoIG91ciBidWlsZCBwcm9jZXNz LgorSW4gb3VyIHByZXZpb3VzIHppZy1idWlsZC1zeXN0ZW0gd2UgY2hvc2UgdG8gYWRkIGAt RGNwdT1iYXNlbGluZWAgZmxhZworaW4gZWFjaCBgemlnIGJ1aWxkYCBleGVjdXRpb24sIGJ1 dCB0aGF0IGRvZXNuJ3QgYWxsb3cgdXMgdG8gdHVuZSB0aGUKK3BhY2thZ2UgbGF0ZXIuIFR1 bm5pbmcgaXMgb25seSBkZXNpZ25lZCB0byBhZGQgZXh0cmEgZmxhZ3MgaW4gdGhlCitjb21t YW5kIGxpbmUgY2FsbCwgYW5kIHdlIGFscmVhZHkgaGFkIG9uZSBzZXQgZm9yIHRoZSBiYXNl bGluZSBjYXNlLgorV2l0aCB0aGlzIHBhdGNoIHdlIHNldCB0aGUgc3RhbmRhcmQgYmVoYXZp b3IgdG8gYGJhc2VsaW5lYCBzbyB3ZSBkb24ndAorbmVlZCB0byBhZGQgdGhlIGAtRGNwdT1i YXNlbGluZWAgZmxhZyBpbiB0aGUgemlnLWJ1aWxkLXN5c3RlbSBhbmQgd2UgY2FuCit0dW5l IHdpdGggbm8gaXNzdWVzLgorLS0tCisgbGliL3N0ZC96aWcvQ3Jvc3NUYXJnZXQuemlnIHwg MiArLQorIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQor CitkaWZmIC0tZ2l0IGEvbGliL3N0ZC96aWcvQ3Jvc3NUYXJnZXQuemlnIGIvbGliL3N0ZC96 aWcvQ3Jvc3NUYXJnZXQuemlnCitpbmRleCA2YzU5YTRhM2EuLmY1ZWMwNjVmZSAxMDA2NDQK Ky0tLSBhL2xpYi9zdGQvemlnL0Nyb3NzVGFyZ2V0LnppZworKysrIGIvbGliL3N0ZC96aWcv Q3Jvc3NUYXJnZXQuemlnCitAQCAtMTIsNyArMTIsNyBAQCBjb25zdCBtZW0gPSBzdGQubWVt OworIC8vLyBgbnVsbGAgbWVhbnMgbmF0aXZlLgorIGNwdV9hcmNoOiA/VGFyZ2V0LkNwdS5B cmNoID0gbnVsbCwKKyAKKy1jcHVfbW9kZWw6IENwdU1vZGVsID0gQ3B1TW9kZWwuZGV0ZXJt aW5lZF9ieV9jcHVfYXJjaCwKKytjcHVfbW9kZWw6IENwdU1vZGVsID0gQ3B1TW9kZWwuYmFz ZWxpbmUsCisgCisgLy8vIFNwYXJzZSBzZXQgb2YgQ1BVIGZlYXR1cmVzIHRvIGFkZCB0byB0 aGUgc2V0IGZyb20gYGNwdV9tb2RlbGAuCisgY3B1X2ZlYXR1cmVzX2FkZDogVGFyZ2V0LkNw dS5GZWF0dXJlLlNldCA9IFRhcmdldC5DcHUuRmVhdHVyZS5TZXQuZW1wdHksCistLSAKKzIu NDEuMAorCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvemlnLnNjbSBiL2dudS9wYWNrYWdl cy96aWcuc2NtCmluZGV4IGRjY2E5YTExMjEuLjgyYjgzZjQ0YzIgMTAwNjQ0Ci0tLSBhL2du dS9wYWNrYWdlcy96aWcuc2NtCisrKyBiL2dudS9wYWNrYWdlcy96aWcuc2NtCkBAIC00Miw3 ICs0Miw4IEBAIChkZWZpbmUtcHVibGljIHppZy0wLjEwCiAgICAgICAgKGZpbGUtbmFtZSAo Z2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQogICAgICAgIChzaGEyNTYKICAgICAgICAg KGJhc2UzMiAiMXNoNXhqc2tzbDUyaTRjZnYxcWozNnN6NWgwbG43Y3E0cGRoZ3MzOTYwbWs4 YTkwaW03YiIpKQotICAgICAgIChwYXRjaGVzIChzZWFyY2gtcGF0Y2hlcyAiemlnLWRvLW5v dC1saW5rLWFnYWluc3QtbGlicnQucGF0Y2giKSkpKQorICAgICAgIChwYXRjaGVzIChzZWFy Y2gtcGF0Y2hlcyAiemlnLWRvLW5vdC1saW5rLWFnYWluc3QtbGlicnQucGF0Y2giCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ6aWctdXNlLURjcHUtYmFzZWxpbmUtYnkt ZGVmYXVsdC5wYXRjaCIpKSkpCiAgICAgKGJ1aWxkLXN5c3RlbSBjbWFrZS1idWlsZC1zeXN0 ZW0pCiAgICAgKGlucHV0cwogICAgICAobGlzdCBjbGFuZy0xNSA7IENsYW5nIHByb3BhZ2F0 ZXMgbGx2bS4KZGlmZiAtLWdpdCBhL2d1aXgvdHJhbnNmb3JtYXRpb25zLnNjbSBiL2d1aXgv dHJhbnNmb3JtYXRpb25zLnNjbQppbmRleCA5Y2JhNmJlZGFiLi44OTY0ZmViMDQ2IDEwMDY0 NAotLS0gYS9ndWl4L3RyYW5zZm9ybWF0aW9ucy5zY20KKysrIGIvZ3VpeC90cmFuc2Zvcm1h dGlvbnMuc2NtCkBAIC00MzksNyArNDM5LDggQEAgKGRlZmluZSB0dW5pbmctY29tcGlsZXIK IGFjdHVhbCBjb21waWxlci4iCiAgICAgKGRlZmluZSB3cmFwcGVyCiAgICAgICAjfihiZWdp bgotICAgICAgICAgICh1c2UtbW9kdWxlcyAoaWNlLTkgbWF0Y2gpKQorICAgICAgICAgICh1 c2UtbW9kdWxlcyAoaWNlLTkgbWF0Y2gpCisgICAgICAgICAgICAgICAgICAgICAgIChpY2Ut OSBzdHJpbmctZnVuKSkKIAogICAgICAgICAgIChkZWZpbmUgcHNhYmkgIyQoZ2NjLWFyY2hp dGVjdHVyZS0+bWljcm8tYXJjaGl0ZWN0dXJlLWxldmVsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbWljcm8tYXJjaGl0ZWN0dXJlKSkKQEAgLTQ4NiwxMSArNDg3LDIwIEBAIChk ZWZpbmUgdHVuaW5nLWNvbXBpbGVyCiAgICAgICAgICAgICAgICAgKGFwcGx5CiAgICAgICAg ICAgICAgICAgICBleGVjbCBuZXh0CiAgICAgICAgICAgICAgICAgICAgICAgIChhcHBlbmQg KGNvbnMgbmV4dCBhcmd1bWVudHMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChh bmQgKHNlYXJjaC1uZXh0ICJnbyIpCisgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbmQK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICgoYW5kIChzZWFyY2gtbmV4dCAiZ28iKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmc9PyBuZXh0IChzZWFy Y2gtbmV4dCAiZ28iKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAnKCkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChzdHJpbmctYXBwZW5kICItbWFyY2g9Igot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyRtaWNy by1hcmNoaXRlY3R1cmUpKSkpKSkpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg JygpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKChhbmQgKHNlYXJjaC1uZXh0ICJ6 aWciKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmc9PyBuZXh0 IChzZWFyY2gtbmV4dCAiemlnIikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxp c3QgKHN0cmluZy1hcHBlbmQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDs7IGh0dHBzOi8vaXNzdWVzLmd1aXguZ251Lm9yZy82NzA3NSMzCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiLURjcHU9IgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKHN0cmluZy1yZXBsYWNlLXN1YnN0cmluZworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAjJG1pY3JvLWFyY2hpdGVjdHVyZSAiLSIgIl8i KSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChlbHNlCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChsaXN0IChzdHJpbmctYXBwZW5kICItbWFyY2g9IgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMkbWljcm8tYXJjaGl0ZWN0dXJlKSkp KSkpKSkpKSkpCiAKICAgICAoZGVmaW5lIHByb2dyYW0KICAgICAgIChwcm9ncmFtLWZpbGUg KHN0cmluZy1hcHBlbmQgInR1bmluZy1jb21waWxlci13cmFwcGVyLSIgbWljcm8tYXJjaGl0 ZWN0dXJlKQpAQCAtNTA4LDcgKzUxOCw3IEBAIChkZWZpbmUgdHVuaW5nLWNvbXBpbGVyCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN5bWxpbmsgIyRwcm9ncmFt CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmlu Zy1hcHBlbmQgYmluICIvIiBwcm9ncmFtKSkpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICcoImNjIiAiZ2NjIiAiY2xhbmciICJnKysiICJjKysiICJjbGFuZysrIgot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJnbyIpKSkpKSkpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImdvIiAiemlnIikpKSkpKSkKIAog KGRlZmluZSAoYnVpbGQtc3lzdGVtLXdpdGgtdHVuaW5nLWNvbXBpbGVyIGJzIG1pY3JvLWFy Y2hpdGVjdHVyZSkKICAgIlJldHVybiBhIHZhcmlhbnQgb2YgQlMsIGEgYnVpbGQgc3lzdGVt LCB0aGF0IGVuc3VyZXMgdGhhdCB0aGUgY29tcGlsZXIgdGhhdAoKYmFzZS1jb21taXQ6IGE1 MTQ5NzM0MTNkYzgxNzkxMDBlZjhmMGZjZjQxZjVhYzM4Yzk4MmYKLS0gCjIuNDEuMAoK --------------io9OgYsFc8uiFk30C0JbjTbP-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 03:10:21 2023 Received: (at 67075-done) by debbugs.gnu.org; 3 Dec 2023 08:10:21 +0000 Received: from localhost ([127.0.0.1]:59076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9hYS-00031k-VU for submit@debbugs.gnu.org; Sun, 03 Dec 2023 03:10:21 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:59568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9hYP-00031T-NP for 67075-done@debbugs.gnu.org; Sun, 03 Dec 2023 03:10:19 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40c09fcfa9fso1416845e9.2 for <67075-done@debbugs.gnu.org>; Sun, 03 Dec 2023 00:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701591001; x=1702195801; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=WlANT2YuNvu3l4Nxc2Fg2xY+j07qXMn96RbYb7EDXo8=; b=I5qnWxOS99/D1tl3lGsY0Xkahwm7JK5vnP1YDSii7nmfDFKM3ugzo4dG5dVWvh8YiO 3crN1xzEfgrtnNpSaZiLB2LPEheP8ARb6T06vjSqnbksZvYVAhzCLceVk+qLFVNgqKFr T0vgP0+W6ZxjoOv/YnFlVS6kxSFwSa9Rh1K0PF8OowMSb3np9iQhYsO2fHHJMCxJSko5 Aj02wneIUBJ8HWu6XDE/0EH8MD7IlJumOEGFdTBUtNjp2Fn2WitswLy9XjR82XRM0iVa HSPkG9NyQIYtVlbh1VCKFMgWl4FjM5JXCpjif2lXMjdzMAzAj6qodQ1ycSeXeMIFZ1g+ vScQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701591001; x=1702195801; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WlANT2YuNvu3l4Nxc2Fg2xY+j07qXMn96RbYb7EDXo8=; b=qFFjv3BdNP8VsGqBIZObuZnq63kF9b2qcF4zBCw0hnEEZTwTbnhjtLeqdL3mfwPK08 2jX8mF69a6tYVgU3OYS9YuJXSIvgx6+tbC/w955o+O2ex/j/5wCur0UiqCRjimKpAxnY 5F+44sc9nIpDLfV7X8C3IqfSMbynLFnPjLe12PkRCi8ANaz8ZHxj6gJybGqQR+RVUrHm 6qENrlSPkgt3uqpc0wv2puuwA9nbq04HOyqAg1CnwMl+z/4LXBhNUr3Oc0TD/xMicG0Q xQnSMAdI7kLAKD7IVrwTq/R3qAuzQVXYOHpTiG5TV3tLvunqO5/Bn8aU+DRAX1DnvQR9 ycIQ== X-Gm-Message-State: AOJu0Yyxb9NkEDgojyvJdcoWRZi+JDOVMKX0Xxzek+pJZkSdOspqEg5v 9y2TaUeesYx3R06k5K95Uuo= X-Google-Smtp-Source: AGHT+IHL7JaWQoDaRuwZKHBf3UGSRHIq8eNPWVq8tOjKnD3tpi/rJp1zpaccvRL33xezTjcy6km9aw== X-Received: by 2002:adf:fa4a:0:b0:333:3117:c412 with SMTP id y10-20020adffa4a000000b003333117c412mr1004408wrr.163.1701591000408; Sun, 03 Dec 2023 00:10:00 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id o3-20020a5d6843000000b0033340d2b127sm1532584wrw.89.2023.12.03.00.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 00:09:59 -0800 (PST) Date: Sun, 3 Dec 2023 10:09:57 +0200 From: Efraim Flashner To: Ekaitz Zarraga Subject: Re: [PATCH] build: zig-build-system: Add CPU option Message-ID: Mail-Followup-To: Efraim Flashner , Ekaitz Zarraga , 67075-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YpBa3JUG12uTWWoR" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67075-done Cc: 67075-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --YpBa3JUG12uTWWoR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patch applied with a couple of helper patches. Some comments inline. On Sat, Nov 18, 2023 at 05:51:09PM +0100, Ekaitz Zarraga wrote: > Hi, >=20 > Following Efraim's suggestion I arranged a new patch around the tuning > option. I needed to patch Zig itself to use baseline cpu by default, which > is safer in general for us. >=20 > If anyone need a more specific cpu, can use the tuning option to choose i= t. >=20 > Maybe I should split the changes in Zig and the tuning system, but if I do > they wont appear together, and they mostly only make sense if applied at > once. I split the patch and applied the one adjusting zig to use -Dcpu=3Dbaseline first. > Please let me know if you like this one better. >=20 > Hope it's cool. >=20 > Cheers, > Ekaitz > From 03616b9764278e05d74f8e8bf5d65b043603a437 Mon Sep 17 00:00:00 2001 > Message-ID: <03616b9764278e05d74f8e8bf5d65b043603a437.1700325640.git.ekai= tz@elenq.tech> > From: Ekaitz Zarraga > Date: Sat, 18 Nov 2023 17:29:07 +0100 > Subject: [PATCH] gnu: zig: Make compiler tunable. >=20 > In order to make Zig tunable, we have to make sure by default it does > the right thing, that is use the `baseline` CPU instead of the `native` > one because the tuning system only adds an extra flag to the compiler > command line execution. >=20 > * gnu/packages/patches/zig-use-baseline-cpu-by-default.patch: Add file. > * gnu/packages/zig.scm(zig-0.10.1): Apply patch above. > * guix/transformations.scm(tuning-compiler): Add support for zig. Missing a change for gnu/local.mk > Change-Id: I40bd28071c97c0dd0a907c704072b52b26d2de28 > --- > .../zig-use-baseline-cpu-by-default.patch | 36 +++++++++++++++++++ > gnu/packages/zig.scm | 3 +- > guix/transformations.scm | 22 ++++++++---- > 3 files changed, 54 insertions(+), 7 deletions(-) > create mode 100644 gnu/packages/patches/zig-use-baseline-cpu-by-default.= patch >=20 > diff --git a/gnu/packages/patches/zig-use-baseline-cpu-by-default.patch b= /gnu/packages/patches/zig-use-baseline-cpu-by-default.patch > new file mode 100644 > index 0000000000..be78d9c6c7 > --- /dev/null > +++ b/gnu/packages/patches/zig-use-baseline-cpu-by-default.patch > @@ -0,0 +1,36 @@ > +From 1dc188129950031243c5a0c80ec2562fab8ec549 Mon Sep 17 00:00:00 2001 > +From: Ekaitz Zarraga > +Date: Sat, 18 Nov 2023 15:04:16 +0100 > +Subject: [PATCH] Use `baseline` cpu by default. > + > +This helps Guix tune the package later. Tunning will only add > +`-Dcpu=3Dwhatever` which should override the standard behaviour. > + > +Zig by default uses `native`, which interferes with our build process. > +In our previous zig-build-system we chose to add `-Dcpu=3Dbaseline` flag > +in each `zig build` execution, but that doesn't allow us to tune the > +package later. Tunning is only designed to add extra flags in the > +command line call, and we already had one set for the baseline case. > +With this patch we set the standard behavior to `baseline` so we don't > +need to add the `-Dcpu=3Dbaseline` flag in the zig-build-system and we c= an > +tune with no issues. > +--- > + lib/std/zig/CrossTarget.zig | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/lib/std/zig/CrossTarget.zig b/lib/std/zig/CrossTarget.zig > +index 6c59a4a3a..f5ec065fe 100644 > +--- a/lib/std/zig/CrossTarget.zig > ++++ b/lib/std/zig/CrossTarget.zig > +@@ -12,7 +12,7 @@ const mem =3D std.mem; > + /// `null` means native. > + cpu_arch: ?Target.Cpu.Arch =3D null, > +=20 > +-cpu_model: CpuModel =3D CpuModel.determined_by_cpu_arch, > ++cpu_model: CpuModel =3D CpuModel.baseline, > +=20 > + /// Sparse set of CPU features to add to the set from `cpu_model`. > + cpu_features_add: Target.Cpu.Feature.Set =3D Target.Cpu.Feature.Set.emp= ty, > +--=20 > +2.41.0 > + > diff --git a/gnu/packages/zig.scm b/gnu/packages/zig.scm > index dcca9a1121..82b83f44c2 100644 > --- a/gnu/packages/zig.scm > +++ b/gnu/packages/zig.scm > @@ -42,7 +42,8 @@ (define-public zig-0.10 > (file-name (git-file-name name version)) > (sha256 > (base32 "1sh5xjsksl52i4cfv1qj36sz5h0ln7cq4pdhgs3960mk8a90im7b")) > - (patches (search-patches "zig-do-not-link-against-librt.patch")))) > + (patches (search-patches "zig-do-not-link-against-librt.patch" > + "zig-use-Dcpu-baseline-by-default.patch"= )))) > (build-system cmake-build-system) > (inputs > (list clang-15 ; Clang propagates llvm. > diff --git a/guix/transformations.scm b/guix/transformations.scm > index 9cba6bedab..8964feb046 100644 > --- a/guix/transformations.scm > +++ b/guix/transformations.scm > @@ -439,7 +439,8 @@ (define tuning-compiler > actual compiler." > (define wrapper > #~(begin > - (use-modules (ice-9 match)) > + (use-modules (ice-9 match) > + (ice-9 string-fun)) > =20 > (define psabi #$(gcc-architecture->micro-architecture-level > micro-architecture)) > @@ -486,11 +487,20 @@ (define tuning-compiler > (apply > execl next > (append (cons next arguments) > - (if (and (search-next "go") > + (cond > + ((and (search-next "go") > (string=3D? next (search-next "go"))) > - '() > - (list (string-append "-march=3D" > - #$micro-architecture))))= ))))))) > + '()) > + ((and (search-next "zig") > + (string=3D? next (search-next "zig")) Indentation is off, the and should end with string=3D? > + (list (string-append This I changed to `(,(string-append, otherwise it complains about receiving a list instead of a string. > + ;; https://issues.guix.gnu.org/67075= #3 > + "-Dcpu=3D" > + (string-replace-substring > + #$micro-architecture "-" "_"))))) > + (else > + (list (string-append "-march=3D" > + #$micro-architecture)))))))))))) > =20 > (define program > (program-file (string-append "tuning-compiler-wrapper-" micro-arch= itecture) > @@ -508,7 +518,7 @@ (define tuning-compiler > (symlink #$program > (string-append bin "/" pro= gram))) > '("cc" "gcc" "clang" "g++" "c++" "cla= ng++" > - "go"))))))) > + "go" "zig"))))))) > =20 > (define (build-system-with-tuning-compiler bs micro-architecture) > "Return a variant of BS, a build system, that ensures that the compile= r that >=20 > base-commit: a514973413dc8179100ef8f0fcf41f5ac38c982f > --=20 > 2.41.0 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --YpBa3JUG12uTWWoR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVsN9MACgkQQarn3Mo9 g1FmJg//XYv0thJ4Txr3AlGN8OgfcW3Ov/spWXgNvVavtkDDvSAwcIICfKVKip8C vlYfr0HjmNAdIvKXpdjFF8BRJTSehYDyqATVHL+nhY3etPcxbaY1Yvmw9WBiFOq3 mHxi+GXscAIARCuoXtJqgLc7ikKWJvc3vHUn7LGaX6PJL88FJhGSyW68QgSKgFIG Eu2u1+TtxLk1IdyEepPPck8NCX1SHACirKpNxdxGpTB0im3/AlZCOuT+gUVJa4LY NoQOcn8lZFaYmeW7sbIurpSysBDXUpXHTL1K0W39FDwAd/y0UV1i5QEbwpcsXYSr fcvUrrW2Bnypo9ZmlJDGH36WJQIKBhJosyUTTa6vMyMd1cmVpyeh+gCBsFQZSZrP mvNkhA9PLT20xSD5P76CbI9y0Ige7bgBE3EnHOqJeH1lCg8bUpZEXHDu9wiqIEdV tBhgCHAN/FzsNK5pHYiBksYOUdAkFJgFrtavpopKxvt7ITQ+VH4TxWKxTBhutEYM R+wK/Tz/5Rc7vGQ3id/+CsW54OqskJWnCjj/TNePUVFmdhiNsbWBXoJhUtNXxoz+ cRKYgNeLCYUWzUgyAvn4Xg1uQJX94BesT31oIiOA9JusRVlv7jGoTFQt7qbcNRly k6oNatI7yfKLAZudiER1eAIb+6k1sbg3RuWVOaLgD0qC+5UEyts= =wF2x -----END PGP SIGNATURE----- --YpBa3JUG12uTWWoR-- From unknown Tue Jun 24 15:44:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Dec 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator