GNU bug report logs - #67061
[PATCH] Improve syntax highlighting for python-ts-mode

Previous Next

Full log

Message #59 received at 67061 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Yuan Fu <casouri <at> gmail.com>, Denis Zubarev <dvzubarev <at> yandex.ru>,
 Eli Zaretskii <eliz <at> gnu.org>
Cc: "67061 <at> debbugs.gnu.org" <67061 <at> debbugs.gnu.org>
Subject: Re: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode
Date: Mon, 11 Dec 2023 14:02:01 +0200

On 11/12/2023 09:10, Yuan Fu wrote:
>>> I wanted shorthand form to be consistent with the full form.
>>> Your point makes sense too, I don't have strong opinion about this.
>>> Also I'm not sure now about `var[ii] = 1`, since it is actually 
>>> accessing the list or dictionary element and 
>>> `font-lock-variable-use-face` may suit better here.
>>
>> Yep. To sum up, I would add highlighting to your examples `for var in 
>> range(3)` and `var := 3` but not others.
> IMHO, for the assignment feature, we should stick to the narrow 
> definition of assignments, ie, anything that looks like "a = b". Things 
> like "for var in range(3)" could be highlighted by variable feature, I 
> think.

I think "for var in range(3)" should be part of the "definition" feature 
because a variable is defined there. Alongside parameters.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.