GNU bug report logs - #6704
23.2; Rename git-commits-coding-system to vc-git-commits-coding-system

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Thu, 22 Jul 2010 10:55:02 UTC

Severity: minor

Found in version 23.2

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6704 in the body.
You can then email your comments to 6704 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6704; Package emacs. (Thu, 22 Jul 2010 10:55:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 22 Jul 2010 10:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; Rename git-commits-coding-system to vc-git-commits-coding-system
Date: Thu, 22 Jul 2010 11:41:42 +0100

It seems git-commits-coding-system should be renamed as shown in the
patch below.

commit 148cbd7fed28b7f9d9017713bb35638a6ab5dd58
Date:   Thu Jul 22 11:38:57 2010 +0100

    Rename git-commits-coding-system to vc-git-commits-coding-system

	Modified lisp/vc-git.el
diff --git a/lisp/vc-git.el b/lisp/vc-git.el
index 24062a0..2361564 100644
--- a/lisp/vc-git.el
+++ b/lisp/vc-git.el
@@ -118,7 +118,7 @@ If nil, use the value of `vc-diff-switches'.  If t, use no switches."
   :version "23.1"
   :group 'vc)
 
-(defvar git-commits-coding-system 'utf-8
+(defvar vc-git-commits-coding-system 'utf-8
   "Default coding system for git commits.")
 
 ;;; BACKEND PROPERTIES
@@ -543,7 +543,7 @@ or an empty string if none."
 
 
 (defun vc-git-checkin (files rev comment)
-  (let ((coding-system-for-write git-commits-coding-system))
+  (let ((coding-system-for-write vc-git-commits-coding-system))
     (vc-git-command nil 0 files "commit"
 		    "-m" comment "--only" "--")))
 
@@ -580,7 +580,7 @@ or an empty string if none."
   "Get change log associated with FILES.
 Note that using SHORTLOG requires at least Git version 1.5.6,
 for the --graph option."
-  (let ((coding-system-for-read git-commits-coding-system))
+  (let ((coding-system-for-read vc-git-commits-coding-system))
     ;; `vc-do-command' creates the buffer, but we need it before running
     ;; the command.
     (vc-setup-buffer buffer)
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Fri, 03 Dec 2010 18:45:02 GMT) Full text and rfc822 format available.
Notification sent to Leo <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Fri, 03 Dec 2010 18:45:02 GMT) Full text and rfc822 format available.

Message #10 received at 6704-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 6704-done <at> debbugs.gnu.org
Subject: Re: bug#6704: 23.2;
	Rename git-commits-coding-system to vc-git-commits-coding-system
Date: Fri, 3 Dec 2010 13:50:16 -0500

2010-10-31  Stefan Monnier  <monnier at iro.umontreal.ca>

    * vc-git.el (vc-git-commits-coding-system): Rename from
    git-commits-coding-system.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Jan 2011 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 230 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.