GNU bug report logs - #67038
Inconsistent use of space before ellipsis

Previous Next

To reply to this bug, email your comments to 67038 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: bug-guix <at> gnu.org
Subject: Inconsistent use of space before ellipsis
Date: Fri, 10 Nov 2023 10:12:18 +0100

When running “guix shell python python-numpy” we see output like this:

--8<---------------cut here---------------start------------->8---
applying 3 grafts for python-pytest-bootstrap-7.1.3 ...
applying 9 grafts for libxslt-1.1.37 ...
applying 6 grafts for python-lxml-4.9.1 ...
waiting for locks or build slots...
applying 4 grafts for python-xmlschema-1.2.5 ...
applying 7 grafts for python-pytest-7.1.3 ...
applying 11 grafts for python-numpy-1.23.2 ...
building CA certificate bundle...
listing Emacs sub-directories...
building fonts directory...
building directory of Info manuals...
building profile with 2 packages...
--8<---------------cut here---------------end--------------->8---

Note the inconsistency in whether we separate the ellipses from the
preceding text with a space or not.

-- 
Ricardo

Message #8 received at 67038 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>, 67038 <at> debbugs.gnu.org
Subject: Re: bug#67038: Inconsistent use of space before ellipsis
Date: Thu, 16 Nov 2023 10:43:17 +0100

[Message part 1 (text/plain, inline)]

Hi,

On Fri, 10 Nov 2023 at 10:12, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> --8<---------------cut here---------------start------------->8---
> applying 3 grafts for python-pytest-bootstrap-7.1.3 ...
> applying 9 grafts for libxslt-1.1.37 ...
> applying 6 grafts for python-lxml-4.9.1 ...
> waiting for locks or build slots...
> applying 4 grafts for python-xmlschema-1.2.5 ...
> applying 7 grafts for python-pytest-7.1.3 ...
> applying 11 grafts for python-numpy-1.23.2 ...
> building CA certificate bundle...
> listing Emacs sub-directories...
> building fonts directory...
> building directory of Info manuals...
> building profile with 2 packages...
> --8<---------------cut here---------------end--------------->8---
>
> Note the inconsistency in whether we separate the ellipses from the
> preceding text with a space or not.

Well, to my knowledge, the typographical rule is not clear depending on
some style; without going to USA vs UK vs ….

For consistency, I suggest the rule: ’word...’ and not ’word ...’

Something like the patch attached.

[p.patch (text/x-diff, inline)]

diff --git a/guix/status.scm b/guix/status.scm
index fd89ba9dd3..0ed6d3318a 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -494,8 +494,8 @@ (define* (print-build-event event old-status status
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a ..."
-                                    "applying ~a grafts for ~a ..."
+             (format port (info (N_ "applying ~a graft for ~a..."
+                                    "applying ~a grafts for ~a..."
                                     count))
                      count
                      (string-drop-right (store-path-package-name drv)

[Message part 3 (text/plain, inline)]

WDYT?

Cheers,
simon

Message #11 received at 67038 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 67038 <at> debbugs.gnu.org
Subject: Re: bug#67038: Inconsistent use of space before ellipsis
Date: Thu, 16 Nov 2023 15:09:04 +0100

Simon Tournier <zimon.toutoune <at> gmail.com> writes:
> For consistency, I suggest the rule: ’word...’ and not ’word ...’
>
> Something like the patch attached.

+1

This is more consistent.  Looking at the translation files in po/guix,
only guix/status.scm:568 uses the space before ellipsis.  The message
"applying ~a graft" does not occur in the manual, so it does not need
changing.

(match event
  […]
  (('download-started item uri _ ...)
   (when print-urls?
     (erase-current-line*)
     (format port (info (G_ "downloading from ~a ...")) uri)
     (newline port)))

Should we keep this space?  Perhaps keep it; it is clearer where the
URI ends.

Regards,
Florian

Message #14 received at 67038 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 67038 <at> debbugs.gnu.org,
 Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: Re: bug#67038: Inconsistent use of space before ellipsis
Date: Fri, 17 Nov 2023 16:47:18 +0100

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> skribis:

> Simon Tournier <zimon.toutoune <at> gmail.com> writes:
>> For consistency, I suggest the rule: ’word...’ and not ’word ...’
>>
>> Something like the patch attached.
>
> +1

+1!

> (match event
>   […]
>   (('download-started item uri _ ...)
>    (when print-urls?
>      (erase-current-line*)
>      (format port (info (G_ "downloading from ~a ...")) uri)
>      (newline port)))
>
> Should we keep this space?  Perhaps keep it; it is clearer where the
> URI ends.

Yes, we should keep this one: somebody added it on the grounds that it
allowed them to click on URLs in their terminal and get the correct URL,
without the period.

Ludo’.

Message #17 received at 67038 <at> debbugs.gnu.org (full text, mbox):

From: Adriel Dumas--Jondeau <leirda <at> disroot.org>
To: 67038 <at> debbugs.gnu.org
Subject: [PATCH] guix: status: Fix ellipsis inconsistencies.
Date: Sun, 19 Nov 2023 17:55:40 +0100

Fixes <https://issues.guix.gnu.org/67038>.
Reported by Ricardo Wurmus.

* guix/status.scm (print-build-event): Fix ellipsis inconsistencies.
---
 guix/status.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

We just made this patch after Capitole du Libre at Toulouse as an example for
my first patch \o/

diff --git a/guix/status.scm b/guix/status.scm
index fd89ba9dd3..0ed6d3318a 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -494,8 +494,8 @@ (define* (print-build-event event old-status status
            (let ((count (match (assq-ref properties 'graft)
                           (#f  0)
                           (lst (or (assq-ref lst 'count) 0)))))
-             (format port (info (N_ "applying ~a graft for ~a ..."
-                                    "applying ~a grafts for ~a ..."
+             (format port (info (N_ "applying ~a graft for ~a..."
+                                    "applying ~a grafts for ~a..."
                                     count))
                      count
                      (string-drop-right (store-path-package-name drv)

base-commit: 761810d32a0550912b5bb36a0c9f60141bcb7d20
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.